From: Lee Jones <lee.jones@linaro.org>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: khilman@baylibre.com, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: meson: Switch simple-mfd and syscon order
Date: Fri, 27 Jul 2018 07:03:54 +0100 [thread overview]
Message-ID: <20180727060354.GA4628@dell> (raw)
In-Reply-To: <1532614438-7207-1-git-send-email-narmstrong@baylibre.com>
On Thu, 26 Jul 2018, Neil Armstrong wrote:
> The order between "syscon" and "simple-mfd" is important because in these
> particular cases, the node needs to be first a "simple-mfd" to expose
> it's sub-nodes, and later on a "syscon" to permit other nodes to access
> this register space through the "syscon" mechanism.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> This also has a consequence for U-Boot since the U-Boot DM is much simpler
> and can only associate a single device to a node, thus here we want these
> nodes to be an mfd bus to be able to probe the sub-nodes.
>
> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
> arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index 6adc8d3..3f0de9d 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -342,7 +342,7 @@
> ranges = <0x0 0x0 0x0 0xff63c000 0x0 0x1c00>;
>
> sysctrl: system-controller@0 {
> - compatible = "amlogic,meson-axg-hhi-sysctrl", "syscon", "simple-mfd";
> + compatible = "amlogic,meson-axg-hhi-sysctrl", "simple-mfd", "syscon";
I must profess, I haven't looked at the code recently so can't really
comment on the semantics - I'll leave that to Rob et. al.
However, if the ordering is important, you should add a comment to
prevent anyone re-jigging it or reverting the patch for some reason.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: meson: Switch simple-mfd and syscon order
Date: Fri, 27 Jul 2018 07:03:54 +0100 [thread overview]
Message-ID: <20180727060354.GA4628@dell> (raw)
In-Reply-To: <1532614438-7207-1-git-send-email-narmstrong@baylibre.com>
On Thu, 26 Jul 2018, Neil Armstrong wrote:
> The order between "syscon" and "simple-mfd" is important because in these
> particular cases, the node needs to be first a "simple-mfd" to expose
> it's sub-nodes, and later on a "syscon" to permit other nodes to access
> this register space through the "syscon" mechanism.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> This also has a consequence for U-Boot since the U-Boot DM is much simpler
> and can only associate a single device to a node, thus here we want these
> nodes to be an mfd bus to be able to probe the sub-nodes.
>
> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
> arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index 6adc8d3..3f0de9d 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -342,7 +342,7 @@
> ranges = <0x0 0x0 0x0 0xff63c000 0x0 0x1c00>;
>
> sysctrl: system-controller at 0 {
> - compatible = "amlogic,meson-axg-hhi-sysctrl", "syscon", "simple-mfd";
> + compatible = "amlogic,meson-axg-hhi-sysctrl", "simple-mfd", "syscon";
I must profess, I haven't looked at the code recently so can't really
comment on the semantics - I'll leave that to Rob et. al.
However, if the ordering is important, you should add a comment to
prevent anyone re-jigging it or reverting the patch for some reason.
--
Lee Jones [???]
Linaro Services Technical Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH] arm64: dts: meson: Switch simple-mfd and syscon order
Date: Fri, 27 Jul 2018 07:03:54 +0100 [thread overview]
Message-ID: <20180727060354.GA4628@dell> (raw)
In-Reply-To: <1532614438-7207-1-git-send-email-narmstrong@baylibre.com>
On Thu, 26 Jul 2018, Neil Armstrong wrote:
> The order between "syscon" and "simple-mfd" is important because in these
> particular cases, the node needs to be first a "simple-mfd" to expose
> it's sub-nodes, and later on a "syscon" to permit other nodes to access
> this register space through the "syscon" mechanism.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> This also has a consequence for U-Boot since the U-Boot DM is much simpler
> and can only associate a single device to a node, thus here we want these
> nodes to be an mfd bus to be able to probe the sub-nodes.
>
> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 4 ++--
> arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index 6adc8d3..3f0de9d 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -342,7 +342,7 @@
> ranges = <0x0 0x0 0x0 0xff63c000 0x0 0x1c00>;
>
> sysctrl: system-controller at 0 {
> - compatible = "amlogic,meson-axg-hhi-sysctrl", "syscon", "simple-mfd";
> + compatible = "amlogic,meson-axg-hhi-sysctrl", "simple-mfd", "syscon";
I must profess, I haven't looked at the code recently so can't really
comment on the semantics - I'll leave that to Rob et. al.
However, if the ordering is important, you should add a comment to
prevent anyone re-jigging it or reverting the patch for some reason.
--
Lee Jones [???]
Linaro Services Technical Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-07-27 6:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 14:13 [PATCH] arm64: dts: meson: Switch simple-mfd and syscon order Neil Armstrong
2018-07-26 14:13 ` Neil Armstrong
2018-07-26 14:13 ` Neil Armstrong
2018-07-26 14:41 ` Yixun Lan
2018-07-26 14:41 ` Yixun Lan
2018-07-26 14:41 ` Yixun Lan
2018-07-26 14:50 ` Neil Armstrong
2018-07-26 14:50 ` Neil Armstrong
2018-07-26 14:50 ` Neil Armstrong
2018-09-13 4:07 ` Chen-Yu Tsai
2018-09-13 4:07 ` Chen-Yu Tsai
2018-09-13 4:07 ` Chen-Yu Tsai
2018-07-27 6:03 ` Lee Jones [this message]
2018-07-27 6:03 ` Lee Jones
2018-07-27 6:03 ` Lee Jones
2018-09-13 3:59 ` Kevin Hilman
2018-09-13 3:59 ` Kevin Hilman
2018-09-13 3:59 ` Kevin Hilman
2018-09-13 4:20 ` Kevin Hilman
2018-09-13 4:20 ` Kevin Hilman
2018-09-13 4:20 ` Kevin Hilman
2018-09-13 7:04 ` Neil Armstrong
2018-09-13 7:04 ` Neil Armstrong
2018-09-13 7:04 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180727060354.GA4628@dell \
--to=lee.jones@linaro.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.