* [PATCH] net: phy: marvell: Replace mdelay() with msleep() in m88e1116r_config_init()
@ 2018-07-27 8:34 Jia-Ju Bai
2018-07-27 13:31 ` Andrew Lunn
2018-07-27 21:12 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Jia-Ju Bai @ 2018-07-27 8:34 UTC (permalink / raw)
To: andrew, f.fainelli; +Cc: netdev, linux-kernel, Jia-Ju Bai
m88e1116r_config_init() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().
This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
drivers/net/phy/marvell.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
index 25e2a099b71c..ed04346df235 100644
--- a/drivers/net/phy/marvell.c
+++ b/drivers/net/phy/marvell.c
@@ -646,7 +646,7 @@ static int m88e1116r_config_init(struct phy_device *phydev)
if (err < 0)
return err;
- mdelay(500);
+ msleep(500);
err = marvell_set_page(phydev, MII_MARVELL_COPPER_PAGE);
if (err < 0)
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: marvell: Replace mdelay() with msleep() in m88e1116r_config_init()
2018-07-27 8:34 [PATCH] net: phy: marvell: Replace mdelay() with msleep() in m88e1116r_config_init() Jia-Ju Bai
@ 2018-07-27 13:31 ` Andrew Lunn
2018-07-27 21:12 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2018-07-27 13:31 UTC (permalink / raw)
To: Jia-Ju Bai; +Cc: f.fainelli, netdev, linux-kernel
On Fri, Jul 27, 2018 at 04:34:25PM +0800, Jia-Ju Bai wrote:
> m88e1116r_config_init() is never called in atomic context.
> It calls mdelay() to busily wait, which is not necessary.
> mdelay() can be replaced with msleep().
>
> This is found by a static analysis tool named DCNS written by myself.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: marvell: Replace mdelay() with msleep() in m88e1116r_config_init()
2018-07-27 8:34 [PATCH] net: phy: marvell: Replace mdelay() with msleep() in m88e1116r_config_init() Jia-Ju Bai
2018-07-27 13:31 ` Andrew Lunn
@ 2018-07-27 21:12 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-07-27 21:12 UTC (permalink / raw)
To: baijiaju1990; +Cc: andrew, f.fainelli, netdev, linux-kernel
From: Jia-Ju Bai <baijiaju1990@gmail.com>
Date: Fri, 27 Jul 2018 16:34:25 +0800
> m88e1116r_config_init() is never called in atomic context.
> It calls mdelay() to busily wait, which is not necessary.
> mdelay() can be replaced with msleep().
>
> This is found by a static analysis tool named DCNS written by myself.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-27 21:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-27 8:34 [PATCH] net: phy: marvell: Replace mdelay() with msleep() in m88e1116r_config_init() Jia-Ju Bai
2018-07-27 13:31 ` Andrew Lunn
2018-07-27 21:12 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.