[virtio-dev] [PATCH v3] content: Introduce VIRTIO_NET_F_STANDBY feature

[virtio-dev] [PATCH v3] content: Introduce VIRTIO_NET_F_STANDBY feature

[Sridhar Samudrala]

VIRTIO_NET_F_STANDBY feature enables hypervisor to indicate virtio_net
device to act as a standby for another device with the same MAC address.

Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com
---
 content.tex | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/content.tex b/content.tex
index be18234..42a0e7e 100644
--- a/content.tex
+++ b/content.tex
@@ -2525,6 +2525,9 @@ features.
 
 \item[VIRTIO_NET_F_CTRL_MAC_ADDR(23)] Set MAC address through control
     channel.
+
+\item[VIRTIO_NET_F_STANDBY(62)] Device may act as a standby for a primary
+    device with the same MAC address.
 \end{description}
 
 \subsubsection{Feature bit requirements}\label{sec:Device Types / Network Device / Feature bits / Feature bit requirements}
@@ -2614,6 +2617,9 @@ level ethernet header length) size with \field{gso_type} NONE or ECN, and do
 so without fragmentation, after VIRTIO_NET_F_MTU has been successfully
 negotiated.
 
+If the driver negotiates the VIRTIO_NET_F_STANDBY feature, the device MAY act
+as a standby device for a primary device with the same MAC address.
+
 \drivernormative{\subsubsection}{Device configuration layout}{Device Types / Network Device / Device configuration layout}
 
 A driver SHOULD negotiate VIRTIO_NET_F_MAC if the device offers it.
@@ -2636,6 +2642,8 @@ If the driver negotiates VIRTIO_NET_F_MTU, it MUST NOT transmit packets of
 size exceeding the value of \field{mtu} (plus low level ethernet header length)
 with \field{gso_type} NONE or ECN.
 
+A driver SHOULD negotiate the VIRTIO_NET_F_STANDBY feature if the device offers it.
+
 \subsubsection{Legacy Interface: Device configuration layout}\label{sec:Device Types / Network Device / Device configuration layout / Legacy Interface: Device configuration layout}
 \label{sec:Device Types / Block Device / Feature bits / Device configuration layout / Legacy Interface: Device configuration layout}
 When using the legacy interface, transitional devices and drivers
-- 
2.14.4


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

[virtio-dev] Re: [PATCH v3] content: Introduce VIRTIO_NET_F_STANDBY feature

[Cornelia Huck]

On Wed, 25 Jul 2018 09:40:40 -0700
Sridhar Samudrala <sridhar.samudrala@intel.com> wrote:

> VIRTIO_NET_F_STANDBY feature enables hypervisor to indicate virtio_net
> device to act as a standby for another device with the same MAC address.
> 
> Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com

(missing closing bracket)

> ---
>  content.tex | 8 ++++++++
>  1 file changed, 8 insertions(+)

While we certainly need to add more details later, I think we should
just go ahead with this now as it at least gives some basic information
about the merged feature.

Acked-by: Cornelia Huck <cohuck@redhat.com>

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

[virtio-dev] Re: [PATCH v3] content: Introduce VIRTIO_NET_F_STANDBY feature

[Michael S. Tsirkin]

On Fri, Jul 27, 2018 at 02:58:59PM +0200, Cornelia Huck wrote:
> On Wed, 25 Jul 2018 09:40:40 -0700
> Sridhar Samudrala <sridhar.samudrala@intel.com> wrote:
> 
> > VIRTIO_NET_F_STANDBY feature enables hypervisor to indicate virtio_net
> > device to act as a standby for another device with the same MAC address.
> > 
> > Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com
> 
> (missing closing bracket)
> 
> > ---
> >  content.tex | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> 
> While we certainly need to add more details later, I think we should
> just go ahead with this now as it at least gives some basic information
> about the merged feature.
> 
> Acked-by: Cornelia Huck <cohuck@redhat.com>

Sounds good. Sridhar, for voting to proceed, you need to open a github
issue, then repost the patch with acks callected and including header
Fixes: <issue url>

Ideally you would put something like [PATCH voting-proposal] in the subject but we
did not yet standardize on this.
Thanks!

-- 
MST

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org

Re: [virtio-dev] Re: [PATCH v3] content: Introduce VIRTIO_NET_F_STANDBY feature

[Samudrala, Sridhar]

> On Jul 27, 2018, at 6:03 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
> 
>> On Fri, Jul 27, 2018 at 02:58:59PM +0200, Cornelia Huck wrote:
>> On Wed, 25 Jul 2018 09:40:40 -0700
>> Sridhar Samudrala <sridhar.samudrala@intel.com> wrote:
>> 
>>> VIRTIO_NET_F_STANDBY feature enables hypervisor to indicate virtio_net
>>> device to act as a standby for another device with the same MAC address.
>>> 
>>> Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com
>> 
>> (missing closing bracket)
>> 
>>> ---
>>> content.tex | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>> 
>> While we certainly need to add more details later, I think we should
>> just go ahead with this now as it at least gives some basic information
>> about the merged feature.
>> 
>> Acked-by: Cornelia Huck <cohuck@redhat.com>
> 
> Sounds good. Sridhar, for voting to proceed, you need to open a github
> issue, then repost the patch with acks callected and including header
> Fixes: <issue url>

I am on vacation for next 2 weeks.
Will do this after I am back.

> 
> Ideally you would put something like [PATCH voting-proposal] in the subject but we
> did not yet standardize on this.
> Thanks!
> 
> -- 
> MST
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org