From: Andrew Lunn <andrew@lunn.ch>
To: Anton Vasilyev <vasilyev@ispras.ru>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Jon Mason <jonmason@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org
Subject: Re: [PATCH] net: mdio-mux: bcm-iproc: fix wrong getter and setter pair
Date: Fri, 27 Jul 2018 18:17:07 +0200 [thread overview]
Message-ID: <20180727161707.GP10686@lunn.ch> (raw)
In-Reply-To: <20180727155747.24978-1-vasilyev@ispras.ru>
On Fri, Jul 27, 2018 at 06:57:47PM +0300, Anton Vasilyev wrote:
> mdio_mux_iproc_probe() uses platform_set_drvdata() to store md pointer
> in device, whereas mdio_mux_iproc_remove() restores md pointer by
> dev_get_platdata(&pdev->dev). This leads to wrong resources release.
>
> The patch replaces getter to platform_get_drvdata.
>
> Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
Fixes: 98bc865a1ec8 ("net: mdio-mux: Add MDIO mux driver for iProc SoCs")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net: mdio-mux: bcm-iproc: fix wrong getter and setter pair
Date: Fri, 27 Jul 2018 18:17:07 +0200 [thread overview]
Message-ID: <20180727161707.GP10686@lunn.ch> (raw)
In-Reply-To: <20180727155747.24978-1-vasilyev@ispras.ru>
On Fri, Jul 27, 2018 at 06:57:47PM +0300, Anton Vasilyev wrote:
> mdio_mux_iproc_probe() uses platform_set_drvdata() to store md pointer
> in device, whereas mdio_mux_iproc_remove() restores md pointer by
> dev_get_platdata(&pdev->dev). This leads to wrong resources release.
>
> The patch replaces getter to platform_get_drvdata.
>
> Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
Fixes: 98bc865a1ec8 ("net: mdio-mux: Add MDIO mux driver for iProc SoCs")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2018-07-27 16:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 15:57 [PATCH] net: mdio-mux: bcm-iproc: fix wrong getter and setter pair Anton Vasilyev
2018-07-27 15:57 ` Anton Vasilyev
2018-07-27 16:17 ` Andrew Lunn [this message]
2018-07-27 16:17 ` Andrew Lunn
2018-07-29 2:08 ` David Miller
2018-07-29 2:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180727161707.GP10686@lunn.ch \
--to=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jonmason@broadcom.com \
--cc=ldv-project@linuxtesting.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=vasilyev@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.