* [Buildroot] [PATCH 1/1] postgresql --with-libxml configure option added [not found] ` <F73717A01AEC1F4CB9A3D10E39CBB88F443662EA@INNO-EX-2010.innovaphone.sifi> @ 2018-07-27 7:06 ` Thomas Ehrhardt 2018-07-27 7:31 ` Thomas Petazzoni 0 siblings, 1 reply; 6+ messages in thread From: Thomas Ehrhardt @ 2018-07-27 7:06 UTC (permalink / raw) To: buildroot The postgresql package is now built with --with-libxml if BR2_PACKAGE_LIBXML2 is selected to allow the use of XML functions in postgresql. Signed-off-by: Daniel Deterding <dde@innovaphone.com> --- package/postgresql/postgresql.mk | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/package/postgresql/postgresql.mk b/package/postgresql/postgresql.mk index 94b3e60e59..0940873686 100644 --- a/package/postgresql/postgresql.mk +++ b/package/postgresql/postgresql.mk @@ -70,6 +70,14 @@ else POSTGRESQL_CONF_OPTS += --without-ldap endif +ifeq ($(BR2_PACKAGE_LIBXML2),y) +POSTGRESQL_DEPENDENCIES += libxml2 +POSTGRESQL_CONF_OPTS += --with-libxml +POSTGRESQL_CONF_ENV += XML2_CONFIG=$(STAGING_DIR)/usr/bin/xml2-config +else +POSTGRESQL_CONF_OPTS += --without-libxml +endif + define POSTGRESQL_USERS postgres -1 postgres -1 * /var/lib/pgsql /bin/sh - PostgreSQL Server endef -- 2.11.0 _______________________________________________________________________________ Thomas Ehrhardt | Development _______________________________________________________________________________ innovaphone AG PURE IP COMMUNICATIONS B?blinger Stra?e 76 | 71065 Sindelfingen | Germany Tel: +49(7031)73009-648 | Fax: +49(7031)73009-9 E-Mail: tehrhardt at innovaphone.com | http://www.innovaphone.com [Sitz der Gesellschaft: Sindelfingen | HRB Nr. 245196 Amtsgericht Stuttgart | Vorstand: Dagmar Geer (Vorsitzende), Carsten Bode, Guntram Diehl, Gerd Hornig | Vorsitzender des Aufsichtsrates: Gebhard Michel] Campaign - https://www.youtube.com/user/innovaphoneTV [X] ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] postgresql --with-libxml configure option added 2018-07-27 7:06 ` [Buildroot] [PATCH 1/1] postgresql --with-libxml configure option added Thomas Ehrhardt @ 2018-07-27 7:31 ` Thomas Petazzoni 2018-07-27 9:55 ` Arnout Vandecappelle 0 siblings, 1 reply; 6+ messages in thread From: Thomas Petazzoni @ 2018-07-27 7:31 UTC (permalink / raw) To: buildroot Hello Thomas, On Fri, 27 Jul 2018 07:06:48 +0000, Thomas Ehrhardt wrote: > The postgresql package is now built with --with-libxml if BR2_PACKAGE_LIBXML2 is selected to allow the use of XML functions in postgresql. > > Signed-off-by: Daniel Deterding <dde@innovaphone.com> Thanks for your patch, it looks good, but there's one issue: the From doesn't match the Signed-off-by. If I understand correctly, the patch was done by your colleague Daniel Deterding, and you are sending it on his behalf. If that is correct, then you need to add your own Signed-off-by below the one from Daniel. While you're at it, could you fix the minor issues below (I had fixed them locally as I was about to apply the patch, but realized the Signed-off-by issue) : - The commit title should have the format: <package>: <description> A better commit title is: postgresql: add optional dependency on libxml2 - The commit log text should be wrapped at 72 characters. Except these, it looks good. Could you resend an updated version ? Thanks a lot for your contribution! Thomas -- Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] postgresql --with-libxml configure option added 2018-07-27 7:31 ` Thomas Petazzoni @ 2018-07-27 9:55 ` Arnout Vandecappelle 2018-07-27 21:39 ` Adam Duskett 0 siblings, 1 reply; 6+ messages in thread From: Arnout Vandecappelle @ 2018-07-27 9:55 UTC (permalink / raw) To: buildroot On 27-07-18 09:31, Thomas Petazzoni wrote: > Hello Thomas, > > On Fri, 27 Jul 2018 07:06:48 +0000, Thomas Ehrhardt wrote: >> The postgresql package is now built with --with-libxml if BR2_PACKAGE_LIBXML2 is selected to allow the use of XML functions in postgresql. >> >> Signed-off-by: Daniel Deterding <dde@innovaphone.com> > > Thanks for your patch, it looks good, but there's one issue: the From > doesn't match the Signed-off-by. > > If I understand correctly, the patch was done by your colleague Daniel > Deterding, and you are sending it on his behalf. If that is correct, > then you need to add your own Signed-off-by below the one from Daniel. And you should also set the author to Daniel, e.g. with git commit --amend --author="Daniel Deterding <dde@innovaphone.com>" Regards, Arnout > > While you're at it, could you fix the minor issues below (I had fixed > them locally as I was about to apply the patch, but realized the > Signed-off-by issue) : > > - The commit title should have the format: > > <package>: <description> > > A better commit title is: > > postgresql: add optional dependency on libxml2 > > - The commit log text should be wrapped at 72 characters. > > Except these, it looks good. Could you resend an updated version ? > > Thanks a lot for your contribution! > > Thomas > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] postgresql --with-libxml configure option added 2018-07-27 9:55 ` Arnout Vandecappelle @ 2018-07-27 21:39 ` Adam Duskett 2018-07-27 21:49 ` Thomas Petazzoni 0 siblings, 1 reply; 6+ messages in thread From: Adam Duskett @ 2018-07-27 21:39 UTC (permalink / raw) To: buildroot Hello; Another nitpick I would have is that there should probably be a Config.in entry for this as well. On Fri, Jul 27, 2018 at 5:55 AM Arnout Vandecappelle <arnout@mind.be> wrote: > > > > On 27-07-18 09:31, Thomas Petazzoni wrote: > > Hello Thomas, > > > > On Fri, 27 Jul 2018 07:06:48 +0000, Thomas Ehrhardt wrote: > >> The postgresql package is now built with --with-libxml if BR2_PACKAGE_LIBXML2 is selected to allow the use of XML functions in postgresql. > >> > >> Signed-off-by: Daniel Deterding <dde@innovaphone.com> > > > > Thanks for your patch, it looks good, but there's one issue: the From > > doesn't match the Signed-off-by. > > > > If I understand correctly, the patch was done by your colleague Daniel > > Deterding, and you are sending it on his behalf. If that is correct, > > then you need to add your own Signed-off-by below the one from Daniel. > > And you should also set the author to Daniel, e.g. with > > git commit --amend --author="Daniel Deterding <dde@innovaphone.com>" > > Regards, > Arnout > > > > > While you're at it, could you fix the minor issues below (I had fixed > > them locally as I was about to apply the patch, but realized the > > Signed-off-by issue) : > > > > - The commit title should have the format: > > > > <package>: <description> > > > > A better commit title is: > > > > postgresql: add optional dependency on libxml2 > > > > - The commit log text should be wrapped at 72 characters. > > > > Except these, it looks good. Could you resend an updated version ? > > > > Thanks a lot for your contribution! > > > > Thomas > > > > -- > Arnout Vandecappelle arnout at mind be > Senior Embedded Software Architect +32-16-286500 > Essensium/Mind http://www.mind.be > G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven > LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle > GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] postgresql --with-libxml configure option added 2018-07-27 21:39 ` Adam Duskett @ 2018-07-27 21:49 ` Thomas Petazzoni 0 siblings, 0 replies; 6+ messages in thread From: Thomas Petazzoni @ 2018-07-27 21:49 UTC (permalink / raw) To: buildroot Hello, On Fri, 27 Jul 2018 17:39:57 -0400, Adam Duskett wrote: > Another nitpick I would have is that there should probably be a > Config.in entry for this as well. No, probably not. As a general rule in Buildroot, we prefer automatic handling of optional dependencies, in order to avoid a proliferation of gazillion of Config.in options. In addition, postgresql.mk already handles all its optional dependencies this way. The only reason to not do this in this case would be if the XML2 support in postgresql increases significantly the size of the postgresql binary. But again, in general, automatic handling of optional dependencies is preferred. Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <549ffe67-ad9f-b607-6735-09faa86f0b09@gmx.de>]
* [Buildroot] [PATCH 1/1] postgresql --with-libxml configure option added [not found] <549ffe67-ad9f-b607-6735-09faa86f0b09@gmx.de> @ 2018-06-11 20:19 ` Peter Seiderer 0 siblings, 0 replies; 6+ messages in thread From: Peter Seiderer @ 2018-06-11 20:19 UTC (permalink / raw) To: buildroot Hello Daniel, On Fri, 8 Jun 2018 08:46:42 +0200, Daniel Deterding <daniel.deterding@gmx.de> wrote: > The postgresql package is now built with --with-libxml if > BR2_PACKAGE_LIBXML2 is selected to allow the use of XML functions in > postgresql. Minor nit, maybe add: Fixes https://bugs.busybox.net/show_bug.cgi?id=11071 > > Signed-off-by: Daniel Deterding <dde@innovaphone.com> Thanks for the patch, you can add my Reviewed-by: Peter Seiderer <ps.report@gmx.net> But I believe your email did not yet hit the mailing list/patchwork (I did not find it there [1], [2])... Regards, Peter [1] http://lists.busybox.net/pipermail/buildroot/2018-June/date.html [2] https://patchwork.ozlabs.org/project/buildroot/list/ > --- > ?package/postgresql/postgresql.mk | 8 ++++++++ > ?1 file changed, 8 insertions(+) > > diff --git a/package/postgresql/postgresql.mk > b/package/postgresql/postgresql.mk > index 94b3e60e59..0940873686 100644 > --- a/package/postgresql/postgresql.mk > +++ b/package/postgresql/postgresql.mk > @@ -70,6 +70,14 @@ else > ?POSTGRESQL_CONF_OPTS += --without-ldap > ?endif > > +ifeq ($(BR2_PACKAGE_LIBXML2),y) > +POSTGRESQL_DEPENDENCIES += libxml2 > +POSTGRESQL_CONF_OPTS += --with-libxml > +POSTGRESQL_CONF_ENV += XML2_CONFIG=$(STAGING_DIR)/usr/bin/xml2-config > +else > +POSTGRESQL_CONF_OPTS += --without-libxml > +endif > + > ?define POSTGRESQL_USERS > ??????? postgres -1 postgres -1 * /var/lib/pgsql /bin/sh - PostgreSQL > Server > ?endef > -- > 2.11.0 > > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-27 21:49 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20180608062231.2345-1-dde@innovaphone.com> [not found] ` <F73717A01AEC1F4CB9A3D10E39CBB88F4424CD47@INNO-EX-2010.innovaphone.sifi> [not found] ` <F73717A01AEC1F4CB9A3D10E39CBB88F443662EA@INNO-EX-2010.innovaphone.sifi> 2018-07-27 7:06 ` [Buildroot] [PATCH 1/1] postgresql --with-libxml configure option added Thomas Ehrhardt 2018-07-27 7:31 ` Thomas Petazzoni 2018-07-27 9:55 ` Arnout Vandecappelle 2018-07-27 21:39 ` Adam Duskett 2018-07-27 21:49 ` Thomas Petazzoni [not found] <549ffe67-ad9f-b607-6735-09faa86f0b09@gmx.de> 2018-06-11 20:19 ` Peter Seiderer
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.