* [PATCH] net/wireless/atmel: fix defined but not used warning
@ 2018-07-07 15:33 Randy Dunlap
2018-07-31 7:05 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2018-07-07 15:33 UTC (permalink / raw)
To: Simon Kelley, linux-wireless, Kalle Valo, David Miller, netdev
From: Randy Dunlap <rdunlap@infradead.org>
Fix a build warning in drivers/net/wireless/atmel/ when CONFIG_PROC_FS
is not enabled by marking the unused function as __maybe_unused.
../drivers/net/wireless/atmel/atmel.c:1402:12: warning: 'atmel_proc_show' defined but not used [-Wunused-function]
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Simon Kelley <simon@thekelleys.org.uk>
Cc: linux-wireless@vger.kernel.org
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
---
drivers/net/wireless/atmel/atmel.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-next-20180706.orig/drivers/net/wireless/atmel/atmel.c
+++ linux-next-20180706/drivers/net/wireless/atmel/atmel.c
@@ -39,6 +39,7 @@
******************************************************************************/
+#include <linux/compiler.h>
#include <linux/interrupt.h>
#include <linux/kernel.h>
@@ -1399,7 +1400,7 @@ static int atmel_validate_channel(struct
return 0;
}
-static int atmel_proc_show(struct seq_file *m, void *v)
+static int __maybe_unused atmel_proc_show(struct seq_file *m, void *v)
{
struct atmel_private *priv = m->private;
int i;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net/wireless/atmel: fix defined but not used warning
2018-07-07 15:33 [PATCH] net/wireless/atmel: fix defined but not used warning Randy Dunlap
@ 2018-07-31 7:05 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2018-07-31 7:05 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Simon Kelley, linux-wireless, David Miller, netdev
Randy Dunlap <rdunlap@infradead.org> wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix a build warning in drivers/net/wireless/atmel/ when CONFIG_PROC_FS
> is not enabled by marking the unused function as __maybe_unused.
>
> ../drivers/net/wireless/atmel/atmel.c:1402:12: warning: 'atmel_proc_show' defined but not used [-Wunused-function]
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Simon Kelley <simon@thekelleys.org.uk>
> Cc: linux-wireless@vger.kernel.org
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: netdev@vger.kernel.org
I'll drop this as I take Yue's version instead.
Patch set to Changes Requested.
--
https://patchwork.kernel.org/patch/10512913/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-31 8:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-07 15:33 [PATCH] net/wireless/atmel: fix defined but not used warning Randy Dunlap
2018-07-31 7:05 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.