From: Rob Herring <robh@kernel.org> To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Cc: lee.jones@linaro.org, broonie@kernel.org, mark.rutland@arm.com, lgirdwood@gmail.com, tiwai@suse.com, bgoswami@codeaurora.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, vkoul@kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v2 01/10] ASoC: dt-bindings: add dt bindings for wcd9335 audio codec Date: Tue, 31 Jul 2018 14:43:15 -0600 [thread overview] Message-ID: <20180731204315.GA5265@rob-hp-laptop> (raw) In-Reply-To: <20180727121806.18209-2-srinivas.kandagatla@linaro.org> On Fri, Jul 27, 2018 at 01:17:57PM +0100, Srinivas Kandagatla wrote: > This patch adds bindings for wcd9335 audio codec which can support both SLIMbus > and I2S/I2C interface. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > .../devicetree/bindings/sound/qcom,wcd9335.txt | 123 +++++++++++++++++++++ > 1 file changed, 123 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd9335.txt > > diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt b/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt > new file mode 100644 > index 000000000000..1d8d49e30af7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt > @@ -0,0 +1,123 @@ > +QCOM WCD9335 Codec > + > +Qualcomm WCD9335 Codec is a standalone Hi-Fi audio codec IC, supports > +Qualcomm Technologies, Inc. (QTI) multimedia solutions, including > +the MSM8996, MSM8976, and MSM8956 chipsets. It has in-built > +Soundwire controller, interrupt mux. It supports both I2S/I2C and > +SLIMbus audio interfaces. > + > +Required properties with SLIMbus Interface: > + > +- compatible: > + Usage: required > + Value type: <stringlist> > + Definition: For SLIMbus interface it should be "slimMID,PID", > + textual representation of Manufacturer ID, Product Code, > + shall be in lower case hexadecimal with leading zeroes > + suppressed. Refer to slimbus/bus.txt for details. > + Should be: > + "slim217,1a0" for MSM8996 and APQ8096 SoCs with SLIMbus. > + > +- reg > + Usage: required > + Value type: <u32 u32> > + Definition: Should be ('Device index', 'Instance ID') > + > +- interrupts > + Usage: required > + Value type: <prop-encoded-array> > + Definition: Interrupts via WCD INTR1 and INTR2 pins > + > +- interrupt-names: > + Usage: required > + Value type: <String array> > + Definition: Interrupt names of WCD INTR1 and INTR2 > + Should be: "intr1", "intr2" > + > +- reset-gpio: reset-gpios > + Usage: required > + Value type: <String Array> > + Definition: Reset gpio line > + > +- qcom,ifd: > + Usage: required > + Value type: <phandle> > + Definition: SLIM interface device Wouldn't this be the parent? > + > +- clocks: > + Usage: required > + Value type: <prop-encoded-array> > + Definition: See clock-bindings.txt section "consumers". List of > + three clock specifiers for mclk, mclk2 and slimbus clock. > + > +- clock-names: > + Usage: required > + Value type: <string> > + Definition: Must contain "mclk", "mclk2" and "slimbus" strings. > + > +- vdd-buck-supply: > + Usage: required > + Value type: <phandle> > + Definition: Should contain a reference to the 1.8V buck supply > + > +- vdd-buck-sido-supply: > + Usage: required > + Value type: <phandle> > + Definition: Should contain a reference to the 1.8V SIDO buck supply > + > +- vdd-rx-supply: > + Usage: required > + Value type: <phandle> > + Definition: Should contain a reference to the 1.8V rx supply > + > +- vdd-tx-supply: > + Usage: required > + Value type: <phandle> > + Definition: Should contain a reference to the 1.8V tx supply > + > +- vdd-vbat-supply: > + Usage: Optional > + Value type: <phandle> > + Definition: Should contain a reference to the vbat supply > + > +- vdd-micbias-supply: > + Usage: required > + Value type: <phandle> > + Definition: Should contain a reference to the micbias supply > + > +- vdd-io-supply: > + Usage: required > + Value type: <phandle> > + Definition: Should contain a reference to the 1.8V io supply > + > +- interrupt-controller: > + Usage: required > + Definition: Indicating that this is a interrupt controller > + > +- #interrupt-cells: > + Usage: required > + Value type: <int> > + Definition: should be 1 > + > +#sound-dai-cells > + Usage: required > + Value type: <u32> > + Definition: Must be 1 > + > +codec@1{ audio-codec@1 > + compatible = "slim217,1a0"; > + reg = <1 0>; > + interrupts = <&msmgpio 54 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "intr2" > + reset-gpio = <&msmgpio 64 0>; > + qcom,ifd = <&wc9335_ifd>; > + clock-names = "mclk", "native"; > + clocks = <&rpmcc RPM_SMD_DIV_CLK1>, > + <&rpmcc RPM_SMD_BB_CLK1>; > + vdd-buck-supply = <&pm8994_s4>; > + vdd-rx-supply = <&pm8994_s4>; > + vdd-buck-sido-supply = <&pm8994_s4>; > + vdd-tx-supply = <&pm8994_s4>; > + vdd-io-supply = <&pm8994_s4>; > + #sound-dai-cells = <1>; > +} > -- > 2.16.2 >
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, tiwai@suse.com, vkoul@kernel.org, broonie@kernel.org, lee.jones@linaro.org Subject: Re: [PATCH v2 01/10] ASoC: dt-bindings: add dt bindings for wcd9335 audio codec Date: Tue, 31 Jul 2018 14:43:15 -0600 [thread overview] Message-ID: <20180731204315.GA5265@rob-hp-laptop> (raw) In-Reply-To: <20180727121806.18209-2-srinivas.kandagatla@linaro.org> On Fri, Jul 27, 2018 at 01:17:57PM +0100, Srinivas Kandagatla wrote: > This patch adds bindings for wcd9335 audio codec which can support both SLIMbus > and I2S/I2C interface. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > .../devicetree/bindings/sound/qcom,wcd9335.txt | 123 +++++++++++++++++++++ > 1 file changed, 123 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd9335.txt > > diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt b/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt > new file mode 100644 > index 000000000000..1d8d49e30af7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt > @@ -0,0 +1,123 @@ > +QCOM WCD9335 Codec > + > +Qualcomm WCD9335 Codec is a standalone Hi-Fi audio codec IC, supports > +Qualcomm Technologies, Inc. (QTI) multimedia solutions, including > +the MSM8996, MSM8976, and MSM8956 chipsets. It has in-built > +Soundwire controller, interrupt mux. It supports both I2S/I2C and > +SLIMbus audio interfaces. > + > +Required properties with SLIMbus Interface: > + > +- compatible: > + Usage: required > + Value type: <stringlist> > + Definition: For SLIMbus interface it should be "slimMID,PID", > + textual representation of Manufacturer ID, Product Code, > + shall be in lower case hexadecimal with leading zeroes > + suppressed. Refer to slimbus/bus.txt for details. > + Should be: > + "slim217,1a0" for MSM8996 and APQ8096 SoCs with SLIMbus. > + > +- reg > + Usage: required > + Value type: <u32 u32> > + Definition: Should be ('Device index', 'Instance ID') > + > +- interrupts > + Usage: required > + Value type: <prop-encoded-array> > + Definition: Interrupts via WCD INTR1 and INTR2 pins > + > +- interrupt-names: > + Usage: required > + Value type: <String array> > + Definition: Interrupt names of WCD INTR1 and INTR2 > + Should be: "intr1", "intr2" > + > +- reset-gpio: reset-gpios > + Usage: required > + Value type: <String Array> > + Definition: Reset gpio line > + > +- qcom,ifd: > + Usage: required > + Value type: <phandle> > + Definition: SLIM interface device Wouldn't this be the parent? > + > +- clocks: > + Usage: required > + Value type: <prop-encoded-array> > + Definition: See clock-bindings.txt section "consumers". List of > + three clock specifiers for mclk, mclk2 and slimbus clock. > + > +- clock-names: > + Usage: required > + Value type: <string> > + Definition: Must contain "mclk", "mclk2" and "slimbus" strings. > + > +- vdd-buck-supply: > + Usage: required > + Value type: <phandle> > + Definition: Should contain a reference to the 1.8V buck supply > + > +- vdd-buck-sido-supply: > + Usage: required > + Value type: <phandle> > + Definition: Should contain a reference to the 1.8V SIDO buck supply > + > +- vdd-rx-supply: > + Usage: required > + Value type: <phandle> > + Definition: Should contain a reference to the 1.8V rx supply > + > +- vdd-tx-supply: > + Usage: required > + Value type: <phandle> > + Definition: Should contain a reference to the 1.8V tx supply > + > +- vdd-vbat-supply: > + Usage: Optional > + Value type: <phandle> > + Definition: Should contain a reference to the vbat supply > + > +- vdd-micbias-supply: > + Usage: required > + Value type: <phandle> > + Definition: Should contain a reference to the micbias supply > + > +- vdd-io-supply: > + Usage: required > + Value type: <phandle> > + Definition: Should contain a reference to the 1.8V io supply > + > +- interrupt-controller: > + Usage: required > + Definition: Indicating that this is a interrupt controller > + > +- #interrupt-cells: > + Usage: required > + Value type: <int> > + Definition: should be 1 > + > +#sound-dai-cells > + Usage: required > + Value type: <u32> > + Definition: Must be 1 > + > +codec@1{ audio-codec@1 > + compatible = "slim217,1a0"; > + reg = <1 0>; > + interrupts = <&msmgpio 54 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "intr2" > + reset-gpio = <&msmgpio 64 0>; > + qcom,ifd = <&wc9335_ifd>; > + clock-names = "mclk", "native"; > + clocks = <&rpmcc RPM_SMD_DIV_CLK1>, > + <&rpmcc RPM_SMD_BB_CLK1>; > + vdd-buck-supply = <&pm8994_s4>; > + vdd-rx-supply = <&pm8994_s4>; > + vdd-buck-sido-supply = <&pm8994_s4>; > + vdd-tx-supply = <&pm8994_s4>; > + vdd-io-supply = <&pm8994_s4>; > + #sound-dai-cells = <1>; > +} > -- > 2.16.2 >
next prev parent reply other threads:[~2018-07-31 20:43 UTC|newest] Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-27 12:17 [PATCH v2 00/10] ASoC: Add support to WCD9335 Audio Codec Srinivas Kandagatla 2018-07-27 12:17 ` Srinivas Kandagatla 2018-07-27 12:17 ` [PATCH v2 01/10] ASoC: dt-bindings: add dt bindings for wcd9335 audio codec Srinivas Kandagatla 2018-07-31 20:43 ` Rob Herring [this message] 2018-07-31 20:43 ` Rob Herring 2018-08-01 8:56 ` Srinivas Kandagatla 2018-08-01 22:20 ` Rob Herring 2018-08-01 22:20 ` Rob Herring 2018-08-02 7:33 ` Srinivas Kandagatla 2018-08-02 14:07 ` Rob Herring 2018-08-01 11:20 ` Applied "ASoC: dt-bindings: add dt bindings for wcd9335 audio codec" to the asoc tree Mark Brown 2018-08-01 11:20 ` Mark Brown 2018-08-14 16:24 ` Rob Herring 2018-08-15 10:52 ` Mark Brown 2018-08-15 10:52 ` Mark Brown 2018-07-27 12:17 ` [PATCH v2 02/10] mfd: wcd9335: add support to wcd9335 core Srinivas Kandagatla 2018-07-30 4:12 ` Vinod 2018-08-01 8:57 ` Srinivas Kandagatla 2018-08-02 8:33 ` Lee Jones 2018-08-02 9:26 ` Srinivas Kandagatla 2018-08-02 9:57 ` Lee Jones 2018-08-02 9:57 ` Lee Jones 2018-07-27 12:17 ` [PATCH v2 03/10] mfd: wcd9335: add wcd irq support Srinivas Kandagatla 2018-07-31 20:45 ` Rob Herring 2018-08-01 8:57 ` Srinivas Kandagatla 2018-08-01 22:17 ` Rob Herring 2018-08-02 7:34 ` Srinivas Kandagatla 2018-08-02 8:05 ` Lee Jones 2018-08-02 8:54 ` Srinivas Kandagatla 2018-08-02 10:01 ` Lee Jones 2018-08-02 10:07 ` Srinivas Kandagatla 2018-07-27 12:18 ` [PATCH v2 04/10] ASoC: wcd9335: add support to wcd9335 codec Srinivas Kandagatla 2018-07-27 12:18 ` Srinivas Kandagatla 2018-08-01 11:20 ` Applied "ASoC: wcd9335: add support to wcd9335 codec" to the asoc tree Mark Brown 2018-08-01 11:20 ` Mark Brown 2018-08-01 12:24 ` Srinivas Kandagatla 2018-08-02 6:32 ` Lee Jones 2018-08-02 6:32 ` Lee Jones 2018-07-27 12:18 ` [PATCH v2 05/10] ASoC: wcd9335: add CLASS-H Controller support Srinivas Kandagatla 2018-07-31 17:05 ` Mark Brown 2018-07-31 17:05 ` Mark Brown 2018-08-01 8:57 ` Srinivas Kandagatla 2018-08-01 11:20 ` Applied "ASoC: wcd9335: add CLASS-H Controller support" to the asoc tree Mark Brown 2018-08-01 11:20 ` Mark Brown 2018-08-01 12:26 ` Srinivas Kandagatla 2018-08-01 12:26 ` Srinivas Kandagatla 2018-08-02 6:31 ` Lee Jones 2018-08-02 9:52 ` Mark Brown 2018-07-27 12:18 ` [PATCH v2 06/10] ASoC: wcd9335: add basic controls Srinivas Kandagatla 2018-07-31 17:16 ` Mark Brown 2018-08-01 8:57 ` Srinivas Kandagatla 2018-07-27 12:18 ` [PATCH v2 07/10] ASoC: wcd9335: add playback dapm widgets Srinivas Kandagatla 2018-07-27 12:18 ` [PATCH v2 08/10] ASoC: wcd9335: add capture " Srinivas Kandagatla 2018-07-27 12:18 ` [PATCH v2 09/10] ASoC: wcd9335: add audio routings Srinivas Kandagatla 2018-07-27 12:18 ` [PATCH v2 10/10] ASoC: apq8096: add support to Analog audio via WCD9335 slim Srinivas Kandagatla 2018-07-30 4:49 ` [PATCH v2 00/10] ASoC: Add support to WCD9335 Audio Codec Vinod 2018-07-30 4:49 ` Vinod
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180731204315.GA5265@rob-hp-laptop \ --to=robh@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=bgoswami@codeaurora.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=lee.jones@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=srinivas.kandagatla@linaro.org \ --cc=tiwai@suse.com \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.