* [PATCH net-next] rds: remove redundant variable 'rds_ibdev'
@ 2018-08-01 7:14 ` YueHaibing
0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2018-08-01 7:14 UTC (permalink / raw)
To: davem, santosh.shilimkar
Cc: linux-kernel, netdev, linux-rdma, rds-devel, YueHaibing
Variable 'rds_ibdev' is being assigned but never used,
so can be removed.
fix this clang warning:
net/rds/ib_send.c:762:24: warning: variable ‘rds_ibdev’ set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
net/rds/ib_send.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/rds/ib_send.c b/net/rds/ib_send.c
index c4cdfe49..c8dd312 100644
--- a/net/rds/ib_send.c
+++ b/net/rds/ib_send.c
@@ -759,14 +759,11 @@ int rds_ib_xmit_atomic(struct rds_connection *conn, struct rm_atomic_op *op)
struct rds_ib_connection *ic = conn->c_transport_data;
struct rds_ib_send_work *send = NULL;
struct ib_send_wr *failed_wr;
- struct rds_ib_device *rds_ibdev;
u32 pos;
u32 work_alloc;
int ret;
int nr_sig = 0;
- rds_ibdev = ib_get_client_data(ic->i_cm_id->device, &rds_ib_client);
-
work_alloc = rds_ib_ring_alloc(&ic->i_send_ring, 1, &pos);
if (work_alloc != 1) {
rds_ib_stats_inc(s_ib_tx_ring_full);
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH net-next] rds: remove redundant variable 'rds_ibdev'
@ 2018-08-01 7:14 ` YueHaibing
0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2018-08-01 7:14 UTC (permalink / raw)
To: davem, santosh.shilimkar
Cc: linux-kernel, netdev, linux-rdma, rds-devel, YueHaibing
Variable 'rds_ibdev' is being assigned but never used,
so can be removed.
fix this clang warning:
net/rds/ib_send.c:762:24: warning: variable ‘rds_ibdev’ set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
net/rds/ib_send.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/rds/ib_send.c b/net/rds/ib_send.c
index c4cdfe49..c8dd312 100644
--- a/net/rds/ib_send.c
+++ b/net/rds/ib_send.c
@@ -759,14 +759,11 @@ int rds_ib_xmit_atomic(struct rds_connection *conn, struct rm_atomic_op *op)
struct rds_ib_connection *ic = conn->c_transport_data;
struct rds_ib_send_work *send = NULL;
struct ib_send_wr *failed_wr;
- struct rds_ib_device *rds_ibdev;
u32 pos;
u32 work_alloc;
int ret;
int nr_sig = 0;
- rds_ibdev = ib_get_client_data(ic->i_cm_id->device, &rds_ib_client);
-
work_alloc = rds_ib_ring_alloc(&ic->i_send_ring, 1, &pos);
if (work_alloc != 1) {
rds_ib_stats_inc(s_ib_tx_ring_full);
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] rds: remove redundant variable 'rds_ibdev'
2018-08-01 7:14 ` YueHaibing
(?)
@ 2018-08-01 17:01 ` David Miller
-1 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2018-08-01 17:01 UTC (permalink / raw)
To: yuehaibing; +Cc: santosh.shilimkar, linux-kernel, netdev, linux-rdma, rds-devel
From: YueHaibing <yuehaibing@huawei.com>
Date: Wed, 1 Aug 2018 15:14:07 +0800
> Variable 'rds_ibdev' is being assigned but never used,
> so can be removed.
>
> fix this clang warning:
> net/rds/ib_send.c:762:24: warning: variable ‘rds_ibdev’ set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-01 17:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-01 7:14 [PATCH net-next] rds: remove redundant variable 'rds_ibdev' YueHaibing
2018-08-01 7:14 ` YueHaibing
2018-08-01 17:01 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.