[Buildroot] [PATCH 1/1] package/polkit: bump version to 1.105

[Buildroot] [PATCH 1/1] package/polkit: bump version to 1.105

[Artem Panfilov]

Fixes build issue with network-manager package when polkit package is
enabled.

Signed-off-by: Artem Panfilov <apanfilov@spectracom.com>
---
 package/polkit/polkit.hash | 2 +-
 package/polkit/polkit.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/polkit/polkit.hash b/package/polkit/polkit.hash
index 5e133b43e2..b4a1a854c5 100644
--- a/package/polkit/polkit.hash
+++ b/package/polkit/polkit.hash
@@ -1,2 +1,2 @@
 # Locally calculated after checking pgp signature
-sha256	36607c8ce576980ee55bd12bab1944f13217eb8e9d04ab56022545861ece3bc5	polkit-0.103.tar.gz
+sha256	8fdc7cc8ba4750fcce1a4db9daa759c12afebc7901237e1c993c38f08985e1df	polkit-0.103.tar.gz
diff --git a/package/polkit/polkit.mk b/package/polkit/polkit.mk
index e283181427..fb4c171c52 100644
--- a/package/polkit/polkit.mk
+++ b/package/polkit/polkit.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-POLKIT_VERSION = 0.103
+POLKIT_VERSION = 0.105
 POLKIT_SITE = http://www.freedesktop.org/software/polkit/releases
 POLKIT_LICENSE = GPL-2.0
 POLKIT_LICENSE_FILES = COPYING
-- 
2.17.1

[Buildroot] [PATCH 1/1] package/polkit: bump version to 1.105

[Thomas Petazzoni]

Hello,

On Wed,  1 Aug 2018 10:41:08 +0300, Artem Panfilov wrote:
> Fixes build issue with network-manager package when polkit package is
> enabled.
> 
> Signed-off-by: Artem Panfilov <apanfilov@spectracom.com>

Is this version still independent from the Javascript stuff that newer
versions need ? I thought we were stuck to 0.103 because of the
dependency of newer versions on MozJS.

Could you comment on this ?

Also, do you have a defconfig that exhibits the issue. I'm surprised
our autobuilders haven't found any build issue.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] package/polkit: bump version to 1.105

[tema]

 > Is this version still independent from the Javascript stuff that newer
 > versions need ? I thought we were stuck to 0.103 because of the
 > dependency of newer versions on MozJS.

Could you please provide name of the package which depends on polkit?

 > Also, do you have a defconfig that exhibits the issue. I'm surprised
 > our autobuilders haven't found any build issue.

defconfig used for build:
BR2_arm=y
BR2_cortex_a9=y
BR2_ARM_ENABLE_NEON=y
BR2_ARM_ENABLE_VFP=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_INIT_SYSTEMD=y
BR2_LINUX_KERNEL=y
BR2_LINUX_KERNEL_DEFCONFIG="socfpga"
BR2_PACKAGE_NETWORK_MANAGER=y
BR2_PACKAGE_SYSTEMD_POLKIT=y

This is build output:
 ? CCLD???? clients/cli/nmcli
clients/common/clients_cli_nmcli-nm-polkit-listener.o: In function 
`compare_users':
nm-polkit-listener.c:(.text.compare_users+0x48): undefined reference to 
`polkit_unix_user_get_name'
clients/common/clients_cli_nmcli-nm-polkit-listener.o: In function 
`initiate_authentication':
nm-polkit-listener.c:(.text.initiate_authentication+0x1c4): undefined 
reference to `polkit_unix_user_get_name'
collect2: error: ld returned 1 exit status

Thanks!

On 01.08.2018 11:57, Thomas Petazzoni wrote:
> Hello,
>
> On Wed,  1 Aug 2018 10:41:08 +0300, Artem Panfilov wrote:
>> Fixes build issue with network-manager package when polkit package is
>> enabled.
>>
>> Signed-off-by: Artem Panfilov <apanfilov@spectracom.com>
> Is this version still independent from the Javascript stuff that newer
> versions need ? I thought we were stuck to 0.103 because of the
> dependency of newer versions on MozJS.
>
> Could you comment on this ?
>
> Also, do you have a defconfig that exhibits the issue. I'm surprised
> our autobuilders haven't found any build issue.
>
> Thanks!
>
> Thomas

[Buildroot] [PATCH 1/1] package/polkit: bump version to 1.105

[Thomas Petazzoni]

Hello,

(Now with the mailing list in Cc)

On Wed, 1 Aug 2018 14:01:35 +0300, tema wrote:
> > Is this version still independent from the Javascript stuff that newer
> > versions need ? I thought we were stuck to 0.103 because of the
> > dependency of newer versions on MozJS.  
> 
> Could you please provide name of the package which depends on polkit?

Sorry, I don't get your question. My point is that recent versions of
Polkit require a Javascript interpreter, and this Javascript
interpreter is not packaged in Buildroot yet, and is a pain to package.
There were some effort a few years ago to achieve this, but it was
never completed.

> > Also, do you have a defconfig that exhibits the issue. I'm surprised
> > our autobuilders haven't found any build issue.  
> 
> defconfig used for build:
> BR2_arm=y
> BR2_cortex_a9=y
> BR2_ARM_ENABLE_NEON=y
> BR2_ARM_ENABLE_VFP=y
> BR2_TOOLCHAIN_EXTERNAL=y
> BR2_INIT_SYSTEMD=y
> BR2_LINUX_KERNEL=y
> BR2_LINUX_KERNEL_DEFCONFIG="socfpga"
> BR2_PACKAGE_NETWORK_MANAGER=y
> BR2_PACKAGE_SYSTEMD_POLKIT=y
> 
> This is build output:
>    CCLD     clients/cli/nmcli
> clients/common/clients_cli_nmcli-nm-polkit-listener.o: In function `compare_users':
> nm-polkit-listener.c:(.text.compare_users+0x48): undefined reference to `polkit_unix_user_get_name'
> clients/common/clients_cli_nmcli-nm-polkit-listener.o: In function `initiate_authentication':
> nm-polkit-listener.c:(.text.initiate_authentication+0x1c4): undefined reference to `polkit_unix_user_get_name'
> collect2: error: ld returned 1 exit status

Thanks, I'll try this out!

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] package/polkit: bump version to 1.105

[Artem Panfilov]

> Sorry, I don't get your question. My point is that recent versions of
> Polkit require a Javascript interpreter, and this Javascript
> interpreter is not packaged in Buildroot yet, and is a pain to package.
> There were some effort a few years ago to achieve this, but it was
> never completed.

mozjs build requirement was added in 0.106 version.


On 01.08.2018 14:10, Thomas Petazzoni wrote:
> Hello,
>
> (Now with the mailing list in Cc)
>
> On Wed, 1 Aug 2018 14:01:35 +0300, tema wrote:
>>> Is this version still independent from the Javascript stuff that newer
>>> versions need ? I thought we were stuck to 0.103 because of the
>>> dependency of newer versions on MozJS.
>> Could you please provide name of the package which depends on polkit?
> Sorry, I don't get your question. My point is that recent versions of
> Polkit require a Javascript interpreter, and this Javascript
> interpreter is not packaged in Buildroot yet, and is a pain to package.
> There were some effort a few years ago to achieve this, but it was
> never completed.
>
>>> Also, do you have a defconfig that exhibits the issue. I'm surprised
>>> our autobuilders haven't found any build issue.
>> defconfig used for build:
>> BR2_arm=y
>> BR2_cortex_a9=y
>> BR2_ARM_ENABLE_NEON=y
>> BR2_ARM_ENABLE_VFP=y
>> BR2_TOOLCHAIN_EXTERNAL=y
>> BR2_INIT_SYSTEMD=y
>> BR2_LINUX_KERNEL=y
>> BR2_LINUX_KERNEL_DEFCONFIG="socfpga"
>> BR2_PACKAGE_NETWORK_MANAGER=y
>> BR2_PACKAGE_SYSTEMD_POLKIT=y
>>
>> This is build output:
>>     CCLD     clients/cli/nmcli
>> clients/common/clients_cli_nmcli-nm-polkit-listener.o: In function `compare_users':
>> nm-polkit-listener.c:(.text.compare_users+0x48): undefined reference to `polkit_unix_user_get_name'
>> clients/common/clients_cli_nmcli-nm-polkit-listener.o: In function `initiate_authentication':
>> nm-polkit-listener.c:(.text.initiate_authentication+0x1c4): undefined reference to `polkit_unix_user_get_name'
>> collect2: error: ld returned 1 exit status
> Thanks, I'll try this out!
>
> Best regards,
>
> Thomas

[Buildroot] [PATCH 1/1] package/polkit: bump version to 1.105

[Thomas Petazzoni]

Hello Artem,

On Wed,  1 Aug 2018 10:41:08 +0300, Artem Panfilov wrote:
> Fixes build issue with network-manager package when polkit package is
> enabled.
> 
> Signed-off-by: Artem Panfilov <apanfilov@spectracom.com>
> ---
>  package/polkit/polkit.hash | 2 +-
>  package/polkit/polkit.mk   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

I've applied to master. However, your change to the .hash file was
wrong, and it couldn't build with it:

ERROR: No hash found for polkit-0.105.tar.gz
make[1]: *** [package/pkg-generic.mk:138: /home/thomas/projets/buildroot/output/build/polkit-0.105/.stamp_downloaded] Error 1
make: *** [Makefile:79: _all] Error 2

Indeed, you changed the hash, but not the name of the tarball.

I've fixed that up, and also extended the commit log with more details.

Thanks a lot for this contribution!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com