[igt-dev] [PATCH i-g-t] tests/psr: Skip if PSR cannot be enabled for the current mode.

[igt-dev] [PATCH i-g-t] tests/psr: Skip if PSR cannot be enabled for the current mode.

[Dhinakaran Pandiyan]

PSR tests on ICL fail waiting for PSR to become active, whereas the
driver does not enable it on the HW due to unmet timing requirements
[  482.485873] [drm:intel_dp_compute_config [i915]] PSR condition failed: PSR setup time (330 us) too long
We should probably bring back the kernel patch that programmed an alternate
mode, but skip tests for now.

Cc: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
 tests/kms_psr.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/tests/kms_psr.c b/tests/kms_psr.c
index 218b3960..89118ad4 100644
--- a/tests/kms_psr.c
+++ b/tests/kms_psr.c
@@ -193,11 +193,19 @@ static bool sink_support(data_t *data)
 	char buf[512];
 
 	igt_debugfs_read(data->drm_fd, "i915_edp_psr_status", buf);
-
 	return data->with_psr_disabled ||
 		strstr(buf, "Sink_Support: yes\n");
 }
 
+static bool mode_support(data_t *data)
+{
+	char buf[512];
+
+	igt_debugfs_read(data->drm_fd, "i915_edp_psr_status", buf);
+	return data->with_psr_disabled ||
+		strstr(buf, "Enabled: yes\n");
+}
+
 static bool psr_wait_entry_if_enabled(data_t *data)
 {
 	if (data->with_psr_disabled)
@@ -422,6 +430,8 @@ int main(int argc, char *argv[])
 		drm_intel_bufmgr_gem_enable_reuse(data.bufmgr);
 
 		display_init(&data);
+		igt_require_f(mode_support(&data),
+			     "PSR not enabled for current mode\n");
 	}
 
 	igt_subtest("basic") {
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/psr: Skip if PSR cannot be enabled for the current mode.

[Patchwork]

== Series Details ==

Series: tests/psr: Skip if PSR cannot be enabled for the current mode.
URL   : https://patchwork.freedesktop.org/series/47528/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4592 -> IGTPW_1674 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/47528/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1674:

  === IGT changes ===

    ==== Warnings ====

    {igt@kms_psr@cursor_plane_move}:
      fi-kbl-r:           PASS -> SKIP +3
      {fi-bdw-samus}:     PASS -> SKIP +2
      fi-whl-u:           PASS -> SKIP +3

    {igt@kms_psr@primary_mmap_gtt}:
      fi-kbl-7560u:       PASS -> SKIP +3

    {igt@kms_psr@primary_page_flip}:
      fi-skl-6600u:       PASS -> SKIP +3

    {igt@kms_psr@sprite_plane_onoff}:
      fi-skl-6700hq:      PASS -> SKIP +3
      fi-cfl-s3:          PASS -> SKIP +3
      fi-cnl-psr:         PASS -> SKIP

    
== Known issues ==

  Here are the changes found in IGTPW_1674 that come from known issues:

  === IGT changes ===

    ==== Possible fixes ====

    {igt@kms_psr@cursor_plane_move}:
      fi-cnl-psr:         DMESG-FAIL (fdo#107372) -> SKIP

    {igt@kms_psr@primary_mmap_gtt}:
      fi-cnl-psr:         DMESG-WARN (fdo#107372) -> SKIP +1

    {igt@kms_psr@sprite_plane_onoff}:
      {fi-bdw-samus}:     FAIL (fdo#107360) -> SKIP

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#107360 https://bugs.freedesktop.org/show_bug.cgi?id=107360
  fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372


== Participating hosts (52 -> 45) ==

  Additional (1): fi-kbl-8809g 
  Missing    (8): fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-u fi-byt-clapper 


== Build changes ==

    * IGT: IGT_4580 -> IGTPW_1674

  CI_DRM_4592: ed4b6c987889caf5a4041cf78eacdede85964577 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1674: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1674/
  IGT_4580: f1c868dae24056ebc27e4f3c197724ce9b956a8a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1674/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/psr: Skip if PSR cannot be enabled for the current mode.

[Chris Wilson]

Quoting Dhinakaran Pandiyan (2018-08-01 07:43:23)
> PSR tests on ICL fail waiting for PSR to become active, whereas the
> driver does not enable it on the HW due to unmet timing requirements
> [  482.485873] [drm:intel_dp_compute_config [i915]] PSR condition failed: PSR setup time (330 us) too long
> We should probably bring back the kernel patch that programmed an alternate
> mode, but skip tests for now.
> 
> Cc: José Roberto de Souza <jose.souza@intel.com>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
>  tests/kms_psr.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_psr.c b/tests/kms_psr.c
> index 218b3960..89118ad4 100644
> --- a/tests/kms_psr.c
> +++ b/tests/kms_psr.c
> @@ -193,11 +193,19 @@ static bool sink_support(data_t *data)
>         char buf[512];
>  
>         igt_debugfs_read(data->drm_fd, "i915_edp_psr_status", buf);
> -
>         return data->with_psr_disabled ||
>                 strstr(buf, "Sink_Support: yes\n");
>  }
>  
> +static bool mode_support(data_t *data)
> +{
> +       char buf[512];

For both of these, we don't even need to read debugfs if data->with_psr_disabled.

> +       igt_debugfs_read(data->drm_fd, "i915_edp_psr_status", buf);

If you are reading the debugfs frequently, cache the debugfs dir

data->debugfs = igt_debugfs_dir(data->drm_fd);

Then use igt_sysfs_read(data->debugfs, "i915_edp_psr_status", buf, sizeof(buf));

> +       return data->with_psr_disabled ||
> +               strstr(buf, "Enabled: yes\n");

Is there any delay before PSR is enabled?

We really should adopt yaml (mild background rant).
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/psr: Skip if PSR cannot be enabled for the current mode.

[Patchwork]

== Series Details ==

Series: tests/psr: Skip if PSR cannot be enabled for the current mode.
URL   : https://patchwork.freedesktop.org/series/47528/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4580_full -> IGTPW_1674_full =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/47528/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1674_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_ctx_isolation@vcs0-s3:
      shard-snb:          SKIP -> INCOMPLETE (fdo#105411)

    igt@gem_ppgtt@blt-vs-render-ctx0:
      shard-kbl:          PASS -> INCOMPLETE (fdo#106023, fdo#103665)

    igt@kms_draw_crc@draw-method-rgb565-pwrite-xtiled:
      shard-glk:          PASS -> FAIL (fdo#103184)

    igt@kms_flip@flip-vs-expired-vblank-interruptible:
      shard-glk:          PASS -> FAIL (fdo#105363, fdo#102887)

    
    ==== Possible fixes ====

    igt@kms_flip@plain-flip-fb-recreate-interruptible:
      shard-glk:          FAIL (fdo#100368) -> PASS

    igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
      shard-snb:          FAIL (fdo#103166) -> PASS

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103184 https://bugs.freedesktop.org/show_bug.cgi?id=103184
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4580 -> IGTPW_1674
    * Linux: CI_DRM_4562 -> CI_DRM_4592

  CI_DRM_4562: 99bbd80f75cdcf28699ffd3c93a714ca4a89b962 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4592: ed4b6c987889caf5a4041cf78eacdede85964577 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1674: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1674/
  IGT_4580: f1c868dae24056ebc27e4f3c197724ce9b956a8a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1674/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/psr: Skip if PSR cannot be enabled for the current mode.

[Dhinakaran Pandiyan]

On Wed, 2018-08-01 at 09:59 +0100, Chris Wilson wrote:
> Quoting Dhinakaran Pandiyan (2018-08-01 07:43:23)
> > PSR tests on ICL fail waiting for PSR to become active, whereas the
> > driver does not enable it on the HW due to unmet timing
> > requirements
> > [  482.485873] [drm:intel_dp_compute_config [i915]] PSR condition
> > failed: PSR setup time (330 us) too long
> > We should probably bring back the kernel patch that programmed an
> > alternate
> > mode, but skip tests for now.
> > 
> > Cc: José Roberto de Souza <jose.souza@intel.com>
> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > ---
> >  tests/kms_psr.c | 12 +++++++++++-
> >  1 file changed, 11 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tests/kms_psr.c b/tests/kms_psr.c
> > index 218b3960..89118ad4 100644
> > --- a/tests/kms_psr.c
> > +++ b/tests/kms_psr.c
> > @@ -193,11 +193,19 @@ static bool sink_support(data_t *data)
> >         char buf[512];
> >  
> >         igt_debugfs_read(data->drm_fd, "i915_edp_psr_status", buf);
> > -
> >         return data->with_psr_disabled ||
> >                 strstr(buf, "Sink_Support: yes\n");
> >  }
> >  
> > +static bool mode_support(data_t *data)
> > +{
> > +       char buf[512];
> 
> For both of these, we don't even need to read debugfs if data-
> >with_psr_disabled.
Correct, will move the check ahead.

> 
> > +       igt_debugfs_read(data->drm_fd, "i915_edp_psr_status", buf);
> 
> If you are reading the debugfs frequently, cache the debugfs dir
> 
> data->debugfs = igt_debugfs_dir(data->drm_fd);
Didn't know we had a function to do this, thanks.

> 
> Then use igt_sysfs_read(data->debugfs, "i915_edp_psr_status", buf,
> sizeof(buf));
> 
> > +       return data->with_psr_disabled ||
> > +               strstr(buf, "Enabled: yes\n");
> 
> Is there any delay before PSR is enabled?
Enabled should be set when modeset completes, so we shouldn't be
needing a delay. Not too sure how a non-blocking modeset would behave.

> 
> We really should adopt yaml (mild background rant).
As a standard debugfs format?

> -Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/psr: Skip if PSR cannot be enabled for the current mode.

[Chris Wilson]

Quoting Dhinakaran Pandiyan (2018-08-01 20:05:46)
> On Wed, 2018-08-01 at 09:59 +0100, Chris Wilson wrote:
> > We really should adopt yaml (mild background rant).
> As a standard debugfs format?

Yeah, still human readable yet parseable and gets us away from our ad
hoc parsers/interpreters. I guess what I really want is an introspection
framework. I can but dream.

At the moment, I am just trying to remind myself that the next time I do
a debugfs file, it should talk yaml and igt should complain if it is
malformed -- as well as provide a framework for convenient
interpretation.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/psr: Skip if PSR cannot be enabled for the current mode.

[Souza, Jose]

On Tue, 2018-07-31 at 23:43 -0700, Dhinakaran Pandiyan wrote:
> PSR tests on ICL fail waiting for PSR to become active, whereas the
> driver does not enable it on the HW due to unmet timing requirements
> [  482.485873] [drm:intel_dp_compute_config [i915]] PSR condition
> failed: PSR setup time (330 us) too long
> We should probably bring back the kernel patch that programmed an
> alternate
> mode, but skip tests for now.
> 
> Cc: José Roberto de Souza <jose.souza@intel.com>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
>  tests/kms_psr.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_psr.c b/tests/kms_psr.c
> index 218b3960..89118ad4 100644
> --- a/tests/kms_psr.c
> +++ b/tests/kms_psr.c
> @@ -193,11 +193,19 @@ static bool sink_support(data_t *data)
>  	char buf[512];
>  
>  	igt_debugfs_read(data->drm_fd, "i915_edp_psr_status", buf);
> -
>  	return data->with_psr_disabled ||
>  		strstr(buf, "Sink_Support: yes\n");
>  }
>  
> +static bool mode_support(data_t *data)
> +{
> +	char buf[512];
> +
> +	igt_debugfs_read(data->drm_fd, "i915_edp_psr_status", buf);
> +	return data->with_psr_disabled ||
> +		strstr(buf, "Enabled: yes\n");
> +}

This could hide bugs in gen <= 9.

> +
>  static bool psr_wait_entry_if_enabled(data_t *data)
>  {
>  	if (data->with_psr_disabled)
> @@ -422,6 +430,8 @@ int main(int argc, char *argv[])
>  		drm_intel_bufmgr_gem_enable_reuse(data.bufmgr);
>  
>  		display_init(&data);
> +		igt_require_f(mode_support(&data),
> +			     "PSR not enabled for current mode\n");

Why not just require that gen is <= 9 or 10(if it is working in CNL)?
and leave a TODO.

>  	}
>  
>  	igt_subtest("basic") {
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/psr: Skip if PSR cannot be enabled for the current mode.

[Patchwork]

== Series Details ==

Series: tests/psr: Skip if PSR cannot be enabled for the current mode.
URL   : https://patchwork.freedesktop.org/series/47528/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4600 -> IGTPW_1675 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/47528/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1675:

  === IGT changes ===

    ==== Warnings ====

    {igt@kms_psr@cursor_plane_move}:
      fi-kbl-r:           PASS -> SKIP +3
      {fi-bdw-samus}:     PASS -> SKIP +2
      fi-whl-u:           PASS -> SKIP +3

    {igt@kms_psr@primary_mmap_gtt}:
      fi-kbl-7560u:       PASS -> SKIP +3

    {igt@kms_psr@primary_page_flip}:
      fi-skl-6600u:       PASS -> SKIP +3

    {igt@kms_psr@sprite_plane_onoff}:
      fi-skl-6700hq:      PASS -> SKIP +3
      fi-cfl-s3:          PASS -> SKIP +3
      fi-cnl-psr:         PASS -> SKIP

    
== Known issues ==

  Here are the changes found in IGTPW_1675 that come from known issues:

  === IGT changes ===

    ==== Possible fixes ====

    igt@kms_frontbuffer_tracking@basic:
      fi-hsw-peppy:       DMESG-FAIL (fdo#106103, fdo#102614) -> PASS

    igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a:
      fi-skl-6700k2:      FAIL (fdo#103191) -> PASS

    {igt@kms_psr@cursor_plane_move}:
      fi-cnl-psr:         DMESG-FAIL (fdo#107372) -> SKIP +1

    {igt@kms_psr@primary_mmap_gtt}:
      fi-cnl-psr:         DMESG-WARN (fdo#107372) -> SKIP

    {igt@kms_psr@sprite_plane_onoff}:
      {fi-bdw-samus}:     FAIL (fdo#107360) -> SKIP

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103
  fdo#107360 https://bugs.freedesktop.org/show_bug.cgi?id=107360
  fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372


== Participating hosts (48 -> 45) ==

  Additional (2): fi-skl-guc fi-glk-j4005 
  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-byt-clapper fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4581 -> IGTPW_1675

  CI_DRM_4600: 308427119c70d0aaa90433b05969a0317165b122 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1675: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1675/
  IGT_4581: f1c868dae24056ebc27e4f3c197724ce9b956a8a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1675/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/psr: Skip if PSR cannot be enabled for the current mode.

[Patchwork]

== Series Details ==

Series: tests/psr: Skip if PSR cannot be enabled for the current mode.
URL   : https://patchwork.freedesktop.org/series/47528/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4581_full -> IGTPW_1675_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1675_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1675_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/47528/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1675_full:

  === IGT changes ===

    ==== Warnings ====

    igt@pm_rc6_residency@rc6-accuracy:
      shard-kbl:          PASS -> SKIP

    
== Known issues ==

  Here are the changes found in IGTPW_1675_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_schedule@pi-ringfull-bsd:
      shard-glk:          NOTRUN -> FAIL (fdo#103158)

    igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-gtt:
      shard-glk:          PASS -> FAIL (fdo#103167)

    igt@kms_setmode@basic:
      shard-apl:          PASS -> FAIL (fdo#99912)

    igt@pm_rps@min-max-config-loaded:
      shard-glk:          PASS -> FAIL (fdo#102250)

    igt@prime_vgem@basic-fence-flip:
      shard-hsw:          PASS -> FAIL (fdo#104008)

    igt@testdisplay:
      shard-glk:          PASS -> INCOMPLETE (k.org#198133, fdo#103359, fdo#107093)

    
    ==== Possible fixes ====

    igt@gem_ctx_isolation@vcs0-s3:
      shard-kbl:          INCOMPLETE (fdo#103665) -> PASS

    igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
      shard-glk:          FAIL (fdo#102887) -> PASS

    igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
      shard-glk:          FAIL (fdo#103375) -> PASS

    igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
      shard-snb:          FAIL (fdo#103166) -> PASS

    igt@kms_setmode@basic:
      shard-kbl:          FAIL (fdo#99912) -> PASS

    
  fdo#102250 https://bugs.freedesktop.org/show_bug.cgi?id=102250
  fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
  fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
  fdo#107093 https://bugs.freedesktop.org/show_bug.cgi?id=107093
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4581 -> IGTPW_1675
    * Linux: CI_DRM_4592 -> CI_DRM_4600

  CI_DRM_4592: ed4b6c987889caf5a4041cf78eacdede85964577 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4600: 308427119c70d0aaa90433b05969a0317165b122 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1675: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1675/
  IGT_4581: f1c868dae24056ebc27e4f3c197724ce9b956a8a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1675/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/psr: Skip if PSR cannot be enabled for the current mode.

[Dhinakaran Pandiyan]

On Wed, 2018-08-01 at 20:03 +0000, Souza, Jose wrote:
> On Tue, 2018-07-31 at 23:43 -0700, Dhinakaran Pandiyan wrote:
> > PSR tests on ICL fail waiting for PSR to become active, whereas the
> > driver does not enable it on the HW due to unmet timing
> > requirements
> > [  482.485873] [drm:intel_dp_compute_config [i915]] PSR condition
> > failed: PSR setup time (330 us) too long
> > We should probably bring back the kernel patch that programmed an
> > alternate
> > mode, but skip tests for now.
> > 
> > Cc: José Roberto de Souza <jose.souza@intel.com>
> > Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > ---
> >  tests/kms_psr.c | 12 +++++++++++-
> >  1 file changed, 11 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tests/kms_psr.c b/tests/kms_psr.c
> > index 218b3960..89118ad4 100644
> > --- a/tests/kms_psr.c
> > +++ b/tests/kms_psr.c
> > @@ -193,11 +193,19 @@ static bool sink_support(data_t *data)
> >  	char buf[512];
> >  
> >  	igt_debugfs_read(data->drm_fd, "i915_edp_psr_status",
> > buf);
> > -
> >  	return data->with_psr_disabled ||
> >  		strstr(buf, "Sink_Support: yes\n");
> >  }
> >  
> > +static bool mode_support(data_t *data)
> > +{
> > +	char buf[512];
> > +
> > +	igt_debugfs_read(data->drm_fd, "i915_edp_psr_status",
> > buf);
> > +	return data->with_psr_disabled ||
> > +		strstr(buf, "Enabled: yes\n");
> > +}
> 
> This could hide bugs in gen <= 9.
This isn't related to gen, it just so happens that the panel on the ICL
machine has a setup time that cannot be met.

But, the patch does hide bugs if the driver does not enable PSR when it
should have.


> 
> > +
> >  static bool psr_wait_entry_if_enabled(data_t *data)
> >  {
> >  	if (data->with_psr_disabled)
> > @@ -422,6 +430,8 @@ int main(int argc, char *argv[])
> >  		drm_intel_bufmgr_gem_enable_reuse(data.bufmgr);
> >  
> >  		display_init(&data);
> > +		igt_require_f(mode_support(&data),
> > +			     "PSR not enabled for current
> > mode\n");
> 
> Why not just require that gen is <= 9 or 10(if it is working in CNL)?
> and leave a TODO.
> 
> >  	}
> >  
> >  	igt_subtest("basic") {
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/psr: Skip if PSR cannot be enabled for the current mode.

[Rodrigo Vivi]

On Tue, Jul 31, 2018 at 11:43:23PM -0700, Dhinakaran Pandiyan wrote:
> PSR tests on ICL fail waiting for PSR to become active, whereas the
> driver does not enable it on the HW due to unmet timing requirements
> [  482.485873] [drm:intel_dp_compute_config [i915]] PSR condition failed: PSR setup time (330 us) too long
> We should probably bring back the kernel patch that programmed an alternate
> mode, but skip tests for now.

I'm in favor of allowing alternate modes. If panel advertises 2 modes
I believe we should be able to support both and unblock cases like this.

But it need to be done correctly this time...

> 
> Cc: José Roberto de Souza <jose.souza@intel.com>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
>  tests/kms_psr.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_psr.c b/tests/kms_psr.c
> index 218b3960..89118ad4 100644
> --- a/tests/kms_psr.c
> +++ b/tests/kms_psr.c
> @@ -193,11 +193,19 @@ static bool sink_support(data_t *data)
>  	char buf[512];
>  
>  	igt_debugfs_read(data->drm_fd, "i915_edp_psr_status", buf);
> -
>  	return data->with_psr_disabled ||
>  		strstr(buf, "Sink_Support: yes\n");
>  }
>  
> +static bool mode_support(data_t *data)
> +{
> +	char buf[512];
> +
> +	igt_debugfs_read(data->drm_fd, "i915_edp_psr_status", buf);
> +	return data->with_psr_disabled ||
> +		strstr(buf, "Enabled: yes\n");
> +}
> +
>  static bool psr_wait_entry_if_enabled(data_t *data)
>  {
>  	if (data->with_psr_disabled)
> @@ -422,6 +430,8 @@ int main(int argc, char *argv[])
>  		drm_intel_bufmgr_gem_enable_reuse(data.bufmgr);
>  
>  		display_init(&data);
> +		igt_require_f(mode_support(&data),
> +			     "PSR not enabled for current mode\n");
>  	}
>  
>  	igt_subtest("basic") {
> -- 
> 2.17.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev