All of lore.kernel.org
 help / color / mirror / Atom feed
From: Colin King <colin.king@canonical.com>
To: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Jaya Kumar <jayakumar.alsa@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Olivier Moysan <olivier.moysan@st.com>,
	Arnaud Pouliquen <arnaud.pouliquen@st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	alsa-devel@alsa-project.org,
	linux-arm-kernel@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 9/9] ALSA: intel_hdmi: remove redundant variable cfg_val
Date: Wed,  1 Aug 2018 11:47:42 +0100	[thread overview]
Message-ID: <20180801104742.4328-10-colin.king@canonical.com> (raw)
In-Reply-To: <20180801104742.4328-1-colin.king@canonical.com>

From: Colin Ian King <colin.king@canonical.com>

Variable cfg_val is being assigned but is never used hence it is
redundant and can be removed.

Cleans up clang warning:
warning: variable 'cfg_val' set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 sound/x86/intel_hdmi_audio.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c
index edc9f5a34eff..fa7dca5a68c8 100644
--- a/sound/x86/intel_hdmi_audio.c
+++ b/sound/x86/intel_hdmi_audio.c
@@ -290,7 +290,6 @@ static void had_reset_audio(struct snd_intelhad *intelhaddata)
 static int had_prog_status_reg(struct snd_pcm_substream *substream,
 			struct snd_intelhad *intelhaddata)
 {
-	union aud_cfg cfg_val = {.regval = 0};
 	union aud_ch_status_0 ch_stat0 = {.regval = 0};
 	union aud_ch_status_1 ch_stat1 = {.regval = 0};
 
@@ -298,7 +297,6 @@ static int had_prog_status_reg(struct snd_pcm_substream *substream,
 					  IEC958_AES0_NONAUDIO) >> 1;
 	ch_stat0.regx.clk_acc = (intelhaddata->aes_bits &
 					  IEC958_AES3_CON_CLOCK) >> 4;
-	cfg_val.regx.val_bit = ch_stat0.regx.lpcm_id;
 
 	switch (substream->runtime->rate) {
 	case AUD_SAMPLE_RATE_32:
-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: Colin King <colin.king@canonical.com>
To: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Jaya Kumar <jayakumar.alsa@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Olivier Moysan <olivier.moysan@st.com>,
	Arnaud Pouliquen <arnaud.pouliquen@st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	alsa-devel@alsa-project.org,
	linux-arm-kernel@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 9/9] ALSA: intel_hdmi: remove redundant variable cfg_val
Date: Wed, 01 Aug 2018 10:47:42 +0000	[thread overview]
Message-ID: <20180801104742.4328-10-colin.king@canonical.com> (raw)
In-Reply-To: <20180801104742.4328-1-colin.king@canonical.com>

From: Colin Ian King <colin.king@canonical.com>

Variable cfg_val is being assigned but is never used hence it is
redundant and can be removed.

Cleans up clang warning:
warning: variable 'cfg_val' set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 sound/x86/intel_hdmi_audio.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c
index edc9f5a34eff..fa7dca5a68c8 100644
--- a/sound/x86/intel_hdmi_audio.c
+++ b/sound/x86/intel_hdmi_audio.c
@@ -290,7 +290,6 @@ static void had_reset_audio(struct snd_intelhad *intelhaddata)
 static int had_prog_status_reg(struct snd_pcm_substream *substream,
 			struct snd_intelhad *intelhaddata)
 {
-	union aud_cfg cfg_val = {.regval = 0};
 	union aud_ch_status_0 ch_stat0 = {.regval = 0};
 	union aud_ch_status_1 ch_stat1 = {.regval = 0};
 
@@ -298,7 +297,6 @@ static int had_prog_status_reg(struct snd_pcm_substream *substream,
 					  IEC958_AES0_NONAUDIO) >> 1;
 	ch_stat0.regx.clk_acc = (intelhaddata->aes_bits &
 					  IEC958_AES3_CON_CLOCK) >> 4;
-	cfg_val.regx.val_bit = ch_stat0.regx.lpcm_id;
 
 	switch (substream->runtime->rate) {
 	case AUD_SAMPLE_RATE_32:
-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: colin.king@canonical.com (Colin King)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 9/9] ALSA: intel_hdmi: remove redundant variable cfg_val
Date: Wed,  1 Aug 2018 11:47:42 +0100	[thread overview]
Message-ID: <20180801104742.4328-10-colin.king@canonical.com> (raw)
In-Reply-To: <20180801104742.4328-1-colin.king@canonical.com>

From: Colin Ian King <colin.king@canonical.com>

Variable cfg_val is being assigned but is never used hence it is
redundant and can be removed.

Cleans up clang warning:
warning: variable 'cfg_val' set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 sound/x86/intel_hdmi_audio.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sound/x86/intel_hdmi_audio.c b/sound/x86/intel_hdmi_audio.c
index edc9f5a34eff..fa7dca5a68c8 100644
--- a/sound/x86/intel_hdmi_audio.c
+++ b/sound/x86/intel_hdmi_audio.c
@@ -290,7 +290,6 @@ static void had_reset_audio(struct snd_intelhad *intelhaddata)
 static int had_prog_status_reg(struct snd_pcm_substream *substream,
 			struct snd_intelhad *intelhaddata)
 {
-	union aud_cfg cfg_val = {.regval = 0};
 	union aud_ch_status_0 ch_stat0 = {.regval = 0};
 	union aud_ch_status_1 ch_stat1 = {.regval = 0};
 
@@ -298,7 +297,6 @@ static int had_prog_status_reg(struct snd_pcm_substream *substream,
 					  IEC958_AES0_NONAUDIO) >> 1;
 	ch_stat0.regx.clk_acc = (intelhaddata->aes_bits &
 					  IEC958_AES3_CON_CLOCK) >> 4;
-	cfg_val.regx.val_bit = ch_stat0.regx.lpcm_id;
 
 	switch (substream->runtime->rate) {
 	case AUD_SAMPLE_RATE_32:
-- 
2.17.1

  parent reply	other threads:[~2018-08-01 10:48 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-01 10:47 [PATCH 0/9] ALSA: remove redundant variables Colin King
2018-08-01 10:47 ` Colin King
2018-08-01 10:47 ` Colin King
2018-08-01 10:47 ` [PATCH 1/9] ALSA: asihpi: remove redundant variable max_streams Colin King
2018-08-01 10:47   ` Colin King
2018-08-01 10:47   ` Colin King
2018-08-01 12:00   ` Takashi Iwai
2018-08-01 12:00     ` Takashi Iwai
2018-08-01 12:00     ` Takashi Iwai
2018-08-01 12:00     ` Takashi Iwai
2018-08-01 10:47 ` [PATCH 2/9] ALSA: cs5535audio: remove redundant pointer 'dma' Colin King
2018-08-01 10:47   ` Colin King
2018-08-01 10:47   ` Colin King
2018-08-01 12:01   ` Takashi Iwai
2018-08-01 12:01     ` Takashi Iwai
2018-08-01 12:01     ` Takashi Iwai
2018-08-01 12:01     ` Takashi Iwai
2018-08-01 10:47 ` [PATCH 3/9] ALSA: emu10k1: remove redundant variable attn Colin King
2018-08-01 10:47   ` Colin King
2018-08-01 10:47   ` Colin King
2018-08-01 12:01   ` Takashi Iwai
2018-08-01 12:01     ` Takashi Iwai
2018-08-01 12:01     ` Takashi Iwai
2018-08-01 12:01     ` Takashi Iwai
2018-08-01 10:47 ` [PATCH 4/9] ALSA: ens137x: remove redundant array pcm_devs Colin King
2018-08-01 10:47   ` Colin King
2018-08-01 10:47   ` Colin King
2018-08-01 12:01   ` Takashi Iwai
2018-08-01 12:01     ` Takashi Iwai
2018-08-01 12:01     ` Takashi Iwai
2018-08-01 12:01     ` Takashi Iwai
2018-08-01 10:47 ` [PATCH 5/9] ALSA: sonicvibes: remove redundant pointer 'dir' Colin King
2018-08-01 10:47   ` Colin King
2018-08-01 10:47   ` Colin King
2018-08-01 12:01   ` Takashi Iwai
2018-08-01 12:01     ` Takashi Iwai
2018-08-01 12:01     ` Takashi Iwai
2018-08-01 12:01     ` Takashi Iwai
2018-08-01 10:47 ` [PATCH 6/9] ASoC: nau8540: remove redundant variable osrate Colin King
2018-08-01 10:47   ` Colin King
2018-08-01 10:47   ` Colin King
2018-08-01 11:17   ` Applied "ASoC: nau8540: remove redundant variable osrate" to the asoc tree Mark Brown
2018-08-01 11:17     ` Mark Brown
2018-08-01 11:17     ` Mark Brown
2018-08-01 11:17     ` Mark Brown
2018-08-01 10:47 ` [PATCH 7/9] ASoC: stm32: remove redundant pointers 'priv' and 'rtd' Colin King
2018-08-01 10:47   ` Colin King
2018-08-01 10:47   ` Colin King
2018-08-01 11:16   ` Applied "ASoC: stm32: remove redundant pointers 'priv' and 'rtd'" to the asoc tree Mark Brown
2018-08-01 11:16     ` Mark Brown
2018-08-01 11:16     ` Mark Brown
2018-08-01 11:16     ` Mark Brown
2018-08-01 10:47 ` [PATCH 8/9] ALSA: usb-audio: remove redundant pointer 'urb' Colin King
2018-08-01 10:47   ` Colin King
2018-08-01 10:47   ` Colin King
2018-08-01 12:01   ` Takashi Iwai
2018-08-01 12:01     ` Takashi Iwai
2018-08-01 12:01     ` Takashi Iwai
2018-08-01 12:01     ` Takashi Iwai
2018-08-01 10:47 ` Colin King [this message]
2018-08-01 10:47   ` [PATCH 9/9] ALSA: intel_hdmi: remove redundant variable cfg_val Colin King
2018-08-01 10:47   ` Colin King
2018-08-01 11:00   ` Takashi Iwai
2018-08-01 11:00     ` Takashi Iwai
2018-08-01 11:00     ` Takashi Iwai
2018-08-01 11:00     ` Takashi Iwai
2018-08-01 14:55     ` [alsa-devel] " Pierre-Louis Bossart
2018-08-01 14:55       ` Pierre-Louis Bossart
2018-08-01 14:55       ` Pierre-Louis Bossart
2018-08-06 18:37     ` Pierre-Louis Bossart
2018-08-06 18:37       ` Pierre-Louis Bossart
2018-08-06 18:37       ` Pierre-Louis Bossart
2018-08-06 19:37       ` Takashi Iwai
2018-08-06 19:37         ` Takashi Iwai
2018-08-06 19:37         ` Takashi Iwai
2018-08-06 19:59         ` Pierre-Louis Bossart
2018-08-06 19:59           ` Pierre-Louis Bossart
2018-08-06 19:59           ` Pierre-Louis Bossart
2018-08-01 13:03 [PATCH 3/9] ALSA: emu10k1: remove redundant variable attn Walter Harms
2018-08-01 13:03 ` Walter Harms
2018-08-01 13:03 ` Walter Harms
2018-08-01 13:14 ` Takashi Iwai
2018-08-01 13:14   ` Takashi Iwai
2018-08-01 13:14   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180801104742.4328-10-colin.king@canonical.com \
    --to=colin.king@canonical.com \
    --cc=alexandre.torgue@st.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnaud.pouliquen@st.com \
    --cc=broonie@kernel.org \
    --cc=jayakumar.alsa@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=olivier.moysan@st.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.