[PATCH] machine: remove kernel-modules from RRECOMMENDS

[PATCH] machine: remove kernel-modules from RRECOMMENDS

[Maxin B. John]

qemumips,qemumips64 and x86 based machines include kernel-modules by
default. Remove the kernel modules from RRECOMMENDS to make it consistent
across the machines.

Tested using core-image-sato on qemumips, qemumips64, qemux86 and
qemux86-64

[YOCTO #12383]

Signed-off-by: Maxin B. John <maxin.john@intel.com>
---
 meta/conf/machine/include/x86-base.inc | 2 --
 meta/conf/machine/qemumips.conf        | 2 --
 meta/conf/machine/qemumips64.conf      | 2 --
 3 files changed, 6 deletions(-)

diff --git a/meta/conf/machine/include/x86-base.inc b/meta/conf/machine/include/x86-base.inc
index 0edcea7..be037be 100644
--- a/meta/conf/machine/include/x86-base.inc
+++ b/meta/conf/machine/include/x86-base.inc
@@ -8,8 +8,6 @@
 MACHINE_FEATURES += "screen keyboard pci usbhost ext2 ext3 x86 \
                      acpi serial usbgadget alsa"
 
-MACHINE_EXTRA_RRECOMMENDS += "kernel-modules"
-
 IMAGE_FSTYPES ?= "hddimg"
 
 KERNEL_IMAGETYPE ?= "bzImage"
diff --git a/meta/conf/machine/qemumips.conf b/meta/conf/machine/qemumips.conf
index 986315a..a60f67a 100644
--- a/meta/conf/machine/qemumips.conf
+++ b/meta/conf/machine/qemumips.conf
@@ -10,5 +10,3 @@ KERNEL_IMAGETYPE = "vmlinux"
 KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
 
 SERIAL_CONSOLES ?= "115200;ttyS0 115200;ttyS1"
-
-MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
diff --git a/meta/conf/machine/qemumips64.conf b/meta/conf/machine/qemumips64.conf
index 3f91cbe..a166a10 100644
--- a/meta/conf/machine/qemumips64.conf
+++ b/meta/conf/machine/qemumips64.conf
@@ -10,5 +10,3 @@ KERNEL_IMAGETYPE = "vmlinux"
 KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
 
 SERIAL_CONSOLES ?= "115200;ttyS0 115200;ttyS1"
-
-MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
-- 
2.4.0

Re: [PATCH] machine: remove kernel-modules from RRECOMMENDS

[Richard Purdie]

On Tue, 2018-07-31 at 17:15 +0300, Maxin B. John wrote:
> qemumips,qemumips64 and x86 based machines include kernel-modules by
> default. Remove the kernel modules from RRECOMMENDS to make it
> consistent
> across the machines.
> 
> Tested using core-image-sato on qemumips, qemumips64, qemux86 and
> qemux86-64
> 
> [YOCTO #12383]
> 
> Signed-off-by: Maxin B. John <maxin.john@intel.com>
> ---
>  meta/conf/machine/include/x86-base.inc | 2 --
>  meta/conf/machine/qemumips.conf        | 2 --
>  meta/conf/machine/qemumips64.conf      | 2 --
>  3 files changed, 6 deletions(-)

Looks good, do we need to add this to genericx86 or anything in meta-
intel given its changing x86-base.inc?

Cheers,

Richard

Re: [PATCH] machine: remove kernel-modules from RRECOMMENDS

[Anuj Mittal]

On 07/31/2018 11:22 PM, openembedded-core-bounces@lists.openembedded.org
wrote:
> On Tue, 2018-07-31 at 17:15 +0300, Maxin B. John wrote:
>> qemumips,qemumips64 and x86 based machines include kernel-modules by
>> default. Remove the kernel modules from RRECOMMENDS to make it
>> consistent
>> across the machines.
>>
>> Tested using core-image-sato on qemumips, qemumips64, qemux86 and
>> qemux86-64
>>
>> [YOCTO #12383]
>>
>> Signed-off-by: Maxin B. John <maxin.john@intel.com>
>> ---
>>  meta/conf/machine/include/x86-base.inc | 2 --
>>  meta/conf/machine/qemumips.conf        | 2 --
>>  meta/conf/machine/qemumips64.conf      | 2 --
>>  3 files changed, 6 deletions(-)
> 
> Looks good, do we need to add this to genericx86 or anything in meta-
> intel given its changing x86-base.inc?
> 

meta-intel explicitly includes the modules so no change needed there. I
have sent the patch for genericx86 where it should be included now.

Thanks,
Anuj

Re: [PATCH] machine: remove kernel-modules from RRECOMMENDS

[Maxin B. John]

Hi Anuj,

On Wed, Aug 01, 2018 at 10:43:03AM +0800, Anuj Mittal wrote:
> On 07/31/2018 11:22 PM, openembedded-core-bounces@lists.openembedded.org
> wrote:
> > On Tue, 2018-07-31 at 17:15 +0300, Maxin B. John wrote:
> >> qemumips,qemumips64 and x86 based machines include kernel-modules by
> >> default. Remove the kernel modules from RRECOMMENDS to make it
> >> consistent
> >> across the machines.
> >>
> >> Tested using core-image-sato on qemumips, qemumips64, qemux86 and
> >> qemux86-64
> >>
> >> [YOCTO #12383]
> >>
> >> Signed-off-by: Maxin B. John <maxin.john@intel.com>
> >> ---
> >>  meta/conf/machine/include/x86-base.inc | 2 --
> >>  meta/conf/machine/qemumips.conf        | 2 --
> >>  meta/conf/machine/qemumips64.conf      | 2 --
> >>  3 files changed, 6 deletions(-)
> > 
> > Looks good, do we need to add this to genericx86 or anything in meta-
> > intel given its changing x86-base.inc?
> > 
> 
> meta-intel explicitly includes the modules so no change needed there. I
> have sent the patch for genericx86 where it should be included now.

Thanks, Just curious why we need to change genericx86. Do we have a list
of kernel modules which are required there ?

> Thanks,
> Anuj

Best Regards,
Maxin

Re: [PATCH] machine: remove kernel-modules from RRECOMMENDS

[Burton, Ross]

I believe the rationale for genericx86 is "this BSP should boot on
most hardware, so build and ship all the modules".

Ross

On 1 August 2018 at 12:58, Maxin B. John <maxin.john@intel.com> wrote:
> Hi Anuj,
>
> On Wed, Aug 01, 2018 at 10:43:03AM +0800, Anuj Mittal wrote:
>> On 07/31/2018 11:22 PM, openembedded-core-bounces@lists.openembedded.org
>> wrote:
>> > On Tue, 2018-07-31 at 17:15 +0300, Maxin B. John wrote:
>> >> qemumips,qemumips64 and x86 based machines include kernel-modules by
>> >> default. Remove the kernel modules from RRECOMMENDS to make it
>> >> consistent
>> >> across the machines.
>> >>
>> >> Tested using core-image-sato on qemumips, qemumips64, qemux86 and
>> >> qemux86-64
>> >>
>> >> [YOCTO #12383]
>> >>
>> >> Signed-off-by: Maxin B. John <maxin.john@intel.com>
>> >> ---
>> >>  meta/conf/machine/include/x86-base.inc | 2 --
>> >>  meta/conf/machine/qemumips.conf        | 2 --
>> >>  meta/conf/machine/qemumips64.conf      | 2 --
>> >>  3 files changed, 6 deletions(-)
>> >
>> > Looks good, do we need to add this to genericx86 or anything in meta-
>> > intel given its changing x86-base.inc?
>> >
>>
>> meta-intel explicitly includes the modules so no change needed there. I
>> have sent the patch for genericx86 where it should be included now.
>
> Thanks, Just curious why we need to change genericx86. Do we have a list
> of kernel modules which are required there ?
>
>> Thanks,
>> Anuj
>
> Best Regards,
> Maxin
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core