From: Dan Carpenter <dan.carpenter@oracle.com> To: Wu Hao <hao.wu@intel.com>, Kang Luwei <luwei.kang@intel.com> Cc: Alan Tull <atull@kernel.org>, Moritz Fischer <mdf@kernel.org>, linux-fpga@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] fpga: dfl: fme: error pointer vs NULL bug Date: Thu, 02 Aug 2018 08:29:31 +0000 [thread overview] Message-ID: <20180802082931.6nfcgaztkxbkrgh7@kili.mountain> (raw) The dfl_fme_create_region() function doesn't return NULL pointers, it returns error pointers. Fixes: 29de76240e86 ("fpga: dfl: fme: add partial reconfiguration sub feature support") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> diff --git a/drivers/fpga/dfl-fme-pr.c b/drivers/fpga/dfl-fme-pr.c index fc9fd2d0482f..0b840531ef33 100644 --- a/drivers/fpga/dfl-fme-pr.c +++ b/drivers/fpga/dfl-fme-pr.c @@ -420,7 +420,7 @@ static int pr_mgmt_init(struct platform_device *pdev, /* Create region for each port */ fme_region = dfl_fme_create_region(pdata, mgr, fme_br->br, i); - if (!fme_region) { + if (IS_ERR(fme_region)) { ret = PTR_ERR(fme_region); goto destroy_region; }
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com> To: Wu Hao <hao.wu@intel.com>, Kang Luwei <luwei.kang@intel.com> Cc: Alan Tull <atull@kernel.org>, Moritz Fischer <mdf@kernel.org>, linux-fpga@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] fpga: dfl: fme: error pointer vs NULL bug Date: Thu, 2 Aug 2018 11:29:31 +0300 [thread overview] Message-ID: <20180802082931.6nfcgaztkxbkrgh7@kili.mountain> (raw) The dfl_fme_create_region() function doesn't return NULL pointers, it returns error pointers. Fixes: 29de76240e86 ("fpga: dfl: fme: add partial reconfiguration sub feature support") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> diff --git a/drivers/fpga/dfl-fme-pr.c b/drivers/fpga/dfl-fme-pr.c index fc9fd2d0482f..0b840531ef33 100644 --- a/drivers/fpga/dfl-fme-pr.c +++ b/drivers/fpga/dfl-fme-pr.c @@ -420,7 +420,7 @@ static int pr_mgmt_init(struct platform_device *pdev, /* Create region for each port */ fme_region = dfl_fme_create_region(pdata, mgr, fme_br->br, i); - if (!fme_region) { + if (IS_ERR(fme_region)) { ret = PTR_ERR(fme_region); goto destroy_region; }
next reply other threads:[~2018-08-02 8:29 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-02 8:29 Dan Carpenter [this message] 2018-08-02 8:29 ` [PATCH] fpga: dfl: fme: error pointer vs NULL bug Dan Carpenter 2018-08-02 8:40 ` Wu Hao 2018-08-02 8:40 ` Wu Hao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180802082931.6nfcgaztkxbkrgh7@kili.mountain \ --to=dan.carpenter@oracle.com \ --cc=atull@kernel.org \ --cc=hao.wu@intel.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-fpga@vger.kernel.org \ --cc=luwei.kang@intel.com \ --cc=mdf@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.