From: Hans de Goede <hdegoede@redhat.com> To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Cc: Hans de Goede <hdegoede@redhat.com>, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH fix for 4.19 0/3] fbcon: Fix VT switching being broken in combination with vgacon Date: Thu, 02 Aug 2018 11:28:38 +0000 [thread overview] Message-ID: <20180802112841.27679-1-hdegoede@redhat.com> (raw) Hi Bartlomiej, After backporting the deferred fbcon takeover patches to the 4.18 kernel for the upcoming Fedora 29 release, Fedora QA found a serious bug caused by the fbcon takeover support. When using classic (non EFI) boot on x86 and thus using vgacon, dummycon is not used, so the deferred takeover never happens as that depends on dummycon being the vt-console driver until the takeover happens. This is fixed by the 2nd patch in this set, futher testing has shown that that breaks the build when fb.o is a module, because of the conswitchp symbol not being exported. This made me realize that I never intended for deferred fbcon takeover to be possible when fbdev+fbcon are being build as a module (*), so instead of exporting yet more symbols, the first patch is a preparation patch which only allows deferred fbcon takeover when builtin. The third patch is a cleanup patch unexporting the dummycon_[un]register_output symbols since those now no longer need to be exported. At least patches 1 and 2 should be added to your tree for merging into 4.19, patch 3 can go in in the 4.20 cycle if you prefer delaying it till then. Regards, Hans *) which I should have realized when we hit the same issue with the dummycon_[un]register_output symbols
WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com> To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Cc: Hans de Goede <hdegoede@redhat.com>, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH fix for 4.19 0/3] fbcon: Fix VT switching being broken in combination with vgacon Date: Thu, 2 Aug 2018 13:28:38 +0200 [thread overview] Message-ID: <20180802112841.27679-1-hdegoede@redhat.com> (raw) Hi Bartlomiej, After backporting the deferred fbcon takeover patches to the 4.18 kernel for the upcoming Fedora 29 release, Fedora QA found a serious bug caused by the fbcon takeover support. When using classic (non EFI) boot on x86 and thus using vgacon, dummycon is not used, so the deferred takeover never happens as that depends on dummycon being the vt-console driver until the takeover happens. This is fixed by the 2nd patch in this set, futher testing has shown that that breaks the build when fb.o is a module, because of the conswitchp symbol not being exported. This made me realize that I never intended for deferred fbcon takeover to be possible when fbdev+fbcon are being build as a module (*), so instead of exporting yet more symbols, the first patch is a preparation patch which only allows deferred fbcon takeover when builtin. The third patch is a cleanup patch unexporting the dummycon_[un]register_output symbols since those now no longer need to be exported. At least patches 1 and 2 should be added to your tree for merging into 4.19, patch 3 can go in in the 4.20 cycle if you prefer delaying it till then. Regards, Hans *) which I should have realized when we hit the same issue with the dummycon_[un]register_output symbols _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2018-08-02 11:28 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20180802112848epcas5p293ab8ff240c214b2394f0c169adbe145@epcas5p2.samsung.com> 2018-08-02 11:28 ` Hans de Goede [this message] 2018-08-02 11:28 ` [PATCH fix for 4.19 0/3] fbcon: Fix VT switching being broken in combination with vgacon Hans de Goede 2018-08-02 11:28 ` [PATCH fix for 4.19 1/3] fbcon: Only allow FRAMEBUFFER_CONSOLE_DEFERRED_TAKEOVER if fbdev is builtin Hans de Goede 2018-08-02 11:28 ` Hans de Goede 2018-08-02 11:28 ` [PATCH fix for 4.19 2/3] fbcon: Only defer console takeover if the current console driver is the dum Hans de Goede 2018-08-02 11:28 ` [PATCH fix for 4.19 2/3] fbcon: Only defer console takeover if the current console driver is the dummycon Hans de Goede 2018-08-02 11:28 ` [PATCH fix for 4.19 3/3] dummycon: Stop exporting dummycon_[un]register_output_notifier Hans de Goede 2018-08-02 11:28 ` Hans de Goede 2018-08-10 15:20 ` [PATCH fix for 4.19 0/3] fbcon: Fix VT switching being broken in combination with vgacon Bartlomiej Zolnierkiewicz 2018-08-10 15:20 ` Bartlomiej Zolnierkiewicz
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180802112841.27679-1-hdegoede@redhat.com \ --to=hdegoede@redhat.com \ --cc=b.zolnierkie@samsung.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-fbdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.