* [PATCH] tools: fix python shebangs to use /usr/bin/env
@ 2018-08-02 9:05 Roger Pau Monne
2018-08-02 9:09 ` Christian Lindig
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Roger Pau Monne @ 2018-08-02 9:05 UTC (permalink / raw)
To: xen-devel
Cc: Wei Liu, David Scott, Ian Jackson, Christian Lindig, Roger Pau Monne
The path to the python binary can be different from /usr/bin/python
depending on the distro/OS.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
Cc: Christian Lindig <christian.lindig@citrix.com>
Cc: David Scott <dave@recoil.org>
---
tools/include/xen-foreign/mkchecker.py | 2 +-
| 2 +-
tools/libxl/gentest.py | 2 +-
tools/libxl/gentypes.py | 2 +-
tools/misc/xen-ringwatch | 2 +-
tools/misc/xencov_split | 2 +-
tools/ocaml/libs/xentoollog/genlevels.py | 2 +-
tools/ocaml/libs/xl/genwrap.py | 2 +-
8 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/tools/include/xen-foreign/mkchecker.py b/tools/include/xen-foreign/mkchecker.py
index fdad869a91..3f1debf3af 100644
--- a/tools/include/xen-foreign/mkchecker.py
+++ b/tools/include/xen-foreign/mkchecker.py
@@ -1,4 +1,4 @@
-#!/usr/bin/python
+#!/usr/bin/env python
import sys;
from structs import structs, compat_arches;
--git a/tools/include/xen-foreign/mkheader.py b/tools/include/xen-foreign/mkheader.py
index 97e0c7a984..812f50ed4e 100644
--- a/tools/include/xen-foreign/mkheader.py
+++ b/tools/include/xen-foreign/mkheader.py
@@ -1,4 +1,4 @@
-#!/usr/bin/python
+#!/usr/bin/env python
import sys, re;
from structs import unions, structs, defines;
diff --git a/tools/libxl/gentest.py b/tools/libxl/gentest.py
index 989959fc68..fbf577d4b5 100644
--- a/tools/libxl/gentest.py
+++ b/tools/libxl/gentest.py
@@ -1,4 +1,4 @@
-#!/usr/bin/python
+#!/usr/bin/env python
import os
import sys
diff --git a/tools/libxl/gentypes.py b/tools/libxl/gentypes.py
index 88e5c5f30e..a36abfb0aa 100644
--- a/tools/libxl/gentypes.py
+++ b/tools/libxl/gentypes.py
@@ -1,4 +1,4 @@
-#!/usr/bin/python
+#!/usr/bin/env python
import sys
import re
diff --git a/tools/misc/xen-ringwatch b/tools/misc/xen-ringwatch
index e6f5361231..df7db5c312 100644
--- a/tools/misc/xen-ringwatch
+++ b/tools/misc/xen-ringwatch
@@ -1,4 +1,4 @@
-#!/usr/bin/python
+#!/usr/bin/env python
#
# Copyright (C) 2011 Citrix Systems, Inc.
#
diff --git a/tools/misc/xencov_split b/tools/misc/xencov_split
index 1f20518b86..5771f6cfc2 100755
--- a/tools/misc/xencov_split
+++ b/tools/misc/xencov_split
@@ -1,4 +1,4 @@
-#!/usr/bin/python
+#!/usr/bin/env python
import sys, os, os.path as path, struct, errno
from optparse import OptionParser
diff --git a/tools/ocaml/libs/xentoollog/genlevels.py b/tools/ocaml/libs/xentoollog/genlevels.py
index 8c233c59b1..9dd3048a46 100755
--- a/tools/ocaml/libs/xentoollog/genlevels.py
+++ b/tools/ocaml/libs/xentoollog/genlevels.py
@@ -1,4 +1,4 @@
-#!/usr/bin/python
+#!/usr/bin/env python
import sys
diff --git a/tools/ocaml/libs/xl/genwrap.py b/tools/ocaml/libs/xl/genwrap.py
index 9a65d7334d..75ed4b400d 100644
--- a/tools/ocaml/libs/xl/genwrap.py
+++ b/tools/ocaml/libs/xl/genwrap.py
@@ -1,4 +1,4 @@
-#!/usr/bin/python
+#!/usr/bin/env python
import sys,os
--
2.18.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] tools: fix python shebangs to use /usr/bin/env
2018-08-02 9:05 [PATCH] tools: fix python shebangs to use /usr/bin/env Roger Pau Monne
@ 2018-08-02 9:09 ` Christian Lindig
2018-08-02 10:18 ` Wei Liu
2018-08-02 13:49 ` Anthony PERARD
2 siblings, 0 replies; 6+ messages in thread
From: Christian Lindig @ 2018-08-02 9:09 UTC (permalink / raw)
To: Roger Pau Monne; +Cc: Xen-devel, David Scott, Wei Liu, Ian Jackson
> On 2 Aug 2018, at 10:05, Roger Pau Monne <roger.pau@citrix.com> wrote:
>
> The path to the python binary can be different from /usr/bin/python
> depending on the distro/OS.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
--
Acked-by: Christian Lindig <christian.lindig@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tools: fix python shebangs to use /usr/bin/env
2018-08-02 9:05 [PATCH] tools: fix python shebangs to use /usr/bin/env Roger Pau Monne
2018-08-02 9:09 ` Christian Lindig
@ 2018-08-02 10:18 ` Wei Liu
2018-08-02 13:49 ` Anthony PERARD
2 siblings, 0 replies; 6+ messages in thread
From: Wei Liu @ 2018-08-02 10:18 UTC (permalink / raw)
To: Roger Pau Monne
Cc: xen-devel, David Scott, Ian Jackson, Wei Liu, Christian Lindig
On Thu, Aug 02, 2018 at 11:05:27AM +0200, Roger Pau Monne wrote:
> The path to the python binary can be different from /usr/bin/python
> depending on the distro/OS.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tools: fix python shebangs to use /usr/bin/env
2018-08-02 9:05 [PATCH] tools: fix python shebangs to use /usr/bin/env Roger Pau Monne
2018-08-02 9:09 ` Christian Lindig
2018-08-02 10:18 ` Wei Liu
@ 2018-08-02 13:49 ` Anthony PERARD
2018-08-02 13:56 ` Roger Pau Monné
2018-08-02 13:56 ` Wei Liu
2 siblings, 2 replies; 6+ messages in thread
From: Anthony PERARD @ 2018-08-02 13:49 UTC (permalink / raw)
To: Roger Pau Monne
Cc: xen-devel, Wei Liu, Ian Jackson, Christian Lindig, David Scott
On Thu, Aug 02, 2018 at 11:05:27AM +0200, Roger Pau Monne wrote:
> The path to the python binary can be different from /usr/bin/python
> depending on the distro/OS.
Shouldn't we also s/python/python2/ as recommended by
https://www.python.org/dev/peps/pep-0394/ ?
I don't think all those scripts works with python2 and python3.
--
Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tools: fix python shebangs to use /usr/bin/env
2018-08-02 13:49 ` Anthony PERARD
@ 2018-08-02 13:56 ` Roger Pau Monné
2018-08-02 13:56 ` Wei Liu
1 sibling, 0 replies; 6+ messages in thread
From: Roger Pau Monné @ 2018-08-02 13:56 UTC (permalink / raw)
To: Anthony PERARD
Cc: xen-devel, Wei Liu, Ian Jackson, Christian Lindig, David Scott
On Thu, Aug 02, 2018 at 02:49:25PM +0100, Anthony PERARD wrote:
> On Thu, Aug 02, 2018 at 11:05:27AM +0200, Roger Pau Monne wrote:
> > The path to the python binary can be different from /usr/bin/python
> > depending on the distro/OS.
>
> Shouldn't we also s/python/python2/ as recommended by
> https://www.python.org/dev/peps/pep-0394/ ?
>
> I don't think all those scripts works with python2 and python3.
Oh, maybe. I think however this should be done in a separate patch.
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tools: fix python shebangs to use /usr/bin/env
2018-08-02 13:49 ` Anthony PERARD
2018-08-02 13:56 ` Roger Pau Monné
@ 2018-08-02 13:56 ` Wei Liu
1 sibling, 0 replies; 6+ messages in thread
From: Wei Liu @ 2018-08-02 13:56 UTC (permalink / raw)
To: Anthony PERARD
Cc: Wei Liu, Ian Jackson, Christian Lindig, David Scott, xen-devel,
Roger Pau Monne
On Thu, Aug 02, 2018 at 02:49:25PM +0100, Anthony PERARD wrote:
> On Thu, Aug 02, 2018 at 11:05:27AM +0200, Roger Pau Monne wrote:
> > The path to the python binary can be different from /usr/bin/python
> > depending on the distro/OS.
>
> Shouldn't we also s/python/python2/ as recommended by
> https://www.python.org/dev/peps/pep-0394/ ?
>
> I don't think all those scripts works with python2 and python3.
This is a good point.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-08-02 13:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-02 9:05 [PATCH] tools: fix python shebangs to use /usr/bin/env Roger Pau Monne
2018-08-02 9:09 ` Christian Lindig
2018-08-02 10:18 ` Wei Liu
2018-08-02 13:49 ` Anthony PERARD
2018-08-02 13:56 ` Roger Pau Monné
2018-08-02 13:56 ` Wei Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.