All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masami Hiramatsu <mhiramat@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Shuah Khan <shuah@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/25] selftests/ftrace: Improve kprobe on module testcase to load/unload module
Date: Thu, 2 Aug 2018 16:22:58 +0900	[thread overview]
Message-ID: <20180802162258.e038d6b1114f6c3c9e2dc238@kernel.org> (raw)
In-Reply-To: <20180802100240.a27b72abe375c5817d970a0c@kernel.org>

On Thu, 2 Aug 2018 10:02:40 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> On Fri, 27 Jul 2018 21:15:08 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
> 
> > --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_module.tc
> > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_module.tc
> > @@ -4,11 +4,18 @@
> >  
> >  [ -f kprobe_events ] || exit_unsupported # this is configurable
> >  
> > +rmmod trace-printk ||:
> > +if ! modprobe trace-printk.ko ; then
> > +  echo "No trace-printk sample module - please make CONFIG_SAMPLE_TRACE_PRINTK=
> > +m"
> > +  exit_unresolved;
> > +fi
> > +
> > +MOD=trace_printk
> > +FUNC=trace_printk_irq_work
> 
> Hmm, this caused a problem with CONFIG_KPROBE_EVENTS_ON_NOTRACE=n.
> However, as far as I can see, the trace_printk_irq_work() is not
> marked as notrace...

Ah, I found this was caused by my prevent probe on notrace patch.
I was a bit too greedy to check out-of-range probes in it.
I'll fix that.

Thank you,

-- 
Masami Hiramatsu <mhiramat@kernel.org>

WARNING: multiple messages have this Message-ID
From: mhiramat at kernel.org (Masami Hiramatsu)
Subject: [PATCH 11/25] selftests/ftrace: Improve kprobe on module testcase to load/unload module
Date: Thu, 2 Aug 2018 16:22:58 +0900	[thread overview]
Message-ID: <20180802162258.e038d6b1114f6c3c9e2dc238@kernel.org> (raw)
In-Reply-To: <20180802100240.a27b72abe375c5817d970a0c@kernel.org>

On Thu, 2 Aug 2018 10:02:40 +0900
Masami Hiramatsu <mhiramat at kernel.org> wrote:

> On Fri, 27 Jul 2018 21:15:08 +0900
> Masami Hiramatsu <mhiramat at kernel.org> wrote:
> 
> > --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_module.tc
> > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_module.tc
> > @@ -4,11 +4,18 @@
> >  
> >  [ -f kprobe_events ] || exit_unsupported # this is configurable
> >  
> > +rmmod trace-printk ||:
> > +if ! modprobe trace-printk.ko ; then
> > +  echo "No trace-printk sample module - please make CONFIG_SAMPLE_TRACE_PRINTK=
> > +m"
> > +  exit_unresolved;
> > +fi
> > +
> > +MOD=trace_printk
> > +FUNC=trace_printk_irq_work
> 
> Hmm, this caused a problem with CONFIG_KPROBE_EVENTS_ON_NOTRACE=n.
> However, as far as I can see, the trace_printk_irq_work() is not
> marked as notrace...

Ah, I found this was caused by my prevent probe on notrace patch.
I was a bit too greedy to check out-of-range probes in it.
I'll fix that.

Thank you,

-- 
Masami Hiramatsu <mhiramat at kernel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID
From: mhiramat@kernel.org (Masami Hiramatsu)
Subject: [PATCH 11/25] selftests/ftrace: Improve kprobe on module testcase to load/unload module
Date: Thu, 2 Aug 2018 16:22:58 +0900	[thread overview]
Message-ID: <20180802162258.e038d6b1114f6c3c9e2dc238@kernel.org> (raw)
Message-ID: <20180802072258.V0oF__alLC6dfgBxRLi6iNZsYUvAnvF35r30o7r1GSI@z> (raw)
In-Reply-To: <20180802100240.a27b72abe375c5817d970a0c@kernel.org>

On Thu, 2 Aug 2018 10:02:40 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> On Fri, 27 Jul 2018 21:15:08 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
> 
> > --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_module.tc
> > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_module.tc
> > @@ -4,11 +4,18 @@
> >  
> >  [ -f kprobe_events ] || exit_unsupported # this is configurable
> >  
> > +rmmod trace-printk ||:
> > +if ! modprobe trace-printk.ko ; then
> > +  echo "No trace-printk sample module - please make CONFIG_SAMPLE_TRACE_PRINTK=
> > +m"
> > +  exit_unresolved;
> > +fi
> > +
> > +MOD=trace_printk
> > +FUNC=trace_printk_irq_work
> 
> Hmm, this caused a problem with CONFIG_KPROBE_EVENTS_ON_NOTRACE=n.
> However, as far as I can see, the trace_printk_irq_work() is not
> marked as notrace...

Ah, I found this was caused by my prevent probe on notrace patch.
I was a bit too greedy to check out-of-range probes in it.
I'll fix that.

Thank you,

-- 
Masami Hiramatsu <mhiramat at kernel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-08-02  7:23 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-27 12:09 [PATCH 00/25] selftests/ftrace: Improve ftracetest with coverage check Masami Hiramatsu
2018-07-27 12:09 ` Masami Hiramatsu
2018-07-27 12:09 ` mhiramat
2018-07-27 12:10 ` [PATCH 01/25] tracing: Allow gcov profiling on only ftrace subsystem Masami Hiramatsu
2018-07-27 12:10   ` Masami Hiramatsu
2018-07-27 12:10   ` mhiramat
2018-07-27 12:10 ` [PATCH 02/25] selftests/ftrace: Add --stop-fail hidden option for debug Masami Hiramatsu
2018-07-27 12:10   ` Masami Hiramatsu
2018-07-27 12:10   ` mhiramat
2018-07-27 12:11 ` [PATCH 03/25] selftests/ftrace: Add --console hidden option Masami Hiramatsu
2018-07-27 12:11   ` Masami Hiramatsu
2018-07-27 12:11   ` mhiramat
2018-07-27 12:11 ` [PATCH 04/25] selftests/ftrace: Add case number prefix to logfile Masami Hiramatsu
2018-07-27 12:11   ` Masami Hiramatsu
2018-07-27 12:11   ` mhiramat
2018-07-27 12:12 ` [PATCH 05/25] selftests/ftrace: More initialize features in initialize_ftrace Masami Hiramatsu
2018-07-27 12:12   ` Masami Hiramatsu
2018-07-27 12:12   ` mhiramat
2018-07-27 12:12 ` [PATCH 06/25] selftests/ftrace: Cleanup ftrace after running test Masami Hiramatsu
2018-07-27 12:12   ` Masami Hiramatsu
2018-07-27 12:12   ` mhiramat
2018-07-27 12:13 ` [PATCH 07/25] selftests/ftrace: Remove unneeded per-test init/cleanup ftrace Masami Hiramatsu
2018-07-27 12:13   ` Masami Hiramatsu
2018-07-27 12:13   ` mhiramat
2018-07-27 12:13 ` [PATCH 08/25] selftests/ftrace: Fix to test kprobe $comm arg only if available Masami Hiramatsu
2018-07-27 12:13   ` Masami Hiramatsu
2018-07-27 12:13   ` mhiramat
2018-07-27 12:14 ` [PATCH 09/25] selftests/ftrace: Fix checkbashisms errors Masami Hiramatsu
2018-07-27 12:14   ` Masami Hiramatsu
2018-07-27 12:14   ` mhiramat
2018-07-27 12:14 ` [PATCH 10/25] selftests/ftrace: Use loopback address instead of localhost Masami Hiramatsu
2018-07-27 12:14   ` Masami Hiramatsu
2018-07-27 12:14   ` mhiramat
2018-07-27 12:15 ` [PATCH 11/25] selftests/ftrace: Improve kprobe on module testcase to load/unload module Masami Hiramatsu
2018-07-27 12:15   ` Masami Hiramatsu
2018-07-27 12:15   ` mhiramat
2018-08-02  1:02   ` Masami Hiramatsu
2018-08-02  1:02     ` Masami Hiramatsu
2018-08-02  1:02     ` mhiramat
2018-08-02  7:22     ` Masami Hiramatsu [this message]
2018-08-02  7:22       ` Masami Hiramatsu
2018-08-02  7:22       ` mhiramat
2018-07-27 12:15 ` [PATCH 12/25] selftests/ftrace: Improve kprobe testcase to check log data Masami Hiramatsu
2018-07-27 12:15   ` Masami Hiramatsu
2018-07-27 12:15   ` mhiramat
2018-07-27 12:16 ` [PATCH 13/25] selftests/ftrace: Improve kretprobe " Masami Hiramatsu
2018-07-27 12:16   ` Masami Hiramatsu
2018-07-27 12:16   ` mhiramat
2018-07-27 12:16 ` [PATCH 14/25] selftests/ftrace: Test kprobe-event argument with various bitsize Masami Hiramatsu
2018-07-27 12:16   ` Masami Hiramatsu
2018-07-27 12:16   ` mhiramat
2018-07-27 12:17 ` [PATCH 15/25] selftests/ftrace: Check set_event_pid result Masami Hiramatsu
2018-07-27 12:17   ` Masami Hiramatsu
2018-07-27 12:17   ` mhiramat
2018-07-27 12:17 ` [PATCH 16/25] selftests/ftrace: Add kprobe event with $comm argument testcase Masami Hiramatsu
2018-07-27 12:17   ` Masami Hiramatsu
2018-07-27 12:17   ` mhiramat
2018-07-27 12:17 ` [PATCH 17/25] selftests/ftrace: Add kprobe profile testcase Masami Hiramatsu
2018-07-27 12:17   ` Masami Hiramatsu
2018-07-27 12:17   ` mhiramat
2018-07-27 12:18 ` [PATCH 18/25] selftests/ftrace: Add a testcase for nop tracer Masami Hiramatsu
2018-07-27 12:18   ` Masami Hiramatsu
2018-07-27 12:18   ` mhiramat
2018-07-27 12:18 ` [PATCH 19/25] selftests/ftrace: Add kprobe-event with symbol argument test Masami Hiramatsu
2018-07-27 12:18   ` Masami Hiramatsu
2018-07-27 12:18   ` mhiramat
2018-07-27 12:19 ` [PATCH 20/25] selftests/ftrace: Add trace_printk sample module test Masami Hiramatsu
2018-07-27 12:19   ` Masami Hiramatsu
2018-07-27 12:19   ` mhiramat
2018-07-27 12:19 ` [PATCH 21/25] selftests/ftrace: Add ringbuffer size changing testcase Masami Hiramatsu
2018-07-27 12:19   ` Masami Hiramatsu
2018-07-27 12:19   ` mhiramat
2018-07-27 12:20 ` [PATCH 22/25] selftests/ftrace: Add function profiling stat testcase Masami Hiramatsu
2018-07-27 12:20   ` Masami Hiramatsu
2018-07-27 12:20   ` mhiramat
2018-07-27 12:20 ` [PATCH 23/25] selftests/ftrace: Add max stack tracer testcase Masami Hiramatsu
2018-07-27 12:20   ` Masami Hiramatsu
2018-07-27 12:20   ` mhiramat
2018-08-03  5:24   ` Masami Hiramatsu
2018-08-03  5:24     ` Masami Hiramatsu
2018-08-03  5:24     ` mhiramat
2018-07-27 12:21 ` [PATCH 24/25] selftests/ftrace: Add function filter on module testcase Masami Hiramatsu
2018-07-27 12:21   ` Masami Hiramatsu
2018-07-27 12:21   ` mhiramat
2018-07-27 12:21 ` [PATCH 25/25] selftests/ftrace: Add trace_pipe testcase Masami Hiramatsu
2018-07-27 12:21   ` Masami Hiramatsu
2018-07-27 12:21   ` mhiramat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180802162258.e038d6b1114f6c3c9e2dc238@kernel.org \
    --to=mhiramat@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=shuah@kernel.org \
    --subject='Re: [PATCH 11/25] selftests/ftrace: Improve kprobe on module testcase to load/unload module' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.