From: "Máté Eckl" <ecklm94@gmail.com> To: Randy Dunlap <rdunlap@infradead.org> Cc: Stephen Rothwell <sfr@canb.auug.org.au>, Linux-Next Mailing List <linux-next@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, pablo@netfilter.org Subject: Re: linux-next: Tree for Aug 2 (netfilter: tproxy) Date: Thu, 2 Aug 2018 21:05:57 +0200 [thread overview] Message-ID: <20180802190557.sha6wer6gkdgrd6i@sch.bme.hu> (raw) In-Reply-To: <0185f82e-4bf5-6c6c-a131-ba2c0197c9a0@infradead.org> [-- Attachment #1: Type: text/plain, Size: 627 bytes --] Hi Randy, Thanks for reporting! Please find the patch attached. Regards, Mate On Thu, Aug 02, 2018 at 09:28:16AM -0700, Randy Dunlap wrote: > On 08/02/2018 02:31 AM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20180801: > > > > on i386: > > ../net/netfilter/nft_tproxy.c: In function 'nft_tproxy_init': > ../net/netfilter/nft_tproxy.c:237:3: error: implicit declaration of function 'nf_defrag_ipv6_enable' [-Werror=implicit-function-declaration] > err = nf_defrag_ipv6_enable(ctx->net); > > > Full randconfig file is attached. > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > > -- > ~Randy [-- Attachment #2: 0001-netfilter-nft_tproxy-Add-missing-config-check.patch --] [-- Type: text/plain, Size: 1559 bytes --] From 2c3a7d3209ed5e539ecd69192fc0f4186fdc7d99 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A1t=C3=A9=20Eckl?= <ecklm94@gmail.com> Date: Thu, 2 Aug 2018 20:46:13 +0200 Subject: [PATCH] netfilter: nft_tproxy: Add missing config check MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A config check was missing form the code when using nf_defrag_ipv6_enable with NFT_TPROXY != n and NF_DEFRAG_IPV6 = n and this caused the following error in case of : ../net/netfilter/nft_tproxy.c: In function 'nft_tproxy_init': ../net/netfilter/nft_tproxy.c:237:3: error: implicit declaration of function +'nf_defrag_ipv6_enable' [-Werror=implicit-function-declaration] err = nf_defrag_ipv6_enable(ctx->net); This patch adds a check for NF_TABLES_IPV6 when NF_DEFRAG_IPV6 is selected by Kconfig. Reported-by: Randy Dunlap <rdunlap@infradead.org> Fixes: 4ed8eb6570a4 ("netfilter: nf_tables: Add native tproxy support") Signed-off-by: Máté Eckl <ecklm94@gmail.com> --- net/netfilter/nft_tproxy.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/netfilter/nft_tproxy.c b/net/netfilter/nft_tproxy.c index c6845f7baa08..eff99dffc842 100644 --- a/net/netfilter/nft_tproxy.c +++ b/net/netfilter/nft_tproxy.c @@ -234,9 +234,11 @@ static int nft_tproxy_init(const struct nft_ctx *ctx, err = nf_defrag_ipv4_enable(ctx->net); if (err) return err; +#if IS_ENABLED(CONFIG_NF_TABLES_IPV6) err = nf_defrag_ipv6_enable(ctx->net); if (err) return err; +#endif break; default: return -EOPNOTSUPP; -- ecklm
WARNING: multiple messages have this Message-ID (diff)
From: "Máté Eckl" <ecklm94@gmail.com> To: Randy Dunlap <rdunlap@infradead.org> Cc: Stephen Rothwell <sfr@canb.auug.org.au>, Linux-Next Mailing List <linux-next@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, pablo@netfilter.org Subject: Re: linux-next: Tree for Aug 2 (netfilter: tproxy) Date: Thu, 2 Aug 2018 21:05:57 +0200 [thread overview] Message-ID: <20180802190557.sha6wer6gkdgrd6i@sch.bme.hu> (raw) In-Reply-To: <0185f82e-4bf5-6c6c-a131-ba2c0197c9a0@infradead.org> [-- Attachment #1: Type: text/plain, Size: 627 bytes --] Hi Randy, Thanks for reporting! Please find the patch attached. Regards, Mate On Thu, Aug 02, 2018 at 09:28:16AM -0700, Randy Dunlap wrote: > On 08/02/2018 02:31 AM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20180801: > > > > on i386: > > ../net/netfilter/nft_tproxy.c: In function 'nft_tproxy_init': > ../net/netfilter/nft_tproxy.c:237:3: error: implicit declaration of function 'nf_defrag_ipv6_enable' [-Werror=implicit-function-declaration] > err = nf_defrag_ipv6_enable(ctx->net); > > > Full randconfig file is attached. > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > > -- > ~Randy [-- Attachment #2: 0001-netfilter-nft_tproxy-Add-missing-config-check.patch --] [-- Type: text/plain, Size: 1560 bytes --] >From 2c3a7d3209ed5e539ecd69192fc0f4186fdc7d99 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A1t=C3=A9=20Eckl?= <ecklm94@gmail.com> Date: Thu, 2 Aug 2018 20:46:13 +0200 Subject: [PATCH] netfilter: nft_tproxy: Add missing config check MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A config check was missing form the code when using nf_defrag_ipv6_enable with NFT_TPROXY != n and NF_DEFRAG_IPV6 = n and this caused the following error in case of : ../net/netfilter/nft_tproxy.c: In function 'nft_tproxy_init': ../net/netfilter/nft_tproxy.c:237:3: error: implicit declaration of function +'nf_defrag_ipv6_enable' [-Werror=implicit-function-declaration] err = nf_defrag_ipv6_enable(ctx->net); This patch adds a check for NF_TABLES_IPV6 when NF_DEFRAG_IPV6 is selected by Kconfig. Reported-by: Randy Dunlap <rdunlap@infradead.org> Fixes: 4ed8eb6570a4 ("netfilter: nf_tables: Add native tproxy support") Signed-off-by: Máté Eckl <ecklm94@gmail.com> --- net/netfilter/nft_tproxy.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/netfilter/nft_tproxy.c b/net/netfilter/nft_tproxy.c index c6845f7baa08..eff99dffc842 100644 --- a/net/netfilter/nft_tproxy.c +++ b/net/netfilter/nft_tproxy.c @@ -234,9 +234,11 @@ static int nft_tproxy_init(const struct nft_ctx *ctx, err = nf_defrag_ipv4_enable(ctx->net); if (err) return err; +#if IS_ENABLED(CONFIG_NF_TABLES_IPV6) err = nf_defrag_ipv6_enable(ctx->net); if (err) return err; +#endif break; default: return -EOPNOTSUPP; -- ecklm
next prev parent reply other threads:[~2018-08-02 19:06 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-02 9:31 linux-next: Tree for Aug 2 Stephen Rothwell 2018-08-02 16:28 ` linux-next: Tree for Aug 2 (netfilter: tproxy) Randy Dunlap 2018-08-02 19:05 ` Máté Eckl [this message] 2018-08-02 19:05 ` Máté Eckl 2018-08-02 19:10 ` Máté Eckl 2018-08-02 19:12 ` Pablo Neira Ayuso
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180802190557.sha6wer6gkdgrd6i@sch.bme.hu \ --to=ecklm94@gmail.com \ --cc=coreteam@netfilter.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-next@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=netfilter-devel@vger.kernel.org \ --cc=pablo@netfilter.org \ --cc=rdunlap@infradead.org \ --cc=sfr@canb.auug.org.au \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.