From: Andrew Lunn <andrew@lunn.ch>
To: Jose Abreu <Jose.Abreu@synopsys.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Joao Pinto <Joao.Pinto@synopsys.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>
Subject: Re: [PATCH v2 net-next 5/9] net: stmmac: Add MDIO related functions for XGMAC2
Date: Fri, 3 Aug 2018 17:30:46 +0200 [thread overview]
Message-ID: <20180803153046.GE15029@lunn.ch> (raw)
In-Reply-To: <21eb5877-ebdd-7710-e445-a60cb6e31ad6@synopsys.com>
> > Probably you want to wait for the bus to be idle before you change the
> > mode to C22. Some PHYs can do both C22 and C45, e.g. EEE registers can
> > be in C45 space, while the rest are in C22.
>
> Ok but I can't test C45 right now so maybe leave that change to
> when I can test it ?
I would fix this now. It probably cannot cause issues now, but it is
wrong. You are going to have to fix it some time, so why not now?
Andrew
next prev parent reply other threads:[~2018-08-03 17:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 14:56 [PATCH v2 net-next 0/9] Add support for XGMAC2 in stmmac Jose Abreu
2018-08-03 14:56 ` [PATCH v2 net-next 1/9] net: stmmac: Add XGMAC 2.10 HWIF entry Jose Abreu
2018-08-03 14:56 ` [PATCH v2 net-next 2/9] net: stmmac: Add MAC related callbacks for XGMAC2 Jose Abreu
2018-08-03 14:56 ` [PATCH v2 net-next 3/9] net: stmmac: Add DMA " Jose Abreu
2018-08-03 14:56 ` [PATCH v2 net-next 4/9] net: stmmac: Add descriptor " Jose Abreu
2018-08-03 14:56 ` [PATCH v2 net-next 5/9] net: stmmac: Add MDIO related functions " Jose Abreu
2018-08-03 15:20 ` Andrew Lunn
2018-08-03 15:25 ` Jose Abreu
2018-08-03 15:30 ` Andrew Lunn [this message]
2018-08-03 14:56 ` [PATCH v2 net-next 6/9] net: stmmac: Add PTP support " Jose Abreu
2018-08-03 14:56 ` [PATCH v2 net-next 7/9] net: stmmac: Integrate XGMAC into main driver flow Jose Abreu
2018-08-03 14:56 ` [PATCH v2 net-next 8/9] net: stmmac: Add the bindings parsing for XGMAC2 Jose Abreu
2018-08-03 14:56 ` [PATCH v2 net-next 9/9] dt-bindings: net: stmmac: Add the bindings documentation " Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180803153046.GE15029@lunn.ch \
--to=andrew@lunn.ch \
--cc=Joao.Pinto@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.