[PATCH i-g-t] igt/gem_eio: Apply reset-stress to each engine

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH i-g-t] igt/gem_eio: Apply reset-stress to each engine
@ 2018-08-08  8:49 ` Chris Wilson
  0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2018-08-08  8:49 UTC (permalink / raw)
  To: intel-gfx; +Cc: igt-dev, Mika Kuoppala

A simple question as to whether the error only occurs on rcs/hsw, or all.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
---
 tests/gem_eio.c | 22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)

diff --git a/tests/gem_eio.c b/tests/gem_eio.c
index 9d608e83e..45f9f9c2d 100644
--- a/tests/gem_eio.c
+++ b/tests/gem_eio.c
@@ -646,13 +646,10 @@ static void test_inflight_internal(int fd, unsigned int wait)
 	close(fd);
 }
 
-/*
- * Verify that we can submit and execute work after unwedging the GPU.
- */
-static void test_reset_stress(int fd, unsigned int flags)
+static void reset_stress(int fd,
+			 uint32_t ctx0, unsigned int engine,
+			 unsigned int flags)
 {
-	uint32_t ctx0 = context_create_safe(fd);
-
 	igt_until_timeout(5) {
 		struct drm_i915_gem_execbuffer2 execbuf = { };
 		struct drm_i915_gem_exec_object2 obj = { };
@@ -680,6 +677,7 @@ static void test_reset_stress(int fd, unsigned int flags)
 		execbuf.buffers_ptr = to_user_pointer(&obj);
 		execbuf.buffer_count = 1;
 		execbuf.rsvd1 = ctx0;
+		execbuf.flags = engine;
 
 		for (i = 0; i < 10; i++)
 			gem_execbuf(fd, &execbuf);
@@ -710,6 +708,18 @@ static void test_reset_stress(int fd, unsigned int flags)
 		gem_context_destroy(fd, ctx);
 		gem_close(fd, obj.handle);
 	}
+}
+
+/*
+ * Verify that we can submit and execute work after unwedging the GPU.
+ */
+static void test_reset_stress(int fd, unsigned int flags)
+{
+	uint32_t ctx0 = context_create_safe(fd);
+	unsigned int engine;
+
+	for_each_engine(fd, engine)
+		reset_stress(fd, ctx0, engine, flags);
 
 	gem_context_destroy(fd, ctx0);
 }
-- 
2.18.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [igt-dev] [PATCH i-g-t] igt/gem_eio: Apply reset-stress to each engine
@ 2018-08-08  8:49 ` Chris Wilson
  0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2018-08-08  8:49 UTC (permalink / raw)
  To: intel-gfx; +Cc: igt-dev, Mika Kuoppala

A simple question as to whether the error only occurs on rcs/hsw, or all.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
---
 tests/gem_eio.c | 22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)

diff --git a/tests/gem_eio.c b/tests/gem_eio.c
index 9d608e83e..45f9f9c2d 100644
--- a/tests/gem_eio.c
+++ b/tests/gem_eio.c
@@ -646,13 +646,10 @@ static void test_inflight_internal(int fd, unsigned int wait)
 	close(fd);
 }
 
-/*
- * Verify that we can submit and execute work after unwedging the GPU.
- */
-static void test_reset_stress(int fd, unsigned int flags)
+static void reset_stress(int fd,
+			 uint32_t ctx0, unsigned int engine,
+			 unsigned int flags)
 {
-	uint32_t ctx0 = context_create_safe(fd);
-
 	igt_until_timeout(5) {
 		struct drm_i915_gem_execbuffer2 execbuf = { };
 		struct drm_i915_gem_exec_object2 obj = { };
@@ -680,6 +677,7 @@ static void test_reset_stress(int fd, unsigned int flags)
 		execbuf.buffers_ptr = to_user_pointer(&obj);
 		execbuf.buffer_count = 1;
 		execbuf.rsvd1 = ctx0;
+		execbuf.flags = engine;
 
 		for (i = 0; i < 10; i++)
 			gem_execbuf(fd, &execbuf);
@@ -710,6 +708,18 @@ static void test_reset_stress(int fd, unsigned int flags)
 		gem_context_destroy(fd, ctx);
 		gem_close(fd, obj.handle);
 	}
+}
+
+/*
+ * Verify that we can submit and execute work after unwedging the GPU.
+ */
+static void test_reset_stress(int fd, unsigned int flags)
+{
+	uint32_t ctx0 = context_create_safe(fd);
+	unsigned int engine;
+
+	for_each_engine(fd, engine)
+		reset_stress(fd, ctx0, engine, flags);
 
 	gem_context_destroy(fd, ctx0);
 }
-- 
2.18.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for igt/gem_eio: Apply reset-stress to each engine
  2018-08-08  8:49 ` [igt-dev] " Chris Wilson
  (?)
@ 2018-08-08  9:09 ` Patchwork
  -1 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-08-08  9:09 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: igt/gem_eio: Apply reset-stress to each engine
URL   : https://patchwork.freedesktop.org/series/47863/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4612 -> IGTPW_1689 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/47863/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1689 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_module_reload@basic-reload-inject:
      fi-hsw-4770r:       PASS -> DMESG-WARN (fdo#107425)

    igt@drv_selftest@live_coherency:
      fi-gdg-551:         PASS -> DMESG-FAIL (fdo#107164)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_workarounds:
      {fi-bsw-kefka}:     DMESG-FAIL (fdo#107292) -> PASS

    igt@kms_chamelium@common-hpd-after-suspend:
      fi-skl-6700k2:      INCOMPLETE (fdo#105524, k.org#199541, fdo#104108) -> PASS

    igt@kms_frontbuffer_tracking@basic:
      fi-hsw-peppy:       DMESG-FAIL (fdo#102614, fdo#106103) -> PASS

    {igt@kms_psr@primary_mmap_gtt}:
      fi-cnl-psr:         DMESG-WARN (fdo#107372) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
  fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
  fdo#105524 https://bugs.freedesktop.org/show_bug.cgi?id=105524
  fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103
  fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
  fdo#107292 https://bugs.freedesktop.org/show_bug.cgi?id=107292
  fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372
  fdo#107425 https://bugs.freedesktop.org/show_bug.cgi?id=107425
  k.org#199541 https://bugzilla.kernel.org/show_bug.cgi?id=199541


== Participating hosts (53 -> 46) ==

  Missing    (7): fi-ilk-m540 fi-bxt-dsi fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-icl-u 


== Build changes ==

    * IGT: IGT_4586 -> IGTPW_1689

  CI_DRM_4612: 54b418b10dad143d1bbe7708de5bbf3344164303 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1689: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1689/
  IGT_4586: 57caaf440520e397403d898e1d3f1d65ef7b79e2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1689/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH i-g-t] igt/gem_eio: Apply reset-stress to each engine
  2018-08-08  8:49 ` [igt-dev] " Chris Wilson
@ 2018-08-08  9:14   ` Mika Kuoppala
  -1 siblings, 0 replies; 6+ messages in thread
From: Mika Kuoppala @ 2018-08-08  9:14 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx; +Cc: igt-dev

Chris Wilson <chris@chris-wilson.co.uk> writes:

> A simple question as to whether the error only occurs on rcs/hsw, or all.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  tests/gem_eio.c | 22 ++++++++++++++++------
>  1 file changed, 16 insertions(+), 6 deletions(-)
>
> diff --git a/tests/gem_eio.c b/tests/gem_eio.c
> index 9d608e83e..45f9f9c2d 100644
> --- a/tests/gem_eio.c
> +++ b/tests/gem_eio.c
> @@ -646,13 +646,10 @@ static void test_inflight_internal(int fd, unsigned int wait)
>  	close(fd);
>  }
>  
> -/*
> - * Verify that we can submit and execute work after unwedging the GPU.
> - */
> -static void test_reset_stress(int fd, unsigned int flags)
> +static void reset_stress(int fd,
> +			 uint32_t ctx0, unsigned int engine,
> +			 unsigned int flags)
>  {
> -	uint32_t ctx0 = context_create_safe(fd);
> -
>  	igt_until_timeout(5) {
>  		struct drm_i915_gem_execbuffer2 execbuf = { };
>  		struct drm_i915_gem_exec_object2 obj = { };
> @@ -680,6 +677,7 @@ static void test_reset_stress(int fd, unsigned int flags)
>  		execbuf.buffers_ptr = to_user_pointer(&obj);
>  		execbuf.buffer_count = 1;
>  		execbuf.rsvd1 = ctx0;
> +		execbuf.flags = engine;
>  
>  		for (i = 0; i < 10; i++)
>  			gem_execbuf(fd, &execbuf);
> @@ -710,6 +708,18 @@ static void test_reset_stress(int fd, unsigned int flags)
>  		gem_context_destroy(fd, ctx);
>  		gem_close(fd, obj.handle);
>  	}
> +}
> +
> +/*
> + * Verify that we can submit and execute work after unwedging the GPU.
> + */
> +static void test_reset_stress(int fd, unsigned int flags)
> +{
> +	uint32_t ctx0 = context_create_safe(fd);
> +	unsigned int engine;
> +
> +	for_each_engine(fd, engine)
> +		reset_stress(fd, ctx0, engine, flags);
>  
>  	gem_context_destroy(fd, ctx0);
>  }
> -- 
> 2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] igt/gem_eio: Apply reset-stress to each engine
@ 2018-08-08  9:14   ` Mika Kuoppala
  0 siblings, 0 replies; 6+ messages in thread
From: Mika Kuoppala @ 2018-08-08  9:14 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx; +Cc: igt-dev

Chris Wilson <chris@chris-wilson.co.uk> writes:

> A simple question as to whether the error only occurs on rcs/hsw, or all.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>

Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> ---
>  tests/gem_eio.c | 22 ++++++++++++++++------
>  1 file changed, 16 insertions(+), 6 deletions(-)
>
> diff --git a/tests/gem_eio.c b/tests/gem_eio.c
> index 9d608e83e..45f9f9c2d 100644
> --- a/tests/gem_eio.c
> +++ b/tests/gem_eio.c
> @@ -646,13 +646,10 @@ static void test_inflight_internal(int fd, unsigned int wait)
>  	close(fd);
>  }
>  
> -/*
> - * Verify that we can submit and execute work after unwedging the GPU.
> - */
> -static void test_reset_stress(int fd, unsigned int flags)
> +static void reset_stress(int fd,
> +			 uint32_t ctx0, unsigned int engine,
> +			 unsigned int flags)
>  {
> -	uint32_t ctx0 = context_create_safe(fd);
> -
>  	igt_until_timeout(5) {
>  		struct drm_i915_gem_execbuffer2 execbuf = { };
>  		struct drm_i915_gem_exec_object2 obj = { };
> @@ -680,6 +677,7 @@ static void test_reset_stress(int fd, unsigned int flags)
>  		execbuf.buffers_ptr = to_user_pointer(&obj);
>  		execbuf.buffer_count = 1;
>  		execbuf.rsvd1 = ctx0;
> +		execbuf.flags = engine;
>  
>  		for (i = 0; i < 10; i++)
>  			gem_execbuf(fd, &execbuf);
> @@ -710,6 +708,18 @@ static void test_reset_stress(int fd, unsigned int flags)
>  		gem_context_destroy(fd, ctx);
>  		gem_close(fd, obj.handle);
>  	}
> +}
> +
> +/*
> + * Verify that we can submit and execute work after unwedging the GPU.
> + */
> +static void test_reset_stress(int fd, unsigned int flags)
> +{
> +	uint32_t ctx0 = context_create_safe(fd);
> +	unsigned int engine;
> +
> +	for_each_engine(fd, engine)
> +		reset_stress(fd, ctx0, engine, flags);
>  
>  	gem_context_destroy(fd, ctx0);
>  }
> -- 
> 2.18.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [igt-dev] ✗ Fi.CI.IGT: failure for igt/gem_eio: Apply reset-stress to each engine
  2018-08-08  8:49 ` [igt-dev] " Chris Wilson
                   ` (2 preceding siblings ...)
  (?)
@ 2018-08-08 11:17 ` Patchwork
  -1 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-08-08 11:17 UTC (permalink / raw)
  To: Chris Wilson; +Cc: igt-dev

== Series Details ==

Series: igt/gem_eio: Apply reset-stress to each engine
URL   : https://patchwork.freedesktop.org/series/47863/
State : failure

== Summary ==

= CI Bug Log - changes from IGT_4586_full -> IGTPW_1689_full =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_1689_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1689_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/47863/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1689_full:

  === IGT changes ===

    ==== Possible regressions ====

    igt@gem_eio@unwedge-stress:
      shard-glk:          PASS -> FAIL
      shard-snb:          PASS -> FAIL
      shard-kbl:          PASS -> FAIL
      shard-hsw:          PASS -> FAIL

    
    ==== Warnings ====

    igt@perf_pmu@rc6:
      shard-kbl:          SKIP -> PASS

    
== Known issues ==

  Here are the changes found in IGTPW_1689_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_ctx_isolation@bcs0-s3:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665) +1

    igt@gem_eio@reset-stress:
      shard-hsw:          PASS -> FAIL (fdo#107500)

    igt@gem_eio@unwedge-stress:
      shard-apl:          PASS -> FAIL (fdo#107260)

    
    ==== Possible fixes ====

    igt@gem_ppgtt@blt-vs-render-ctxn:
      shard-kbl:          INCOMPLETE (fdo#103665, fdo#106023) -> PASS

    igt@gem_softpin@noreloc-s3:
      shard-glk:          FAIL (fdo#103375) -> PASS

    igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
      shard-kbl:          INCOMPLETE (fdo#103665) -> PASS

    igt@kms_rotation_crc@primary-rotation-180:
      shard-snb:          FAIL (fdo#103925) -> PASS

    igt@perf_pmu@init-wait-rcs0:
      shard-snb:          INCOMPLETE (fdo#105411) -> PASS

    igt@pm_rpm@dpms-mode-unset-lpsp:
      shard-glk:          FAIL (fdo#106539) -> SKIP +1
      shard-apl:          FAIL (fdo#106539) -> SKIP +1
      shard-kbl:          FAIL (fdo#106539) -> SKIP +1

    igt@pm_rpm@modeset-lpsp-stress:
      shard-hsw:          FAIL (fdo#106539) -> SKIP +1

    igt@pm_rps@min-max-config-loaded:
      shard-glk:          FAIL (fdo#107466) -> PASS

    
    ==== Warnings ====

    igt@testdisplay:
      shard-glk:          DMESG-WARN (fdo#105763) -> INCOMPLETE (fdo#103359, k.org#198133, fdo#107093)

    
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
  fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
  fdo#106539 https://bugs.freedesktop.org/show_bug.cgi?id=106539
  fdo#107093 https://bugs.freedesktop.org/show_bug.cgi?id=107093
  fdo#107260 https://bugs.freedesktop.org/show_bug.cgi?id=107260
  fdo#107466 https://bugs.freedesktop.org/show_bug.cgi?id=107466
  fdo#107500 https://bugs.freedesktop.org/show_bug.cgi?id=107500
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4586 -> IGTPW_1689
    * Linux: CI_DRM_4606 -> CI_DRM_4612

  CI_DRM_4606: 603c0696f3c56d3f1e47c283de897448473c9041 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4612: 54b418b10dad143d1bbe7708de5bbf3344164303 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1689: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1689/
  IGT_4586: 57caaf440520e397403d898e1d3f1d65ef7b79e2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1689/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-08-08 11:17 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-08  8:49 [PATCH i-g-t] igt/gem_eio: Apply reset-stress to each engine Chris Wilson
2018-08-08  8:49 ` [igt-dev] " Chris Wilson
2018-08-08  9:09 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-08-08  9:14 ` [PATCH i-g-t] " Mika Kuoppala
2018-08-08  9:14   ` [igt-dev] " Mika Kuoppala
2018-08-08 11:17 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.