* [U-Boot] [PATCH 1/1] fat: provide position in debug message
@ 2018-08-09 18:37 Heinrich Schuchardt
2018-08-14 5:39 ` Heinrich Schuchardt
0 siblings, 1 reply; 2+ messages in thread
From: Heinrich Schuchardt @ 2018-08-09 18:37 UTC (permalink / raw)
To: u-boot
The debug message in file_fat_read_at() is not very useful without
indicating the position at which the file is read.
Suggested-by: Tero Kristo <t-kristo@ti.com>
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
fs/fat/fat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/fat/fat.c b/fs/fat/fat.c
index 4efe8a3eda..27004823cd 100644
--- a/fs/fat/fat.c
+++ b/fs/fat/fat.c
@@ -1095,7 +1095,7 @@ int file_fat_read_at(const char *filename, loff_t pos, void *buffer,
if (ret)
goto out_free_both;
- debug("reading %s\n", filename);
+ debug("reading %s at %llx\n", filename, pos);
ret = get_contents(&fsdata, itr->dent, pos, buffer, maxsize, actread);
out_free_both:
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH 1/1] fat: provide position in debug message
2018-08-09 18:37 [U-Boot] [PATCH 1/1] fat: provide position in debug message Heinrich Schuchardt
@ 2018-08-14 5:39 ` Heinrich Schuchardt
0 siblings, 0 replies; 2+ messages in thread
From: Heinrich Schuchardt @ 2018-08-14 5:39 UTC (permalink / raw)
To: u-boot
On 08/09/2018 08:37 PM, Heinrich Schuchardt wrote:
> The debug message in file_fat_read_at() is not very useful without
> indicating the position at which the file is read.
>
> Suggested-by: Tero Kristo <t-kristo@ti.com>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> fs/fat/fat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fat/fat.c b/fs/fat/fat.c
> index 4efe8a3eda..27004823cd 100644
> --- a/fs/fat/fat.c
> +++ b/fs/fat/fat.c
> @@ -1095,7 +1095,7 @@ int file_fat_read_at(const char *filename, loff_t pos, void *buffer,
> if (ret)
> goto out_free_both;
>
> - debug("reading %s\n", filename);
> + debug("reading %s at %llx\n", filename, pos);
> ret = get_contents(&fsdata, itr->dent, pos, buffer, maxsize, actread);
>
> out_free_both:
>
Superseded by:
fs/fat: debug-print file read position during file_fat_read_at()
https://lists.denx.de/pipermail/u-boot/2018-August/338289.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-14 5:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-09 18:37 [U-Boot] [PATCH 1/1] fat: provide position in debug message Heinrich Schuchardt
2018-08-14 5:39 ` Heinrich Schuchardt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.