* [PATCH V2] ARM: dts: silk: Add DA9063 PMIC node
@ 2018-08-04 16:38 ` Marek Vasut
0 siblings, 0 replies; 8+ messages in thread
From: Marek Vasut @ 2018-08-04 16:38 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Marek Vasut, Geert Uytterhoeven, Kuninori Morimoto, Simon Horman,
Wolfram Sang, linux-renesas-soc
Add DA9063 PMIC node to the I2C bus.
Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Simon Horman <horms+renesas@verge.net.au>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc@vger.kernel.org
---
V2: - Replace shmobile with dts since it's a DT patch in subject
- Connect the 9063_IRQ# line to GP3_31
- Since the DA9063 is connected to both i2c1 and i2c7, connect
it to i2c7, which is the dedicated dvfs i2c.
---
arch/arm/boot/dts/r8a7794-silk.dts | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7794-silk.dts b/arch/arm/boot/dts/r8a7794-silk.dts
index daec965889d3..6ea60e1faf75 100644
--- a/arch/arm/boot/dts/r8a7794-silk.dts
+++ b/arch/arm/boot/dts/r8a7794-silk.dts
@@ -405,6 +405,23 @@
clock-frequency = <400000>;
};
+&i2c7 {
+ status = "okay";
+ clock-frequency = <100000>;
+
+ pmic@58 {
+ compatible = "dlg,da9063";
+ reg = <0x58>;
+ interrupt-parent = <&gpio3>;
+ interrupts = <31 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-controller;
+
+ wdt {
+ compatible = "dlg,da9063-watchdog";
+ };
+ };
+};
+
&mmcif0 {
pinctrl-0 = <&mmcif0_pins>;
pinctrl-names = "default";
--
2.16.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH V2] ARM: dts: silk: Add DA9063 PMIC node
@ 2018-08-04 16:38 ` Marek Vasut
0 siblings, 0 replies; 8+ messages in thread
From: Marek Vasut @ 2018-08-04 16:38 UTC (permalink / raw)
To: linux-arm-kernel
Add DA9063 PMIC node to the I2C bus.
Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Simon Horman <horms+renesas@verge.net.au>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-renesas-soc at vger.kernel.org
---
V2: - Replace shmobile with dts since it's a DT patch in subject
- Connect the 9063_IRQ# line to GP3_31
- Since the DA9063 is connected to both i2c1 and i2c7, connect
it to i2c7, which is the dedicated dvfs i2c.
---
arch/arm/boot/dts/r8a7794-silk.dts | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7794-silk.dts b/arch/arm/boot/dts/r8a7794-silk.dts
index daec965889d3..6ea60e1faf75 100644
--- a/arch/arm/boot/dts/r8a7794-silk.dts
+++ b/arch/arm/boot/dts/r8a7794-silk.dts
@@ -405,6 +405,23 @@
clock-frequency = <400000>;
};
+&i2c7 {
+ status = "okay";
+ clock-frequency = <100000>;
+
+ pmic at 58 {
+ compatible = "dlg,da9063";
+ reg = <0x58>;
+ interrupt-parent = <&gpio3>;
+ interrupts = <31 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-controller;
+
+ wdt {
+ compatible = "dlg,da9063-watchdog";
+ };
+ };
+};
+
&mmcif0 {
pinctrl-0 = <&mmcif0_pins>;
pinctrl-names = "default";
--
2.16.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH V2] ARM: dts: silk: Add DA9063 PMIC node
2018-08-04 16:38 ` Marek Vasut
@ 2018-08-07 8:16 ` Geert Uytterhoeven
-1 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2018-08-07 8:16 UTC (permalink / raw)
To: Marek Vasut
Cc: Linux ARM, Marek Vasut, Geert Uytterhoeven, Kuninori Morimoto,
Simon Horman, Wolfram Sang, Linux-Renesas
Hi Marek,
On Sat, Aug 4, 2018 at 6:38 PM Marek Vasut <marek.vasut@gmail.com> wrote:
> Add DA9063 PMIC node to the I2C bus.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Cc: Simon Horman <horms+renesas@verge.net.au>
> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Cc: linux-renesas-soc@vger.kernel.org
> ---
> V2: - Replace shmobile with dts since it's a DT patch in subject
> - Connect the 9063_IRQ# line to GP3_31
> - Since the DA9063 is connected to both i2c1 and i2c7, connect
> it to i2c7, which is the dedicated dvfs i2c.
Thanks for the update!
> --- a/arch/arm/boot/dts/r8a7794-silk.dts
> +++ b/arch/arm/boot/dts/r8a7794-silk.dts
> @@ -405,6 +405,23 @@
> clock-frequency = <400000>;
> };
>
> +&i2c7 {
> + status = "okay";
> + clock-frequency = <100000>;
> +
> + pmic@58 {
> + compatible = "dlg,da9063";
> + reg = <0x58>;
> + interrupt-parent = <&gpio3>;
> + interrupts = <31 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-controller;
> +
> + wdt {
> + compatible = "dlg,da9063-watchdog";
> + };
Given Silk has the full da9063 (unlike the "L" version on Porter), shouldn't
you add an rtc subnode?
Oh, Silk also has the onkey pin wired, so perhaps you want to add an onkey
subnode, too? Does that feature work?
BTW, Stout also has the onkey wired, but lacks the onkey subnode.
> + };
> +};
> +
Nevertheless:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH V2] ARM: dts: silk: Add DA9063 PMIC node
@ 2018-08-07 8:16 ` Geert Uytterhoeven
0 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2018-08-07 8:16 UTC (permalink / raw)
To: linux-arm-kernel
Hi Marek,
On Sat, Aug 4, 2018 at 6:38 PM Marek Vasut <marek.vasut@gmail.com> wrote:
> Add DA9063 PMIC node to the I2C bus.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Cc: Simon Horman <horms+renesas@verge.net.au>
> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Cc: linux-renesas-soc at vger.kernel.org
> ---
> V2: - Replace shmobile with dts since it's a DT patch in subject
> - Connect the 9063_IRQ# line to GP3_31
> - Since the DA9063 is connected to both i2c1 and i2c7, connect
> it to i2c7, which is the dedicated dvfs i2c.
Thanks for the update!
> --- a/arch/arm/boot/dts/r8a7794-silk.dts
> +++ b/arch/arm/boot/dts/r8a7794-silk.dts
> @@ -405,6 +405,23 @@
> clock-frequency = <400000>;
> };
>
> +&i2c7 {
> + status = "okay";
> + clock-frequency = <100000>;
> +
> + pmic at 58 {
> + compatible = "dlg,da9063";
> + reg = <0x58>;
> + interrupt-parent = <&gpio3>;
> + interrupts = <31 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-controller;
> +
> + wdt {
> + compatible = "dlg,da9063-watchdog";
> + };
Given Silk has the full da9063 (unlike the "L" version on Porter), shouldn't
you add an rtc subnode?
Oh, Silk also has the onkey pin wired, so perhaps you want to add an onkey
subnode, too? Does that feature work?
BTW, Stout also has the onkey wired, but lacks the onkey subnode.
> + };
> +};
> +
Nevertheless:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2] ARM: dts: silk: Add DA9063 PMIC node
2018-08-07 8:16 ` Geert Uytterhoeven
@ 2018-08-10 11:57 ` Simon Horman
-1 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2018-08-10 11:57 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Marek Vasut, Linux ARM, Marek Vasut, Geert Uytterhoeven,
Kuninori Morimoto, Wolfram Sang, Linux-Renesas
On Tue, Aug 07, 2018 at 10:16:16AM +0200, Geert Uytterhoeven wrote:
> Hi Marek,
>
> On Sat, Aug 4, 2018 at 6:38 PM Marek Vasut <marek.vasut@gmail.com> wrote:
> > Add DA9063 PMIC node to the I2C bus.
> >
> > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> > Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> > Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > Cc: Simon Horman <horms+renesas@verge.net.au>
> > Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > Cc: linux-renesas-soc@vger.kernel.org
> > ---
> > V2: - Replace shmobile with dts since it's a DT patch in subject
> > - Connect the 9063_IRQ# line to GP3_31
> > - Since the DA9063 is connected to both i2c1 and i2c7, connect
> > it to i2c7, which is the dedicated dvfs i2c.
>
> Thanks for the update!
>
> > --- a/arch/arm/boot/dts/r8a7794-silk.dts
> > +++ b/arch/arm/boot/dts/r8a7794-silk.dts
> > @@ -405,6 +405,23 @@
> > clock-frequency = <400000>;
> > };
> >
> > +&i2c7 {
> > + status = "okay";
> > + clock-frequency = <100000>;
> > +
> > + pmic@58 {
> > + compatible = "dlg,da9063";
> > + reg = <0x58>;
> > + interrupt-parent = <&gpio3>;
> > + interrupts = <31 IRQ_TYPE_LEVEL_LOW>;
> > + interrupt-controller;
> > +
> > + wdt {
> > + compatible = "dlg,da9063-watchdog";
> > + };
>
> Given Silk has the full da9063 (unlike the "L" version on Porter), shouldn't
> you add an rtc subnode?
>
> Oh, Silk also has the onkey pin wired, so perhaps you want to add an onkey
> subnode, too? Does that feature work?
>
> BTW, Stout also has the onkey wired, but lacks the onkey subnode.
>
> > + };
> > +};
> > +
>
> Nevertheless:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks, I have applied this patch for v4.20.
Marek,
please consider some follow-up patches to address the issues
raised by Geert.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH V2] ARM: dts: silk: Add DA9063 PMIC node
@ 2018-08-10 11:57 ` Simon Horman
0 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2018-08-10 11:57 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Aug 07, 2018 at 10:16:16AM +0200, Geert Uytterhoeven wrote:
> Hi Marek,
>
> On Sat, Aug 4, 2018 at 6:38 PM Marek Vasut <marek.vasut@gmail.com> wrote:
> > Add DA9063 PMIC node to the I2C bus.
> >
> > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> > Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> > Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > Cc: Simon Horman <horms+renesas@verge.net.au>
> > Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > Cc: linux-renesas-soc at vger.kernel.org
> > ---
> > V2: - Replace shmobile with dts since it's a DT patch in subject
> > - Connect the 9063_IRQ# line to GP3_31
> > - Since the DA9063 is connected to both i2c1 and i2c7, connect
> > it to i2c7, which is the dedicated dvfs i2c.
>
> Thanks for the update!
>
> > --- a/arch/arm/boot/dts/r8a7794-silk.dts
> > +++ b/arch/arm/boot/dts/r8a7794-silk.dts
> > @@ -405,6 +405,23 @@
> > clock-frequency = <400000>;
> > };
> >
> > +&i2c7 {
> > + status = "okay";
> > + clock-frequency = <100000>;
> > +
> > + pmic at 58 {
> > + compatible = "dlg,da9063";
> > + reg = <0x58>;
> > + interrupt-parent = <&gpio3>;
> > + interrupts = <31 IRQ_TYPE_LEVEL_LOW>;
> > + interrupt-controller;
> > +
> > + wdt {
> > + compatible = "dlg,da9063-watchdog";
> > + };
>
> Given Silk has the full da9063 (unlike the "L" version on Porter), shouldn't
> you add an rtc subnode?
>
> Oh, Silk also has the onkey pin wired, so perhaps you want to add an onkey
> subnode, too? Does that feature work?
>
> BTW, Stout also has the onkey wired, but lacks the onkey subnode.
>
> > + };
> > +};
> > +
>
> Nevertheless:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks, I have applied this patch for v4.20.
Marek,
please consider some follow-up patches to address the issues
raised by Geert.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2] ARM: dts: silk: Add DA9063 PMIC node
2018-08-10 11:57 ` Simon Horman
@ 2018-08-11 11:03 ` Marek Vasut
-1 siblings, 0 replies; 8+ messages in thread
From: Marek Vasut @ 2018-08-11 11:03 UTC (permalink / raw)
To: Simon Horman, Geert Uytterhoeven
Cc: Linux ARM, Marek Vasut, Geert Uytterhoeven, Kuninori Morimoto,
Wolfram Sang, Linux-Renesas
On 08/10/2018 01:57 PM, Simon Horman wrote:
> On Tue, Aug 07, 2018 at 10:16:16AM +0200, Geert Uytterhoeven wrote:
>> Hi Marek,
>>
>> On Sat, Aug 4, 2018 at 6:38 PM Marek Vasut <marek.vasut@gmail.com> wrote:
>>> Add DA9063 PMIC node to the I2C bus.
>>>
>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
>>> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
>>> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>>> Cc: Simon Horman <horms+renesas@verge.net.au>
>>> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
>>> Cc: linux-renesas-soc@vger.kernel.org
>>> ---
>>> V2: - Replace shmobile with dts since it's a DT patch in subject
>>> - Connect the 9063_IRQ# line to GP3_31
>>> - Since the DA9063 is connected to both i2c1 and i2c7, connect
>>> it to i2c7, which is the dedicated dvfs i2c.
>>
>> Thanks for the update!
>>
>>> --- a/arch/arm/boot/dts/r8a7794-silk.dts
>>> +++ b/arch/arm/boot/dts/r8a7794-silk.dts
>>> @@ -405,6 +405,23 @@
>>> clock-frequency = <400000>;
>>> };
>>>
>>> +&i2c7 {
>>> + status = "okay";
>>> + clock-frequency = <100000>;
>>> +
>>> + pmic@58 {
>>> + compatible = "dlg,da9063";
>>> + reg = <0x58>;
>>> + interrupt-parent = <&gpio3>;
>>> + interrupts = <31 IRQ_TYPE_LEVEL_LOW>;
>>> + interrupt-controller;
>>> +
>>> + wdt {
>>> + compatible = "dlg,da9063-watchdog";
>>> + };
>>
>> Given Silk has the full da9063 (unlike the "L" version on Porter), shouldn't
>> you add an rtc subnode?
>>
>> Oh, Silk also has the onkey pin wired, so perhaps you want to add an onkey
>> subnode, too? Does that feature work?
>>
>> BTW, Stout also has the onkey wired, but lacks the onkey subnode.
>>
>>> + };
>>> +};
>>> +
>>
>> Nevertheless:
>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Thanks, I have applied this patch for v4.20.
>
> Marek,
>
> please consider some follow-up patches to address the issues
> raised by Geert.
Thanks for the reminder, I missed the email. Patch is out.
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH V2] ARM: dts: silk: Add DA9063 PMIC node
@ 2018-08-11 11:03 ` Marek Vasut
0 siblings, 0 replies; 8+ messages in thread
From: Marek Vasut @ 2018-08-11 11:03 UTC (permalink / raw)
To: linux-arm-kernel
On 08/10/2018 01:57 PM, Simon Horman wrote:
> On Tue, Aug 07, 2018 at 10:16:16AM +0200, Geert Uytterhoeven wrote:
>> Hi Marek,
>>
>> On Sat, Aug 4, 2018 at 6:38 PM Marek Vasut <marek.vasut@gmail.com> wrote:
>>> Add DA9063 PMIC node to the I2C bus.
>>>
>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
>>> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
>>> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>>> Cc: Simon Horman <horms+renesas@verge.net.au>
>>> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
>>> Cc: linux-renesas-soc at vger.kernel.org
>>> ---
>>> V2: - Replace shmobile with dts since it's a DT patch in subject
>>> - Connect the 9063_IRQ# line to GP3_31
>>> - Since the DA9063 is connected to both i2c1 and i2c7, connect
>>> it to i2c7, which is the dedicated dvfs i2c.
>>
>> Thanks for the update!
>>
>>> --- a/arch/arm/boot/dts/r8a7794-silk.dts
>>> +++ b/arch/arm/boot/dts/r8a7794-silk.dts
>>> @@ -405,6 +405,23 @@
>>> clock-frequency = <400000>;
>>> };
>>>
>>> +&i2c7 {
>>> + status = "okay";
>>> + clock-frequency = <100000>;
>>> +
>>> + pmic at 58 {
>>> + compatible = "dlg,da9063";
>>> + reg = <0x58>;
>>> + interrupt-parent = <&gpio3>;
>>> + interrupts = <31 IRQ_TYPE_LEVEL_LOW>;
>>> + interrupt-controller;
>>> +
>>> + wdt {
>>> + compatible = "dlg,da9063-watchdog";
>>> + };
>>
>> Given Silk has the full da9063 (unlike the "L" version on Porter), shouldn't
>> you add an rtc subnode?
>>
>> Oh, Silk also has the onkey pin wired, so perhaps you want to add an onkey
>> subnode, too? Does that feature work?
>>
>> BTW, Stout also has the onkey wired, but lacks the onkey subnode.
>>
>>> + };
>>> +};
>>> +
>>
>> Nevertheless:
>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Thanks, I have applied this patch for v4.20.
>
> Marek,
>
> please consider some follow-up patches to address the issues
> raised by Geert.
Thanks for the reminder, I missed the email. Patch is out.
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-08-11 13:37 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-04 16:38 [PATCH V2] ARM: dts: silk: Add DA9063 PMIC node Marek Vasut
2018-08-04 16:38 ` Marek Vasut
2018-08-07 8:16 ` Geert Uytterhoeven
2018-08-07 8:16 ` Geert Uytterhoeven
2018-08-10 11:57 ` Simon Horman
2018-08-10 11:57 ` Simon Horman
2018-08-11 11:03 ` Marek Vasut
2018-08-11 11:03 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.