* [PATCH v3 0/5] Add GPIO and EAVB Pinctrl support
@ 2018-08-07 7:57 Biju Das
2018-08-07 7:57 ` [PATCH v3 1/5] gpio: rcar: Add GPIO hole support Biju Das
` (4 more replies)
0 siblings, 5 replies; 17+ messages in thread
From: Biju Das @ 2018-08-07 7:57 UTC (permalink / raw)
To: Rob Herring, Mark Rutland
Cc: Biju Das, Simon Horman, Magnus Damm, linux-renesas-soc,
devicetree, Geert Uytterhoeven, Chris Paterson, Fabrizio Castro
This patch series aims to add GPIO and EAVB Pinctrl support for RZ/G1C SoC.
----
V1-->V2
* Add support for gpio-reserved-ranges
V2-->V3
* Updated binding documentation
* Rework based on Geert's comment.
----
Biju Das (5):
gpio: rcar: Add GPIO hole support
dt-bindings: gpio: rcar: Add gpio-reserved-ranges support
ARM: dts: r8a77470: Add GPIO support
ARM: dts: iwg23s-sbc: specify EtherAVB PHY IRQ
ARM: dts: iwg23s-sbc: Add pinctl support for EtherAVB
.../devicetree/bindings/gpio/renesas,gpio-rcar.txt | 61 ++++++++-------
arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 10 +++
arch/arm/boot/dts/r8a77470.dtsi | 91 ++++++++++++++++++++++
drivers/gpio/gpio-rcar.c | 6 ++
4 files changed, 142 insertions(+), 26 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v3 1/5] gpio: rcar: Add GPIO hole support
2018-08-07 7:57 [PATCH v3 0/5] Add GPIO and EAVB Pinctrl support Biju Das
@ 2018-08-07 7:57 ` Biju Das
2018-08-07 8:36 ` Geert Uytterhoeven
2018-08-29 8:47 ` Linus Walleij
2018-08-07 7:57 ` [PATCH v3 2/5] dt-bindings: gpio: rcar: Add gpio-reserved-ranges support Biju Das
` (3 subsequent siblings)
4 siblings, 2 replies; 17+ messages in thread
From: Biju Das @ 2018-08-07 7:57 UTC (permalink / raw)
To: Linus Walleij
Cc: Biju Das, linux-gpio, Simon Horman, Geert Uytterhoeven,
Chris Paterson, Fabrizio Castro, linux-renesas-soc
GPIO hole is present in RZ/G1C SoC. Valid GPIO pins on bank3 are in the
range GP3_0 to GP3_16 and GP3_27 to GP3_29. The GPIO pins between GP3_17
to GP3_26 are unused. Add support for handling unused GPIO's.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
V1-->V2
* Added gpio-reserved-ranges support for handling
unused gpios.
V2-->V3
* Incorporated Geert's review comment.
---
drivers/gpio/gpio-rcar.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
index 350390c..5e72b27 100644
--- a/drivers/gpio/gpio-rcar.c
+++ b/drivers/gpio/gpio-rcar.c
@@ -314,6 +314,9 @@ static void gpio_rcar_set_multiple(struct gpio_chip *chip, unsigned long *mask,
u32 val, bankmask;
bankmask = mask[0] & GENMASK(chip->ngpio - 1, 0);
+ if (chip->valid_mask)
+ bankmask &= chip->valid_mask[0];
+
if (!bankmask)
return;
@@ -550,6 +553,9 @@ static int gpio_rcar_resume(struct device *dev)
u32 mask;
for (offset = 0; offset < p->gpio_chip.ngpio; offset++) {
+ if (!gpiochip_line_is_valid(&p->gpio_chip, offset))
+ continue;
+
mask = BIT(offset);
/* I/O pin */
if (!(p->bank_info.iointsel & mask)) {
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v3 2/5] dt-bindings: gpio: rcar: Add gpio-reserved-ranges support
2018-08-07 7:57 [PATCH v3 0/5] Add GPIO and EAVB Pinctrl support Biju Das
2018-08-07 7:57 ` [PATCH v3 1/5] gpio: rcar: Add GPIO hole support Biju Das
@ 2018-08-07 7:57 ` Biju Das
2018-08-07 8:18 ` Geert Uytterhoeven
` (2 more replies)
2018-08-07 7:57 ` [PATCH v3 3/5] ARM: dts: r8a77470: Add GPIO support Biju Das
` (2 subsequent siblings)
4 siblings, 3 replies; 17+ messages in thread
From: Biju Das @ 2018-08-07 7:57 UTC (permalink / raw)
To: Linus Walleij, Rob Herring, Mark Rutland
Cc: Biju Das, linux-gpio, devicetree, Simon Horman,
Geert Uytterhoeven, Chris Paterson, Fabrizio Castro,
linux-renesas-soc
Update the DT bindings documentation with the optional gpio-reserved-ranges
properties.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
V2 --> V3
* Incorporated review comments.
---
.../devicetree/bindings/gpio/renesas,gpio-rcar.txt | 61 +++++++++++++---------
1 file changed, 35 insertions(+), 26 deletions(-)
diff --git a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
index 378f132..f8c81e4 100644
--- a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
+++ b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
@@ -38,7 +38,7 @@ Required Properties:
- #gpio-cells: Should be 2. The first cell is the GPIO number and the second
cell specifies GPIO flags, as defined in <dt-bindings/gpio/gpio.h>. Only the
GPIO_ACTIVE_HIGH and GPIO_ACTIVE_LOW flags are supported.
- - gpio-ranges: Range of pins managed by the GPIO controller.
+ - gpio-ranges: See gpio.txt.
Optional properties:
@@ -46,35 +46,44 @@ Optional properties:
mandatory if the hardware implements a controllable functional clock for
the GPIO instance.
-Please refer to gpio.txt in this directory for details of gpio-ranges property
-and the common GPIO bindings used by client devices.
+ - gpio-reserved-ranges: See gpio.txt.
+
+Please refer to gpio.txt in this directory for the common GPIO bindings used by
+client devices.
The GPIO controller also acts as an interrupt controller. It uses the default
two cells specifier as described in Documentation/devicetree/bindings/
interrupt-controller/interrupts.txt.
-Example: R8A7779 (R-Car H1) GPIO controller nodes
+Example: R8A77470 (RZ/G1C) GPIO controller nodes
- gpio0: gpio@ffc40000 {
- compatible = "renesas,gpio-r8a7779", "renesas,rcar-gen1-gpio";
- reg = <0xffc40000 0x2c>;
- interrupt-parent = <&gic>;
- interrupts = <0 141 0x4>;
- #gpio-cells = <2>;
- gpio-controller;
- gpio-ranges = <&pfc 0 0 32>;
- interrupt-controller;
- #interrupt-cells = <2>;
- };
+ gpio0: gpio@e6050000 {
+ compatible = "renesas,gpio-r8a77470",
+ "renesas,rcar-gen2-gpio";
+ reg = <0 0xe6050000 0 0x50>;
+ interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-ranges = <&pfc 0 0 23>;
+ #interrupt-cells = <2>;
+ interrupt-controller;
+ clocks = <&cpg CPG_MOD 912>;
+ power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
+ resets = <&cpg 912>;
+ };
...
- gpio6: gpio@ffc46000 {
- compatible = "renesas,gpio-r8a7779", "renesas,rcar-gen1-gpio";
- reg = <0xffc46000 0x2c>;
- interrupt-parent = <&gic>;
- interrupts = <0 147 0x4>;
- #gpio-cells = <2>;
- gpio-controller;
- gpio-ranges = <&pfc 0 192 9>;
- interrupt-controller;
- #interrupt-cells = <2>;
- };
+ gpio3: gpio@e6053000 {
+ compatible = "renesas,gpio-r8a77470",
+ "renesas,rcar-gen2-gpio";
+ reg = <0 0xe6053000 0 0x50>;
+ interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-ranges = <&pfc 0 96 30>;
+ gpio-reserved-ranges = <17 10>;
+ #interrupt-cells = <2>;
+ interrupt-controller;
+ clocks = <&cpg CPG_MOD 909>;
+ power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
+ resets = <&cpg 909>;
+ };
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v3 3/5] ARM: dts: r8a77470: Add GPIO support
2018-08-07 7:57 [PATCH v3 0/5] Add GPIO and EAVB Pinctrl support Biju Das
2018-08-07 7:57 ` [PATCH v3 1/5] gpio: rcar: Add GPIO hole support Biju Das
2018-08-07 7:57 ` [PATCH v3 2/5] dt-bindings: gpio: rcar: Add gpio-reserved-ranges support Biju Das
@ 2018-08-07 7:57 ` Biju Das
2018-08-10 12:10 ` Simon Horman
2018-08-07 7:57 ` [PATCH v3 4/5] ARM: dts: iwg23s-sbc: specify EtherAVB PHY IRQ Biju Das
2018-08-07 7:57 ` [PATCH v3 5/5] ARM: dts: iwg23s-sbc: Add pinctl support for EtherAVB Biju Das
4 siblings, 1 reply; 17+ messages in thread
From: Biju Das @ 2018-08-07 7:57 UTC (permalink / raw)
To: Rob Herring, Mark Rutland
Cc: Biju Das, Simon Horman, Magnus Damm, linux-renesas-soc,
devicetree, Geert Uytterhoeven, Chris Paterson, Fabrizio Castro
Describe GPIO blocks in the R8A77470 device tree.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
V2-->V3
* Moved gpio-reserved-ranges property just below gpio-ranges
---
arch/arm/boot/dts/r8a77470.dtsi | 91 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 91 insertions(+)
diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi
index c6730f4..0bea5a2 100644
--- a/arch/arm/boot/dts/r8a77470.dtsi
+++ b/arch/arm/boot/dts/r8a77470.dtsi
@@ -61,6 +61,97 @@
#size-cells = <2>;
ranges;
+ gpio0: gpio@e6050000 {
+ compatible = "renesas,gpio-r8a77470",
+ "renesas,rcar-gen2-gpio";
+ reg = <0 0xe6050000 0 0x50>;
+ interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-ranges = <&pfc 0 0 23>;
+ #interrupt-cells = <2>;
+ interrupt-controller;
+ clocks = <&cpg CPG_MOD 912>;
+ power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
+ resets = <&cpg 912>;
+ };
+
+ gpio1: gpio@e6051000 {
+ compatible = "renesas,gpio-r8a77470",
+ "renesas,rcar-gen2-gpio";
+ reg = <0 0xe6051000 0 0x50>;
+ interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-ranges = <&pfc 0 32 23>;
+ #interrupt-cells = <2>;
+ interrupt-controller;
+ clocks = <&cpg CPG_MOD 911>;
+ power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
+ resets = <&cpg 911>;
+ };
+
+ gpio2: gpio@e6052000 {
+ compatible = "renesas,gpio-r8a77470",
+ "renesas,rcar-gen2-gpio";
+ reg = <0 0xe6052000 0 0x50>;
+ interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-ranges = <&pfc 0 64 32>;
+ #interrupt-cells = <2>;
+ interrupt-controller;
+ clocks = <&cpg CPG_MOD 910>;
+ power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
+ resets = <&cpg 910>;
+ };
+
+ gpio3: gpio@e6053000 {
+ compatible = "renesas,gpio-r8a77470",
+ "renesas,rcar-gen2-gpio";
+ reg = <0 0xe6053000 0 0x50>;
+ interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-ranges = <&pfc 0 96 30>;
+ gpio-reserved-ranges = <17 10>;
+ #interrupt-cells = <2>;
+ interrupt-controller;
+ clocks = <&cpg CPG_MOD 909>;
+ power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
+ resets = <&cpg 909>;
+ };
+
+ gpio4: gpio@e6054000 {
+ compatible = "renesas,gpio-r8a77470",
+ "renesas,rcar-gen2-gpio";
+ reg = <0 0xe6054000 0 0x50>;
+ interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-ranges = <&pfc 0 128 26>;
+ #interrupt-cells = <2>;
+ interrupt-controller;
+ clocks = <&cpg CPG_MOD 908>;
+ power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
+ resets = <&cpg 908>;
+ };
+
+ gpio5: gpio@e6055000 {
+ compatible = "renesas,gpio-r8a77470",
+ "renesas,rcar-gen2-gpio";
+ reg = <0 0xe6055000 0 0x50>;
+ interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ gpio-ranges = <&pfc 0 160 32>;
+ #interrupt-cells = <2>;
+ interrupt-controller;
+ clocks = <&cpg CPG_MOD 907>;
+ power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
+ resets = <&cpg 907>;
+ };
+
pfc: pin-controller@e6060000 {
compatible = "renesas,pfc-r8a77470";
reg = <0 0xe6060000 0 0x118>;
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v3 4/5] ARM: dts: iwg23s-sbc: specify EtherAVB PHY IRQ
2018-08-07 7:57 [PATCH v3 0/5] Add GPIO and EAVB Pinctrl support Biju Das
` (2 preceding siblings ...)
2018-08-07 7:57 ` [PATCH v3 3/5] ARM: dts: r8a77470: Add GPIO support Biju Das
@ 2018-08-07 7:57 ` Biju Das
2018-08-10 12:11 ` Simon Horman
2018-08-07 7:57 ` [PATCH v3 5/5] ARM: dts: iwg23s-sbc: Add pinctl support for EtherAVB Biju Das
4 siblings, 1 reply; 17+ messages in thread
From: Biju Das @ 2018-08-07 7:57 UTC (permalink / raw)
To: Rob Herring, Mark Rutland
Cc: Biju Das, Simon Horman, Magnus Damm, linux-renesas-soc,
devicetree, Geert Uytterhoeven, Chris Paterson, Fabrizio Castro
Specify EtherAVB PHY IRQ in the board specific device tree, now that we
have GPIO support.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
---
V1-->V2
* No change
V2-->V3
* No change
* compile time dependency on gpio dtsi patch
---
---
arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
index 2dab6d1..a3d92d9 100644
--- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
+++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
@@ -59,6 +59,8 @@
phy3: ethernet-phy@3 {
reg = <3>;
+ interrupt-parent = <&gpio5>;
+ interrupts = <16 IRQ_TYPE_LEVEL_LOW>;
micrel,led-mode = <1>;
};
};
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v3 5/5] ARM: dts: iwg23s-sbc: Add pinctl support for EtherAVB
2018-08-07 7:57 [PATCH v3 0/5] Add GPIO and EAVB Pinctrl support Biju Das
` (3 preceding siblings ...)
2018-08-07 7:57 ` [PATCH v3 4/5] ARM: dts: iwg23s-sbc: specify EtherAVB PHY IRQ Biju Das
@ 2018-08-07 7:57 ` Biju Das
2018-08-10 12:12 ` Simon Horman
4 siblings, 1 reply; 17+ messages in thread
From: Biju Das @ 2018-08-07 7:57 UTC (permalink / raw)
To: Rob Herring, Mark Rutland
Cc: Biju Das, Simon Horman, Magnus Damm, linux-renesas-soc,
devicetree, Geert Uytterhoeven, Chris Paterson, Fabrizio Castro
Adding pinctrl support for EtherAVB interface.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
V1-->V2
* No change
V2-->V3
* No change
Depend onthe below patch
https://patchwork.kernel.org/patch/10546801/
---
arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
index a3d92d9..2bfba93 100644
--- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
+++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
@@ -52,6 +52,9 @@
};
&avb {
+ pinctrl-0 = <&avb_pins>;
+ pinctrl-names = "default";
+
phy-handle = <&phy3>;
phy-mode = "gmii";
renesas,no-ether-link;
@@ -70,6 +73,11 @@
};
&pfc {
+ avb_pins: avb {
+ groups = "avb_mdio", "avb_gmii_tx_rx";
+ function = "avb";
+ };
+
scif1_pins: scif1 {
groups = "scif1_data_b";
function = "scif1";
--
2.7.4
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v3 2/5] dt-bindings: gpio: rcar: Add gpio-reserved-ranges support
2018-08-07 7:57 ` [PATCH v3 2/5] dt-bindings: gpio: rcar: Add gpio-reserved-ranges support Biju Das
@ 2018-08-07 8:18 ` Geert Uytterhoeven
2018-08-07 17:43 ` Rob Herring
2018-08-29 8:48 ` Linus Walleij
2 siblings, 0 replies; 17+ messages in thread
From: Geert Uytterhoeven @ 2018-08-07 8:18 UTC (permalink / raw)
To: Biju Das
Cc: Linus Walleij, Rob Herring, Mark Rutland,
open list:GPIO SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Simon Horman, Geert Uytterhoeven, Chris Paterson,
Fabrizio Castro, Linux-Renesas
On Tue, Aug 7, 2018 at 10:03 AM Biju Das <biju.das@bp.renesas.com> wrote:
> Update the DT bindings documentation with the optional gpio-reserved-ranges
> properties.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 1/5] gpio: rcar: Add GPIO hole support
2018-08-07 7:57 ` [PATCH v3 1/5] gpio: rcar: Add GPIO hole support Biju Das
@ 2018-08-07 8:36 ` Geert Uytterhoeven
2018-08-29 8:47 ` Linus Walleij
1 sibling, 0 replies; 17+ messages in thread
From: Geert Uytterhoeven @ 2018-08-07 8:36 UTC (permalink / raw)
To: Biju Das
Cc: Linus Walleij, open list:GPIO SUBSYSTEM, Simon Horman,
Geert Uytterhoeven, Chris Paterson, Fabrizio Castro,
Linux-Renesas
On Tue, Aug 7, 2018 at 10:03 AM Biju Das <biju.das@bp.renesas.com> wrote:
> GPIO hole is present in RZ/G1C SoC. Valid GPIO pins on bank3 are in the
> range GP3_0 to GP3_16 and GP3_27 to GP3_29. The GPIO pins between GP3_17
> to GP3_26 are unused. Add support for handling unused GPIO's.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> ---
> V1-->V2
> * Added gpio-reserved-ranges support for handling
> unused gpios.
> V2-->V3
> * Incorporated Geert's review comment.
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 2/5] dt-bindings: gpio: rcar: Add gpio-reserved-ranges support
2018-08-07 7:57 ` [PATCH v3 2/5] dt-bindings: gpio: rcar: Add gpio-reserved-ranges support Biju Das
2018-08-07 8:18 ` Geert Uytterhoeven
@ 2018-08-07 17:43 ` Rob Herring
2018-08-29 8:48 ` Linus Walleij
2 siblings, 0 replies; 17+ messages in thread
From: Rob Herring @ 2018-08-07 17:43 UTC (permalink / raw)
To: Biju Das
Cc: Linus Walleij, Mark Rutland, linux-gpio, devicetree,
Simon Horman, Geert Uytterhoeven, Chris Paterson,
Fabrizio Castro, linux-renesas-soc
On Tue, Aug 07, 2018 at 08:57:03AM +0100, Biju Das wrote:
> Update the DT bindings documentation with the optional gpio-reserved-ranges
> properties.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
> V2 --> V3
> * Incorporated review comments.
> ---
> .../devicetree/bindings/gpio/renesas,gpio-rcar.txt | 61 +++++++++++++---------
> 1 file changed, 35 insertions(+), 26 deletions(-)
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 3/5] ARM: dts: r8a77470: Add GPIO support
2018-08-07 7:57 ` [PATCH v3 3/5] ARM: dts: r8a77470: Add GPIO support Biju Das
@ 2018-08-10 12:10 ` Simon Horman
0 siblings, 0 replies; 17+ messages in thread
From: Simon Horman @ 2018-08-10 12:10 UTC (permalink / raw)
To: Biju Das
Cc: Rob Herring, Mark Rutland, Magnus Damm, linux-renesas-soc,
devicetree, Geert Uytterhoeven, Chris Paterson, Fabrizio Castro
On Tue, Aug 07, 2018 at 08:57:04AM +0100, Biju Das wrote:
> Describe GPIO blocks in the R8A77470 device tree.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> V2-->V3
> * Moved gpio-reserved-ranges property just below gpio-ranges
Thanks, applied for v4.20.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 4/5] ARM: dts: iwg23s-sbc: specify EtherAVB PHY IRQ
2018-08-07 7:57 ` [PATCH v3 4/5] ARM: dts: iwg23s-sbc: specify EtherAVB PHY IRQ Biju Das
@ 2018-08-10 12:11 ` Simon Horman
0 siblings, 0 replies; 17+ messages in thread
From: Simon Horman @ 2018-08-10 12:11 UTC (permalink / raw)
To: Biju Das
Cc: Rob Herring, Mark Rutland, Magnus Damm, linux-renesas-soc,
devicetree, Geert Uytterhoeven, Chris Paterson, Fabrizio Castro
On Tue, Aug 07, 2018 at 08:57:05AM +0100, Biju Das wrote:
> Specify EtherAVB PHY IRQ in the board specific device tree, now that we
> have GPIO support.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks, applied for v4.20.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 5/5] ARM: dts: iwg23s-sbc: Add pinctl support for EtherAVB
2018-08-07 7:57 ` [PATCH v3 5/5] ARM: dts: iwg23s-sbc: Add pinctl support for EtherAVB Biju Das
@ 2018-08-10 12:12 ` Simon Horman
2018-08-10 13:47 ` Biju Das
0 siblings, 1 reply; 17+ messages in thread
From: Simon Horman @ 2018-08-10 12:12 UTC (permalink / raw)
To: Biju Das
Cc: Rob Herring, Mark Rutland, Magnus Damm, linux-renesas-soc,
devicetree, Geert Uytterhoeven, Chris Paterson, Fabrizio Castro
On Tue, Aug 07, 2018 at 08:57:06AM +0100, Biju Das wrote:
> Adding pinctrl support for EtherAVB interface.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> V1-->V2
> * No change
> V2-->V3
> * No change
> Depend onthe below patch
> https://patchwork.kernel.org/patch/10546801/
What is the effect of applying this patch without that dependency present?
^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: [PATCH v3 5/5] ARM: dts: iwg23s-sbc: Add pinctl support for EtherAVB
2018-08-10 12:12 ` Simon Horman
@ 2018-08-10 13:47 ` Biju Das
2018-08-17 8:44 ` Simon Horman
0 siblings, 1 reply; 17+ messages in thread
From: Biju Das @ 2018-08-10 13:47 UTC (permalink / raw)
To: Simon Horman
Cc: Rob Herring, Mark Rutland, Magnus Damm, linux-renesas-soc,
devicetree, Geert Uytterhoeven, Chris Paterson, Fabrizio Castro
Hello Simon,
Thanks for the feedback.
> Subject: Re: [PATCH v3 5/5] ARM: dts: iwg23s-sbc: Add pinctl support for
> EtherAVB
>
> On Tue, Aug 07, 2018 at 08:57:06AM +0100, Biju Das wrote:
> > Adding pinctrl support for EtherAVB interface.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > V1-->V2
> > * No change
> > V2-->V3
> > * No change
> > Depend onthe below patch
> > https://patchwork.kernel.org/patch/10546801/
>
> What is the effect of applying this patch without that dependency present?
No build dependency. Only driver probe will fail during run time.
[ 0.838091] ravb: probe of e6800000.ethernet failed with error -22
Regards,
Biju
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 5/5] ARM: dts: iwg23s-sbc: Add pinctl support for EtherAVB
2018-08-10 13:47 ` Biju Das
@ 2018-08-17 8:44 ` Simon Horman
2018-08-17 9:03 ` Biju Das
0 siblings, 1 reply; 17+ messages in thread
From: Simon Horman @ 2018-08-17 8:44 UTC (permalink / raw)
To: Biju Das
Cc: Rob Herring, Mark Rutland, Magnus Damm, linux-renesas-soc,
devicetree, Geert Uytterhoeven, Chris Paterson, Fabrizio Castro
On Fri, Aug 10, 2018 at 01:47:12PM +0000, Biju Das wrote:
> Hello Simon,
>
> Thanks for the feedback.
>
> > Subject: Re: [PATCH v3 5/5] ARM: dts: iwg23s-sbc: Add pinctl support for
> > EtherAVB
> >
> > On Tue, Aug 07, 2018 at 08:57:06AM +0100, Biju Das wrote:
> > > Adding pinctrl support for EtherAVB interface.
> > >
> > > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > > V1-->V2
> > > * No change
> > > V2-->V3
> > > * No change
> > > Depend onthe below patch
> > > https://patchwork.kernel.org/patch/10546801/
> >
> > What is the effect of applying this patch without that dependency present?
>
> No build dependency. Only driver probe will fail during run time.
> [ 0.838091] ravb: probe of e6800000.ethernet failed with error -22
Thanks, but does the driver probe fail without this patch?
If so I'd rather hold off on this until v4.21.
^ permalink raw reply [flat|nested] 17+ messages in thread
* RE: [PATCH v3 5/5] ARM: dts: iwg23s-sbc: Add pinctl support for EtherAVB
2018-08-17 8:44 ` Simon Horman
@ 2018-08-17 9:03 ` Biju Das
0 siblings, 0 replies; 17+ messages in thread
From: Biju Das @ 2018-08-17 9:03 UTC (permalink / raw)
To: Simon Horman
Cc: Rob Herring, Mark Rutland, Magnus Damm, linux-renesas-soc,
devicetree, Geert Uytterhoeven, Chris Paterson, Fabrizio Castro
Hi Simon,
Thanks for the feedback.
> -----Original Message-----
> From: devicetree-owner@vger.kernel.org <devicetree-
> owner@vger.kernel.org> On Behalf Of Simon Horman
> Sent: 17 August 2018 09:45
> To: Biju Das <biju.das@bp.renesas.com>
> Cc: Rob Herring <robh+dt@kernel.org>; Mark Rutland
> <mark.rutland@arm.com>; Magnus Damm <magnus.damm@gmail.com>;
> linux-renesas-soc@vger.kernel.org; devicetree@vger.kernel.org; Geert
> Uytterhoeven <geert+renesas@glider.be>; Chris Paterson
> <Chris.Paterson2@renesas.com>; Fabrizio Castro
> <fabrizio.castro@bp.renesas.com>
> Subject: Re: [PATCH v3 5/5] ARM: dts: iwg23s-sbc: Add pinctl support for
> EtherAVB
>
> On Fri, Aug 10, 2018 at 01:47:12PM +0000, Biju Das wrote:
> > Hello Simon,
> >
> > Thanks for the feedback.
> >
> > > Subject: Re: [PATCH v3 5/5] ARM: dts: iwg23s-sbc: Add pinctl support
> > > for EtherAVB
> > >
> > > On Tue, Aug 07, 2018 at 08:57:06AM +0100, Biju Das wrote:
> > > > Adding pinctrl support for EtherAVB interface.
> > > >
> > > > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > > > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > > ---
> > > > V1-->V2
> > > > * No change
> > > > V2-->V3
> > > > * No change
> > > > Depend onthe below patch
> > > > https://patchwork.kernel.org/patch/10546801/
> > >
> > > What is the effect of applying this patch without that dependency
> present?
> >
> > No build dependency. Only driver probe will fail during run time.
> > [ 0.838091] ravb: probe of e6800000.ethernet failed with error -22
>
> Thanks, but does the driver probe fail without this patch?
Drive probe works ok without this patch.
> If so I'd rather hold off on this until v4.21.
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 1/5] gpio: rcar: Add GPIO hole support
2018-08-07 7:57 ` [PATCH v3 1/5] gpio: rcar: Add GPIO hole support Biju Das
2018-08-07 8:36 ` Geert Uytterhoeven
@ 2018-08-29 8:47 ` Linus Walleij
1 sibling, 0 replies; 17+ messages in thread
From: Linus Walleij @ 2018-08-29 8:47 UTC (permalink / raw)
To: Biju Das
Cc: open list:GPIO SUBSYSTEM, Simon Horman, Geert Uytterhoeven,
Chris Paterson, Fabrizio Castro, Linux-Renesas
On Tue, Aug 7, 2018 at 10:03 AM Biju Das <biju.das@bp.renesas.com> wrote:
> GPIO hole is present in RZ/G1C SoC. Valid GPIO pins on bank3 are in the
> range GP3_0 to GP3_16 and GP3_27 to GP3_29. The GPIO pins between GP3_17
> to GP3_26 are unused. Add support for handling unused GPIO's.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Patch applied with Geert's review tag.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v3 2/5] dt-bindings: gpio: rcar: Add gpio-reserved-ranges support
2018-08-07 7:57 ` [PATCH v3 2/5] dt-bindings: gpio: rcar: Add gpio-reserved-ranges support Biju Das
2018-08-07 8:18 ` Geert Uytterhoeven
2018-08-07 17:43 ` Rob Herring
@ 2018-08-29 8:48 ` Linus Walleij
2 siblings, 0 replies; 17+ messages in thread
From: Linus Walleij @ 2018-08-29 8:48 UTC (permalink / raw)
To: Biju Das
Cc: Rob Herring, Mark Rutland, open list:GPIO SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Simon Horman, Geert Uytterhoeven, Chris Paterson,
Fabrizio Castro, Linux-Renesas
On Tue, Aug 7, 2018 at 10:03 AM Biju Das <biju.das@bp.renesas.com> wrote:
> Update the DT bindings documentation with the optional gpio-reserved-ranges
> properties.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Patch applied with the ACKs.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2018-08-29 12:43 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-07 7:57 [PATCH v3 0/5] Add GPIO and EAVB Pinctrl support Biju Das
2018-08-07 7:57 ` [PATCH v3 1/5] gpio: rcar: Add GPIO hole support Biju Das
2018-08-07 8:36 ` Geert Uytterhoeven
2018-08-29 8:47 ` Linus Walleij
2018-08-07 7:57 ` [PATCH v3 2/5] dt-bindings: gpio: rcar: Add gpio-reserved-ranges support Biju Das
2018-08-07 8:18 ` Geert Uytterhoeven
2018-08-07 17:43 ` Rob Herring
2018-08-29 8:48 ` Linus Walleij
2018-08-07 7:57 ` [PATCH v3 3/5] ARM: dts: r8a77470: Add GPIO support Biju Das
2018-08-10 12:10 ` Simon Horman
2018-08-07 7:57 ` [PATCH v3 4/5] ARM: dts: iwg23s-sbc: specify EtherAVB PHY IRQ Biju Das
2018-08-10 12:11 ` Simon Horman
2018-08-07 7:57 ` [PATCH v3 5/5] ARM: dts: iwg23s-sbc: Add pinctl support for EtherAVB Biju Das
2018-08-10 12:12 ` Simon Horman
2018-08-10 13:47 ` Biju Das
2018-08-17 8:44 ` Simon Horman
2018-08-17 9:03 ` Biju Das
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.