* [PATCH] staging: mt7621-mmc: place a check for sscanf
@ 2018-08-10 12:31 Sumit Pundir
0 siblings, 0 replies; only message in thread
From: Sumit Pundir @ 2018-08-10 12:31 UTC (permalink / raw)
To: gregkh; +Cc: neil, devel, linux-kernel, Sumit Pundir
Placed a check for the return value of sscanf. -EINVAL is returned if
the value is anything other than expected. Reported by checkpatch.pl
Signed-off-by: Sumit Pundir <pundirsumit11@gmail.com>
---
drivers/staging/mt7621-mmc/dbg.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/mt7621-mmc/dbg.c b/drivers/staging/mt7621-mmc/dbg.c
index 6e518dce9029..4fe4d2fd111e 100644
--- a/drivers/staging/mt7621-mmc/dbg.c
+++ b/drivers/staging/mt7621-mmc/dbg.c
@@ -249,7 +249,9 @@ static ssize_t msdc_debug_proc_write(struct file *file,
cmd_buf[count] = '\0';
pr_debug("msdc Write %s\n", cmd_buf);
- sscanf(cmd_buf, "%x %x %x", &cmd, &p1, &p2);
+ ret = sscanf(cmd_buf, "%x %x %x", &cmd, &p1, &p2);
+ if (ret != 3)
+ return -EINVAL;
if (cmd == SD_TOOL_ZONE) {
id = p1;
--
2.17.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-08-10 12:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-10 12:31 [PATCH] staging: mt7621-mmc: place a check for sscanf Sumit Pundir
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.