[meta-java][PATCH v2] icedtea: disable error format-overflow for gcc 7

[meta-java][PATCH v2] icedtea: disable error format-overflow for gcc 7

[Richard Leitner]

From: Andreas Obergschwandtner <andreas.obergschwandtner@skidata.com>

As no patch has been found in debian and hotspot repo for this issue we
just disable this warning which was introduced with GCC 7.

Also known as: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=881824

Signed-off-by: Andreas Obergschwandtner <andreas.obergschwandtner@skidata.com>
Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
---
Changes v2:
   + adapted by Richard Leitner to use the openjdk-build-helper class from
     André Draszik instead of our own in the java class.
    (Therefore it now depends on the "prepare for openjdk-8 build infra re-use"
     series from André)
---
 recipes-core/icedtea/icedtea7-native.inc | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/recipes-core/icedtea/icedtea7-native.inc b/recipes-core/icedtea/icedtea7-native.inc
index 30fb24a..796acb6 100644
--- a/recipes-core/icedtea/icedtea7-native.inc
+++ b/recipes-core/icedtea/icedtea7-native.inc
@@ -24,6 +24,12 @@ CFLAGS_append = " -fno-tree-dse"
 CXXFLAGS_append = " -fno-tree-dse"
 CXX_append = " -std=gnu++98"
 
+# Disable format-overflow error with host g++ >= 7.3.
+# This bug is known as https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=881824
+FLAGS_GCC7 = " -Wno-error=format-overflow"
+BUILD_CFLAGS_append = " ${@openjdk_build_helper_get_build_cflags(d)}"
+BUILD_CXXFLAGS_append = " ${@openjdk_build_helper_get_build_cflags(d)}"
+
 inherit native java autotools pkgconfig
 inherit openjdk-build-helper
 
-- 
2.11.0

Re: [meta-java][PATCH v2] icedtea: disable error format-overflow for gcc 7

[Richard Leitner]

Hi,
this is a note to let you know that I've just added this patch to the
master-next branch of the meta-java repository at
	git://git.yoctoproject.org/meta-java

As soon as it has gone through some more testing it will likely be
merged to the master branch.

If you have any questions, please let me know.

regards;Richard.L

On 08/13/2018 05:46 PM, Richard Leitner wrote:
> From: Andreas Obergschwandtner <andreas.obergschwandtner@skidata.com>
> 
> As no patch has been found in debian and hotspot repo for this issue we
> just disable this warning which was introduced with GCC 7.
> 
> Also known as: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=881824
> 
> Signed-off-by: Andreas Obergschwandtner <andreas.obergschwandtner@skidata.com>
> Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
> ---
> Changes v2:
>     + adapted by Richard Leitner to use the openjdk-build-helper class from
>       André Draszik instead of our own in the java class.
>      (Therefore it now depends on the "prepare for openjdk-8 build infra re-use"
>       series from André)
> ---
>   recipes-core/icedtea/icedtea7-native.inc | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/recipes-core/icedtea/icedtea7-native.inc b/recipes-core/icedtea/icedtea7-native.inc
> index 30fb24a..796acb6 100644
> --- a/recipes-core/icedtea/icedtea7-native.inc
> +++ b/recipes-core/icedtea/icedtea7-native.inc
> @@ -24,6 +24,12 @@ CFLAGS_append = " -fno-tree-dse"
>   CXXFLAGS_append = " -fno-tree-dse"
>   CXX_append = " -std=gnu++98"
>   
> +# Disable format-overflow error with host g++ >= 7.3.
> +# This bug is known as https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=881824
> +FLAGS_GCC7 = " -Wno-error=format-overflow"
> +BUILD_CFLAGS_append = " ${@openjdk_build_helper_get_build_cflags(d)}"
> +BUILD_CXXFLAGS_append = " ${@openjdk_build_helper_get_build_cflags(d)}"
> +
>   inherit native java autotools pkgconfig
>   inherit openjdk-build-helper
>   
> 

Re: [meta-java][PATCH v2] icedtea: disable error format-overflow for gcc 7

[André Draszik]

On Mon, 2018-08-13 at 17:46 +0200, Richard Leitner wrote:
> From: Andreas Obergschwandtner <andreas.obergschwandtner@skidata.com>
> 
> As no patch has been found in debian and hotspot repo for this issue we
> just disable this warning which was introduced with GCC 7.
> 
> Also known as: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=881824

Two points:

TBH, I'd be a bit wary of this considering the recent fallout from silencing
compiler warnings. Can you try to address this instead please?

E.g. OpenJDK-8 has very similar code, so should be possible?

Also, I have gcc 7.3, yet I don't see that error. Is there something else
happening?


Cheers,
Andre'

Re: [meta-java][PATCH v2] icedtea: disable error format-overflow for gcc 7

[Richard Leitner]

Hi,

On 8/14/18 10:27 AM, André Draszik wrote:
> On Mon, 2018-08-13 at 17:46 +0200, Richard Leitner wrote:
>> From: Andreas Obergschwandtner <andreas.obergschwandtner@skidata.com>
>>
>> As no patch has been found in debian and hotspot repo for this issue we
>> just disable this warning which was introduced with GCC 7.
>>
>> Also known as: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=881824
> 
> Two points:
> 
> TBH, I'd be a bit wary of this considering the recent fallout from silencing
> compiler warnings. Can you try to address this instead please?

I agree... Therefore I've removed the patch from master-next.

> 
> E.g. OpenJDK-8 has very similar code, so should be possible?
> 
> Also, I have gcc 7.3, yet I don't see that error. Is there something else
> happening?

We have already looked into it more deeply and will probably send a patch
for it next week. Although we are currently not entirely sure why the compiler
is complaining ;-)

regards;Richard.L