[meta-java][PATCH] openjdk-7: clarify a bitbake warning

[meta-java][PATCH] openjdk-7: clarify a bitbake warning

[Richard Leitner]

We get a bitbake warning during recipe building complaining about
unsupported architectures unconditionally. That check is relevant
only for shark builds, so it is quite confusing for non-shark
builds.

Make the warning conditional on whether shark builds are enabled
or not.

This is the same patch as the one for openjdk-8 by André Draszik
(commit 86c729cb51f880fd5a1ec6485baddfa2bedaa998)

Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
---
 recipes-core/openjdk/openjdk-common.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/recipes-core/openjdk/openjdk-common.inc b/recipes-core/openjdk/openjdk-common.inc
index 816b463..c92af40 100644
--- a/recipes-core/openjdk/openjdk-common.inc
+++ b/recipes-core/openjdk/openjdk-common.inc
@@ -55,7 +55,8 @@ def get_llvm_configure_arch(d):
     elif arch == "powerpc" or arch == "powerpc64":
         arch = "powerpc"
     else:
-        bb.warn("%s does not support %s yet" % (d.getVar('PN', True), arch) );
+        if 'shark' in d.getVar('PACKAGECONFIG').split():
+            bb.warn("%s does not support %s in Shark builds yet" % (d.getVar('PN', True), arch) );
 
     return arch
 
-- 
2.11.0

Re: [meta-java][PATCH] openjdk-7: clarify a bitbake warning

[Henning Heinold]

On Mon, Aug 13, 2018 at 05:20:21PM +0200, Richard Leitner wrote:
> We get a bitbake warning during recipe building complaining about
> unsupported architectures unconditionally. That check is relevant
> only for shark builds, so it is quite confusing for non-shark
> builds.
> 
> Make the warning conditional on whether shark builds are enabled
> or not.
> 
> This is the same patch as the one for openjdk-8 by André Draszik
> (commit 86c729cb51f880fd5a1ec6485baddfa2bedaa998)
> 
> Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
> ---
>  recipes-core/openjdk/openjdk-common.inc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/recipes-core/openjdk/openjdk-common.inc b/recipes-core/openjdk/openjdk-common.inc
> index 816b463..c92af40 100644
> --- a/recipes-core/openjdk/openjdk-common.inc
> +++ b/recipes-core/openjdk/openjdk-common.inc
> @@ -55,7 +55,8 @@ def get_llvm_configure_arch(d):
>      elif arch == "powerpc" or arch == "powerpc64":
>          arch = "powerpc"
>      else:
> -        bb.warn("%s does not support %s yet" % (d.getVar('PN', True), arch) );
> +        if 'shark' in d.getVar('PACKAGECONFIG').split():
> +            bb.warn("%s does not support %s in Shark builds yet" % (d.getVar('PN', True), arch) );
>  
>      return arch
>  
> -- 
> 2.11.0

Looks good to me.

Bye Henning

Re: [meta-java][PATCH] openjdk-7: clarify a bitbake warning

[Richard Leitner]

On 08/13/2018 05:53 PM, Henning Heinold wrote:
> On Mon, Aug 13, 2018 at 05:20:21PM +0200, Richard Leitner wrote:
>> We get a bitbake warning during recipe building complaining about
>> unsupported architectures unconditionally. That check is relevant
>> only for shark builds, so it is quite confusing for non-shark
>> builds.
>>
>> Make the warning conditional on whether shark builds are enabled
>> or not.
>>
>> This is the same patch as the one for openjdk-8 by André Draszik
>> (commit 86c729cb51f880fd5a1ec6485baddfa2bedaa998)
>>
>> Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
>> ---
...
>> -- 
>> 2.11.0
> 
> Looks good to me.

Thanks!

fyi: I "converted" this to an Acked-by for the patch.

> 
> Bye Henning
> 

regards;Richard.L