All of lore.kernel.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] igt/pm_rpm: Close local fd before trying to unload module
Date: Wed, 15 Aug 2018 14:01:31 +0300	[thread overview]
Message-ID: <20180815110131.GA8037@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <20180815092511.3838-1-chris@chris-wilson.co.uk>

On Wed, Aug 15, 2018 at 10:25:11AM +0100, Chris Wilson wrote:
> Fixes: d8e78990aa2b ("igt/pm_rpm: Test reaquisition of runtime-pm after module reload")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  tests/pm_rpm.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> index 65489bcdb..a4f9f783e 100644
> --- a/tests/pm_rpm.c
> +++ b/tests/pm_rpm.c
> @@ -2034,6 +2034,8 @@ int main(int argc, char *argv[])
>  		teardown_environment();
>  
>  	igt_subtest("module-reload") {
> +		teardown_environment();
> +

Why isn't the teardown_environment(); under igt_fixture enough?

>  		igt_debug("Reload w/o display\n");
>  		igt_i915_driver_unload();
>  		igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
> -- 
> 2.18.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Imre Deak <imre.deak@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] igt/pm_rpm: Close local fd before trying to unload module
Date: Wed, 15 Aug 2018 14:01:31 +0300	[thread overview]
Message-ID: <20180815110131.GA8037@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <20180815092511.3838-1-chris@chris-wilson.co.uk>

On Wed, Aug 15, 2018 at 10:25:11AM +0100, Chris Wilson wrote:
> Fixes: d8e78990aa2b ("igt/pm_rpm: Test reaquisition of runtime-pm after module reload")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  tests/pm_rpm.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> index 65489bcdb..a4f9f783e 100644
> --- a/tests/pm_rpm.c
> +++ b/tests/pm_rpm.c
> @@ -2034,6 +2034,8 @@ int main(int argc, char *argv[])
>  		teardown_environment();
>  
>  	igt_subtest("module-reload") {
> +		teardown_environment();
> +

Why isn't the teardown_environment(); under igt_fixture enough?

>  		igt_debug("Reload w/o display\n");
>  		igt_i915_driver_unload();
>  		igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
> -- 
> 2.18.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-08-15 11:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-15  9:25 [PATCH i-g-t] igt/pm_rpm: Close local fd before trying to unload module Chris Wilson
2018-08-15  9:25 ` [Intel-gfx] " Chris Wilson
2018-08-15 10:48 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-08-15 11:01 ` Imre Deak [this message]
2018-08-15 11:01   ` [Intel-gfx] [igt-dev] [PATCH i-g-t] " Imre Deak
2018-08-15 11:04   ` Chris Wilson
2018-08-15 11:04     ` Chris Wilson
2018-08-15 11:08 ` Chris Wilson
2018-08-15 20:58   ` Chris Wilson
2018-08-15 11:45 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2018-08-15 16:11 ` [igt-dev] ✓ Fi.CI.BAT: success for igt/pm_rpm: Close local fd before trying to unload module (rev2) Patchwork
2018-08-15 20:53 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-08-17 17:29 ` [igt-dev] [PATCH i-g-t] igt/pm_rpm: Close local fd before trying to unload module Antonio Argenziano
2018-08-17 17:29   ` Antonio Argenziano
2018-08-17 17:49   ` Chris Wilson
2018-08-17 17:49     ` Chris Wilson
2018-08-17 18:27     ` Antonio Argenziano
2018-08-17 18:27       ` Antonio Argenziano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180815110131.GA8037@ideak-desk.fi.intel.com \
    --to=imre.deak@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.