[PATCH] RFT: Do we detect WA_TAIL?

[PATCH] RFT: Do we detect WA_TAIL?

[Chris Wilson]

---
 drivers/gpu/drm/i915/intel_lrc.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index 3f90c74038ef..fff2fbb6bac5 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -161,7 +161,7 @@
 
 /* Typical size of the average request (2 pipecontrols and a MI_BB) */
 #define EXECLISTS_REQUEST_SIZE 64 /* bytes */
-#define WA_TAIL_DWORDS 2
+#define WA_TAIL_DWORDS 0
 #define WA_TAIL_BYTES (sizeof(u32) * WA_TAIL_DWORDS)
 
 static int execlists_context_deferred_alloc(struct i915_gem_context *ctx,
@@ -2195,8 +2195,10 @@ static int gen8_emit_flush_render(struct i915_request *request,
 static void gen8_emit_wa_tail(struct i915_request *request, u32 *cs)
 {
 	/* Ensure there's always at least one preemption point per-request. */
-	*cs++ = MI_ARB_CHECK;
-	*cs++ = MI_NOOP;
+	if (WA_TAIL_DWORDS) {
+		*cs++ = MI_ARB_CHECK;
+		*cs++ = MI_NOOP;
+	}
 	request->wa_tail = intel_ring_offset(request, cs);
 }
 
-- 
2.18.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.CHECKPATCH: warning for RFT: Do we detect WA_TAIL?

[Patchwork]

== Series Details ==

Series: RFT: Do we detect WA_TAIL?
URL   : https://patchwork.freedesktop.org/series/48247/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
ea2011cc92cd RFT: Do we detect WA_TAIL?
-:32: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 0 checks, 20 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for RFT: Do we detect WA_TAIL?

[Patchwork]

== Series Details ==

Series: RFT: Do we detect WA_TAIL?
URL   : https://patchwork.freedesktop.org/series/48247/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4671 -> Patchwork_9949 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48247/revisions/1/mbox/

== Known issues ==

  Here are the changes found in Patchwork_9949 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_hangcheck:
      fi-bxt-dsi:         PASS -> DMESG-FAIL (fdo#106560)

    
    ==== Possible fixes ====

    igt@kms_frontbuffer_tracking@basic:
      fi-hsw-peppy:       DMESG-FAIL (fdo#102614) -> PASS

    
  fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
  fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560


== Participating hosts (53 -> 48) ==

  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * Linux: CI_DRM_4671 -> Patchwork_9949

  CI_DRM_4671: 77a98fa3e9b6eb29d513b1666ecddfdcfc424e86 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4598: 9c0f04355107a8693650b16756b6343a78501138 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9949: ea2011cc92cd73536c59ac9392cfe108e10b13a8 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

ea2011cc92cd RFT: Do we detect WA_TAIL?

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9949/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] RFT: Do we detect WA_TAIL?

[Chris Wilson]

Quoting Chris Wilson (2018-08-15 12:13:51)

The answer is no. So either our wait-for-ack is the ultimate panacea, or
we just don't have the right pattern to trigger the bug.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] RFT: Do we detect WA_TAIL?

[Chris Wilson]

Quoting Chris Wilson (2018-08-15 13:23:12)
> Quoting Chris Wilson (2018-08-15 12:13:51)
> 
> The answer is no. So either our wait-for-ack is the ultimate panacea, or
> we just don't have the right pattern to trigger the bug.

Fwiw, the small batch sizes for gem_concurrent_blit were good at hitting
it on bdw/skl.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.IGT: success for RFT: Do we detect WA_TAIL?

[Patchwork]

== Series Details ==

Series: RFT: Do we detect WA_TAIL?
URL   : https://patchwork.freedesktop.org/series/48247/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4671_full -> Patchwork_9949_full =

== Summary - SUCCESS ==

  No regressions found.

  

== Known issues ==

  Here are the changes found in Patchwork_9949_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_plane_lowres@pipe-a-tiling-y:
      shard-glk:          PASS -> FAIL (fdo#103166)

    igt@perf@polling:
      shard-hsw:          PASS -> FAIL (fdo#102252)

    
    ==== Possible fixes ====

    igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
      shard-glk:          FAIL (fdo#105363) -> PASS

    
  fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * Linux: CI_DRM_4671 -> Patchwork_9949

  CI_DRM_4671: 77a98fa3e9b6eb29d513b1666ecddfdcfc424e86 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4598: 9c0f04355107a8693650b16756b6343a78501138 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9949: ea2011cc92cd73536c59ac9392cfe108e10b13a8 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9949/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx