All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfstests: generic/062: Change output of empty attribute values
@ 2018-08-22  8:32 Su Yue
  2018-08-22 11:45 ` Eryu Guan
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Su Yue @ 2018-08-22  8:32 UTC (permalink / raw)
  To: fstests; +Cc: suy.fnst

Since v2.4.47 of attr(5)[1], commit 0550d2bc989d (Properly
set and report empty attribute values) changed output format of
empty attribute value with quotes.

Here, change generic/062.out to match the actual output.

[1]: https://git.savannah.nongnu.org/git/attr.git

Signed-off-by: Su Yue <suy.fnst@cn.fujitsu.com>
---
 tests/generic/062.out | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/tests/generic/062.out b/tests/generic/062.out
index 8cc3c655..9b9cd744 100644
--- a/tests/generic/062.out
+++ b/tests/generic/062.out
@@ -13,7 +13,7 @@ SCRATCH_MNT/reg
 
 *** set/get one initially empty attribute
 # file: SCRATCH_MNT/reg
-user.name
+user.name=""
 
 *** overwrite empty, set several new attributes
 *** fetch several attribute names and values (hex)
@@ -42,7 +42,7 @@ user.name3=0xdeface
 
 *** set an empty value for second attribute
 # file: SCRATCH_MNT/reg
-user.name2
+user.name2=""
 
 *** overwrite empty value
 # file: SCRATCH_MNT/reg
@@ -60,7 +60,7 @@ user.name3=0xdeface
 
 *** set/get one initially empty attribute
 # file: SCRATCH_MNT/dir
-user.name
+user.name=""
 
 *** overwrite empty, set several new attributes
 *** fetch several attribute names and values (hex)
@@ -89,7 +89,7 @@ user.name3=0xdeface
 
 *** set an empty value for second attribute
 # file: SCRATCH_MNT/dir
-user.name2
+user.name2=""
 
 *** overwrite empty value
 # file: SCRATCH_MNT/dir
@@ -207,7 +207,7 @@ SCRATCH_MNT/dev/p: user.name2: No such attribute or operation not permitted
 
 *** set/get one initially empty attribute
 # file: SCRATCH_MNT/reg
-trusted.name
+trusted.name=""
 
 *** overwrite empty, set several new attributes
 *** fetch several attribute names and values (hex)
@@ -236,7 +236,7 @@ trusted.name3=0xdeface
 
 *** set an empty value for second attribute
 # file: SCRATCH_MNT/reg
-trusted.name2
+trusted.name2=""
 
 *** overwrite empty value
 # file: SCRATCH_MNT/reg
@@ -256,7 +256,7 @@ user.name3=0xdeface
 
 *** set/get one initially empty attribute
 # file: SCRATCH_MNT/dir
-trusted.name
+trusted.name=""
 
 *** overwrite empty, set several new attributes
 *** fetch several attribute names and values (hex)
@@ -285,7 +285,7 @@ trusted.name3=0xdeface
 
 *** set an empty value for second attribute
 # file: SCRATCH_MNT/dir
-trusted.name2
+trusted.name2=""
 
 *** overwrite empty value
 # file: SCRATCH_MNT/dir
@@ -305,7 +305,7 @@ user.name3=0xdeface
 
 *** set/get one initially empty attribute
 # file: SCRATCH_MNT/lnk
-trusted.name
+trusted.name=""
 
 *** overwrite empty, set several new attributes
 *** fetch several attribute names and values (hex)
@@ -334,7 +334,7 @@ trusted.name3=0xdeface
 
 *** set an empty value for second attribute
 # file: SCRATCH_MNT/lnk
-trusted.name2
+trusted.name2=""
 
 *** overwrite empty value
 # file: SCRATCH_MNT/lnk
@@ -352,7 +352,7 @@ trusted.name3=0xdeface
 
 *** set/get one initially empty attribute
 # file: SCRATCH_MNT/dev/b
-trusted.name
+trusted.name=""
 
 *** overwrite empty, set several new attributes
 *** fetch several attribute names and values (hex)
@@ -381,7 +381,7 @@ trusted.name3=0xdeface
 
 *** set an empty value for second attribute
 # file: SCRATCH_MNT/dev/b
-trusted.name2
+trusted.name2=""
 
 *** overwrite empty value
 # file: SCRATCH_MNT/dev/b
@@ -399,7 +399,7 @@ trusted.name3=0xdeface
 
 *** set/get one initially empty attribute
 # file: SCRATCH_MNT/dev/c
-trusted.name
+trusted.name=""
 
 *** overwrite empty, set several new attributes
 *** fetch several attribute names and values (hex)
@@ -428,7 +428,7 @@ trusted.name3=0xdeface
 
 *** set an empty value for second attribute
 # file: SCRATCH_MNT/dev/c
-trusted.name2
+trusted.name2=""
 
 *** overwrite empty value
 # file: SCRATCH_MNT/dev/c
@@ -446,7 +446,7 @@ trusted.name3=0xdeface
 
 *** set/get one initially empty attribute
 # file: SCRATCH_MNT/dev/p
-trusted.name
+trusted.name=""
 
 *** overwrite empty, set several new attributes
 *** fetch several attribute names and values (hex)
@@ -475,7 +475,7 @@ trusted.name3=0xdeface
 
 *** set an empty value for second attribute
 # file: SCRATCH_MNT/dev/p
-trusted.name2
+trusted.name2=""
 
 *** overwrite empty value
 # file: SCRATCH_MNT/dev/p
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] xfstests: generic/062: Change output of empty attribute values
  2018-08-22  8:32 [PATCH] xfstests: generic/062: Change output of empty attribute values Su Yue
@ 2018-08-22 11:45 ` Eryu Guan
  2018-08-23  1:09   ` Su Yue
  2018-08-22 11:49 ` Filipe Manana
  2018-08-22 13:50 ` Theodore Y. Ts'o
  2 siblings, 1 reply; 7+ messages in thread
From: Eryu Guan @ 2018-08-22 11:45 UTC (permalink / raw)
  To: Su Yue; +Cc: fstests

On Wed, Aug 22, 2018 at 04:32:01PM +0800, Su Yue wrote:
> Since v2.4.47 of attr(5)[1], commit 0550d2bc989d (Properly
> set and report empty attribute values) changed output format of
> empty attribute value with quotes.
> 
> Here, change generic/062.out to match the actual output.
> 
> [1]: https://git.savannah.nongnu.org/git/attr.git
> 
> Signed-off-by: Su Yue <suy.fnst@cn.fujitsu.com>
> ---
>  tests/generic/062.out | 32 ++++++++++++++++----------------
>  1 file changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/tests/generic/062.out b/tests/generic/062.out
> index 8cc3c655..9b9cd744 100644
> --- a/tests/generic/062.out
> +++ b/tests/generic/062.out
> @@ -13,7 +13,7 @@ SCRATCH_MNT/reg
>  
>  *** set/get one initially empty attribute
>  # file: SCRATCH_MNT/reg
> -user.name
> +user.name=""

This breaks tests with old attr version, we should filter the output so
that both old and new attr could pass the test.

Please see the discussions in this thread.

https://patchwork.kernel.org/patch/10521875/

Thanks,
Eryu

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] xfstests: generic/062: Change output of empty attribute values
  2018-08-22  8:32 [PATCH] xfstests: generic/062: Change output of empty attribute values Su Yue
  2018-08-22 11:45 ` Eryu Guan
@ 2018-08-22 11:49 ` Filipe Manana
  2018-08-23  0:29   ` Su Yue
  2018-08-22 13:50 ` Theodore Y. Ts'o
  2 siblings, 1 reply; 7+ messages in thread
From: Filipe Manana @ 2018-08-22 11:49 UTC (permalink / raw)
  To: Su Yue; +Cc: fstests

On Wed, Aug 22, 2018 at 9:32 AM, Su Yue <suy.fnst@cn.fujitsu.com> wrote:
> Since v2.4.47 of attr(5)[1], commit 0550d2bc989d (Properly
> set and report empty attribute values) changed output format of
> empty attribute value with quotes.
>
> Here, change generic/062.out to match the actual output.

This will break the test on systems with older versions of the tool
(think enterprise distros for example).
The correct way to do this in fstests is to use filters (we have
numerous examples around).

>
> [1]: https://git.savannah.nongnu.org/git/attr.git
>
> Signed-off-by: Su Yue <suy.fnst@cn.fujitsu.com>
> ---
>  tests/generic/062.out | 32 ++++++++++++++++----------------
>  1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/tests/generic/062.out b/tests/generic/062.out
> index 8cc3c655..9b9cd744 100644
> --- a/tests/generic/062.out
> +++ b/tests/generic/062.out
> @@ -13,7 +13,7 @@ SCRATCH_MNT/reg
>
>  *** set/get one initially empty attribute
>  # file: SCRATCH_MNT/reg
> -user.name
> +user.name=""
>
>  *** overwrite empty, set several new attributes
>  *** fetch several attribute names and values (hex)
> @@ -42,7 +42,7 @@ user.name3=0xdeface
>
>  *** set an empty value for second attribute
>  # file: SCRATCH_MNT/reg
> -user.name2
> +user.name2=""
>
>  *** overwrite empty value
>  # file: SCRATCH_MNT/reg
> @@ -60,7 +60,7 @@ user.name3=0xdeface
>
>  *** set/get one initially empty attribute
>  # file: SCRATCH_MNT/dir
> -user.name
> +user.name=""
>
>  *** overwrite empty, set several new attributes
>  *** fetch several attribute names and values (hex)
> @@ -89,7 +89,7 @@ user.name3=0xdeface
>
>  *** set an empty value for second attribute
>  # file: SCRATCH_MNT/dir
> -user.name2
> +user.name2=""
>
>  *** overwrite empty value
>  # file: SCRATCH_MNT/dir
> @@ -207,7 +207,7 @@ SCRATCH_MNT/dev/p: user.name2: No such attribute or operation not permitted
>
>  *** set/get one initially empty attribute
>  # file: SCRATCH_MNT/reg
> -trusted.name
> +trusted.name=""
>
>  *** overwrite empty, set several new attributes
>  *** fetch several attribute names and values (hex)
> @@ -236,7 +236,7 @@ trusted.name3=0xdeface
>
>  *** set an empty value for second attribute
>  # file: SCRATCH_MNT/reg
> -trusted.name2
> +trusted.name2=""
>
>  *** overwrite empty value
>  # file: SCRATCH_MNT/reg
> @@ -256,7 +256,7 @@ user.name3=0xdeface
>
>  *** set/get one initially empty attribute
>  # file: SCRATCH_MNT/dir
> -trusted.name
> +trusted.name=""
>
>  *** overwrite empty, set several new attributes
>  *** fetch several attribute names and values (hex)
> @@ -285,7 +285,7 @@ trusted.name3=0xdeface
>
>  *** set an empty value for second attribute
>  # file: SCRATCH_MNT/dir
> -trusted.name2
> +trusted.name2=""
>
>  *** overwrite empty value
>  # file: SCRATCH_MNT/dir
> @@ -305,7 +305,7 @@ user.name3=0xdeface
>
>  *** set/get one initially empty attribute
>  # file: SCRATCH_MNT/lnk
> -trusted.name
> +trusted.name=""
>
>  *** overwrite empty, set several new attributes
>  *** fetch several attribute names and values (hex)
> @@ -334,7 +334,7 @@ trusted.name3=0xdeface
>
>  *** set an empty value for second attribute
>  # file: SCRATCH_MNT/lnk
> -trusted.name2
> +trusted.name2=""
>
>  *** overwrite empty value
>  # file: SCRATCH_MNT/lnk
> @@ -352,7 +352,7 @@ trusted.name3=0xdeface
>
>  *** set/get one initially empty attribute
>  # file: SCRATCH_MNT/dev/b
> -trusted.name
> +trusted.name=""
>
>  *** overwrite empty, set several new attributes
>  *** fetch several attribute names and values (hex)
> @@ -381,7 +381,7 @@ trusted.name3=0xdeface
>
>  *** set an empty value for second attribute
>  # file: SCRATCH_MNT/dev/b
> -trusted.name2
> +trusted.name2=""
>
>  *** overwrite empty value
>  # file: SCRATCH_MNT/dev/b
> @@ -399,7 +399,7 @@ trusted.name3=0xdeface
>
>  *** set/get one initially empty attribute
>  # file: SCRATCH_MNT/dev/c
> -trusted.name
> +trusted.name=""
>
>  *** overwrite empty, set several new attributes
>  *** fetch several attribute names and values (hex)
> @@ -428,7 +428,7 @@ trusted.name3=0xdeface
>
>  *** set an empty value for second attribute
>  # file: SCRATCH_MNT/dev/c
> -trusted.name2
> +trusted.name2=""
>
>  *** overwrite empty value
>  # file: SCRATCH_MNT/dev/c
> @@ -446,7 +446,7 @@ trusted.name3=0xdeface
>
>  *** set/get one initially empty attribute
>  # file: SCRATCH_MNT/dev/p
> -trusted.name
> +trusted.name=""
>
>  *** overwrite empty, set several new attributes
>  *** fetch several attribute names and values (hex)
> @@ -475,7 +475,7 @@ trusted.name3=0xdeface
>
>  *** set an empty value for second attribute
>  # file: SCRATCH_MNT/dev/p
> -trusted.name2
> +trusted.name2=""
>
>  *** overwrite empty value
>  # file: SCRATCH_MNT/dev/p
> --
> 2.18.0
>
>
>



-- 
Filipe David Manana,

“Whether you think you can, or you think you can't — you're right.”

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] xfstests: generic/062: Change output of empty attribute values
  2018-08-22  8:32 [PATCH] xfstests: generic/062: Change output of empty attribute values Su Yue
  2018-08-22 11:45 ` Eryu Guan
  2018-08-22 11:49 ` Filipe Manana
@ 2018-08-22 13:50 ` Theodore Y. Ts'o
  2018-08-23  0:48   ` Su Yue
  2 siblings, 1 reply; 7+ messages in thread
From: Theodore Y. Ts'o @ 2018-08-22 13:50 UTC (permalink / raw)
  To: Su Yue; +Cc: fstests

On Wed, Aug 22, 2018 at 04:32:01PM +0800, Su Yue wrote:
> Since v2.4.47 of attr(5)[1], commit 0550d2bc989d (Properly
> set and report empty attribute values) changed output format of
> empty attribute value with quotes.

I think you mean starting with version v2.4.48, right?  "Since
v2.4.47" can easily/commonly be interpreted as "Starting with
v2.4.47".

v2.4.47 was released in 2013, and the commit in question (0550d2bc)
dates from 2015.  v2.4.48 was released very recently, on August 17,
2018.

				- Ted

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] xfstests: generic/062: Change output of empty attribute values
  2018-08-22 11:49 ` Filipe Manana
@ 2018-08-23  0:29   ` Su Yue
  0 siblings, 0 replies; 7+ messages in thread
From: Su Yue @ 2018-08-23  0:29 UTC (permalink / raw)
  To: fdmanana; +Cc: fstests



On 08/22/2018 07:49 PM, Filipe Manana wrote:
> On Wed, Aug 22, 2018 at 9:32 AM, Su Yue <suy.fnst@cn.fujitsu.com> wrote:
>> Since v2.4.47 of attr(5)[1], commit 0550d2bc989d (Properly
>> set and report empty attribute values) changed output format of
>> empty attribute value with quotes.
>>
>> Here, change generic/062.out to match the actual output.
> 
> This will break the test on systems with older versions of the tool
> (think enterprise distros for example).
> The correct way to do this in fstests is to use filters (we have
> numerous examples around).
> 
Thanks, I will do it in V2.
>>
>> [1]: https://git.savannah.nongnu.org/git/attr.git
>>
>> Signed-off-by: Su Yue <suy.fnst@cn.fujitsu.com>
>> ---
>>   tests/generic/062.out | 32 ++++++++++++++++----------------
>>   1 file changed, 16 insertions(+), 16 deletions(-)
>>
>> diff --git a/tests/generic/062.out b/tests/generic/062.out
>> index 8cc3c655..9b9cd744 100644
>> --- a/tests/generic/062.out
>> +++ b/tests/generic/062.out
>> @@ -13,7 +13,7 @@ SCRATCH_MNT/reg
>>
>>   *** set/get one initially empty attribute
>>   # file: SCRATCH_MNT/reg
>> -user.name
>> +user.name=""
>>
>>   *** overwrite empty, set several new attributes
>>   *** fetch several attribute names and values (hex)
>> @@ -42,7 +42,7 @@ user.name3=0xdeface
>>
>>   *** set an empty value for second attribute
>>   # file: SCRATCH_MNT/reg
>> -user.name2
>> +user.name2=""
>>
>>   *** overwrite empty value
>>   # file: SCRATCH_MNT/reg
>> @@ -60,7 +60,7 @@ user.name3=0xdeface
>>
>>   *** set/get one initially empty attribute
>>   # file: SCRATCH_MNT/dir
>> -user.name
>> +user.name=""
>>
>>   *** overwrite empty, set several new attributes
>>   *** fetch several attribute names and values (hex)
>> @@ -89,7 +89,7 @@ user.name3=0xdeface
>>
>>   *** set an empty value for second attribute
>>   # file: SCRATCH_MNT/dir
>> -user.name2
>> +user.name2=""
>>
>>   *** overwrite empty value
>>   # file: SCRATCH_MNT/dir
>> @@ -207,7 +207,7 @@ SCRATCH_MNT/dev/p: user.name2: No such attribute or operation not permitted
>>
>>   *** set/get one initially empty attribute
>>   # file: SCRATCH_MNT/reg
>> -trusted.name
>> +trusted.name=""
>>
>>   *** overwrite empty, set several new attributes
>>   *** fetch several attribute names and values (hex)
>> @@ -236,7 +236,7 @@ trusted.name3=0xdeface
>>
>>   *** set an empty value for second attribute
>>   # file: SCRATCH_MNT/reg
>> -trusted.name2
>> +trusted.name2=""
>>
>>   *** overwrite empty value
>>   # file: SCRATCH_MNT/reg
>> @@ -256,7 +256,7 @@ user.name3=0xdeface
>>
>>   *** set/get one initially empty attribute
>>   # file: SCRATCH_MNT/dir
>> -trusted.name
>> +trusted.name=""
>>
>>   *** overwrite empty, set several new attributes
>>   *** fetch several attribute names and values (hex)
>> @@ -285,7 +285,7 @@ trusted.name3=0xdeface
>>
>>   *** set an empty value for second attribute
>>   # file: SCRATCH_MNT/dir
>> -trusted.name2
>> +trusted.name2=""
>>
>>   *** overwrite empty value
>>   # file: SCRATCH_MNT/dir
>> @@ -305,7 +305,7 @@ user.name3=0xdeface
>>
>>   *** set/get one initially empty attribute
>>   # file: SCRATCH_MNT/lnk
>> -trusted.name
>> +trusted.name=""
>>
>>   *** overwrite empty, set several new attributes
>>   *** fetch several attribute names and values (hex)
>> @@ -334,7 +334,7 @@ trusted.name3=0xdeface
>>
>>   *** set an empty value for second attribute
>>   # file: SCRATCH_MNT/lnk
>> -trusted.name2
>> +trusted.name2=""
>>
>>   *** overwrite empty value
>>   # file: SCRATCH_MNT/lnk
>> @@ -352,7 +352,7 @@ trusted.name3=0xdeface
>>
>>   *** set/get one initially empty attribute
>>   # file: SCRATCH_MNT/dev/b
>> -trusted.name
>> +trusted.name=""
>>
>>   *** overwrite empty, set several new attributes
>>   *** fetch several attribute names and values (hex)
>> @@ -381,7 +381,7 @@ trusted.name3=0xdeface
>>
>>   *** set an empty value for second attribute
>>   # file: SCRATCH_MNT/dev/b
>> -trusted.name2
>> +trusted.name2=""
>>
>>   *** overwrite empty value
>>   # file: SCRATCH_MNT/dev/b
>> @@ -399,7 +399,7 @@ trusted.name3=0xdeface
>>
>>   *** set/get one initially empty attribute
>>   # file: SCRATCH_MNT/dev/c
>> -trusted.name
>> +trusted.name=""
>>
>>   *** overwrite empty, set several new attributes
>>   *** fetch several attribute names and values (hex)
>> @@ -428,7 +428,7 @@ trusted.name3=0xdeface
>>
>>   *** set an empty value for second attribute
>>   # file: SCRATCH_MNT/dev/c
>> -trusted.name2
>> +trusted.name2=""
>>
>>   *** overwrite empty value
>>   # file: SCRATCH_MNT/dev/c
>> @@ -446,7 +446,7 @@ trusted.name3=0xdeface
>>
>>   *** set/get one initially empty attribute
>>   # file: SCRATCH_MNT/dev/p
>> -trusted.name
>> +trusted.name=""
>>
>>   *** overwrite empty, set several new attributes
>>   *** fetch several attribute names and values (hex)
>> @@ -475,7 +475,7 @@ trusted.name3=0xdeface
>>
>>   *** set an empty value for second attribute
>>   # file: SCRATCH_MNT/dev/p
>> -trusted.name2
>> +trusted.name2=""
>>
>>   *** overwrite empty value
>>   # file: SCRATCH_MNT/dev/p
>> --
>> 2.18.0
>>
>>
>>
> 
> 
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] xfstests: generic/062: Change output of empty attribute values
  2018-08-22 13:50 ` Theodore Y. Ts'o
@ 2018-08-23  0:48   ` Su Yue
  0 siblings, 0 replies; 7+ messages in thread
From: Su Yue @ 2018-08-23  0:48 UTC (permalink / raw)
  To: Theodore Y. Ts'o; +Cc: fstests



On 08/22/2018 09:50 PM, Theodore Y. Ts'o wrote:
> On Wed, Aug 22, 2018 at 04:32:01PM +0800, Su Yue wrote:
>> Since v2.4.47 of attr(5)[1], commit 0550d2bc989d (Properly
>> set and report empty attribute values) changed output format of
>> empty attribute value with quotes.
> 
> I think you mean starting with version v2.4.48, right?  "Since
> v2.4.47" can easily/commonly be interpreted as "Starting with
> v2.4.47".
> 
Yes, recent v2.4.48 contains the change.
Thanks.

Su

> v2.4.47 was released in 2013, and the commit in question (0550d2bc)
> dates from 2015.  v2.4.48 was released very recently, on August 17,
> 2018.
> 
> 				- Ted
> 
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] xfstests: generic/062: Change output of empty attribute values
  2018-08-22 11:45 ` Eryu Guan
@ 2018-08-23  1:09   ` Su Yue
  0 siblings, 0 replies; 7+ messages in thread
From: Su Yue @ 2018-08-23  1:09 UTC (permalink / raw)
  To: Eryu Guan; +Cc: fstests, zlang

[CC to zlang@redhat.com to remind]

On 08/22/2018 07:45 PM, Eryu Guan wrote:
> On Wed, Aug 22, 2018 at 04:32:01PM +0800, Su Yue wrote:
>> Since v2.4.47 of attr(5)[1], commit 0550d2bc989d (Properly
>> set and report empty attribute values) changed output format of
>> empty attribute value with quotes.
>>
>> Here, change generic/062.out to match the actual output.
>>
>> [1]: https://git.savannah.nongnu.org/git/attr.git
>>
>> Signed-off-by: Su Yue <suy.fnst@cn.fujitsu.com>
>> ---
>>   tests/generic/062.out | 32 ++++++++++++++++----------------
>>   1 file changed, 16 insertions(+), 16 deletions(-)
>>
>> diff --git a/tests/generic/062.out b/tests/generic/062.out
>> index 8cc3c655..9b9cd744 100644
>> --- a/tests/generic/062.out
>> +++ b/tests/generic/062.out
>> @@ -13,7 +13,7 @@ SCRATCH_MNT/reg
>>   
>>   *** set/get one initially empty attribute
>>   # file: SCRATCH_MNT/reg
>> -user.name
>> +user.name=""
> 
> This breaks tests with old attr version, we should filter the output so
> that both old and new attr could pass the test.
> 
Understood.

> Please see the discussions in this thread.
> 
> https://patchwork.kernel.org/patch/10521875/
> 
Hmmm, I didn't subscribe the fstests ML before.
Maybe I should search releated info next time :).

Since Zorro had a good solution in the discussion already, it
should belong to him.

Thanks,
Su

> Thanks,
> Eryu
> 
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-08-23  4:29 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-22  8:32 [PATCH] xfstests: generic/062: Change output of empty attribute values Su Yue
2018-08-22 11:45 ` Eryu Guan
2018-08-23  1:09   ` Su Yue
2018-08-22 11:49 ` Filipe Manana
2018-08-23  0:29   ` Su Yue
2018-08-22 13:50 ` Theodore Y. Ts'o
2018-08-23  0:48   ` Su Yue

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.