From: "hch@lst.de" <hch@lst.de>
To: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Cc: Vineet Gupta <Vineet.Gupta1@synopsys.com>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>, "hch@lst.de" <hch@lst.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"Alexey.Brodkin@synopsys.com" <Alexey.Brodkin@synopsys.com>
Subject: Re: [PATCH v2 2/4] ARC: allow to use IOC and non-IOC DMA devices simultaneously
Date: Thu, 23 Aug 2018 16:05:25 +0200 [thread overview]
Message-ID: <20180823140525.GA26121@lst.de> (raw)
In-Reply-To: <1534963226.3962.215.camel@synopsys.com>
Btw, given that I assume this is 4.20 material now, any chance we
could merge it through the dma-mapping tree? I have some major changes
pending that would clash if done in a different tree, so I'd rather
get it all together.
> We check this flag in arch_dma_alloc (which are used in non-coherent case) to
> skip MMU mapping if we are advertised that consistency is not required.
>
> So, actually we can get rid of this flag checking in arch_dma_alloc and
> simply always do MMU mapping to enforce non-cachability and return
> non-cacheable memory even if DMA_ATTR_NON_CONSISTENT is passed.
> But I don't sure we want to do that.
I plan to kill this flag for 4.20 (or 4.20 at latest) in favor
of a better interface. But your implementation looks ok, so I'm
fine with keeping it for now.
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (hch@lst.de)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH v2 2/4] ARC: allow to use IOC and non-IOC DMA devices simultaneously
Date: Thu, 23 Aug 2018 16:05:25 +0200 [thread overview]
Message-ID: <20180823140525.GA26121@lst.de> (raw)
In-Reply-To: <1534963226.3962.215.camel@synopsys.com>
Btw, given that I assume this is 4.20 material now, any chance we
could merge it through the dma-mapping tree? I have some major changes
pending that would clash if done in a different tree, so I'd rather
get it all together.
> We check this flag in arch_dma_alloc (which are used in non-coherent case) to
> skip MMU mapping if we are advertised that consistency is not required.
>
> So, actually we can get rid of this flag checking in arch_dma_alloc and
> simply always do MMU mapping to enforce non-cachability and return
> non-cacheable memory even if DMA_ATTR_NON_CONSISTENT is passed.
> But I don't sure we want to do that.
I plan to kill this flag for 4.20 (or 4.20 at latest) in favor
of a better interface. But your implementation looks ok, so I'm
fine with keeping it for now.
next prev parent reply other threads:[~2018-08-23 14:03 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 16:26 [PATCH v2 0/4] ARC: allow to use IOC and non-IOC DMA devices simultaneously Eugeniy Paltsev
2018-07-30 16:26 ` Eugeniy Paltsev
2018-07-30 16:26 ` [PATCH v2 1/4] ARC: DTS: mark DMA devices connected through IOC port as dma-coherent Eugeniy Paltsev
2018-07-30 16:26 ` Eugeniy Paltsev
2018-07-30 16:26 ` [PATCH v2 2/4] ARC: allow to use IOC and non-IOC DMA devices simultaneously Eugeniy Paltsev
2018-07-30 16:26 ` Eugeniy Paltsev
2018-08-13 16:24 ` Vineet Gupta
2018-08-13 16:24 ` Vineet Gupta
2018-08-13 16:24 ` Vineet Gupta
2018-08-13 17:08 ` Eugeniy Paltsev
2018-08-13 17:08 ` Eugeniy Paltsev
2018-08-13 17:08 ` Eugeniy Paltsev
2018-08-20 22:34 ` Vineet Gupta
2018-08-20 22:34 ` Vineet Gupta
2018-08-20 22:34 ` Vineet Gupta
2018-08-22 18:40 ` Eugeniy Paltsev
2018-08-22 18:40 ` Eugeniy Paltsev
2018-08-22 18:40 ` Eugeniy Paltsev
2018-08-23 14:05 ` hch [this message]
2018-08-23 14:05 ` hch
2018-08-23 14:05 ` hch
2018-09-04 18:13 ` Vineet Gupta
2018-09-04 18:13 ` Vineet Gupta
2018-09-04 18:13 ` Vineet Gupta
2018-07-30 16:26 ` [PATCH v2 3/4] ARC: IOC: panic if both IOC and ZONE_HIGHMEM enabled Eugeniy Paltsev
2018-07-30 16:26 ` Eugeniy Paltsev
2018-07-30 16:26 ` [PATCH v2 4/4] ARC: don't check for HIGHMEM pages in arch_dma_alloc Eugeniy Paltsev
2018-07-30 16:26 ` Eugeniy Paltsev
2018-07-31 8:08 ` Christoph Hellwig
2018-07-31 8:08 ` Christoph Hellwig
2018-08-13 16:19 ` [PATCH v2 0/4] ARC: allow to use IOC and non-IOC DMA devices simultaneously Vineet Gupta
2018-08-13 16:19 ` Vineet Gupta
2018-08-13 16:19 ` Vineet Gupta
2018-08-13 17:27 ` Eugeniy Paltsev
2018-08-13 17:27 ` Eugeniy Paltsev
2018-08-13 17:27 ` Eugeniy Paltsev
2018-08-13 17:39 ` Vineet Gupta
2018-08-13 17:39 ` Vineet Gupta
2018-08-13 17:39 ` Vineet Gupta
2018-09-04 20:14 ` Vineet Gupta
2018-09-04 20:14 ` Vineet Gupta
2018-09-04 20:14 ` Vineet Gupta
2018-09-04 21:11 ` Christoph Hellwig
2018-09-04 21:11 ` Christoph Hellwig
2018-09-04 21:34 ` Vineet Gupta
2018-09-04 21:34 ` Vineet Gupta
2018-09-04 21:34 ` Vineet Gupta
2018-09-04 21:38 ` Christoph Hellwig
2018-09-04 21:38 ` Christoph Hellwig
2018-09-04 21:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180823140525.GA26121@lst.de \
--to=hch@lst.de \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.