* [PATCH] Input: synaptics - Lenovo ThinkPad T25 and T480 devices should use RMI
@ 2018-07-07 5:19 ` kitsunyan
0 siblings, 0 replies; 5+ messages in thread
From: kitsunyan @ 2018-07-07 5:19 UTC (permalink / raw)
Cc: kitsunyan, Dmitry Torokhov, Benjamin Tissoires, linux-input,
linux-kernel
The touchpads on both T25 and T480 are accessible over SMBUS/RMI.
Signed-off-by: kitsunyan <kitsunyan@inbox.ru>
---
drivers/input/mouse/synaptics.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 55d33500d55e..be934a082424 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -175,7 +175,9 @@ static const char * const smbus_pnp_ids[] = {
"LEN0071", /* T480 */
"LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */
"LEN0073", /* X1 Carbon G5 (Elantech) */
+ "LEN008e", /* T25 */
"LEN0092", /* X1 Carbon 6 */
+ "LEN0093", /* T480 */
"LEN0096", /* X280 */
"LEN0097", /* X280 -> ALPS trackpoint */
"LEN200f", /* T450s */
--
2.18.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Input: synaptics - Lenovo ThinkPad T25 and T480 devices should use RMI
2018-07-07 5:19 ` kitsunyan
(?)
@ 2018-07-14 6:35 ` Teika Kazura
2018-07-14 13:20 ` kitsunyan
-1 siblings, 1 reply; 5+ messages in thread
From: Teika Kazura @ 2018-07-14 6:35 UTC (permalink / raw)
To: kitsunyan; +Cc: dmitry.torokhov, benjamin.tissoires, linux-input, linux-kernel
Hi, kitsunyan. (Привет, perhaps?) Thanks for you patch, but the "signed-off" tag needs your real name. You can re-submit your patch conforming to that rule. Or if you're ok, the kernel maintainer can instead sign it off, adding "reported-by: kitsunyan <kitsunyan@inbox.ru>". (I'm not sure about the latter case. Sorry if I'm wrong.)
You can find the instruction in <kernell source tree>/Documentation/process/submitting-patches.rst .
Best regards / Пока,
Teika (Teika kazura)
From: kitsunyan <kitsunyan@inbox.ru>
Subject: [PATCH] Input: synaptics - Lenovo ThinkPad T25 and T480 devices should use RMI
Date: Sat, 7 Jul 2018 08:19:12 +0300
> The touchpads on both T25 and T480 are accessible over SMBUS/RMI.
>
> Signed-off-by: kitsunyan <kitsunyan@inbox.ru>
> ---
> drivers/input/mouse/synaptics.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
> index 55d33500d55e..be934a082424 100644
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -175,7 +175,9 @@ static const char * const smbus_pnp_ids[] = {
> "LEN0071", /* T480 */
> "LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */
> "LEN0073", /* X1 Carbon G5 (Elantech) */
> + "LEN008e", /* T25 */
> "LEN0092", /* X1 Carbon 6 */
> + "LEN0093", /* T480 */
> "LEN0096", /* X280 */
> "LEN0097", /* X280 -> ALPS trackpoint */
> "LEN200f", /* T450s */
> --
> 2.18.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Input: synaptics - Lenovo ThinkPad T25 and T480 devices should use RMI
2018-07-14 6:35 ` Teika Kazura
@ 2018-07-14 13:20 ` kitsunyan
0 siblings, 0 replies; 5+ messages in thread
From: kitsunyan @ 2018-07-14 13:20 UTC (permalink / raw)
To: Teika Kazura
Cc: dmitry.torokhov, benjamin.tissoires, linux-input, linux-kernel
Hi, Teika. (Yes, you are right.)
I should've worried about real name earlier since I already sent the patch from pseudonym. I don't mind if the patch will be authored by maintainer, replacing my sign with "reported-by". (Hope it's possible.)
Regards,
kitsunyan
On 14/07/18 09:35, Teika Kazura wrote:
> Hi, kitsunyan. (Привет, perhaps?) Thanks for you patch, but the "signed-off" tag needs your real name. You can re-submit your patch conforming to that rule. Or if you're ok, the kernel maintainer can instead sign it off, adding "reported-by: kitsunyan <kitsunyan@inbox.ru>". (I'm not sure about the latter case. Sorry if I'm wrong.)
>
> You can find the instruction in <kernell source tree>/Documentation/process/submitting-patches.rst .
>
> Best regards / Пока,
> Teika (Teika kazura)
>
>
> From: kitsunyan <kitsunyan@inbox.ru>
> Subject: [PATCH] Input: synaptics - Lenovo ThinkPad T25 and T480 devices should use RMI
> Date: Sat, 7 Jul 2018 08:19:12 +0300
>
>> The touchpads on both T25 and T480 are accessible over SMBUS/RMI.
>>
>> Signed-off-by: kitsunyan <kitsunyan@inbox.ru>
>> ---
>> drivers/input/mouse/synaptics.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
>> index 55d33500d55e..be934a082424 100644
>> --- a/drivers/input/mouse/synaptics.c
>> +++ b/drivers/input/mouse/synaptics.c
>> @@ -175,7 +175,9 @@ static const char * const smbus_pnp_ids[] = {
>> "LEN0071", /* T480 */
>> "LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */
>> "LEN0073", /* X1 Carbon G5 (Elantech) */
>> + "LEN008e", /* T25 */
>> "LEN0092", /* X1 Carbon 6 */
>> + "LEN0093", /* T480 */
>> "LEN0096", /* X280 */
>> "LEN0097", /* X280 -> ALPS trackpoint */
>> "LEN200f", /* T450s */
>> --
>> 2.18.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] Input: synaptics - Lenovo ThinkPad T25 and T480 devices should use RMI
2018-07-07 5:19 ` kitsunyan
(?)
(?)
@ 2018-08-24 5:07 ` Teika Kazura
-1 siblings, 0 replies; 5+ messages in thread
From: Teika Kazura @ 2018-08-24 5:07 UTC (permalink / raw)
To: dmitry.torokhov, linux-input, linux-kernel; +Cc: kitsunyan, benjamin.tissoires
The touchpads on both T25 and T480 are accessible over SMBUS/RMI.
---
v2
Only a tag change.
The original author wants to use a pseudonym, and agrees with the usurpation of the signed-off-by tag. See https://patchwork.kernel.org/patch/10512751/
Reported-by: kitsunyan <kitsunyan@inbox.ru>
Signed-off-by: Teika Kazura <teika@gmx.com>
---
drivers/input/mouse/synaptics.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 55d33500d55e..be934a082424 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -175,7 +175,9 @@ static const char * const smbus_pnp_ids[] = {
"LEN0071", /* T480 */
"LEN0072", /* X1 Carbon Gen 5 (2017) - Elan/ALPS trackpoint */
"LEN0073", /* X1 Carbon G5 (Elantech) */
+ "LEN008e", /* T25 */
"LEN0092", /* X1 Carbon 6 */
+ "LEN0093", /* T480 */
"LEN0096", /* X280 */
"LEN0097", /* X280 -> ALPS trackpoint */
"LEN200f", /* T450s */
--
2.18.0
^ permalink raw reply related [flat|nested] 5+ messages in thread