From: Emmanuel Vadot <manu@bidouilliste.com> To: Mark Kettenis <mark.kettenis@xs4all.nl> Cc: Emmanuel Vadot <manu@freebsd.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/7] dt-bindings: Add DT bindings documentation for Allwinner Thermal Sensor Controller Date: Sat, 25 Aug 2018 17:42:48 +0200 [thread overview] Message-ID: <20180825174248.c76565fe20a3457e3c766d1a@bidouilliste.com> (raw) In-Reply-To: <66249ae2a698cdc7@bloch.sibelius.xs4all.nl> Hi Mark, On Sat, 25 Aug 2018 13:07:40 +0200 (CEST) Mark Kettenis <mark.kettenis@xs4all.nl> wrote: > Hi Emmanuel, > > I think the following bit in your proposed binding is wrong: > > +- #thermal-sensor-cells : Depend on the SoC > + For H3 should be 0 > + For H5 should be 1 > + For A64 should be 2 > + See ./thermal.txt for a description. > > I think what you're trying to say here is that H3 has a single sensor > and that H5 and A64 have more sensors. But even though the number of > sensors is different for H5 and A64 (two for H3, three for A64) you > need only a single cell to describe which sensor to read. So > #thermal-sensors-cells should be 1 for both H5 and A64. You might be right, this part wasn't really clear for me reading the thermal binding docs. Can someone double-confirm that ? > As far as I can see this proposed binding is compatible with the > OpenBSD's sxitemp(4) driver. Go to know. > That driver also supports the R40 with > "allwinner,sun8i-r40-ths" as the compatible string. The R40 has two > sensors so #thermal-sensor-cells should be 1 for this SoC as well. I don't have R40 board, I guess the best thing will be for you to send a patch to update the binding docs and dts when this serie will be merged/acked. > Cheers, > > Mark Cheers, -- Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
WARNING: multiple messages have this Message-ID (diff)
From: manu@bidouilliste.com (Emmanuel Vadot) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/7] dt-bindings: Add DT bindings documentation for Allwinner Thermal Sensor Controller Date: Sat, 25 Aug 2018 17:42:48 +0200 [thread overview] Message-ID: <20180825174248.c76565fe20a3457e3c766d1a@bidouilliste.com> (raw) In-Reply-To: <66249ae2a698cdc7@bloch.sibelius.xs4all.nl> Hi Mark, On Sat, 25 Aug 2018 13:07:40 +0200 (CEST) Mark Kettenis <mark.kettenis@xs4all.nl> wrote: > Hi Emmanuel, > > I think the following bit in your proposed binding is wrong: > > +- #thermal-sensor-cells : Depend on the SoC > + For H3 should be 0 > + For H5 should be 1 > + For A64 should be 2 > + See ./thermal.txt for a description. > > I think what you're trying to say here is that H3 has a single sensor > and that H5 and A64 have more sensors. But even though the number of > sensors is different for H5 and A64 (two for H3, three for A64) you > need only a single cell to describe which sensor to read. So > #thermal-sensors-cells should be 1 for both H5 and A64. You might be right, this part wasn't really clear for me reading the thermal binding docs. Can someone double-confirm that ? > As far as I can see this proposed binding is compatible with the > OpenBSD's sxitemp(4) driver. Go to know. > That driver also supports the R40 with > "allwinner,sun8i-r40-ths" as the compatible string. The R40 has two > sensors so #thermal-sensor-cells should be 1 for this SoC as well. I don't have R40 board, I guess the best thing will be for you to send a patch to update the binding docs and dts when this serie will be merged/acked. > Cheers, > > Mark Cheers, -- Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
next prev parent reply other threads:[~2018-08-25 15:42 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-25 11:07 [PATCH 1/7] dt-bindings: Add DT bindings documentation for Allwinner Thermal Sensor Controller Mark Kettenis 2018-08-25 15:42 ` Emmanuel Vadot [this message] 2018-08-25 15:42 ` Emmanuel Vadot 2018-08-25 15:49 ` Emmanuel Vadot 2018-08-25 15:49 ` Emmanuel Vadot -- strict thread matches above, loose matches on Subject: below -- 2018-08-04 7:03 Emmanuel Vadot 2018-08-04 7:03 ` Emmanuel Vadot 2018-08-14 19:20 ` Rob Herring 2018-08-14 19:20 ` Rob Herring 2018-08-20 11:17 ` Maxime Ripard 2018-08-20 11:17 ` Maxime Ripard 2018-08-20 13:41 ` Rob Herring 2018-08-20 13:41 ` Rob Herring 2018-08-20 13:41 ` Rob Herring 2018-08-20 13:57 ` Emmanuel Vadot 2018-08-20 13:57 ` Emmanuel Vadot 2018-08-20 13:57 ` Emmanuel Vadot 2018-08-20 14:07 ` Maxime Ripard 2018-08-20 14:07 ` Maxime Ripard 2018-08-20 14:07 ` Maxime Ripard 2018-08-20 14:27 ` Emmanuel Vadot 2018-08-20 14:27 ` Emmanuel Vadot 2018-08-20 14:27 ` Emmanuel Vadot 2018-08-24 14:58 ` Maxime Ripard 2018-08-24 14:58 ` Maxime Ripard 2018-08-24 14:58 ` Maxime Ripard 2018-08-24 19:59 ` Emmanuel Vadot 2018-08-24 19:59 ` Emmanuel Vadot 2018-08-24 19:59 ` Emmanuel Vadot 2018-08-24 23:03 ` Eduardo Valentin 2018-08-24 23:03 ` Eduardo Valentin 2018-08-24 23:03 ` Eduardo Valentin 2018-08-25 15:43 ` Emmanuel Vadot 2018-08-25 15:43 ` Emmanuel Vadot 2018-08-25 15:43 ` Emmanuel Vadot 2018-08-29 12:38 ` Maxime Ripard 2018-08-29 12:38 ` Maxime Ripard 2018-08-29 12:38 ` Maxime Ripard 2018-08-29 13:31 ` Maxime Ripard 2018-08-29 13:31 ` Maxime Ripard 2018-08-29 13:31 ` Maxime Ripard 2018-08-20 18:47 ` Rob Herring 2018-08-20 18:47 ` Rob Herring 2018-08-20 18:47 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180825174248.c76565fe20a3457e3c766d1a@bidouilliste.com \ --to=manu@bidouilliste.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=manu@freebsd.org \ --cc=mark.kettenis@xs4all.nl \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.