* [Buildroot] [PATCH/next 1/1] package/vlc: also use AC_PATH_PROG to check for wayland-scanner
@ 2018-08-26 11:04 Bernd Kuhls
2018-09-06 19:40 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Bernd Kuhls @ 2018-08-26 11:04 UTC (permalink / raw)
To: buildroot
Fixes
http://autobuild.buildroot.net/results/a6b/a6b5e5677efc2b46af85837637f2832eefdfed1d/
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
...o-use-AC_PATH_PROG-to-check-for-wayl.patch | 50 +++++++++++++++++++
1 file changed, 50 insertions(+)
create mode 100644 package/vlc/0011-configure.ac-also-use-AC_PATH_PROG-to-check-for-wayl.patch
diff --git a/package/vlc/0011-configure.ac-also-use-AC_PATH_PROG-to-check-for-wayl.patch b/package/vlc/0011-configure.ac-also-use-AC_PATH_PROG-to-check-for-wayl.patch
new file mode 100644
index 0000000000..2b74fe0d39
--- /dev/null
+++ b/package/vlc/0011-configure.ac-also-use-AC_PATH_PROG-to-check-for-wayl.patch
@@ -0,0 +1,50 @@
+From 27635f902831fac898586f1f3dc98369f12582c9 Mon Sep 17 00:00:00 2001
+From: Bernd Kuhls <bernd.kuhls@t-online.de>
+Date: Sun, 26 Aug 2018 12:51:04 +0200
+Subject: [PATCH] configure.ac: also use AC_PATH_PROG to check for
+ wayland-scanner
+
+When cross-compiling the .pc file might point to the wrong
+wayland-scanner binary (target rather than host) resulting in a
+non-executable and wrong scanner.
+Try searching the PATH first, and if that fails fall back into
+pkg-config.
+
+Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
+---
+ configure.ac | 19 +++++++++++--------
+ 1 file changed, 11 insertions(+), 8 deletions(-)
+
+diff --git a/configure.ac b/configure.ac
+index 4808b8becf..a18641ed23 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -3140,14 +3140,17 @@ AS_IF([test "${enable_wayland}" != "no"], [
+ AC_MSG_ERROR([$(${PKG_CONFIG} --print-errors 'wayland-protocols >= 1.4')])
+ ])
+
+- AC_MSG_CHECKING([for the Wayland scanner])
+- PKG_CHECK_EXISTS([wayland-scanner], [
+- WAYLAND_SCANNER="$(${PKG_CONFIG} wayland-scanner --variable wayland_scanner)"
+- AC_MSG_RESULT([${WAYLAND_SCANNER}])
+- ], [
+- AC_MSG_RESULT([not found])
+- AC_MSG_ERROR([$(${PKG_CONFIG} --print-errors wayland-scanner)])
+- ])
++ AC_PATH_PROG([WAYLAND_SCANNER], [wayland-scanner])
++ if test "x$WAYLAND_SCANNER" = x; then
++ AC_MSG_CHECKING([for the Wayland scanner])
++ PKG_CHECK_EXISTS([wayland-scanner], [
++ WAYLAND_SCANNER="$(${PKG_CONFIG} wayland-scanner --variable wayland_scanner)"
++ AC_MSG_RESULT([${WAYLAND_SCANNER}])
++ ], [
++ AC_MSG_RESULT([not found])
++ AC_MSG_ERROR([$(${PKG_CONFIG} --print-errors wayland-scanner)])
++ ])
++ fi
+
+ have_wayland="yes"
+
+--
+2.18.0
+
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH/next 1/1] package/vlc: also use AC_PATH_PROG to check for wayland-scanner
2018-08-26 11:04 [Buildroot] [PATCH/next 1/1] package/vlc: also use AC_PATH_PROG to check for wayland-scanner Bernd Kuhls
@ 2018-09-06 19:40 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2018-09-06 19:40 UTC (permalink / raw)
To: buildroot
Hello,
On Sun, 26 Aug 2018 13:04:52 +0200, Bernd Kuhls wrote:
> Fixes
> http://autobuild.buildroot.net/results/a6b/a6b5e5677efc2b46af85837637f2832eefdfed1d/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> ...o-use-AC_PATH_PROG-to-check-for-wayl.patch | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 package/vlc/0011-configure.ac-also-use-AC_PATH_PROG-to-check-for-wayl.patch
Applied to next, thanks. Please don't forget to submit the patch
upstream. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-06 19:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-26 11:04 [Buildroot] [PATCH/next 1/1] package/vlc: also use AC_PATH_PROG to check for wayland-scanner Bernd Kuhls
2018-09-06 19:40 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.