From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] json-c: needs host-autoconf
Date: Tue, 28 Aug 2018 21:35:57 +0200 [thread overview]
Message-ID: <20180828213557.069e855e@windsurf.home> (raw)
In-Reply-To: <49134bd0971955402d38a456443d4fb8dba45957.1535468087.git.baruch@tkos.co.il>
Hello,
On Tue, 28 Aug 2018 17:54:47 +0300, Baruch Siach wrote:
> The json-c configure script uses the autoheader utility. Use the
> host-autoconf provided autoheader, as this tool is not always installed
> on the host.
>
> Fixes:
> http://autobuild.buildroot.net/results/030/030fddceda4f5bc6379f7bfcc405e92d2e24184a/
> http://autobuild.buildroot.net/results/e48/e482f174b8124ace0690a26bb7daf073fe5fcd75/
> http://autobuild.buildroot.net/results/482/4829425c38c58d9844aa07108532a93d47191d23/
>
> Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/json-c/json-c.mk | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/package/json-c/json-c.mk b/package/json-c/json-c.mk
> index 57d8c35dd5e3..bee57577ceec 100644
> --- a/package/json-c/json-c.mk
> +++ b/package/json-c/json-c.mk
> @@ -10,5 +10,9 @@ JSON_C_INSTALL_STAGING = YES
> JSON_C_LICENSE = MIT
> JSON_C_LICENSE_FILES = COPYING
>
> +# configure requires autoheader
> +JSON_C_DEPENDENCIES = host-autoconf
> +HOST_JSON_C_DEPENDENCIES = host-autoconf
Wait, wait, why is this needed? This is a standard autotools package,
it shouldn't need autoheader at build time.
Isn't it that there is a bogus timestamp or something like that forces
some files to be re-generated ?
This problem only appears on Joseph's machine:
http://autobuild.buildroot.net/?reason=json-glib%.
It doesn't happen on my autobuilder, even though it doesn't have
autoheader installed system-wide.
So I'm skeptical about this fix.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-08-28 19:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 14:54 [Buildroot] [PATCH] json-c: needs host-autoconf Baruch Siach
2018-08-28 15:12 ` Peter Korsgaard
2018-08-28 19:35 ` Thomas Petazzoni [this message]
2018-08-28 19:37 ` Thomas Petazzoni
2018-08-29 4:10 ` Baruch Siach
2018-08-29 6:59 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180828213557.069e855e@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.