All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] json-c: needs host-autoconf
Date: Wed, 29 Aug 2018 07:10:38 +0300	[thread overview]
Message-ID: <87ftyxyfr5.fsf@tkos.co.il> (raw)
In-Reply-To: <20180828213742.12bef8e7@windsurf.home>

Hi Thomas,

Thomas Petazzoni writes:
> On Tue, 28 Aug 2018 21:35:57 +0200, Thomas Petazzoni wrote:
>> Wait, wait, why is this needed? This is a standard autotools package,
>> it shouldn't need autoheader at build time.
>> 
>> Isn't it that there is a bogus timestamp or something like that forces
>> some files to be re-generated ?
>> 
>> This problem only appears on Joseph's machine:
>> http://autobuild.buildroot.net/?reason=json-glib%.
>> 
>> It doesn't happen on my autobuilder, even though it doesn't have
>> autoheader installed system-wide.
>
> Sorry, I messed up here: the package being fixed is json-c, not
> json-glib. So the build failure does occur on several autobuilders:
> http://autobuild.buildroot.net/?reason=json-c%.
>
> However, I would still like to see an explanation of why autoheader is
> needed in an autotools package. It should not be needed.

You are right. Updating the config.h.in timestamp is enough to avoid
autoheader. I sent an updated patch.

Thanks for noting.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  reply	other threads:[~2018-08-29  4:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-28 14:54 [Buildroot] [PATCH] json-c: needs host-autoconf Baruch Siach
2018-08-28 15:12 ` Peter Korsgaard
2018-08-28 19:35 ` Thomas Petazzoni
2018-08-28 19:37   ` Thomas Petazzoni
2018-08-29  4:10     ` Baruch Siach [this message]
2018-08-29  6:59       ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftyxyfr5.fsf@tkos.co.il \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.