From: Andrew Morton <akpm@linux-foundation.org>
To: linux-security-module@vger.kernel.org
Subject: Re: [PATCH resend] uapi/linux/keyctl.h: don't use C++ reserved keyword as a struct member name
Date: Wed, 29 Aug 2018 22:56:48 +0000 [thread overview]
Message-ID: <20180829155648.e4ec141bf7c66b3f13433ffa@linux-foundation.org> (raw)
In-Reply-To: <20180829024224.GA6083@kroah.com>
On Tue, 28 Aug 2018 19:42:24 -0700 Greg KH <gregkh@linuxfoundation.org> wrote:
> > --- lnx-416.orig/include/uapi/linux/keyctl.h
> > +++ lnx-416/include/uapi/linux/keyctl.h
> > @@ -65,7 +65,7 @@
> >
> > /* keyctl structures */
> > struct keyctl_dh_params {
> > - __s32 private;
> > + __s32 dh_private;
>
> Ick ick ick, why not just put the C "namespace" on all uapi files if you
> are including them from c++ code? I'm sure this isn't the only problem
> that has this problem, right?
>
> This is valid C, no need to start worrying about C++ reserved names.
We've done this before and it's a simple enough change in order to be
friendly toward others.
That being said, it's been like this for two years so presumably anyone
who is using this header from C++ is already `extern "C" { ...}' around
their #include.
I'm OK with the patch as-is, but if we run into this issue more often,
we might want to look at doing something kernel-wide.
I'm not sure what though. Adding
#ifdef __cplusplus
extern "C" {
#endif
...
#ifdef __cplusplus
}
#endif
into every uapi file might work. Unpleasing.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Randy Dunlap <rdunlap@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
David Howells <dhowells@redhat.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
Mat Martineau <mathew.j.martineau@linux.intel.com>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH resend] uapi/linux/keyctl.h: don't use C++ reserved keyword as a struct member name
Date: Wed, 29 Aug 2018 15:56:48 -0700 [thread overview]
Message-ID: <20180829155648.e4ec141bf7c66b3f13433ffa@linux-foundation.org> (raw)
In-Reply-To: <20180829024224.GA6083@kroah.com>
On Tue, 28 Aug 2018 19:42:24 -0700 Greg KH <gregkh@linuxfoundation.org> wrote:
> > --- lnx-416.orig/include/uapi/linux/keyctl.h
> > +++ lnx-416/include/uapi/linux/keyctl.h
> > @@ -65,7 +65,7 @@
> >
> > /* keyctl structures */
> > struct keyctl_dh_params {
> > - __s32 private;
> > + __s32 dh_private;
>
> Ick ick ick, why not just put the C "namespace" on all uapi files if you
> are including them from c++ code? I'm sure this isn't the only problem
> that has this problem, right?
>
> This is valid C, no need to start worrying about C++ reserved names.
We've done this before and it's a simple enough change in order to be
friendly toward others.
That being said, it's been like this for two years so presumably anyone
who is using this header from C++ is already `extern "C" { ...}' around
their #include.
I'm OK with the patch as-is, but if we run into this issue more often,
we might want to look at doing something kernel-wide.
I'm not sure what though. Adding
#ifdef __cplusplus
extern "C" {
#endif
...
#ifdef __cplusplus
}
#endif
into every uapi file might work. Unpleasing.
WARNING: multiple messages have this Message-ID (diff)
From: akpm@linux-foundation.org (Andrew Morton)
To: linux-security-module@vger.kernel.org
Subject: [PATCH resend] uapi/linux/keyctl.h: don't use C++ reserved keyword as a struct member name
Date: Wed, 29 Aug 2018 15:56:48 -0700 [thread overview]
Message-ID: <20180829155648.e4ec141bf7c66b3f13433ffa@linux-foundation.org> (raw)
In-Reply-To: <20180829024224.GA6083@kroah.com>
On Tue, 28 Aug 2018 19:42:24 -0700 Greg KH <gregkh@linuxfoundation.org> wrote:
> > --- lnx-416.orig/include/uapi/linux/keyctl.h
> > +++ lnx-416/include/uapi/linux/keyctl.h
> > @@ -65,7 +65,7 @@
> >
> > /* keyctl structures */
> > struct keyctl_dh_params {
> > - __s32 private;
> > + __s32 dh_private;
>
> Ick ick ick, why not just put the C "namespace" on all uapi files if you
> are including them from c++ code? I'm sure this isn't the only problem
> that has this problem, right?
>
> This is valid C, no need to start worrying about C++ reserved names.
We've done this before and it's a simple enough change in order to be
friendly toward others.
That being said, it's been like this for two years so presumably anyone
who is using this header from C++ is already `extern "C" { ...}' around
their #include.
I'm OK with the patch as-is, but if we run into this issue more often,
we might want to look at doing something kernel-wide.
I'm not sure what though. Adding
#ifdef __cplusplus
extern "C" {
#endif
...
#ifdef __cplusplus
}
#endif
into every uapi file might work. Unpleasing.
next prev parent reply other threads:[~2018-08-29 22:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 23:34 [PATCH resend] uapi/linux/keyctl.h: don't use C++ reserved keyword as a struct member name Randy Dunlap
2018-08-28 23:34 ` Randy Dunlap
2018-08-28 23:34 ` Randy Dunlap
2018-08-29 2:42 ` Greg KH
2018-08-29 2:42 ` Greg KH
2018-08-29 2:42 ` Greg KH
2018-08-29 22:56 ` Andrew Morton [this message]
2018-08-29 22:56 ` Andrew Morton
2018-08-29 22:56 ` Andrew Morton
2018-09-09 22:00 ` Eugene Syromiatnikov
2018-09-09 22:00 ` Eugene Syromiatnikov
2018-09-09 22:00 ` Eugene Syromiatnikov
2018-09-10 22:09 ` Andrew Morton
2018-09-10 22:09 ` Andrew Morton
2018-09-10 22:09 ` Andrew Morton
2018-09-22 0:03 ` David Howells
2018-09-22 0:03 ` David Howells
2018-09-22 0:03 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180829155648.e4ec141bf7c66b3f13433ffa@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.