* [PATCH] dma-mapping: fix return type of dma_set_max_seg_size()
@ 2018-08-29 21:29 ` Niklas Söderlund
0 siblings, 0 replies; 10+ messages in thread
From: Niklas Söderlund @ 2018-08-29 21:29 UTC (permalink / raw)
To: Christoph Hellwig, Marek Szyprowski, Robin Murphy,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA
Cc: linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, Niklas Söderlund
The function dma_set_max_seg_size() can return either 0 on success or
-EIO on error. Change its return type from unsigned int to int to
capture this.
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
include/linux/dma-mapping.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
index 1db6a6b46d0d3dbd..669cde2fa8723ac5 100644
--- a/include/linux/dma-mapping.h
+++ b/include/linux/dma-mapping.h
@@ -674,8 +674,7 @@ static inline unsigned int dma_get_max_seg_size(struct device *dev)
return SZ_64K;
}
-static inline unsigned int dma_set_max_seg_size(struct device *dev,
- unsigned int size)
+static inline int dma_set_max_seg_size(struct device *dev, unsigned int size)
{
if (dev->dma_parms) {
dev->dma_parms->max_segment_size = size;
--
2.18.0
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] dma-mapping: fix return type of dma_set_max_seg_size()
@ 2018-08-30 8:31 ` Geert Uytterhoeven
0 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2018-08-30 8:31 UTC (permalink / raw)
To: Niklas Söderlund
Cc: Christoph Hellwig, Marek Szyprowski, Robin Murphy, Linux IOMMU,
Linux-Renesas
On Wed, Aug 29, 2018 at 11:30 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> The function dma_set_max_seg_size() can return either 0 on success or
> -EIO on error. Change its return type from unsigned int to int to
> capture this.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] dma-mapping: fix return type of dma_set_max_seg_size()
@ 2018-08-30 8:31 ` Geert Uytterhoeven
0 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2018-08-30 8:31 UTC (permalink / raw)
To: Niklas Söderlund
Cc: Linux-Renesas, Linux IOMMU, Robin Murphy, Christoph Hellwig
On Wed, Aug 29, 2018 at 11:30 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> The function dma_set_max_seg_size() can return either 0 on success or
> -EIO on error. Change its return type from unsigned int to int to
> capture this.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dma-mapping: fix return type of dma_set_max_seg_size()
@ 2018-11-02 10:22 ` Niklas Söderlund
0 siblings, 0 replies; 10+ messages in thread
From: Niklas Söderlund @ 2018-11-02 10:22 UTC (permalink / raw)
To: Christoph Hellwig, Marek Szyprowski, Robin Murphy, iommu
Cc: linux-renesas-soc
Hi,
A gentle ping on this patch.
On 2018-08-29 23:29:21 +0200, Niklas S�derlund wrote:
> The function dma_set_max_seg_size() can return either 0 on success or
> -EIO on error. Change its return type from unsigned int to int to
> capture this.
>
> Signed-off-by: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> include/linux/dma-mapping.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
> index 1db6a6b46d0d3dbd..669cde2fa8723ac5 100644
> --- a/include/linux/dma-mapping.h
> +++ b/include/linux/dma-mapping.h
> @@ -674,8 +674,7 @@ static inline unsigned int dma_get_max_seg_size(struct device *dev)
> return SZ_64K;
> }
>
> -static inline unsigned int dma_set_max_seg_size(struct device *dev,
> - unsigned int size)
> +static inline int dma_set_max_seg_size(struct device *dev, unsigned int size)
> {
> if (dev->dma_parms) {
> dev->dma_parms->max_segment_size = size;
> --
> 2.18.0
>
--
Regards,
Niklas S�derlund
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] dma-mapping: fix return type of dma_set_max_seg_size()
@ 2018-11-02 10:22 ` Niklas Söderlund
0 siblings, 0 replies; 10+ messages in thread
From: Niklas Söderlund @ 2018-11-02 10:22 UTC (permalink / raw)
To: Christoph Hellwig, Marek Szyprowski, Robin Murphy,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA
Cc: linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA
Hi,
A gentle ping on this patch.
On 2018-08-29 23:29:21 +0200, Niklas Söderlund wrote:
> The function dma_set_max_seg_size() can return either 0 on success or
> -EIO on error. Change its return type from unsigned int to int to
> capture this.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas-1zkq55x86MTxsAP9Fp7wbw@public.gmane.org>
> ---
> include/linux/dma-mapping.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
> index 1db6a6b46d0d3dbd..669cde2fa8723ac5 100644
> --- a/include/linux/dma-mapping.h
> +++ b/include/linux/dma-mapping.h
> @@ -674,8 +674,7 @@ static inline unsigned int dma_get_max_seg_size(struct device *dev)
> return SZ_64K;
> }
>
> -static inline unsigned int dma_set_max_seg_size(struct device *dev,
> - unsigned int size)
> +static inline int dma_set_max_seg_size(struct device *dev, unsigned int size)
> {
> if (dev->dma_parms) {
> dev->dma_parms->max_segment_size = size;
> --
> 2.18.0
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] dma-mapping: fix return type of dma_set_max_seg_size()
@ 2018-11-26 17:06 ` Niklas Söderlund
0 siblings, 0 replies; 10+ messages in thread
From: Niklas Söderlund @ 2018-11-26 17:06 UTC (permalink / raw)
To: Christoph Hellwig, Marek Szyprowski, Robin Murphy, iommu
Cc: linux-renesas-soc
On 2018-11-02 11:22:54 +0100, Niklas S�derlund wrote:
> Hi,
>
> A gentle ping on this patch.
A slightly harder ping :-)
>
> On 2018-08-29 23:29:21 +0200, Niklas S�derlund wrote:
> > The function dma_set_max_seg_size() can return either 0 on success or
> > -EIO on error. Change its return type from unsigned int to int to
> > capture this.
> >
> > Signed-off-by: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se>
> > ---
> > include/linux/dma-mapping.h | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
> > index 1db6a6b46d0d3dbd..669cde2fa8723ac5 100644
> > --- a/include/linux/dma-mapping.h
> > +++ b/include/linux/dma-mapping.h
> > @@ -674,8 +674,7 @@ static inline unsigned int dma_get_max_seg_size(struct device *dev)
> > return SZ_64K;
> > }
> >
> > -static inline unsigned int dma_set_max_seg_size(struct device *dev,
> > - unsigned int size)
> > +static inline int dma_set_max_seg_size(struct device *dev, unsigned int size)
> > {
> > if (dev->dma_parms) {
> > dev->dma_parms->max_segment_size = size;
> > --
> > 2.18.0
> >
>
> --
> Regards,
> Niklas S�derlund
--
Regards,
Niklas S�derlund
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] dma-mapping: fix return type of dma_set_max_seg_size()
@ 2018-11-26 17:06 ` Niklas Söderlund
0 siblings, 0 replies; 10+ messages in thread
From: Niklas Söderlund @ 2018-11-26 17:06 UTC (permalink / raw)
To: Christoph Hellwig, Marek Szyprowski, Robin Murphy,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA
Cc: linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA
On 2018-11-02 11:22:54 +0100, Niklas Söderlund wrote:
> Hi,
>
> A gentle ping on this patch.
A slightly harder ping :-)
>
> On 2018-08-29 23:29:21 +0200, Niklas Söderlund wrote:
> > The function dma_set_max_seg_size() can return either 0 on success or
> > -EIO on error. Change its return type from unsigned int to int to
> > capture this.
> >
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > ---
> > include/linux/dma-mapping.h | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
> > index 1db6a6b46d0d3dbd..669cde2fa8723ac5 100644
> > --- a/include/linux/dma-mapping.h
> > +++ b/include/linux/dma-mapping.h
> > @@ -674,8 +674,7 @@ static inline unsigned int dma_get_max_seg_size(struct device *dev)
> > return SZ_64K;
> > }
> >
> > -static inline unsigned int dma_set_max_seg_size(struct device *dev,
> > - unsigned int size)
> > +static inline int dma_set_max_seg_size(struct device *dev, unsigned int size)
> > {
> > if (dev->dma_parms) {
> > dev->dma_parms->max_segment_size = size;
> > --
> > 2.18.0
> >
>
> --
> Regards,
> Niklas Söderlund
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dma-mapping: fix return type of dma_set_max_seg_size()
@ 2018-11-27 7:40 ` Christoph Hellwig
0 siblings, 0 replies; 10+ messages in thread
From: Christoph Hellwig @ 2018-11-27 7:40 UTC (permalink / raw)
To: Niklas Söderlund
Cc: Christoph Hellwig, Marek Szyprowski, Robin Murphy, iommu,
linux-renesas-soc
On Wed, Aug 29, 2018 at 11:29:21PM +0200, Niklas S�derlund wrote:
> The function dma_set_max_seg_size() can return either 0 on success or
> -EIO on error. Change its return type from unsigned int to int to
> capture this.
>
> Signed-off-by: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se>
Thanks, applied to the dma-mapping tree for 4.21.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] dma-mapping: fix return type of dma_set_max_seg_size()
@ 2018-11-27 7:40 ` Christoph Hellwig
0 siblings, 0 replies; 10+ messages in thread
From: Christoph Hellwig @ 2018-11-27 7:40 UTC (permalink / raw)
To: Niklas Söderlund
Cc: linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, Robin Murphy,
Christoph Hellwig
On Wed, Aug 29, 2018 at 11:29:21PM +0200, Niklas Söderlund wrote:
> The function dma_set_max_seg_size() can return either 0 on success or
> -EIO on error. Change its return type from unsigned int to int to
> capture this.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas-1zkq55x86MTxsAP9Fp7wbw@public.gmane.org>
Thanks, applied to the dma-mapping tree for 4.21.
^ permalink raw reply [flat|nested] 10+ messages in thread