All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Christoph Hellwig <hch@lst.de>
Cc: iommu@lists.linux-foundation.org,
	Robin Murphy <robin.murphy@arm.com>, Meelis Roos <mroos@linux.ee>,
	Linus Walleij <linus.walleij@linaro.org>,
	sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: various dma_mask fixups
Date: Wed, 29 Aug 2018 15:38:21 -0700	[thread overview]
Message-ID: <20180829223821.GA29499@roeck-us.net> (raw)
In-Reply-To: <20180829062401.8701-1-hch@lst.de>

On Wed, Aug 29, 2018 at 08:23:58AM +0200, Christoph Hellwig wrote:
> Fix warnings and regressions from requiring a dma mask.

With this series applied, I see the following in my sh4 boot tests.

sb 1-1: new full-speed USB device number 2 using sm501-usb
sm501-usb sm501-usb: OHCI Unrecoverable Error, disabled
sm501-usb sm501-usb: HC died; cleaning up

This is a persistent problem. Reverting upstream commit 2f606da7823
("mfd: sm501: Set coherent_dma_mask when creating subdevices") does not
make a difference.

The problem is gone if I do not apply 'driver core: initialize a default
DMA mask for platform device'.

On the plus side, the sparc warnings are gone.

Guenter

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Christoph Hellwig <hch@lst.de>
Cc: iommu@lists.linux-foundation.org,
	Robin Murphy <robin.murphy@arm.com>, Meelis Roos <mroos@linux.ee>,
	Linus Walleij <linus.walleij@linaro.org>,
	sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: various dma_mask fixups
Date: Wed, 29 Aug 2018 22:38:21 +0000	[thread overview]
Message-ID: <20180829223821.GA29499@roeck-us.net> (raw)
In-Reply-To: <20180829062401.8701-1-hch@lst.de>

On Wed, Aug 29, 2018 at 08:23:58AM +0200, Christoph Hellwig wrote:
> Fix warnings and regressions from requiring a dma mask.

With this series applied, I see the following in my sh4 boot tests.

sb 1-1: new full-speed USB device number 2 using sm501-usb
sm501-usb sm501-usb: OHCI Unrecoverable Error, disabled
sm501-usb sm501-usb: HC died; cleaning up

This is a persistent problem. Reverting upstream commit 2f606da7823
("mfd: sm501: Set coherent_dma_mask when creating subdevices") does not
make a difference.

The problem is gone if I do not apply 'driver core: initialize a default
DMA mask for platform device'.

On the plus side, the sparc warnings are gone.

Guenter

  parent reply	other threads:[~2018-08-29 22:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29  6:23 various dma_mask fixups Christoph Hellwig
2018-08-29  6:23 ` Christoph Hellwig
2018-08-29  6:23 ` Christoph Hellwig
2018-08-29  6:23 ` [PATCH 1/3] driver core: initialize a default DMA mask for platform device Christoph Hellwig
2018-08-29  6:23   ` Christoph Hellwig
2018-08-29  6:23   ` Christoph Hellwig
2018-08-29  6:24 ` [PATCH 2/3] sparc: set a default 32-bit dma mask for OF devices Christoph Hellwig
2018-08-29  6:24   ` Christoph Hellwig
2018-08-29  6:24 ` [PATCH 3/3] of/platform: initialise AMBA default DMA masks Christoph Hellwig
2018-08-29  6:24   ` Christoph Hellwig
2018-08-29  6:59 ` various dma_mask fixups Linus Walleij
2018-08-29  6:59   ` Linus Walleij
2018-08-29 22:38 ` Guenter Roeck [this message]
2018-08-29 22:38   ` Guenter Roeck
2018-08-30 10:40   ` Guenter Roeck
2018-08-30 10:40     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180829223821.GA29499@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mroos@linux.ee \
    --cc=robin.murphy@arm.com \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.