[igt-dev] [PATCH i-g-t 1/2] tests/kms_plane_scaling: Allow DRM_FORMAT_RGB565 rotation on gen>=11

[igt-dev] [PATCH i-g-t 1/2] tests/kms_plane_scaling: Allow DRM_FORMAT_RGB565 rotation on gen>=11

[Juha-Pekka Heikkila]

Test DRM_FORMAT_RGB565 rotation when gen is 11 or higher.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 tests/kms_plane_scaling.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 2f19a42..7c64ed1 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -156,10 +156,10 @@ static const igt_rotation_t rotations[] = {
 	IGT_ROTATION_270,
 };
 
-static bool can_rotate(unsigned format)
+static bool can_rotate(data_t *d, unsigned format)
 {
 	if (format == DRM_FORMAT_C8 ||
-	    format == DRM_FORMAT_RGB565)
+	    (intel_gen(d->devid) < 11 && format == DRM_FORMAT_RGB565))
 		return false;
 
 	return true;
@@ -180,7 +180,8 @@ static void test_scaler_with_rotation_pipe(data_t *d, enum pipe pipe,
 			igt_rotation_t rot = rotations[i];
 			for (int j = 0; j < plane->drm_plane->count_formats; j++) {
 				unsigned format = plane->drm_plane->formats[j];
-				if (igt_fb_supported_format(format) && can_rotate(format))
+				if (igt_fb_supported_format(format) &&
+				    can_rotate(d, format))
 					check_scaling_pipe_plane_rot(d, plane, format,
 								     LOCAL_I915_FORMAT_MOD_Y_TILED,
 								     pipe, output, rot);
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t 2/2] tests/kms_rotation_crc: Fix bad-pixel-format not to be run on gen11 and later

[Juha-Pekka Heikkila]

gen11 enables 90/270 rotation for RGB565 mode. IGT would need support for
C8 mode to enable running this subtest on gen11 and later.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 tests/kms_rotation_crc.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index b994cc5..35e6721 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -558,6 +558,12 @@ igt_main
 
 	igt_subtest_f("bad-pixel-format") {
 		igt_require(gen >= 9);
+		/*
+		 * gen11 enables RGB565 rotation for 90/270 degrees.
+		 * C8 mode need to be enabled for IGT if want to run this test
+		 * on gen11 onwards.
+		 */
+		igt_require(gen < 11);
 		data.rotation = IGT_ROTATION_90;
 		data.override_fmt = DRM_FORMAT_RGB565;
 		test_plane_rotation(&data, DRM_PLANE_TYPE_PRIMARY, true);
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] tests/kms_plane_scaling: Allow DRM_FORMAT_RGB565 rotation on gen>=11

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/2] tests/kms_plane_scaling: Allow DRM_FORMAT_RGB565 rotation on gen>=11
URL   : https://patchwork.freedesktop.org/series/48756/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4706 -> IGTPW_1746 =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_1746 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1746, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48756/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1746:

  === IGT changes ===

    ==== Possible regressions ====

    igt@gem_exec_suspend@basic-s4-devices:
      fi-blb-e6850:       NOTRUN -> INCOMPLETE

    
    ==== Warnings ====

    igt@drv_selftest@live_execlists:
      fi-whl-u:           SKIP -> PASS +1

    
== Known issues ==

  Here are the changes found in IGTPW_1746 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_guc:
      fi-skl-guc:         NOTRUN -> DMESG-WARN (fdo#107258, fdo#107175)

    igt@gem_mmap_gtt@basic-copy:
      fi-glk-dsi:         PASS -> INCOMPLETE (fdo#103359, k.org#198133)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_hangcheck:
      fi-whl-u:           DMESG-FAIL (fdo#106560) -> PASS

    igt@gem_exec_suspend@basic-s3:
      fi-blb-e6850:       INCOMPLETE -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bxt-dsi:         INCOMPLETE (fdo#103927) -> PASS

    {igt@kms_psr@primary_mmap_gtt}:
      fi-cnl-psr:         DMESG-WARN -> PASS

    {igt@pm_rpm@module-reload}:
      fi-cnl-psr:         WARN (fdo#107602) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
  fdo#107175 https://bugs.freedesktop.org/show_bug.cgi?id=107175
  fdo#107258 https://bugs.freedesktop.org/show_bug.cgi?id=107258
  fdo#107602 https://bugs.freedesktop.org/show_bug.cgi?id=107602
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (53 -> 49) ==

  Additional (1): fi-skl-guc 
  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4609 -> IGTPW_1746

  CI_DRM_4706: 6d5687919f3a3426243041b99111b576dd0576d0 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1746: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1746/
  IGT_4609: 0bc9763af77bbb37f2ed65cc39c398e88db7d8e3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1746/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 1/2] tests/kms_plane_scaling: Allow DRM_FORMAT_RGB565 rotation on gen>=11

[Mika Kahola]

On Mon, 2018-08-27 at 15:27 +0300, Juha-Pekka Heikkila wrote:
> Test DRM_FORMAT_RGB565 rotation when gen is 11 or higher.
> 
Looks ok to me.

Reviewed-by: Mika Kahola <mika.kahola@intel.com>

> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
>  tests/kms_plane_scaling.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 2f19a42..7c64ed1 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -156,10 +156,10 @@ static const igt_rotation_t rotations[] = {
>  	IGT_ROTATION_270,
>  };
>  
> -static bool can_rotate(unsigned format)
> +static bool can_rotate(data_t *d, unsigned format)
>  {
>  	if (format == DRM_FORMAT_C8 ||
> -	    format == DRM_FORMAT_RGB565)
> +	    (intel_gen(d->devid) < 11 && format ==
> DRM_FORMAT_RGB565))
>  		return false;
>  
>  	return true;
> @@ -180,7 +180,8 @@ static void test_scaler_with_rotation_pipe(data_t
> *d, enum pipe pipe,
>  			igt_rotation_t rot = rotations[i];
>  			for (int j = 0; j < plane->drm_plane-
> >count_formats; j++) {
>  				unsigned format = plane->drm_plane-
> >formats[j];
> -				if (igt_fb_supported_format(format)
> && can_rotate(format))
> +				if (igt_fb_supported_format(format)
> &&
> +				    can_rotate(d, format))
>  					check_scaling_pipe_plane_rot
> (d, plane, format,
>  								    
>  LOCAL_I915_FORMAT_MOD_Y_TILED,
>  								    
>  pipe, output, rot);
-- 
Mika Kahola - Intel OTC

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 2/2] tests/kms_rotation_crc: Fix bad-pixel-format not to be run on gen11 and later

[Mika Kahola]

On Mon, 2018-08-27 at 15:27 +0300, Juha-Pekka Heikkila wrote:
> gen11 enables 90/270 rotation for RGB565 mode. IGT would need support
> for
> C8 mode to enable running this subtest on gen11 and later.
> 
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
>  tests/kms_rotation_crc.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index b994cc5..35e6721 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -558,6 +558,12 @@ igt_main
>  
>  	igt_subtest_f("bad-pixel-format") {
>  		igt_require(gen >= 9);
> +		/*
> +		 * gen11 enables RGB565 rotation for 90/270 degrees.
> +		 * C8 mode need to be enabled for IGT if want to run
> this test
> +		 * on gen11 onwards.
> +		 */
> +		igt_require(gen < 11);
Could we combine these two requirements? Comment might need to be
rephrased a bit too.

>  		data.rotation = IGT_ROTATION_90;
>  		data.override_fmt = DRM_FORMAT_RGB565;
>  		test_plane_rotation(&data, DRM_PLANE_TYPE_PRIMARY,
> true);
-- 
Mika Kahola - Intel OTC

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 2/2] tests/kms_rotation_crc: Fix bad-pixel-format not to be run on gen11 and later

[Rodrigo Vivi]

On Mon, Aug 27, 2018 at 04:14:05PM +0300, Mika Kahola wrote:
> On Mon, 2018-08-27 at 15:27 +0300, Juha-Pekka Heikkila wrote:
> > gen11 enables 90/270 rotation for RGB565 mode. IGT would need support
> > for
> > C8 mode to enable running this subtest on gen11 and later.
> > 
> > Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> > ---
> >  tests/kms_rotation_crc.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> > index b994cc5..35e6721 100644
> > --- a/tests/kms_rotation_crc.c
> > +++ b/tests/kms_rotation_crc.c
> > @@ -558,6 +558,12 @@ igt_main
> >  
> >  	igt_subtest_f("bad-pixel-format") {
> >  		igt_require(gen >= 9);
> > +		/*
> > +		 * gen11 enables RGB565 rotation for 90/270 degrees.
> > +		 * C8 mode need to be enabled for IGT if want to run
> > this test
> > +		 * on gen11 onwards.
> > +		 */
> > +		igt_require(gen < 11);
> Could we combine these two requirements? Comment might need to be
> rephrased a bit too.

also, isn't any other way to check the capability instead of spreading
gen checks?

> 
> >  		data.rotation = IGT_ROTATION_90;
> >  		data.override_fmt = DRM_FORMAT_RGB565;
> >  		test_plane_rotation(&data, DRM_PLANE_TYPE_PRIMARY,
> > true);
> -- 
> Mika Kahola - Intel OTC
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/2] tests/kms_plane_scaling: Allow DRM_FORMAT_RGB565 rotation on gen>=11

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/2] tests/kms_plane_scaling: Allow DRM_FORMAT_RGB565 rotation on gen>=11
URL   : https://patchwork.freedesktop.org/series/48756/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4706 -> IGTPW_1747 =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_1747 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1747, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48756/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1747:

  === IGT changes ===

    ==== Possible regressions ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-blb-e6850:       NOTRUN -> INCOMPLETE

    
    ==== Warnings ====

    igt@drv_selftest@live_execlists:
      fi-whl-u:           SKIP -> PASS +1

    
== Known issues ==

  Here are the changes found in IGTPW_1747 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_guc:
      fi-skl-guc:         NOTRUN -> DMESG-WARN (fdo#107258, fdo#107175)

    igt@drv_selftest@live_hangcheck:
      fi-skl-guc:         NOTRUN -> DMESG-FAIL (fdo#107174)

    igt@kms_frontbuffer_tracking@basic:
      {fi-byt-clapper}:   PASS -> FAIL (fdo#103167)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-snb-2520m:       PASS -> INCOMPLETE (fdo#103713)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_hangcheck:
      fi-whl-u:           DMESG-FAIL (fdo#106560) -> PASS

    igt@gem_exec_suspend@basic-s3:
      fi-blb-e6850:       INCOMPLETE -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bxt-dsi:         INCOMPLETE (fdo#103927) -> PASS

    {igt@kms_psr@primary_mmap_gtt}:
      fi-cnl-psr:         DMESG-WARN (fdo#107705) -> PASS

    {igt@pm_rpm@module-reload}:
      fi-cnl-psr:         WARN (fdo#107602) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
  fdo#107174 https://bugs.freedesktop.org/show_bug.cgi?id=107174
  fdo#107175 https://bugs.freedesktop.org/show_bug.cgi?id=107175
  fdo#107258 https://bugs.freedesktop.org/show_bug.cgi?id=107258
  fdo#107602 https://bugs.freedesktop.org/show_bug.cgi?id=107602
  fdo#107705 https://bugs.freedesktop.org/show_bug.cgi?id=107705


== Participating hosts (53 -> 48) ==

  Additional (1): fi-skl-guc 
  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-gdg-551 


== Build changes ==

    * IGT: IGT_4609 -> IGTPW_1747

  CI_DRM_4706: 6d5687919f3a3426243041b99111b576dd0576d0 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1747: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1747/
  IGT_4609: 0bc9763af77bbb37f2ed65cc39c398e88db7d8e3 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1747/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 2/2] tests/kms_rotation_crc: Fix bad-pixel-format not to be run on gen11 and later

[Juha-Pekka Heikkila]

On 27.08.2018 19:33, Rodrigo Vivi wrote:
> On Mon, Aug 27, 2018 at 04:14:05PM +0300, Mika Kahola wrote:
>> On Mon, 2018-08-27 at 15:27 +0300, Juha-Pekka Heikkila wrote:
>>> gen11 enables 90/270 rotation for RGB565 mode. IGT would need support
>>> for
>>> C8 mode to enable running this subtest on gen11 and later.
>>>
>>> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>>> ---
>>>   tests/kms_rotation_crc.c | 6 ++++++
>>>   1 file changed, 6 insertions(+)
>>>
>>> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
>>> index b994cc5..35e6721 100644
>>> --- a/tests/kms_rotation_crc.c
>>> +++ b/tests/kms_rotation_crc.c
>>> @@ -558,6 +558,12 @@ igt_main
>>>   
>>>   	igt_subtest_f("bad-pixel-format") {
>>>   		igt_require(gen >= 9);
>>> +		/*
>>> +		 * gen11 enables RGB565 rotation for 90/270 degrees.
>>> +		 * C8 mode need to be enabled for IGT if want to run
>>> this test
>>> +		 * on gen11 onwards.
>>> +		 */
>>> +		igt_require(gen < 11);
>> Could we combine these two requirements? Comment might need to be
>> rephrased a bit too.

I'll make another patch.

> 
> also, isn't any other way to check the capability instead of spreading
> gen checks?

This is at beginning of test, nothing has been generated yet. I don't 
know where at this stage I would check for capabilities. In any case I'd 
prefer skip early.

Out of curiosity, why to avoid gen checks? I think they are with IGT 
case hand-in-hand on what's written on kernel side?

> 
>>
>>>   		data.rotation = IGT_ROTATION_90;
>>>   		data.override_fmt = DRM_FORMAT_RGB565;
>>>   		test_plane_rotation(&data, DRM_PLANE_TYPE_PRIMARY,
>>> true);
>> -- 
>> Mika Kahola - Intel OTC
>>
>> _______________________________________________
>> igt-dev mailing list
>> igt-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/igt-dev

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] tests/kms_rotation_crc: Fix bad-pixel-format not to be run on gen11 and later

[Juha-Pekka Heikkila]

gen11 enables 90/270 rotation for RGB565 mode. IGT would need support for
C8 mode to enable running this subtest on gen11 and later.

v2 (Mika Kahola): Combine gen checks into one comparison. Update
comment on why bad-pixel-format is disabled beyond gen11.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 tests/kms_rotation_crc.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index b994cc5..5ed0c0b 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -557,7 +557,12 @@ igt_main
 	data.pos_y = 0;
 
 	igt_subtest_f("bad-pixel-format") {
-		igt_require(gen >= 9);
+		/*
+		 * gen11 enables RGB565 rotation for 90/270 degrees.
+		 * DRM_FORMAT_C8 fmt need to be enabled for IGT if want to run
+		 * this test on gen11 and later.
+		 */
+		igt_require(gen >= 9 && gen < 11);
 		data.rotation = IGT_ROTATION_90;
 		data.override_fmt = DRM_FORMAT_RGB565;
 		test_plane_rotation(&data, DRM_PLANE_TYPE_PRIMARY, true);
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t 2/2] tests/kms_rotation_crc: Fix bad-pixel-format not to be run on gen11 and later

[Rodrigo Vivi]

On Tue, Aug 28, 2018 at 04:38:08PM +0300, Juha-Pekka Heikkila wrote:
> On 27.08.2018 19:33, Rodrigo Vivi wrote:
> > On Mon, Aug 27, 2018 at 04:14:05PM +0300, Mika Kahola wrote:
> > > On Mon, 2018-08-27 at 15:27 +0300, Juha-Pekka Heikkila wrote:
> > > > gen11 enables 90/270 rotation for RGB565 mode. IGT would need support
> > > > for
> > > > C8 mode to enable running this subtest on gen11 and later.
> > > > 
> > > > Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> > > > ---
> > > >   tests/kms_rotation_crc.c | 6 ++++++
> > > >   1 file changed, 6 insertions(+)
> > > > 
> > > > diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> > > > index b994cc5..35e6721 100644
> > > > --- a/tests/kms_rotation_crc.c
> > > > +++ b/tests/kms_rotation_crc.c
> > > > @@ -558,6 +558,12 @@ igt_main
> > > >   	igt_subtest_f("bad-pixel-format") {
> > > >   		igt_require(gen >= 9);
> > > > +		/*
> > > > +		 * gen11 enables RGB565 rotation for 90/270 degrees.
> > > > +		 * C8 mode need to be enabled for IGT if want to run
> > > > this test
> > > > +		 * on gen11 onwards.
> > > > +		 */
> > > > +		igt_require(gen < 11);
> > > Could we combine these two requirements? Comment might need to be
> > > rephrased a bit too.
> 
> I'll make another patch.
> 
> > 
> > also, isn't any other way to check the capability instead of spreading
> > gen checks?
> 
> This is at beginning of test, nothing has been generated yet. I don't know
> where at this stage I would check for capabilities. In any case I'd prefer
> skip early.
> 
> Out of curiosity, why to avoid gen checks? I think they are with IGT case
> hand-in-hand on what's written on kernel side?

because when we write same code on both sides we are suitable for making
same mistake twice.

But also to avoid duplication of effort like we have with pci ids across
different components of stack... a such simple thing that is a painful and
boring task :(

So I prefer when we check for capabilities and if it is there we test it.

> 
> > 
> > > 
> > > >   		data.rotation = IGT_ROTATION_90;
> > > >   		data.override_fmt = DRM_FORMAT_RGB565;
> > > >   		test_plane_rotation(&data, DRM_PLANE_TYPE_PRIMARY,
> > > > true);
> > > -- 
> > > Mika Kahola - Intel OTC
> > > 
> > > _______________________________________________
> > > igt-dev mailing list
> > > igt-dev@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/igt-dev
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] tests/kms_plane_scaling: Allow DRM_FORMAT_RGB565 rotation on gen>=11 (rev2)

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/2] tests/kms_plane_scaling: Allow DRM_FORMAT_RGB565 rotation on gen>=11 (rev2)
URL   : https://patchwork.freedesktop.org/series/48756/
State : failure

== Summary ==

= CI Bug Log - changes from IGT_4610_full -> IGTPW_1753_full =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_1753_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1753_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48756/revisions/2/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1753_full:

  === IGT changes ===

    ==== Possible regressions ====

    igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-xtiled:
      shard-glk:          PASS -> FAIL

    
    ==== Warnings ====

    igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-untiled:
      shard-snb:          SKIP -> PASS

    igt@pm_rc6_residency@rc6-accuracy:
      shard-kbl:          PASS -> SKIP

    
== Known issues ==

  Here are the changes found in IGTPW_1753_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@shrink:
      shard-glk:          PASS -> FAIL (fdo#106886)

    igt@gem_exec_await@wide-contexts:
      shard-kbl:          PASS -> FAIL (fdo#105900)

    igt@gem_ppgtt@blt-vs-render-ctxn:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665, fdo#106023)

    igt@gem_workarounds@suspend-resume:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665, fdo#107556)

    igt@kms_flip@flip-vs-expired-vblank-interruptible:
      shard-glk:          PASS -> FAIL (fdo#105363, fdo#102887)

    igt@kms_rotation_crc@primary-rotation-180:
      shard-snb:          PASS -> FAIL (fdo#103925)

    igt@kms_setmode@basic:
      shard-glk:          NOTRUN -> FAIL (fdo#99912)
      shard-kbl:          PASS -> FAIL (fdo#99912)

    igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
      shard-glk:          PASS -> INCOMPLETE (k.org#198133, fdo#103359)

    igt@perf@blocking:
      shard-hsw:          PASS -> FAIL (fdo#102252)

    igt@perf_pmu@semaphore-wait-vcs1:
      shard-snb:          SKIP -> INCOMPLETE (fdo#105411)

    
    ==== Possible fixes ====

    igt@gem_ctx_isolation@vcs0-s3:
      shard-kbl:          INCOMPLETE (fdo#103665, fdo#107556) -> PASS

    igt@gem_ctx_isolation@vcs1-none:
      shard-snb:          INCOMPLETE (fdo#105411) -> SKIP

    igt@gem_ppgtt@blt-vs-render-ctx0:
      shard-kbl:          INCOMPLETE (fdo#103665, fdo#106023) -> PASS

    igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
      shard-snb:          FAIL (fdo#103166) -> PASS

    igt@testdisplay:
      shard-glk:          INCOMPLETE (k.org#198133, fdo#103359, fdo#107093) -> PASS

    
  fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
  fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105900 https://bugs.freedesktop.org/show_bug.cgi?id=105900
  fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#107093 https://bugs.freedesktop.org/show_bug.cgi?id=107093
  fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4610 -> IGTPW_1753
    * Linux: CI_DRM_4706 -> CI_DRM_4715

  CI_DRM_4706: 6d5687919f3a3426243041b99111b576dd0576d0 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4715: 1b73a69651beab39192502181c83e77a1022014a @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1753: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1753/
  IGT_4610: c40743d3fce5055682d31610519758dd7379c0f8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1753/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/kms_plane_scaling: Allow DRM_FORMAT_RGB565 rotation on gen>=11 (rev2)

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/2] tests/kms_plane_scaling: Allow DRM_FORMAT_RGB565 rotation on gen>=11 (rev2)
URL   : https://patchwork.freedesktop.org/series/48756/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4715 -> IGTPW_1753 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48756/revisions/2/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1753 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_hangcheck:
      {fi-cfl-8109u}:     PASS -> DMESG-FAIL (fdo#106560)

    igt@kms_flip@basic-plain-flip:
      fi-ilk-650:         PASS -> DMESG-WARN (fdo#106387)

    igt@kms_frontbuffer_tracking@basic:
      {fi-byt-clapper}:   PASS -> FAIL (fdo#103167)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-blb-e6850:       PASS -> INCOMPLETE (fdo#107718)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bxt-dsi:         NOTRUN -> INCOMPLETE (fdo#103927)

    
    ==== Possible fixes ====

    igt@debugfs_test@read_all_entries:
      fi-snb-2520m:       INCOMPLETE (fdo#103713) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#106387 https://bugs.freedesktop.org/show_bug.cgi?id=106387
  fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
  fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718


== Participating hosts (53 -> 47) ==

  Additional (1): fi-bxt-dsi 
  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-gdg-551 


== Build changes ==

    * IGT: IGT_4610 -> IGTPW_1753

  CI_DRM_4715: 1b73a69651beab39192502181c83e77a1022014a @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1753: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1753/
  IGT_4610: c40743d3fce5055682d31610519758dd7379c0f8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1753/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] tests/kms_plane_scaling: Allow DRM_FORMAT_RGB565 rotation on gen>=11 (rev2)

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/2] tests/kms_plane_scaling: Allow DRM_FORMAT_RGB565 rotation on gen>=11 (rev2)
URL   : https://patchwork.freedesktop.org/series/48756/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4751 -> IGTPW_1772 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48756/revisions/2/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1772 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
      fi-kbl-r:           PASS -> DMESG-WARN (fdo#105602)

    
    ==== Possible fixes ====

    igt@kms_frontbuffer_tracking@basic:
      fi-hsw-peppy:       DMESG-WARN (fdo#102614) -> PASS

    igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
      {fi-byt-clapper}:   FAIL (fdo#103191, fdo#107362) -> PASS +1

    {igt@pm_rpm@module-reload}:
      fi-cnl-psr:         WARN (fdo#107708, fdo#107602) -> PASS

    igt@prime_vgem@basic-fence-flip:
      fi-skl-6770hq:      FAIL (fdo#104008) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
  fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107602 https://bugs.freedesktop.org/show_bug.cgi?id=107602
  fdo#107708 https://bugs.freedesktop.org/show_bug.cgi?id=107708


== Participating hosts (50 -> 45) ==

  Missing    (5): fi-kbl-7560u fi-byt-squawks fi-bsw-cyan fi-ilk-m540 fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4618 -> IGTPW_1772

  CI_DRM_4751: 2679376a6fe30a27b8734442d9b1af6a411f7bc7 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1772: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1772/
  IGT_4618: 9d83154c898b5acc8b462d17104df50cfd71e9a0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1772/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] tests/kms_plane_scaling: Allow DRM_FORMAT_RGB565 rotation on gen>=11 (rev2)

[Patchwork]

== Series Details ==

Series: series starting with [i-g-t,1/2] tests/kms_plane_scaling: Allow DRM_FORMAT_RGB565 rotation on gen>=11 (rev2)
URL   : https://patchwork.freedesktop.org/series/48756/
State : failure

== Summary ==

= CI Bug Log - changes from IGT_4618_full -> IGTPW_1772_full =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_1772_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1772_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48756/revisions/2/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1772_full:

  === IGT changes ===

    ==== Possible regressions ====

    igt@pm_rps@reset:
      shard-kbl:          PASS -> FAIL

    
== Known issues ==

  Here are the changes found in IGTPW_1772_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@shrink:
      shard-hsw:          PASS -> INCOMPLETE (fdo#106886, fdo#103540)

    igt@gem_exec_suspend@basic-s3:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665)

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt:
      shard-glk:          PASS -> FAIL (fdo#103167) +1

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-gtt:
      shard-glk:          NOTRUN -> FAIL (fdo#103167)

    igt@kms_rotation_crc@primary-rotation-180:
      shard-snb:          PASS -> FAIL (fdo#103925)

    igt@perf_pmu@frequency:
      shard-snb:          PASS -> INCOMPLETE (fdo#105411)

    
    ==== Possible fixes ====

    igt@gem_exec_await@wide-contexts:
      shard-glk:          FAIL (fdo#105900) -> PASS

    igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
      shard-hsw:          FAIL (fdo#105767) -> PASS

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-cpu:
      shard-glk:          FAIL (fdo#103167) -> PASS

    igt@kms_plane@pixel-format-pipe-a-planes:
      shard-snb:          FAIL -> PASS

    igt@kms_setmode@basic:
      shard-kbl:          FAIL (fdo#99912) -> PASS

    igt@kms_vblank@pipe-a-ts-continuation-suspend:
      shard-kbl:          INCOMPLETE (fdo#103665, fdo#107556) -> PASS

    
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105767 https://bugs.freedesktop.org/show_bug.cgi?id=105767
  fdo#105900 https://bugs.freedesktop.org/show_bug.cgi?id=105900
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4618 -> IGTPW_1772
    * Linux: CI_DRM_4749 -> CI_DRM_4751

  CI_DRM_4749: 4a46c18fad0de38a78b4b0c848892de494324a17 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4751: 2679376a6fe30a27b8734442d9b1af6a411f7bc7 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1772: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1772/
  IGT_4618: 9d83154c898b5acc8b462d17104df50cfd71e9a0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1772/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/kms_rotation_crc: Fix bad-pixel-format not to be run on gen11 and later

[Mika Kahola]

On Wed, 2018-08-29 at 16:12 +0300, Juha-Pekka Heikkila wrote:
> gen11 enables 90/270 rotation for RGB565 mode. IGT would need support
> for
> C8 mode to enable running this subtest on gen11 and later.
> 
> v2 (Mika Kahola): Combine gen checks into one comparison. Update
> comment on why bad-pixel-format is disabled beyond gen11.
> 
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
>  tests/kms_rotation_crc.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index b994cc5..5ed0c0b 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -557,7 +557,12 @@ igt_main
>  	data.pos_y = 0;
>  
>  	igt_subtest_f("bad-pixel-format") {
> -		igt_require(gen >= 9);
> +		/*
> +		 * gen11 enables RGB565 rotation for 90/270 degrees.
> +		 * DRM_FORMAT_C8 fmt need to be enabled for IGT if
> want to run
> +		 * this test on gen11 and later.
> +		 */
> +		igt_require(gen >= 9 && gen < 11);
>  		data.rotation = IGT_ROTATION_90;
>  		data.override_fmt = DRM_FORMAT_RGB565;
>  		test_plane_rotation(&data, DRM_PLANE_TYPE_PRIMARY,
> true);
Both patches now pushed to IGT.

-- 
Mika Kahola - Intel OTC

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev