* [PATCH] arm64: dts: renesas: salvator-xs: Improve SATA switch settings comments
@ 2018-08-30 12:38 Geert Uytterhoeven
2018-08-30 14:52 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2018-08-30 12:38 UTC (permalink / raw)
To: Simon Horman, Magnus Damm
Cc: Wolfram Sang, linux-renesas-soc, Geert Uytterhoeven
The comments describing the non-default switch settings to use SATA are
confusing: 'Off' refers to the switch position, not to the MD12 logic
value, while the parentheses suggest otherwise. Rephrase to fix this.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts | 2 +-
arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
index ba3357636fdb0fea..cf08a119eec093cd 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
@@ -184,7 +184,7 @@
};
};
-/* MD12 (SW12-7) must be set 'Off' which is not the default! */
+/* SW12-7 must be set 'Off' (MD12 set to 1) which is not the default! */
&sata {
status = "okay";
};
diff --git a/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts b/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts
index 45016a06fab1cd5d..f03a5e9e0c427e0d 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts
@@ -57,7 +57,7 @@
};
};
-/* MD12 (SW12-7) must be set 'Off' which is not the default! */
+/* SW12-7 must be set 'Off' (MD12 set to 1) which is not the default! */
&sata {
status = "okay";
};
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: renesas: salvator-xs: Improve SATA switch settings comments
2018-08-30 12:38 [PATCH] arm64: dts: renesas: salvator-xs: Improve SATA switch settings comments Geert Uytterhoeven
@ 2018-08-30 14:52 ` Simon Horman
0 siblings, 0 replies; 3+ messages in thread
From: Simon Horman @ 2018-08-30 14:52 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Magnus Damm, Wolfram Sang, linux-renesas-soc
On Thu, Aug 30, 2018 at 02:38:07PM +0200, Geert Uytterhoeven wrote:
> The comments describing the non-default switch settings to use SATA are
> confusing: 'Off' refers to the switch position, not to the MD12 logic
> value, while the parentheses suggest otherwise. Rephrase to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Thanks Geert, thanks Wolfram, applied for v4.20.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] arm64: dts: renesas: salvator-xs: Improve SATA switch settings comments
@ 2018-08-30 12:39 Geert Uytterhoeven
0 siblings, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2018-08-30 12:39 UTC (permalink / raw)
To: Simon Horman, Magnus Damm
Cc: Wolfram Sang, linux-renesas-soc, Geert Uytterhoeven
The comments describing the non-default switch settings to use SATA are
confusing: 'Off' refers to the switch position, not to the MD12 logic
value, while the parentheses suggest otherwise. Rephrase to fix this.
Fixes: bec000784d5bb571 ("arm64: dts: renesas: salvator-xs: enable SATA")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts | 2 +-
arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
index ba3357636fdb0fea..cf08a119eec093cd 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
@@ -184,7 +184,7 @@
};
};
-/* MD12 (SW12-7) must be set 'Off' which is not the default! */
+/* SW12-7 must be set 'Off' (MD12 set to 1) which is not the default! */
&sata {
status = "okay";
};
diff --git a/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts b/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts
index 45016a06fab1cd5d..f03a5e9e0c427e0d 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts
@@ -57,7 +57,7 @@
};
};
-/* MD12 (SW12-7) must be set 'Off' which is not the default! */
+/* SW12-7 must be set 'Off' (MD12 set to 1) which is not the default! */
&sata {
status = "okay";
};
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-30 18:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-30 12:38 [PATCH] arm64: dts: renesas: salvator-xs: Improve SATA switch settings comments Geert Uytterhoeven
2018-08-30 14:52 ` Simon Horman
2018-08-30 12:39 Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.