From: Christoph Hellwig <hch@infradead.org>
To: Ezequiel Garcia <ezequiel@collabora.com>
Cc: linux-media@vger.kernel.org, linux-usb@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Tomasz Figa <tfiga@chromium.org>,
"Matwey V . Kornilov" <matwey@sai.msu.ru>,
Alan Stern <stern@rowland.harvard.edu>,
kernel@collabora.com, Keiichi Watanabe <keiichiw@chromium.org>
Subject: Re: [RFC 3/3] stk1160: Use non-coherent buffers for USB transfers
Date: Thu, 30 Aug 2018 10:59:37 -0700 [thread overview]
Message-ID: <20180830175937.GB11521@infradead.org> (raw)
In-Reply-To: <20180830172030.23344-4-ezequiel@collabora.com>
> + dma_sync_single_for_cpu(&urb->dev->dev, urb->transfer_dma,
> + urb->transfer_buffer_length, DMA_FROM_DEVICE);
You can't ue dma_sync_single_for_cpu on non-coherent dma buffers,
which is one of the major issues with them.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Ezequiel Garcia <ezequiel@collabora.com>
Cc: linux-media@vger.kernel.org, linux-usb@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Tomasz Figa <tfiga@chromium.org>,
"Matwey V . Kornilov" <matwey@sai.msu.ru>,
Alan Stern <stern@rowland.harvard.edu>,
kernel@collabora.com, Keiichi Watanabe <keiichiw@chromium.org>
Subject: [RFC,3/3] stk1160: Use non-coherent buffers for USB transfers
Date: Thu, 30 Aug 2018 10:59:37 -0700 [thread overview]
Message-ID: <20180830175937.GB11521@infradead.org> (raw)
> + dma_sync_single_for_cpu(&urb->dev->dev, urb->transfer_dma,
> + urb->transfer_buffer_length, DMA_FROM_DEVICE);
You can't ue dma_sync_single_for_cpu on non-coherent dma buffers,
which is one of the major issues with them.
WARNING: multiple messages have this Message-ID (diff)
From: hch@infradead.org (Christoph Hellwig)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 3/3] stk1160: Use non-coherent buffers for USB transfers
Date: Thu, 30 Aug 2018 10:59:37 -0700 [thread overview]
Message-ID: <20180830175937.GB11521@infradead.org> (raw)
In-Reply-To: <20180830172030.23344-4-ezequiel@collabora.com>
> + dma_sync_single_for_cpu(&urb->dev->dev, urb->transfer_dma,
> + urb->transfer_buffer_length, DMA_FROM_DEVICE);
You can't ue dma_sync_single_for_cpu on non-coherent dma buffers,
which is one of the major issues with them.
next prev parent reply other threads:[~2018-08-30 17:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 17:20 [RFC 0/3] Introduce usb_{alloc,free}_noncoherent API Ezequiel Garcia
2018-08-30 17:20 ` Ezequiel Garcia
2018-08-30 17:20 ` [RFC 1/3] HACK: ARM: dma-mapping: Get writeback memory for non-consistent mappings Ezequiel Garcia
2018-08-30 17:20 ` Ezequiel Garcia
2018-08-30 17:20 ` [RFC,1/3] " Ezequiel Garcia
2018-08-30 17:20 ` [RFC 2/3] USB: core: Add non-coherent buffer allocation helpers Ezequiel Garcia
2018-08-30 17:20 ` Ezequiel Garcia
2018-08-30 17:20 ` [RFC,2/3] " Ezequiel Garcia
2018-08-30 17:58 ` [RFC 2/3] " Christoph Hellwig
2018-08-30 17:58 ` Christoph Hellwig
2018-08-30 17:58 ` [RFC,2/3] " Christoph Hellwig
2018-08-30 22:11 ` [RFC 2/3] " Ezequiel Garcia
2018-08-30 22:11 ` Ezequiel Garcia
2018-08-30 22:11 ` [RFC,2/3] " Ezequiel Garcia
2018-08-31 5:50 ` [RFC 2/3] " Christoph Hellwig
2018-08-31 5:50 ` Christoph Hellwig
2018-08-31 5:50 ` [RFC,2/3] " Christoph Hellwig
2018-08-31 6:51 ` [RFC 2/3] " Tomasz Figa
2018-08-31 6:51 ` Tomasz Figa
2018-08-31 6:51 ` [RFC,2/3] " Tomasz Figa
2018-10-31 1:55 ` [RFC 2/3] " Tomasz Figa
2018-10-31 1:55 ` Tomasz Figa
2018-10-31 1:55 ` [RFC,2/3] " Tomasz Figa
2018-08-30 17:20 ` [RFC 3/3] stk1160: Use non-coherent buffers for USB transfers Ezequiel Garcia
2018-08-30 17:20 ` Ezequiel Garcia
2018-08-30 17:20 ` [RFC,3/3] " Ezequiel Garcia
2018-08-30 17:59 ` Christoph Hellwig [this message]
2018-08-30 17:59 ` [RFC 3/3] " Christoph Hellwig
2018-08-30 17:59 ` [RFC,3/3] " Christoph Hellwig
2018-09-07 8:54 ` [RFC 3/3] " Tomasz Figa
2018-09-07 8:54 ` Tomasz Figa
2018-09-07 8:54 ` [RFC,3/3] " Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180830175937.GB11521@infradead.org \
--to=hch@infradead.org \
--cc=ezequiel@collabora.com \
--cc=keiichiw@chromium.org \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=matwey@sai.msu.ru \
--cc=stern@rowland.harvard.edu \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.