All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] i40e: mark expected switch fall-through
@ 2018-08-30 18:50 Gustavo A. R. Silva
  2018-08-30 21:09   ` [Intel-wired-lan] " Kirsher, Jeffrey T
  0 siblings, 1 reply; 4+ messages in thread
From: Gustavo A. R. Silva @ 2018-08-30 18:50 UTC (permalink / raw)
  To: Jeff Kirsher, David S. Miller
  Cc: intel-wired-lan, netdev, linux-kernel, Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 1473099 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/net/ethernet/intel/i40e/i40e_xsk.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
index 94947a8..a6f50f6 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
@@ -300,9 +300,10 @@ static int i40e_run_xdp_zc(struct i40e_ring *rx_ring, struct xdp_buff *xdp)
 		break;
 	default:
 		bpf_warn_invalid_xdp_action(act);
+		/* fall through */
 	case XDP_ABORTED:
 		trace_xdp_exception(rx_ring->netdev, xdp_prog, act);
-		/* fallthrough -- handle aborts by dropping packet */
+		/* fall through -- handle aborts by dropping packet */
 	case XDP_DROP:
 		result = I40E_XDP_CONSUMED;
 		break;
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* RE: [PATCH] i40e: mark expected switch fall-through
  2018-08-30 18:50 [PATCH] i40e: mark expected switch fall-through Gustavo A. R. Silva
@ 2018-08-30 21:09   ` Kirsher, Jeffrey T
  0 siblings, 0 replies; 4+ messages in thread
From: Kirsher, Jeffrey T @ 2018-08-30 21:09 UTC (permalink / raw)
  To: Gustavo A. R. Silva, David S. Miller
  Cc: intel-wired-lan, netdev, linux-kernel

> -----Original Message-----
> From: Gustavo A. R. Silva [mailto:gustavo@embeddedor.com]
> Sent: Thursday, August 30, 2018 11:50
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; David S. Miller
> <davem@davemloft.net>
> Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; Gustavo A. R. Silva <gustavo@embeddedor.com>
> Subject: [PATCH] i40e: mark expected switch fall-through
> 
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases where
> we are expecting to fall through.
> 
> Addresses-Coverity-ID: 1473099 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_xsk.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

I have picked this up Dave.

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [Intel-wired-lan] [PATCH] i40e: mark expected switch fall-through
@ 2018-08-30 21:09   ` Kirsher, Jeffrey T
  0 siblings, 0 replies; 4+ messages in thread
From: Kirsher, Jeffrey T @ 2018-08-30 21:09 UTC (permalink / raw)
  To: intel-wired-lan

> -----Original Message-----
> From: Gustavo A. R. Silva [mailto:gustavo at embeddedor.com]
> Sent: Thursday, August 30, 2018 11:50
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; David S. Miller
> <davem@davemloft.net>
> Cc: intel-wired-lan at lists.osuosl.org; netdev at vger.kernel.org; linux-
> kernel at vger.kernel.org; Gustavo A. R. Silva <gustavo@embeddedor.com>
> Subject: [PATCH] i40e: mark expected switch fall-through
> 
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases where
> we are expecting to fall through.
> 
> Addresses-Coverity-ID: 1473099 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_xsk.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

I have picked this up Dave.

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] i40e: mark expected switch fall-through
  2018-08-30 21:09   ` [Intel-wired-lan] " Kirsher, Jeffrey T
  (?)
@ 2018-08-31 22:57   ` Gustavo A. R. Silva
  -1 siblings, 0 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2018-08-31 22:57 UTC (permalink / raw)
  To: Kirsher, Jeffrey T, David S. Miller; +Cc: intel-wired-lan, netdev, linux-kernel



On 8/30/18 4:09 PM, Kirsher, Jeffrey T wrote:
>> -----Original Message-----
>> From: Gustavo A. R. Silva [mailto:gustavo@embeddedor.com]
>> Sent: Thursday, August 30, 2018 11:50
>> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; David S. Miller
>> <davem@davemloft.net>
>> Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-
>> kernel@vger.kernel.org; Gustavo A. R. Silva <gustavo@embeddedor.com>
>> Subject: [PATCH] i40e: mark expected switch fall-through
>>
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases where
>> we are expecting to fall through.
>>
>> Addresses-Coverity-ID: 1473099 ("Missing break in switch")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>>  drivers/net/ethernet/intel/i40e/i40e_xsk.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> I have picked this up Dave.
> 

Thanks, Jeffrey.
--
Gustavo

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-31 22:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-30 18:50 [PATCH] i40e: mark expected switch fall-through Gustavo A. R. Silva
2018-08-30 21:09 ` Kirsher, Jeffrey T
2018-08-30 21:09   ` [Intel-wired-lan] " Kirsher, Jeffrey T
2018-08-31 22:57   ` Gustavo A. R. Silva

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.