* [PATCH xf86-video-amdgpu] Do not push the CM_GAMMA_LUT property values in drmmode_crtc_cm_init
@ 2018-08-31 10:45 Michel Dänzer
[not found] ` <20180831104501.6920-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Michel Dänzer @ 2018-08-31 10:45 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
From: Michel Dänzer <michel.daenzer@amd.com>
The crtc->gamma_lut values aren't initialized yet at this point, and
the property values are pushed again from drmmode_setup_colormap
anyway.
Fixes intermittent flicker due to random gamma LUT values during server
startup.
Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
---
src/drmmode_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/drmmode_display.c b/src/drmmode_display.c
index 46be29d07..6ef6a98e2 100644
--- a/src/drmmode_display.c
+++ b/src/drmmode_display.c
@@ -1863,7 +1863,7 @@ static void drmmode_crtc_cm_init(int drm_fd, xf86CrtcPtr crtc)
drmmode_crtc->ctm->matrix[8] = (uint64_t)1 << 32;
/* Push properties to reset properties currently in hardware */
- for (i = 0; i < CM_DEGAMMA_LUT_SIZE; i++) {
+ for (i = 0; i < CM_GAMMA_LUT; i++) {
if (drmmode_crtc_push_cm_prop(crtc, i))
xf86DrvMsg(crtc->scrn->scrnIndex, X_ERROR,
"Failed to initialize color management "
--
2.18.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH xf86-video-amdgpu] Do not push the CM_GAMMA_LUT property values in drmmode_crtc_cm_init
[not found] ` <20180831104501.6920-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org>
@ 2018-09-02 15:01 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2018-09-02 15:01 UTC (permalink / raw)
To: Michel Dänzer; +Cc: amd-gfx list
On Fri, Aug 31, 2018 at 6:45 AM Michel Dänzer <michel@daenzer.net> wrote:
>
> From: Michel Dänzer <michel.daenzer@amd.com>
>
> The crtc->gamma_lut values aren't initialized yet at this point, and
> the property values are pushed again from drmmode_setup_colormap
> anyway.
>
> Fixes intermittent flicker due to random gamma LUT values during server
> startup.
>
> Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> src/drmmode_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/drmmode_display.c b/src/drmmode_display.c
> index 46be29d07..6ef6a98e2 100644
> --- a/src/drmmode_display.c
> +++ b/src/drmmode_display.c
> @@ -1863,7 +1863,7 @@ static void drmmode_crtc_cm_init(int drm_fd, xf86CrtcPtr crtc)
> drmmode_crtc->ctm->matrix[8] = (uint64_t)1 << 32;
>
> /* Push properties to reset properties currently in hardware */
> - for (i = 0; i < CM_DEGAMMA_LUT_SIZE; i++) {
> + for (i = 0; i < CM_GAMMA_LUT; i++) {
> if (drmmode_crtc_push_cm_prop(crtc, i))
> xf86DrvMsg(crtc->scrn->scrnIndex, X_ERROR,
> "Failed to initialize color management "
> --
> 2.18.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-02 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-31 10:45 [PATCH xf86-video-amdgpu] Do not push the CM_GAMMA_LUT property values in drmmode_crtc_cm_init Michel Dänzer
[not found] ` <20180831104501.6920-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org>
2018-09-02 15:01 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.