All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next 1/1] qed: Lower the severity of a dcbx log message.
@ 2018-08-31 11:10 Sudarsana Reddy Kalluru
  2018-09-02  5:22 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Sudarsana Reddy Kalluru @ 2018-08-31 11:10 UTC (permalink / raw)
  To: davem; +Cc: netdev, Michal.Kalderon

Driver displays an error message for each unrecognized dcbx TLV that's
received from the peer or configured on the device. It is observed that
syslog will be flooded with such messages in certain scenarios e.g.,
frequent link-flaps/lldp-transactions. Changing the severity of this
message to verbose level as it's not an error scenario/message.

Signed-off-by: Sudarsana Reddy Kalluru <Sudarsana.Kalluru@cavium.com>
---
 drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
index 6bb76e6..6ce9a76 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_dcbx.c
@@ -253,8 +253,9 @@ static bool qed_dcbx_roce_v2_tlv(u32 app_info_bitmap, u16 proto_id, bool ieee)
 		*type = DCBX_PROTOCOL_ROCE_V2;
 	} else {
 		*type = DCBX_MAX_PROTOCOL_TYPE;
-		DP_ERR(p_hwfn, "No action required, App TLV entry = 0x%x\n",
-		       app_prio_bitmap);
+		DP_VERBOSE(p_hwfn, QED_MSG_DCB,
+			   "No action required, App TLV entry = 0x%x\n",
+			   app_prio_bitmap);
 		return false;
 	}
 
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next 1/1] qed: Lower the severity of a dcbx log message.
  2018-08-31 11:10 [PATCH net-next 1/1] qed: Lower the severity of a dcbx log message Sudarsana Reddy Kalluru
@ 2018-09-02  5:22 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-09-02  5:22 UTC (permalink / raw)
  To: sudarsana.kalluru; +Cc: netdev, Michal.Kalderon

From: Sudarsana Reddy Kalluru <sudarsana.kalluru@cavium.com>
Date: Fri, 31 Aug 2018 04:10:17 -0700

> Driver displays an error message for each unrecognized dcbx TLV that's
> received from the peer or configured on the device. It is observed that
> syslog will be flooded with such messages in certain scenarios e.g.,
> frequent link-flaps/lldp-transactions. Changing the severity of this
> message to verbose level as it's not an error scenario/message.
> 
> Signed-off-by: Sudarsana Reddy Kalluru <Sudarsana.Kalluru@cavium.com>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-09-02  9:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-31 11:10 [PATCH net-next 1/1] qed: Lower the severity of a dcbx log message Sudarsana Reddy Kalluru
2018-09-02  5:22 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.