All of lore.kernel.org
 help / color / mirror / Atom feed
* 4.18.y build failure
@ 2018-08-30 20:09 Dan Rue
  2018-08-31  6:23 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 3+ messages in thread
From: Dan Rue @ 2018-08-30 20:09 UTC (permalink / raw)
  To: Greg Kroah-Hartman, stable; +Cc: Petr Mladek

The following commit in 4.18.y causes the build to fail:
    79764192e1c4 ("printk/nmi: Prevent deadlock when accessing the main log buffer in NMI")

with:
    | kernel/printk/printk_safe.o: In function `vprintk_func':
    | printk_safe.c:(.text+0x51b): undefined reference to `vprintk_store'
    | printk_safe.c:(.text+0x52f): undefined reference to `defer_console_output'

Picking up these from mainline seems to do the trick:
    a338f84dc196 ("printk: Create helper function to queue deferred console handling")
    ba552399954d ("printk: Split the code for storing a message into the log buffer")

Thanks,
Dan

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: 4.18.y build failure
  2018-08-30 20:09 4.18.y build failure Dan Rue
@ 2018-08-31  6:23 ` Krzysztof Kozlowski
  2018-08-31 15:58   ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2018-08-31  6:23 UTC (permalink / raw)
  To: gregkh, stable, pmladek

On Thu, 30 Aug 2018 at 22:09, Dan Rue <dan.rue@linaro.org> wrote:
>
> The following commit in 4.18.y causes the build to fail:
>     79764192e1c4 ("printk/nmi: Prevent deadlock when accessing the main log buffer in NMI")
>
> with:
>     | kernel/printk/printk_safe.o: In function `vprintk_func':
>     | printk_safe.c:(.text+0x51b): undefined reference to `vprintk_store'
>     | printk_safe.c:(.text+0x52f): undefined reference to `defer_console_output'
>
> Picking up these from mainline seems to do the trick:
>     a338f84dc196 ("printk: Create helper function to queue deferred console handling")
>     ba552399954d ("printk: Split the code for storing a message into the log buffer")

v4.14.68-rc1 (200ff75a6b9d9a6d44dd267c3b84c961983f35ac) fails with same error.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: 4.18.y build failure
  2018-08-31  6:23 ` Krzysztof Kozlowski
@ 2018-08-31 15:58   ` Greg KH
  0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2018-08-31 15:58 UTC (permalink / raw)
  To: Krzysztof Kozlowski; +Cc: stable, pmladek

On Fri, Aug 31, 2018 at 08:23:50AM +0200, Krzysztof Kozlowski wrote:
> On Thu, 30 Aug 2018 at 22:09, Dan Rue <dan.rue@linaro.org> wrote:
> >
> > The following commit in 4.18.y causes the build to fail:
> >     79764192e1c4 ("printk/nmi: Prevent deadlock when accessing the main log buffer in NMI")
> >
> > with:
> >     | kernel/printk/printk_safe.o: In function `vprintk_func':
> >     | printk_safe.c:(.text+0x51b): undefined reference to `vprintk_store'
> >     | printk_safe.c:(.text+0x52f): undefined reference to `defer_console_output'
> >
> > Picking up these from mainline seems to do the trick:
> >     a338f84dc196 ("printk: Create helper function to queue deferred console handling")
> >     ba552399954d ("printk: Split the code for storing a message into the log buffer")
> 
> v4.14.68-rc1 (200ff75a6b9d9a6d44dd267c3b84c961983f35ac) fails with same error.

Sorry, I'll fix this up, my fault.

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-08-31 20:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-30 20:09 4.18.y build failure Dan Rue
2018-08-31  6:23 ` Krzysztof Kozlowski
2018-08-31 15:58   ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.