* Re: xfs_scrub_all warning
[not found] <974f65da-60f9-55aa-2e27-3fe9abb64f97@bodenbinder.de>
@ 2018-08-31 16:45 ` Darrick J. Wong
2018-09-01 10:45 ` Matthias Bodenbinder
0 siblings, 1 reply; 3+ messages in thread
From: Darrick J. Wong @ 2018-08-31 16:45 UTC (permalink / raw)
To: Matthias Bodenbinder; +Cc: xfs
[add linux-xfs to cc]
On Fri, Aug 31, 2018 at 07:31:25AM +0200, Matthias Bodenbinder wrote:
> Hello Darrick,
>
> you are named as maintainer in the xfs_scrub_all python script which is
> coming with Manjaro Linux. Therefore I am writing to you about a
> "cosmetic" issue with invalid unit names.
>
> I have / and /home setup as XFS. When I run the script I get the
> following output:
>
> 1# xfs_scrub_all
> Scrubbing /home...
> Invalid unit name "xfs_scrub@/home" was escaped as "xfs_scrub@-home"
> (maybe you should use systemd-escape?)
Oh, lovely, systemd changed their escaping rules again...
> Starting Online XFS Metadata Check for /home...
> EXPERIMENTAL xfs_scrub program in use! Use at your own risk!
> Info: AG 1 superblock: Optimization is possible.
> Info: AG 2 superblock: Optimization is possible.
> Info: AG 3 superblock: Optimization is possible.
> Scrubbing /home done, (err=0)
> Scrubbing /...
> Invalid unit name "xfs_scrub@/" was escaped as "xfs_scrub@-" (maybe you
> should use systemd-escape?)
> Started Online XFS Metadata Check for /home.
> Scrubbing / done, (err=0)
>
> Can you fix that?
I think so. If you remove the lines:
if '-' not in path:
return path
from systemd_escape() in /sbin/xfs_scrub_all, do the warnings go away?
Does scrub still work afterwards?
--D
>
> Thanks
>
> Matthias
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: xfs_scrub_all warning
2018-08-31 16:45 ` xfs_scrub_all warning Darrick J. Wong
@ 2018-09-01 10:45 ` Matthias Bodenbinder
2018-10-01 17:08 ` Darrick J. Wong
0 siblings, 1 reply; 3+ messages in thread
From: Matthias Bodenbinder @ 2018-09-01 10:45 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: xfs
Am 31.08.18 um 18:45 schrieb Darrick J. Wong:
> I think so. If you remove the lines:
>
> if '-' not in path:
> return path
>
> from systemd_escape() in /sbin/xfs_scrub_all, do the warnings go away?
> Does scrub still work afterwards?
That does work:
8# ./my-xfs_scrub_all
Scrubbing /home...
Failed to add filter for units: No data available
Scrubbing /home done, (err=0)
But what is this "Failed to add filter..." message about?
Thanks for your help
Matthias
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: xfs_scrub_all warning
2018-09-01 10:45 ` Matthias Bodenbinder
@ 2018-10-01 17:08 ` Darrick J. Wong
0 siblings, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2018-10-01 17:08 UTC (permalink / raw)
To: Matthias Bodenbinder; +Cc: xfs
On Sat, Sep 01, 2018 at 12:45:54PM +0200, Matthias Bodenbinder wrote:
> Am 31.08.18 um 18:45 schrieb Darrick J. Wong:
> > I think so. If you remove the lines:
> >
> > if '-' not in path:
> > return path
> >
> > from systemd_escape() in /sbin/xfs_scrub_all, do the warnings go away?
> > Does scrub still work afterwards?
>
> That does work:
>
> 8# ./my-xfs_scrub_all
> Scrubbing /home...
> Failed to add filter for units: No data available
> Scrubbing /home done, (err=0)
>
>
> But what is this "Failed to add filter..." message about?
I /think/ that's journalctl failing to construct a filter for
'xfs_scrub@*' to display whatever output comes out of running the
xfs_scrub jobs. I'll look further into it, but for now I've posted the
fix to xfs_scrub_all to shut up the escaping complaints.
--D
> Thanks for your help
> Matthias
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-01 23:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <974f65da-60f9-55aa-2e27-3fe9abb64f97@bodenbinder.de>
2018-08-31 16:45 ` xfs_scrub_all warning Darrick J. Wong
2018-09-01 10:45 ` Matthias Bodenbinder
2018-10-01 17:08 ` Darrick J. Wong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.