* [PATCH][v2] arm64: dts: remove big-endian filed from IFC controller
@ 2018-08-29 3:27 ` Prabhakar Kushwaha
0 siblings, 0 replies; 6+ messages in thread
From: Prabhakar Kushwaha @ 2018-08-29 3:27 UTC (permalink / raw)
To: devicetree, robh, mark.rutland, shawnguo
Cc: Prabhakar Kushwaha, linux-arm-kernel, leoyang.li
As per IFC binding, Absence of "little-endian" field causes registers
access in big-endian mode.
So no need to set explicit big-endian field IFC node for LS1043A and
LS1046A.
Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
---
Changes for v2: Incorporated Leo's comments
- Remove new line between copyrights
arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 2 +-
arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
index b9f5d2ff4ff2..68af84a8ade8 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
@@ -3,6 +3,7 @@
* Device Tree Include file for Freescale Layerscape-1043A family SoC.
*
* Copyright 2014-2015 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
*
* Mingkai Hu <Mingkai.hu@freescale.com>
*/
@@ -280,7 +281,6 @@
ifc: ifc@1530000 {
compatible = "fsl,ifc", "simple-bus";
reg = <0x0 0x1530000 0x0 0x10000>;
- big-endian;
interrupts = <0 43 0x4>;
};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index 65ce1c3cb568..ae4ca865131b 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
@@ -3,6 +3,7 @@
* Device Tree Include file for Freescale Layerscape-1046A family SoC.
*
* Copyright 2016 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
*
* Mingkai Hu <mingkai.hu@nxp.com>
*/
@@ -198,7 +199,6 @@
ifc: ifc@1530000 {
compatible = "fsl,ifc", "simple-bus";
reg = <0x0 0x1530000 0x0 0x10000>;
- big-endian;
interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
};
--
2.14.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH][v2] arm64: dts: remove big-endian filed from IFC controller
@ 2018-08-29 3:27 ` Prabhakar Kushwaha
0 siblings, 0 replies; 6+ messages in thread
From: Prabhakar Kushwaha @ 2018-08-29 3:27 UTC (permalink / raw)
To: linux-arm-kernel
As per IFC binding, Absence of "little-endian" field causes registers
access in big-endian mode.
So no need to set explicit big-endian field IFC node for LS1043A and
LS1046A.
Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
---
Changes for v2: Incorporated Leo's comments
- Remove new line between copyrights
arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 2 +-
arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
index b9f5d2ff4ff2..68af84a8ade8 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
@@ -3,6 +3,7 @@
* Device Tree Include file for Freescale Layerscape-1043A family SoC.
*
* Copyright 2014-2015 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
*
* Mingkai Hu <Mingkai.hu@freescale.com>
*/
@@ -280,7 +281,6 @@
ifc: ifc at 1530000 {
compatible = "fsl,ifc", "simple-bus";
reg = <0x0 0x1530000 0x0 0x10000>;
- big-endian;
interrupts = <0 43 0x4>;
};
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index 65ce1c3cb568..ae4ca865131b 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
@@ -3,6 +3,7 @@
* Device Tree Include file for Freescale Layerscape-1046A family SoC.
*
* Copyright 2016 Freescale Semiconductor, Inc.
+ * Copyright 2018 NXP
*
* Mingkai Hu <mingkai.hu@nxp.com>
*/
@@ -198,7 +199,6 @@
ifc: ifc at 1530000 {
compatible = "fsl,ifc", "simple-bus";
reg = <0x0 0x1530000 0x0 0x10000>;
- big-endian;
interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
};
--
2.14.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH][v2] arm64: dts: remove big-endian filed from IFC controller
2018-08-29 3:27 ` Prabhakar Kushwaha
@ 2018-08-30 17:09 ` Li Yang
-1 siblings, 0 replies; 6+ messages in thread
From: Li Yang @ 2018-08-30 17:09 UTC (permalink / raw)
To: Prabhakar Kushwaha
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Rob Herring
On Tue, Aug 28, 2018 at 10:28 PM Prabhakar Kushwaha
<prabhakar.kushwaha@nxp.com> wrote:
>
> As per IFC binding, Absence of "little-endian" field causes registers
> access in big-endian mode.
> So no need to set explicit big-endian field IFC node for LS1043A and
> LS1046A.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
Acked-by: Li Yang <leoyang.li@nxp.com>
> ---
> Changes for v2: Incorporated Leo's comments
> - Remove new line between copyrights
>
> arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> index b9f5d2ff4ff2..68af84a8ade8 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> @@ -3,6 +3,7 @@
> * Device Tree Include file for Freescale Layerscape-1043A family SoC.
> *
> * Copyright 2014-2015 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
> *
> * Mingkai Hu <Mingkai.hu@freescale.com>
> */
> @@ -280,7 +281,6 @@
> ifc: ifc@1530000 {
> compatible = "fsl,ifc", "simple-bus";
> reg = <0x0 0x1530000 0x0 0x10000>;
> - big-endian;
> interrupts = <0 43 0x4>;
> };
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index 65ce1c3cb568..ae4ca865131b 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -3,6 +3,7 @@
> * Device Tree Include file for Freescale Layerscape-1046A family SoC.
> *
> * Copyright 2016 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
> *
> * Mingkai Hu <mingkai.hu@nxp.com>
> */
> @@ -198,7 +199,6 @@
> ifc: ifc@1530000 {
> compatible = "fsl,ifc", "simple-bus";
> reg = <0x0 0x1530000 0x0 0x10000>;
> - big-endian;
> interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH][v2] arm64: dts: remove big-endian filed from IFC controller
@ 2018-08-30 17:09 ` Li Yang
0 siblings, 0 replies; 6+ messages in thread
From: Li Yang @ 2018-08-30 17:09 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Aug 28, 2018 at 10:28 PM Prabhakar Kushwaha
<prabhakar.kushwaha@nxp.com> wrote:
>
> As per IFC binding, Absence of "little-endian" field causes registers
> access in big-endian mode.
> So no need to set explicit big-endian field IFC node for LS1043A and
> LS1046A.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
Acked-by: Li Yang <leoyang.li@nxp.com>
> ---
> Changes for v2: Incorporated Leo's comments
> - Remove new line between copyrights
>
> arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> index b9f5d2ff4ff2..68af84a8ade8 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> @@ -3,6 +3,7 @@
> * Device Tree Include file for Freescale Layerscape-1043A family SoC.
> *
> * Copyright 2014-2015 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
> *
> * Mingkai Hu <Mingkai.hu@freescale.com>
> */
> @@ -280,7 +281,6 @@
> ifc: ifc at 1530000 {
> compatible = "fsl,ifc", "simple-bus";
> reg = <0x0 0x1530000 0x0 0x10000>;
> - big-endian;
> interrupts = <0 43 0x4>;
> };
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index 65ce1c3cb568..ae4ca865131b 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -3,6 +3,7 @@
> * Device Tree Include file for Freescale Layerscape-1046A family SoC.
> *
> * Copyright 2016 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
> *
> * Mingkai Hu <mingkai.hu@nxp.com>
> */
> @@ -198,7 +199,6 @@
> ifc: ifc at 1530000 {
> compatible = "fsl,ifc", "simple-bus";
> reg = <0x0 0x1530000 0x0 0x10000>;
> - big-endian;
> interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH][v2] arm64: dts: remove big-endian filed from IFC controller
2018-08-29 3:27 ` Prabhakar Kushwaha
@ 2018-09-03 1:01 ` Shawn Guo
-1 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2018-09-03 1:01 UTC (permalink / raw)
To: Prabhakar Kushwaha
Cc: mark.rutland, devicetree, leoyang.li, linux-arm-kernel, robh
On Wed, Aug 29, 2018 at 08:57:49AM +0530, Prabhakar Kushwaha wrote:
> As per IFC binding, Absence of "little-endian" field causes registers
> access in big-endian mode.
> So no need to set explicit big-endian field IFC node for LS1043A and
> LS1046A.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
s/filed/flied in subject, and having 'fsl' in subject prefix might be
better, so that it's clear this is a fsl specific changes.
I fixed them up and applied the patch.
Shawn
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH][v2] arm64: dts: remove big-endian filed from IFC controller
@ 2018-09-03 1:01 ` Shawn Guo
0 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2018-09-03 1:01 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Aug 29, 2018 at 08:57:49AM +0530, Prabhakar Kushwaha wrote:
> As per IFC binding, Absence of "little-endian" field causes registers
> access in big-endian mode.
> So no need to set explicit big-endian field IFC node for LS1043A and
> LS1046A.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
s/filed/flied in subject, and having 'fsl' in subject prefix might be
better, so that it's clear this is a fsl specific changes.
I fixed them up and applied the patch.
Shawn
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-09-03 1:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-29 3:27 [PATCH][v2] arm64: dts: remove big-endian filed from IFC controller Prabhakar Kushwaha
2018-08-29 3:27 ` Prabhakar Kushwaha
2018-08-30 17:09 ` Li Yang
2018-08-30 17:09 ` Li Yang
2018-09-03 1:01 ` Shawn Guo
2018-09-03 1:01 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.