All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] arm64: dts: dwc3: Add description of 'configure-gfladj'
@ 2018-08-29  7:33 ` yinbo.zhu
  0 siblings, 0 replies; 12+ messages in thread
From: Yinbo Zhu @ 2018-08-29  7:33 UTC (permalink / raw)
  To: yinbo.zhu, Shawn Guo, Rob Herring, Mark Rutland
  Cc: xiaobo.xie, Ran Wang, Greg Kroah-Hartman, linux-usb, devicetree,
	linux-kernel, festevam

This patch is to add description of 'configure-gfladj' to binding
so that configuring devicetree

Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
---
 Documentation/devicetree/bindings/usb/dwc3.txt |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
index 3e4c38b..40c6568 100644
--- a/Documentation/devicetree/bindings/usb/dwc3.txt
+++ b/Documentation/devicetree/bindings/usb/dwc3.txt
@@ -101,6 +101,7 @@ Optional properties:
 			When just one value, which means INCRX burst mode enabled. When
 			more than one value, which means undefined length INCR burst type
 			enabled. The values can be 1, 4, 8, 16, 32, 64, 128 and 256.
+ - configure-gfladj: determine whether frame length adjustment is required or not.
 
  - in addition all properties from usb-xhci.txt from the current directory are
    supported as well
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [v1] arm64: dts: dwc3: Add description of 'configure-gfladj'
@ 2018-08-29  7:33 ` yinbo.zhu
  0 siblings, 0 replies; 12+ messages in thread
From: yinbo.zhu @ 2018-08-29  7:33 UTC (permalink / raw)
  To: yinbo.zhu, Shawn Guo, Rob Herring, Mark Rutland
  Cc: xiaobo.xie, Ran Wang, Greg Kroah-Hartman, linux-usb, devicetree,
	linux-kernel, festevam

This patch is to add description of 'configure-gfladj' to binding
so that configuring devicetree

Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
---
 Documentation/devicetree/bindings/usb/dwc3.txt |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
index 3e4c38b..40c6568 100644
--- a/Documentation/devicetree/bindings/usb/dwc3.txt
+++ b/Documentation/devicetree/bindings/usb/dwc3.txt
@@ -101,6 +101,7 @@ Optional properties:
 			When just one value, which means INCRX burst mode enabled. When
 			more than one value, which means undefined length INCR burst type
 			enabled. The values can be 1, 4, 8, 16, 32, 64, 128 and 256.
+ - configure-gfladj: determine whether frame length adjustment is required or not.
 
  - in addition all properties from usb-xhci.txt from the current directory are
    supported as well

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH v1] arm64: dts: dwc3: Add description of 'configure-gfladj'
@ 2018-09-03  1:19   ` Shawn Guo
  0 siblings, 0 replies; 12+ messages in thread
From: Shawn Guo @ 2018-09-03  1:19 UTC (permalink / raw)
  To: Yinbo Zhu
  Cc: Rob Herring, Mark Rutland, xiaobo.xie, Ran Wang,
	Greg Kroah-Hartman, linux-usb, devicetree, linux-kernel,
	festevam

On Wed, Aug 29, 2018 at 03:33:24PM +0800, Yinbo Zhu wrote:
> This patch is to add description of 'configure-gfladj' to binding
> so that configuring devicetree
> 
> Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>

Ah, okay.  You just started documenting the binding.  So please send me
dts patch only after the corresponding bindings and driver code are
accepted.

Shawn

> ---
>  Documentation/devicetree/bindings/usb/dwc3.txt |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
> index 3e4c38b..40c6568 100644
> --- a/Documentation/devicetree/bindings/usb/dwc3.txt
> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
> @@ -101,6 +101,7 @@ Optional properties:
>  			When just one value, which means INCRX burst mode enabled. When
>  			more than one value, which means undefined length INCR burst type
>  			enabled. The values can be 1, 4, 8, 16, 32, 64, 128 and 256.
> + - configure-gfladj: determine whether frame length adjustment is required or not.
>  
>   - in addition all properties from usb-xhci.txt from the current directory are
>     supported as well
> -- 
> 1.7.1
> 

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [v1] arm64: dts: dwc3: Add description of 'configure-gfladj'
@ 2018-09-03  1:19   ` Shawn Guo
  0 siblings, 0 replies; 12+ messages in thread
From: Shawn Guo @ 2018-09-03  1:19 UTC (permalink / raw)
  To: Yinbo Zhu
  Cc: Rob Herring, Mark Rutland, xiaobo.xie, Ran Wang,
	Greg Kroah-Hartman, linux-usb, devicetree, linux-kernel,
	festevam

On Wed, Aug 29, 2018 at 03:33:24PM +0800, Yinbo Zhu wrote:
> This patch is to add description of 'configure-gfladj' to binding
> so that configuring devicetree
> 
> Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>

Ah, okay.  You just started documenting the binding.  So please send me
dts patch only after the corresponding bindings and driver code are
accepted.

Shawn

> ---
>  Documentation/devicetree/bindings/usb/dwc3.txt |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
> index 3e4c38b..40c6568 100644
> --- a/Documentation/devicetree/bindings/usb/dwc3.txt
> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
> @@ -101,6 +101,7 @@ Optional properties:
>  			When just one value, which means INCRX burst mode enabled. When
>  			more than one value, which means undefined length INCR burst type
>  			enabled. The values can be 1, 4, 8, 16, 32, 64, 128 and 256.
> + - configure-gfladj: determine whether frame length adjustment is required or not.
>  
>   - in addition all properties from usb-xhci.txt from the current directory are
>     supported as well
> -- 
> 1.7.1
>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v1] arm64: dts: dwc3: Add description of 'configure-gfladj'
  2018-08-29  7:33 ` [v1] " yinbo.zhu
  (?)
@ 2018-09-05 20:08   ` Li Yang
  -1 siblings, 0 replies; 12+ messages in thread
From: Li Yang @ 2018-09-05 20:08 UTC (permalink / raw)
  To: Yinbo Zhu
  Cc: Shawn Guo, Rob Herring, Mark Rutland, Xiaobo Xie, Ran Wang,
	Greg Kroah-Hartman, linux-usb,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, lkml,
	Fabio Estevam

On Wed, Aug 29, 2018 at 2:38 AM Yinbo Zhu <yinbo.zhu@nxp.com> wrote:
>
> This patch is to add description of 'configure-gfladj' to binding
> so that configuring devicetree
>
> Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>

This patch should be sent to the DWC3 driver maintainer to review and
probably merged through usb tree.  You shouldn't use the arm64: dts:
prefix for this patch either.

> ---
>  Documentation/devicetree/bindings/usb/dwc3.txt |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
> index 3e4c38b..40c6568 100644
> --- a/Documentation/devicetree/bindings/usb/dwc3.txt
> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
> @@ -101,6 +101,7 @@ Optional properties:
>                         When just one value, which means INCRX burst mode enabled. When
>                         more than one value, which means undefined length INCR burst type
>                         enabled. The values can be 1, 4, 8, 16, 32, 64, 128 and 256.
> + - configure-gfladj: determine whether frame length adjustment is required or not.
>
>   - in addition all properties from usb-xhci.txt from the current directory are
>     supported as well
> --
> 1.7.1
>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v1] arm64: dts: dwc3: Add description of 'configure-gfladj'
@ 2018-09-05 20:08   ` Li Yang
  0 siblings, 0 replies; 12+ messages in thread
From: Li Yang @ 2018-09-05 20:08 UTC (permalink / raw)
  To: Yinbo Zhu
  Cc: Shawn Guo, Rob Herring, Mark Rutland, Xiaobo Xie, Ran Wang,
	Greg Kroah-Hartman, linux-usb,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, lkml,
	Fabio Estevam

On Wed, Aug 29, 2018 at 2:38 AM Yinbo Zhu <yinbo.zhu@nxp.com> wrote:
>
> This patch is to add description of 'configure-gfladj' to binding
> so that configuring devicetree
>
> Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>

This patch should be sent to the DWC3 driver maintainer to review and
probably merged through usb tree.  You shouldn't use the arm64: dts:
prefix for this patch either.

> ---
>  Documentation/devicetree/bindings/usb/dwc3.txt |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
> index 3e4c38b..40c6568 100644
> --- a/Documentation/devicetree/bindings/usb/dwc3.txt
> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
> @@ -101,6 +101,7 @@ Optional properties:
>                         When just one value, which means INCRX burst mode enabled. When
>                         more than one value, which means undefined length INCR burst type
>                         enabled. The values can be 1, 4, 8, 16, 32, 64, 128 and 256.
> + - configure-gfladj: determine whether frame length adjustment is required or not.
>
>   - in addition all properties from usb-xhci.txt from the current directory are
>     supported as well
> --
> 1.7.1
>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [v1] arm64: dts: dwc3: Add description of 'configure-gfladj'
@ 2018-09-05 20:08   ` Li Yang
  0 siblings, 0 replies; 12+ messages in thread
From: Li Yang @ 2018-09-05 20:08 UTC (permalink / raw)
  To: Yinbo Zhu
  Cc: Shawn Guo, Rob Herring, Mark Rutland, Xiaobo Xie, Ran Wang,
	Greg Kroah-Hartman, linux-usb,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, lkml,
	Fabio Estevam

On Wed, Aug 29, 2018 at 2:38 AM Yinbo Zhu <yinbo.zhu@nxp.com> wrote:
>
> This patch is to add description of 'configure-gfladj' to binding
> so that configuring devicetree
>
> Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>

This patch should be sent to the DWC3 driver maintainer to review and
probably merged through usb tree.  You shouldn't use the arm64: dts:
prefix for this patch either.

> ---
>  Documentation/devicetree/bindings/usb/dwc3.txt |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
> index 3e4c38b..40c6568 100644
> --- a/Documentation/devicetree/bindings/usb/dwc3.txt
> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
> @@ -101,6 +101,7 @@ Optional properties:
>                         When just one value, which means INCRX burst mode enabled. When
>                         more than one value, which means undefined length INCR burst type
>                         enabled. The values can be 1, 4, 8, 16, 32, 64, 128 and 256.
> + - configure-gfladj: determine whether frame length adjustment is required or not.
>
>   - in addition all properties from usb-xhci.txt from the current directory are
>     supported as well
> --
> 1.7.1
>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v1] arm64: dts: dwc3: Add description of 'configure-gfladj'
  2018-08-29  7:33 ` [v1] " yinbo.zhu
  (?)
@ 2018-09-10  5:45   ` Felipe Balbi
  -1 siblings, 0 replies; 12+ messages in thread
From: Felipe Balbi @ 2018-09-10  5:45 UTC (permalink / raw)
  To: Yinbo Zhu, yinbo.zhu, Shawn Guo, Rob Herring, Mark Rutland
  Cc: xiaobo.xie, Ran Wang, Greg Kroah-Hartman, linux-usb, devicetree,
	linux-kernel, festevam

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

Yinbo Zhu <yinbo.zhu@nxp.com> writes:

> This patch is to add description of 'configure-gfladj' to binding
> so that configuring devicetree

commit log looks incomplete.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v1] arm64: dts: dwc3: Add description of 'configure-gfladj'
@ 2018-09-10  5:45   ` Felipe Balbi
  0 siblings, 0 replies; 12+ messages in thread
From: Felipe Balbi @ 2018-09-10  5:45 UTC (permalink / raw)
  To: Yinbo Zhu
  Cc: xiaobo.xie, Ran Wang, Greg Kroah-Hartman, linux-usb, devicetree,
	linux-kernel, festevam

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

Yinbo Zhu <yinbo.zhu@nxp.com> writes:

> This patch is to add description of 'configure-gfladj' to binding
> so that configuring devicetree

commit log looks incomplete.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [v1] arm64: dts: dwc3: Add description of 'configure-gfladj'
@ 2018-09-10  5:45   ` Felipe Balbi
  0 siblings, 0 replies; 12+ messages in thread
From: Felipe Balbi @ 2018-09-10  5:45 UTC (permalink / raw)
  To: Yinbo Zhu
  Cc: xiaobo.xie, Ran Wang, Greg Kroah-Hartman, linux-usb, devicetree,
	linux-kernel, festevam

Yinbo Zhu <yinbo.zhu@nxp.com> writes:

> This patch is to add description of 'configure-gfladj' to binding
> so that configuring devicetree

commit log looks incomplete.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v1] arm64: dts: dwc3: Add description of 'configure-gfladj'
@ 2018-09-25 16:48   ` Rob Herring
  0 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2018-09-25 16:48 UTC (permalink / raw)
  To: Yinbo Zhu
  Cc: Shawn Guo, Mark Rutland, xiaobo.xie, Ran Wang,
	Greg Kroah-Hartman, linux-usb, devicetree, linux-kernel,
	festevam

On Wed, Aug 29, 2018 at 03:33:24PM +0800, Yinbo Zhu wrote:
> This patch is to add description of 'configure-gfladj' to binding
> so that configuring devicetree

Not a complete sentence.

The subject should be: "dt-bindings: usb: ..."
> 
> Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
> ---
>  Documentation/devicetree/bindings/usb/dwc3.txt |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
> index 3e4c38b..40c6568 100644
> --- a/Documentation/devicetree/bindings/usb/dwc3.txt
> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
> @@ -101,6 +101,7 @@ Optional properties:
>  			When just one value, which means INCRX burst mode enabled. When
>  			more than one value, which means undefined length INCR burst type
>  			enabled. The values can be 1, 4, 8, 16, 32, 64, 128 and 256.
> + - configure-gfladj: determine whether frame length adjustment is required or not.

Needs a vendor prefix.

What's the type? bool?

What determines if this is needed. If fixed for an SoC or IP version, 
then the compatible string should imply this.

Rob

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [v1] arm64: dts: dwc3: Add description of 'configure-gfladj'
@ 2018-09-25 16:48   ` Rob Herring
  0 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2018-09-25 16:48 UTC (permalink / raw)
  To: Yinbo Zhu
  Cc: Shawn Guo, Mark Rutland, xiaobo.xie, Ran Wang,
	Greg Kroah-Hartman, linux-usb, devicetree, linux-kernel,
	festevam

On Wed, Aug 29, 2018 at 03:33:24PM +0800, Yinbo Zhu wrote:
> This patch is to add description of 'configure-gfladj' to binding
> so that configuring devicetree

Not a complete sentence.

The subject should be: "dt-bindings: usb: ..."
> 
> Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
> ---
>  Documentation/devicetree/bindings/usb/dwc3.txt |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
> index 3e4c38b..40c6568 100644
> --- a/Documentation/devicetree/bindings/usb/dwc3.txt
> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
> @@ -101,6 +101,7 @@ Optional properties:
>  			When just one value, which means INCRX burst mode enabled. When
>  			more than one value, which means undefined length INCR burst type
>  			enabled. The values can be 1, 4, 8, 16, 32, 64, 128 and 256.
> + - configure-gfladj: determine whether frame length adjustment is required or not.

Needs a vendor prefix.

What's the type? bool?

What determines if this is needed. If fixed for an SoC or IP version, 
then the compatible string should imply this.

Rob

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2018-09-25 16:48 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-29  7:33 [PATCH v1] arm64: dts: dwc3: Add description of 'configure-gfladj' Yinbo Zhu
2018-08-29  7:33 ` [v1] " yinbo.zhu
2018-09-03  1:19 ` [PATCH v1] " Shawn Guo
2018-09-03  1:19   ` [v1] " Shawn Guo
2018-09-05 20:08 ` [PATCH v1] " Li Yang
2018-09-05 20:08   ` [v1] " Li Yang
2018-09-05 20:08   ` [PATCH v1] " Li Yang
2018-09-10  5:45 ` Felipe Balbi
2018-09-10  5:45   ` [v1] " Felipe Balbi
2018-09-10  5:45   ` [PATCH v1] " Felipe Balbi
2018-09-25 16:48 ` Rob Herring
2018-09-25 16:48   ` [v1] " Rob Herring

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.