From: Shawn Guo <shawnguo@kernel.org> To: Yogesh Gaur <yogeshnarayan.gaur@nxp.com> Cc: linux-mtd@lists.infradead.org, boris.brezillon@bootlin.com, marek.vasut@gmail.com, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, mark.rutland@arm.com, robh@kernel.org, linux-kernel@vger.kernel.org, frieder.schrempf@exceet.de, computersforpeace@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 5/7] arm64: dts: lx2160a: add fspi node property Date: Mon, 3 Sep 2018 11:01:12 +0800 [thread overview] Message-ID: <20180903030110.GI3850@dragon> (raw) In-Reply-To: <1535711404-29528-6-git-send-email-yogeshnarayan.gaur@nxp.com> On Fri, Aug 31, 2018 at 04:00:02PM +0530, Yogesh Gaur wrote: > Add fspi node property for LX2160A SoC for FlexSPI driver. > Property added for the FlexSPI controller and for the connected > slave device for the LX2160ARDB target. > This is having two SPI-NOR flash device, mt35xu512aba, connected > at CS0 and CS1. > > Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com> > --- > arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 21 +++++++++++++++++++++ > arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 12 ++++++++++++ > 2 files changed, 33 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > index 70fad20..3646315 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > @@ -32,6 +32,27 @@ > status = "okay"; > }; > > +&fspi { > + status = "okay"; Have a newline between property and child node. > + flash0: mt35xu512aba@0 { Generic name for node, and specific name for label. > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "m25p80"; Please take a look at bindings doc jedec,spi-nor.txt on how compatible should be written. > + m25p,fast-read; > + spi-max-frequency = <20000000>; > + reg = <0>; > + }; > + > + flash1: mt35xu512aba@1 { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "m25p80"; > + m25p,fast-read; > + spi-max-frequency = <20000000>; > + reg = <1>; > + }; > +}; > + > &i2c0 { > status = "okay"; > pca9547@77 { > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > index e35e494..031eb26 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > @@ -568,5 +568,17 @@ > timeout-sec = <30>; > }; > > + fspi: flexspi@20c0000 { > + status = "disabled"; We conventionally put 'status' line at the end of property list. Shawn > + compatible = "nxp,lx2160a-fspi"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x0 0x20c0000 0x0 0x10000>, > + <0x0 0x20000000 0x0 0x10000000>; > + reg-names = "fspi_base", "fspi_mmap"; > + interrupts = <0 25 0x4>; /* Level high type */ > + clocks = <&clockgen 4 3>, <&clockgen 4 3>; > + clock-names = "fspi_en", "fspi"; > + }; > }; > }; > -- > 2.7.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: shawnguo@kernel.org (Shawn Guo) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 5/7] arm64: dts: lx2160a: add fspi node property Date: Mon, 3 Sep 2018 11:01:12 +0800 [thread overview] Message-ID: <20180903030110.GI3850@dragon> (raw) In-Reply-To: <1535711404-29528-6-git-send-email-yogeshnarayan.gaur@nxp.com> On Fri, Aug 31, 2018 at 04:00:02PM +0530, Yogesh Gaur wrote: > Add fspi node property for LX2160A SoC for FlexSPI driver. > Property added for the FlexSPI controller and for the connected > slave device for the LX2160ARDB target. > This is having two SPI-NOR flash device, mt35xu512aba, connected > at CS0 and CS1. > > Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com> > --- > arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 21 +++++++++++++++++++++ > arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 12 ++++++++++++ > 2 files changed, 33 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > index 70fad20..3646315 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > @@ -32,6 +32,27 @@ > status = "okay"; > }; > > +&fspi { > + status = "okay"; Have a newline between property and child node. > + flash0: mt35xu512aba at 0 { Generic name for node, and specific name for label. > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "m25p80"; Please take a look at bindings doc jedec,spi-nor.txt on how compatible should be written. > + m25p,fast-read; > + spi-max-frequency = <20000000>; > + reg = <0>; > + }; > + > + flash1: mt35xu512aba at 1 { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "m25p80"; > + m25p,fast-read; > + spi-max-frequency = <20000000>; > + reg = <1>; > + }; > +}; > + > &i2c0 { > status = "okay"; > pca9547 at 77 { > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > index e35e494..031eb26 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > @@ -568,5 +568,17 @@ > timeout-sec = <30>; > }; > > + fspi: flexspi at 20c0000 { > + status = "disabled"; We conventionally put 'status' line at the end of property list. Shawn > + compatible = "nxp,lx2160a-fspi"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x0 0x20c0000 0x0 0x10000>, > + <0x0 0x20000000 0x0 0x10000000>; > + reg-names = "fspi_base", "fspi_mmap"; > + interrupts = <0 25 0x4>; /* Level high type */ > + clocks = <&clockgen 4 3>, <&clockgen 4 3>; > + clock-names = "fspi_en", "fspi"; > + }; > }; > }; > -- > 2.7.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-09-03 3:02 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-31 10:29 [PATCH 0/7] spi: spi-mem: Add a driver for NXP FlexSPI controller Yogesh Gaur 2018-08-31 10:29 ` Yogesh Gaur 2018-08-31 10:29 ` [PATCH 1/7] spi: add slave device size in spi_device struct Yogesh Gaur 2018-08-31 10:29 ` Yogesh Gaur 2018-08-31 11:41 ` Geert Uytterhoeven 2018-08-31 11:41 ` Geert Uytterhoeven 2018-08-31 11:41 ` Geert Uytterhoeven 2018-08-31 11:58 ` Lothar Waßmann 2018-08-31 11:58 ` Lothar Waßmann 2018-09-03 4:47 ` Yogesh Narayan Gaur 2018-09-03 4:47 ` Yogesh Narayan Gaur 2018-09-03 4:47 ` Yogesh Narayan Gaur 2018-09-03 8:36 ` Boris Brezillon 2018-09-03 8:36 ` Boris Brezillon 2018-08-31 10:29 ` [PATCH 2/7] spi: add flags for octal I/O data transfer Yogesh Gaur 2018-08-31 10:29 ` Yogesh Gaur 2018-08-31 10:30 ` [PATCH 3/7] spi: spi-mem: Add a driver for NXP FlexSPI controller Yogesh Gaur 2018-08-31 10:30 ` Yogesh Gaur 2018-09-04 14:58 ` Boris Brezillon 2018-09-04 14:58 ` Boris Brezillon 2018-09-05 10:07 ` Yogesh Narayan Gaur 2018-09-05 10:07 ` Yogesh Narayan Gaur 2018-09-05 10:07 ` Yogesh Narayan Gaur 2018-09-06 8:26 ` Frieder Schrempf 2018-09-06 8:26 ` Frieder Schrempf 2018-09-06 8:26 ` Frieder Schrempf 2018-09-06 8:26 ` Frieder Schrempf 2018-09-06 11:35 ` Yogesh Narayan Gaur 2018-09-06 11:35 ` Yogesh Narayan Gaur 2018-09-06 11:35 ` Yogesh Narayan Gaur 2018-09-06 11:43 ` Boris Brezillon 2018-09-06 11:43 ` Boris Brezillon 2018-09-06 11:43 ` Boris Brezillon 2018-09-06 12:23 ` Yogesh Narayan Gaur 2018-09-06 12:23 ` Yogesh Narayan Gaur 2018-09-06 12:23 ` Yogesh Narayan Gaur 2018-08-31 10:30 ` [PATCH 4/7] dt-bindings: spi: add binding file for NXP FlexSPI driver Yogesh Gaur 2018-08-31 10:30 ` Yogesh Gaur 2018-09-03 9:54 ` Prabhakar Kushwaha 2018-09-03 9:54 ` Prabhakar Kushwaha 2018-09-03 9:54 ` Prabhakar Kushwaha 2018-09-03 9:54 ` Prabhakar Kushwaha 2018-09-04 5:37 ` Yogesh Narayan Gaur 2018-09-04 5:37 ` Yogesh Narayan Gaur 2018-09-04 5:37 ` Yogesh Narayan Gaur 2018-09-04 12:46 ` Boris Brezillon 2018-09-04 12:46 ` Boris Brezillon 2018-09-04 12:46 ` Boris Brezillon 2018-09-06 7:08 ` Jagdish Gediya 2018-09-06 7:08 ` Jagdish Gediya 2018-09-06 7:08 ` Jagdish Gediya 2018-09-04 1:33 ` Rob Herring 2018-09-04 1:33 ` Rob Herring 2018-09-04 1:33 ` Rob Herring 2018-08-31 10:30 ` [PATCH 5/7] arm64: dts: lx2160a: add fspi node property Yogesh Gaur 2018-08-31 10:30 ` Yogesh Gaur 2018-09-03 3:01 ` Shawn Guo [this message] 2018-09-03 3:01 ` Shawn Guo 2018-08-31 10:30 ` [PATCH 6/7] arm64: defconfig: enable NXP FlexSPI driver Yogesh Gaur 2018-08-31 10:30 ` Yogesh Gaur 2018-08-31 10:30 ` [PATCH 7/7] MAINTAINERS: add maintainers for the " Yogesh Gaur 2018-08-31 10:30 ` Yogesh Gaur 2018-09-04 12:43 ` [PATCH 0/7] spi: spi-mem: Add a driver for NXP FlexSPI controller Boris Brezillon 2018-09-04 12:43 ` Boris Brezillon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180903030110.GI3850@dragon \ --to=shawnguo@kernel.org \ --cc=boris.brezillon@bootlin.com \ --cc=computersforpeace@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=frieder.schrempf@exceet.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=marek.vasut@gmail.com \ --cc=mark.rutland@arm.com \ --cc=robh@kernel.org \ --cc=yogeshnarayan.gaur@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.