All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH RESEND] firmware: google: make structure gsmi_dev static
@ 2018-09-03  7:34 Jean Delvare
  0 siblings, 0 replies; only message in thread
From: Jean Delvare @ 2018-09-03  7:34 UTC (permalink / raw)
  To: LKML, Greg KH; +Cc: Colin Ian King, Andrew Morton

From: Colin Ian King <colin.king@canonical.com>
Subject: firmware: google: make structure gsmi_dev static

The structure gsmi_dev is local to the source and does not need to be
in global scope, so make it static.

Cleans up sparse warning:
symbol 'gsmi_dev' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Jean Delvare <jdelvare@suse.de>
---
Colin submitted this trivial patch twice already (2017-10-03,
2018-06-01) but nobody picked it. Greg, can you take this in one of
your trees? Or should it go through Andrew? Thanks.

 drivers/firmware/google/gsmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c
index c8f169bf2e27..734146eec1b9 100644
--- a/drivers/firmware/google/gsmi.c
+++ b/drivers/firmware/google/gsmi.c
@@ -84,7 +84,7 @@ struct gsmi_buf {
 	u32 address;			/* physical address of buffer */
 };
 
-struct gsmi_device {
+static struct gsmi_device {
 	struct platform_device *pdev;	/* platform device */
 	struct gsmi_buf *name_buf;	/* variable name buffer */
 	struct gsmi_buf *data_buf;	/* generic data buffer */
-- 
2.14.1



-- 
Jean Delvare
SUSE L3 Support

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2018-09-03  7:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-03  7:34 [PATCH RESEND] firmware: google: make structure gsmi_dev static Jean Delvare

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.