[PATCH i-g-t] lib/pm: Wait a little for sound module load to complete

[PATCH i-g-t] lib/pm: Wait a little for sound module load to complete

[Chris Wilson]

Sometimes we may probe the sound module as it is still being registered
and its debugfs not yet fully populated. If we do not find a file we
expect to exist, sleep a little and check again.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107801
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@linux.com>
---
 lib/igt_pm.c | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/lib/igt_pm.c b/lib/igt_pm.c
index 339a51e6f..e383f18b5 100644
--- a/lib/igt_pm.c
+++ b/lib/igt_pm.c
@@ -154,20 +154,28 @@ static int __igt_pm_enable_audio_runtime_pm(void)
 	while ((de = readdir(dir))) {
 		const char *match = "hwC";
 		char buf[32] = { }; /* for Valgrind */
-		char *tmp;
+		int loops = 500;
+		int base;
 		int ret;
 
 		if (de->d_type != DT_LNK ||
 		    strncmp(de->d_name, match, strlen(match)))
 			continue;
 
-		igt_assert(asprintf(&tmp,
-				    "/sys/class/sound/%s/vendor_name",
-				    de->d_name));
+		base = openat(dir, de->d_name, O_RDONLY);
+		igt_assert_fd(base);
+
+		do {
+			fd = open(base, "vendor_name", O_RDONLY);
+			if (fd < 0) /* module is still loading? */
+				usleep(1000);
+			else
+				break;
+		} while (--loops);
+		close(base);
+		if (fd < 0)
+			continue;
 
-		fd = open(tmp, O_RDONLY);
-		free(tmp);
-		igt_assert_fd(fd);
 		ret = read(fd, buf, sizeof(buf));
 		close(fd);
 		igt_assert(ret > 0);
-- 
2.19.0.rc1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t] lib/pm: Wait a little for sound module load to complete

[Chris Wilson]

Sometimes we may probe the sound module as it is still being registered
and its debugfs not yet fully populated. If we do not find a file we
expect to exist, sleep a little and check again.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107801
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@linux.com>
---
 lib/igt_pm.c | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/lib/igt_pm.c b/lib/igt_pm.c
index 339a51e6f..e383f18b5 100644
--- a/lib/igt_pm.c
+++ b/lib/igt_pm.c
@@ -154,20 +154,28 @@ static int __igt_pm_enable_audio_runtime_pm(void)
 	while ((de = readdir(dir))) {
 		const char *match = "hwC";
 		char buf[32] = { }; /* for Valgrind */
-		char *tmp;
+		int loops = 500;
+		int base;
 		int ret;
 
 		if (de->d_type != DT_LNK ||
 		    strncmp(de->d_name, match, strlen(match)))
 			continue;
 
-		igt_assert(asprintf(&tmp,
-				    "/sys/class/sound/%s/vendor_name",
-				    de->d_name));
+		base = openat(dir, de->d_name, O_RDONLY);
+		igt_assert_fd(base);
+
+		do {
+			fd = open(base, "vendor_name", O_RDONLY);
+			if (fd < 0) /* module is still loading? */
+				usleep(1000);
+			else
+				break;
+		} while (--loops);
+		close(base);
+		if (fd < 0)
+			continue;
 
-		fd = open(tmp, O_RDONLY);
-		free(tmp);
-		igt_assert_fd(fd);
 		ret = read(fd, buf, sizeof(buf));
 		close(fd);
 		igt_assert(ret > 0);
-- 
2.19.0.rc1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t] lib/pm: Wait a little for sound module load to complete

[Chris Wilson]

Quoting Chris Wilson (2018-09-03 13:51:10)
> Sometimes we may probe the sound module as it is still being registered
> and its debugfs not yet fully populated. If we do not find a file we
> expect to exist, sleep a little and check again.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107801
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak@linux.com>
> ---
>  lib/igt_pm.c | 22 +++++++++++++++-------
>  1 file changed, 15 insertions(+), 7 deletions(-)
> 
> diff --git a/lib/igt_pm.c b/lib/igt_pm.c
> index 339a51e6f..e383f18b5 100644
> --- a/lib/igt_pm.c
> +++ b/lib/igt_pm.c
> @@ -154,20 +154,28 @@ static int __igt_pm_enable_audio_runtime_pm(void)
>         while ((de = readdir(dir))) {
>                 const char *match = "hwC";
>                 char buf[32] = { }; /* for Valgrind */
> -               char *tmp;
> +               int loops = 500;
> +               int base;
>                 int ret;
>  
>                 if (de->d_type != DT_LNK ||
>                     strncmp(de->d_name, match, strlen(match)))
>                         continue;
>  
> -               igt_assert(asprintf(&tmp,
> -                                   "/sys/class/sound/%s/vendor_name",
> -                                   de->d_name));
> +               base = openat(dir, de->d_name, O_RDONLY);
s/dir/dirfd(dir)/
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [PATCH i-g-t] lib/pm: Wait a little for sound module load to complete

[Chris Wilson]

Quoting Chris Wilson (2018-09-03 13:51:10)
> Sometimes we may probe the sound module as it is still being registered
> and its debugfs not yet fully populated. If we do not find a file we
> expect to exist, sleep a little and check again.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107801
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak@linux.com>
> ---
>  lib/igt_pm.c | 22 +++++++++++++++-------
>  1 file changed, 15 insertions(+), 7 deletions(-)
> 
> diff --git a/lib/igt_pm.c b/lib/igt_pm.c
> index 339a51e6f..e383f18b5 100644
> --- a/lib/igt_pm.c
> +++ b/lib/igt_pm.c
> @@ -154,20 +154,28 @@ static int __igt_pm_enable_audio_runtime_pm(void)
>         while ((de = readdir(dir))) {
>                 const char *match = "hwC";
>                 char buf[32] = { }; /* for Valgrind */
> -               char *tmp;
> +               int loops = 500;
> +               int base;
>                 int ret;
>  
>                 if (de->d_type != DT_LNK ||
>                     strncmp(de->d_name, match, strlen(match)))
>                         continue;
>  
> -               igt_assert(asprintf(&tmp,
> -                                   "/sys/class/sound/%s/vendor_name",
> -                                   de->d_name));
> +               base = openat(dir, de->d_name, O_RDONLY);
s/dir/dirfd(dir)/
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[PATCH i-g-t v2] lib/pm: Wait a little for sound module load to complete

[Chris Wilson]

Sometimes we may probe the sound module as it is still being registered
and its debugfs not yet fully populated. If we do not find a file we
expect to exist, sleep a little and check again.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107801
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@linux.com>
---
 lib/igt_pm.c | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/lib/igt_pm.c b/lib/igt_pm.c
index 339a51e6f..c18bb87c6 100644
--- a/lib/igt_pm.c
+++ b/lib/igt_pm.c
@@ -154,20 +154,28 @@ static int __igt_pm_enable_audio_runtime_pm(void)
 	while ((de = readdir(dir))) {
 		const char *match = "hwC";
 		char buf[32] = { }; /* for Valgrind */
-		char *tmp;
+		int loops = 500;
+		int base;
 		int ret;
 
 		if (de->d_type != DT_LNK ||
 		    strncmp(de->d_name, match, strlen(match)))
 			continue;
 
-		igt_assert(asprintf(&tmp,
-				    "/sys/class/sound/%s/vendor_name",
-				    de->d_name));
+		base = openat(dirfd(dir), de->d_name, O_RDONLY);
+		igt_assert_fd(base);
+
+		do {
+			fd = open(base, "vendor_name", O_RDONLY);
+			if (fd < 0) /* module is still loading? */
+				usleep(1000);
+			else
+				break;
+		} while (--loops);
+		close(base);
+		if (fd < 0)
+			continue;
 
-		fd = open(tmp, O_RDONLY);
-		free(tmp);
-		igt_assert_fd(fd);
 		ret = read(fd, buf, sizeof(buf));
 		close(fd);
 		igt_assert(ret > 0);
-- 
2.19.0.rc1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t v2] lib/pm: Wait a little for sound module load to complete

[Chris Wilson]

Sometimes we may probe the sound module as it is still being registered
and its debugfs not yet fully populated. If we do not find a file we
expect to exist, sleep a little and check again.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107801
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@linux.com>
---
 lib/igt_pm.c | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/lib/igt_pm.c b/lib/igt_pm.c
index 339a51e6f..c18bb87c6 100644
--- a/lib/igt_pm.c
+++ b/lib/igt_pm.c
@@ -154,20 +154,28 @@ static int __igt_pm_enable_audio_runtime_pm(void)
 	while ((de = readdir(dir))) {
 		const char *match = "hwC";
 		char buf[32] = { }; /* for Valgrind */
-		char *tmp;
+		int loops = 500;
+		int base;
 		int ret;
 
 		if (de->d_type != DT_LNK ||
 		    strncmp(de->d_name, match, strlen(match)))
 			continue;
 
-		igt_assert(asprintf(&tmp,
-				    "/sys/class/sound/%s/vendor_name",
-				    de->d_name));
+		base = openat(dirfd(dir), de->d_name, O_RDONLY);
+		igt_assert_fd(base);
+
+		do {
+			fd = open(base, "vendor_name", O_RDONLY);
+			if (fd < 0) /* module is still loading? */
+				usleep(1000);
+			else
+				break;
+		} while (--loops);
+		close(base);
+		if (fd < 0)
+			continue;
 
-		fd = open(tmp, O_RDONLY);
-		free(tmp);
-		igt_assert_fd(fd);
 		ret = read(fd, buf, sizeof(buf));
 		close(fd);
 		igt_assert(ret > 0);
-- 
2.19.0.rc1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[igt-dev] ✗ Fi.CI.BAT: failure for lib/pm: Wait a little for sound module load to complete

[Patchwork]

== Series Details ==

Series: lib/pm: Wait a little for sound module load to complete
URL   : https://patchwork.freedesktop.org/series/49079/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4754 -> IGTPW_1777 =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_1777 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1777, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49079/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1777:

  === IGT changes ===

    ==== Possible regressions ====

    igt@pm_rpm@basic-pci-d3-state:
      fi-skl-6600u:       PASS -> FAIL +2
      fi-pnv-d510:        SKIP -> FAIL +2
      fi-kbl-7560u:       PASS -> FAIL +2
      fi-byt-j1900:       PASS -> FAIL +1
      fi-whl-u:           PASS -> FAIL +2
      fi-byt-n2820:       PASS -> FAIL +1
      fi-skl-6770hq:      PASS -> FAIL +2
      fi-skl-6700k2:      PASS -> FAIL +2
      fi-cnl-psr:         PASS -> FAIL +1
      fi-snb-2600:        SKIP -> FAIL +2
      fi-bxt-j4205:       PASS -> FAIL +2
      fi-skl-6260u:       PASS -> FAIL +2
      fi-kbl-8809g:       SKIP -> FAIL +1

    igt@pm_rpm@basic-rte:
      fi-skl-iommu:       PASS -> FAIL +2
      fi-elk-e7500:       SKIP -> FAIL +2
      fi-ilk-650:         SKIP -> FAIL +2
      fi-icl-u:           SKIP -> FAIL +2
      fi-cfl-guc:         PASS -> FAIL +2
      fi-skl-guc:         PASS -> FAIL +2
      fi-kbl-7567u:       PASS -> FAIL +2
      fi-snb-2520m:       NOTRUN -> FAIL +2
      {fi-bdw-samus}:     PASS -> FAIL +1
      fi-hsw-peppy:       PASS -> FAIL +1
      fi-cfl-8700k:       PASS -> FAIL +2
      fi-kbl-r:           PASS -> FAIL +2
      fi-hsw-4770r:       PASS -> FAIL +2
      fi-bwr-2160:        SKIP -> FAIL +2
      fi-bsw-n3050:       PASS -> FAIL +1
      {fi-bsw-kefka}:     PASS -> FAIL +1
      fi-glk-dsi:         PASS -> FAIL +1
      fi-kbl-guc:         SKIP -> FAIL +1

    {igt@pm_rpm@module-reload}:
      fi-blb-e6850:       SKIP -> FAIL +2
      fi-bdw-5557u:       PASS -> FAIL +2
      fi-kbl-guc:         PASS -> FAIL
      {fi-cfl-8109u}:     PASS -> FAIL +2
      fi-cfl-s3:          PASS -> FAIL
      fi-kbl-7500u:       PASS -> FAIL +2
      fi-bxt-dsi:         PASS -> FAIL +2
      fi-hsw-4770:        PASS -> FAIL +2
      fi-ivb-3520m:       SKIP -> FAIL +2
      fi-skl-6700hq:      NOTRUN -> FAIL +2
      fi-ivb-3770:        SKIP -> FAIL +2

    
    ==== Warnings ====

    igt@amdgpu/amd_prime@i915-to-amd:
      fi-kbl-8809g:       SKIP -> PASS

    {igt@pm_rpm@module-reload}:
      {fi-bsw-kefka}:     DMESG-WARN (fdo#107704) -> FAIL
      fi-glk-dsi:         WARN (fdo#107602, fdo#107708) -> FAIL
      fi-bsw-n3050:       DMESG-WARN (fdo#107704) -> FAIL
      fi-hsw-peppy:       DMESG-WARN (fdo#107603) -> FAIL
      {fi-bdw-samus}:     DMESG-WARN (fdo#107603) -> FAIL
      fi-byt-j1900:       DMESG-WARN (fdo#107704) -> FAIL
      fi-byt-n2820:       DMESG-WARN (fdo#107704) -> FAIL

    
== Known issues ==

  Here are the changes found in IGTPW_1777 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@amdgpu/amd_prime@amd-to-i915:
      fi-kbl-8809g:       SKIP -> FAIL (fdo#107341)

    {igt@pm_rpm@module-reload}:
      fi-cnl-psr:         PASS -> FAIL (fdo#107708)

    
    ==== Possible fixes ====

    igt@kms_frontbuffer_tracking@basic:
      {fi-byt-clapper}:   FAIL (fdo#103167) -> PASS

    igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
      {fi-byt-clapper}:   FAIL (fdo#107362, fdo#103191) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-snb-2520m:       INCOMPLETE (fdo#103713) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
  fdo#107341 https://bugs.freedesktop.org/show_bug.cgi?id=107341
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107602 https://bugs.freedesktop.org/show_bug.cgi?id=107602
  fdo#107603 https://bugs.freedesktop.org/show_bug.cgi?id=107603
  fdo#107704 https://bugs.freedesktop.org/show_bug.cgi?id=107704
  fdo#107708 https://bugs.freedesktop.org/show_bug.cgi?id=107708


== Participating hosts (52 -> 48) ==

  Additional (1): fi-skl-6700hq 
  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4620 -> IGTPW_1777

  CI_DRM_4754: b6b0b80157c9ecad0569a42bb8efeb6d2f27dfb3 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1777: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1777/
  IGT_4620: 20087bf22698612a526353f022bc232e2b0dcdcc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1777/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for lib/pm: Wait a little for sound module load to complete (rev2)

[Patchwork]

== Series Details ==

Series: lib/pm: Wait a little for sound module load to complete (rev2)
URL   : https://patchwork.freedesktop.org/series/49079/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4754 -> IGTPW_1778 =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1778 need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1778, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49079/revisions/2/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1778:

  === IGT changes ===

    ==== Warnings ====

    igt@amdgpu/amd_prime@i915-to-amd:
      fi-kbl-8809g:       SKIP -> PASS

    igt@pm_rpm@basic-pci-d3-state:
      fi-hsw-peppy:       PASS -> SKIP
      {fi-bdw-samus}:     PASS -> SKIP
      fi-hsw-4770r:       PASS -> SKIP +1

    {igt@pm_rpm@module-reload}:
      fi-bdw-5557u:       PASS -> SKIP +1
      fi-hsw-4770:        PASS -> SKIP +1

    
== Known issues ==

  Here are the changes found in IGTPW_1778 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@amdgpu/amd_prime@amd-to-i915:
      fi-kbl-8809g:       SKIP -> FAIL (fdo#107341)

    igt@gem_mmap_gtt@basic-copy:
      fi-glk-dsi:         PASS -> INCOMPLETE (fdo#103359, k.org#198133)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      {fi-byt-clapper}:   PASS -> FAIL (fdo#103191, fdo#107362) +1

    igt@pm_rpm@basic-pci-d3-state:
      fi-skl-6600u:       PASS -> WARN (fdo#107708) +1
      fi-kbl-7560u:       PASS -> WARN (fdo#107708) +1
      fi-byt-j1900:       PASS -> WARN (fdo#107708) +1
      fi-whl-u:           PASS -> WARN (fdo#107708) +1
      fi-byt-n2820:       PASS -> WARN (fdo#107708) +1
      fi-skl-6770hq:      PASS -> WARN (fdo#107708) +1
      fi-skl-6700k2:      PASS -> WARN (fdo#107708) +1
      fi-cnl-psr:         PASS -> WARN (fdo#107708) +1
      fi-bxt-j4205:       PASS -> WARN (fdo#107708) +1
      fi-skl-6260u:       PASS -> WARN (fdo#107708) +1
      fi-skl-6700hq:      NOTRUN -> WARN (fdo#107708) +1

    igt@pm_rpm@basic-rte:
      fi-skl-iommu:       PASS -> WARN (fdo#107708) +1
      fi-cfl-guc:         PASS -> WARN (fdo#107708) +1
      fi-skl-guc:         PASS -> WARN (fdo#107708) +1
      fi-kbl-7567u:       PASS -> WARN (fdo#107708) +1
      {fi-bdw-samus}:     PASS -> FAIL (fdo#107708)
      fi-hsw-peppy:       PASS -> FAIL (fdo#107708)
      fi-cfl-8700k:       PASS -> WARN (fdo#107708) +1
      fi-kbl-r:           PASS -> WARN (fdo#107708) +1
      fi-hsw-4770r:       PASS -> FAIL (fdo#107708)
      {fi-cfl-8109u}:     PASS -> WARN (fdo#107708) +1
      fi-bdw-5557u:       PASS -> FAIL (fdo#107708)
      fi-hsw-4770:        PASS -> FAIL (fdo#107708)
      fi-bsw-n3050:       PASS -> WARN (fdo#107708) +1
      {fi-bsw-kefka}:     PASS -> WARN (fdo#107708) +1
      fi-kbl-7500u:       PASS -> WARN (fdo#107708) +1

    {igt@pm_rpm@module-reload}:
      fi-skl-6600u:       PASS -> WARN (fdo#107602, fdo#107708)
      fi-kbl-guc:         PASS -> WARN (fdo#107602, fdo#107708)
      {fi-cfl-8109u}:     PASS -> WARN (fdo#107602, fdo#107708)
      fi-cfl-s3:          PASS -> WARN (fdo#107602, fdo#107708)
      fi-kbl-7500u:       PASS -> WARN (fdo#107602, fdo#107708)
      fi-skl-6700hq:      NOTRUN -> WARN (fdo#107602, fdo#107708)
      fi-cfl-guc:         PASS -> WARN (fdo#107602, fdo#107708)
      fi-skl-guc:         PASS -> WARN (fdo#107602, fdo#107708)
      fi-cfl-8700k:       PASS -> WARN (fdo#107602, fdo#107708)
      fi-skl-6770hq:      PASS -> WARN (fdo#107602, fdo#107708)
      fi-cnl-psr:         PASS -> WARN (fdo#107602, fdo#107708)
      fi-kbl-r:           PASS -> WARN (fdo#107602, fdo#107708)
      fi-skl-6260u:       PASS -> WARN (fdo#107602, fdo#107708)
      fi-bxt-j4205:       PASS -> WARN (fdo#107602, fdo#107708)
      fi-whl-u:           PASS -> WARN (fdo#107602, fdo#107708)
      fi-kbl-7567u:       PASS -> WARN (fdo#107602, fdo#107708)
      fi-kbl-7560u:       PASS -> WARN (fdo#107602, fdo#107708)
      fi-skl-iommu:       PASS -> WARN (fdo#107602, fdo#107708)
      fi-skl-6700k2:      PASS -> WARN (fdo#107602, fdo#107708)

    
    ==== Possible fixes ====

    igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
      {fi-byt-clapper}:   FAIL (fdo#103191, fdo#107362) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-snb-2520m:       INCOMPLETE (fdo#103713) -> PASS

    {igt@pm_rpm@module-reload}:
      fi-hsw-peppy:       DMESG-WARN (fdo#107603) -> SKIP
      {fi-bdw-samus}:     DMESG-WARN (fdo#107603) -> SKIP

    
    ==== Warnings ====

    {igt@pm_rpm@module-reload}:
      {fi-bsw-kefka}:     DMESG-WARN (fdo#107704) -> DMESG-FAIL (fdo#107704)
      fi-bsw-n3050:       DMESG-WARN (fdo#107704) -> DMESG-FAIL (fdo#107704)
      fi-kbl-8809g:       FAIL (fdo#107798) -> WARN (fdo#107602, fdo#107708)
      fi-byt-j1900:       DMESG-WARN (fdo#107704) -> DMESG-FAIL (fdo#107704)
      fi-byt-n2820:       DMESG-WARN (fdo#107704) -> DMESG-FAIL (fdo#107704)

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
  fdo#107341 https://bugs.freedesktop.org/show_bug.cgi?id=107341
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107602 https://bugs.freedesktop.org/show_bug.cgi?id=107602
  fdo#107603 https://bugs.freedesktop.org/show_bug.cgi?id=107603
  fdo#107704 https://bugs.freedesktop.org/show_bug.cgi?id=107704
  fdo#107708 https://bugs.freedesktop.org/show_bug.cgi?id=107708
  fdo#107798 https://bugs.freedesktop.org/show_bug.cgi?id=107798
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (52 -> 47) ==

  Additional (1): fi-skl-6700hq 
  Missing    (6): fi-ilk-m540 fi-bxt-dsi fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 


== Build changes ==

    * IGT: IGT_4620 -> IGTPW_1778

  CI_DRM_4754: b6b0b80157c9ecad0569a42bb8efeb6d2f27dfb3 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1778: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1778/
  IGT_4620: 20087bf22698612a526353f022bc232e2b0dcdcc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1778/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[PATCH i-g-t v3] lib/pm: Wait a little for sound module load to complete

[Chris Wilson]

Sometimes we may probe the sound module as it is still being registered
and its debugfs not yet fully populated. If we do not find a file we
expect to exist, sleep a little and check again.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107801
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@linux.com>
---
 lib/igt_pm.c | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/lib/igt_pm.c b/lib/igt_pm.c
index 339a51e6f..001025939 100644
--- a/lib/igt_pm.c
+++ b/lib/igt_pm.c
@@ -154,20 +154,28 @@ static int __igt_pm_enable_audio_runtime_pm(void)
 	while ((de = readdir(dir))) {
 		const char *match = "hwC";
 		char buf[32] = { }; /* for Valgrind */
-		char *tmp;
+		int loops = 500;
+		int base;
 		int ret;
 
 		if (de->d_type != DT_LNK ||
 		    strncmp(de->d_name, match, strlen(match)))
 			continue;
 
-		igt_assert(asprintf(&tmp,
-				    "/sys/class/sound/%s/vendor_name",
-				    de->d_name));
+		base = openat(dirfd(dir), de->d_name, O_RDONLY);
+		igt_assert_fd(base);
+
+		do {
+			fd = openat(base, "vendor_name", O_RDONLY);
+			if (fd < 0) /* module is still loading? */
+				usleep(1000);
+			else
+				break;
+		} while (--loops);
+		close(base);
+		if (fd < 0)
+			continue;
 
-		fd = open(tmp, O_RDONLY);
-		free(tmp);
-		igt_assert_fd(fd);
 		ret = read(fd, buf, sizeof(buf));
 		close(fd);
 		igt_assert(ret > 0);
-- 
2.19.0.rc1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[igt-dev] [PATCH i-g-t v3] lib/pm: Wait a little for sound module load to complete

[Chris Wilson]

Sometimes we may probe the sound module as it is still being registered
and its debugfs not yet fully populated. If we do not find a file we
expect to exist, sleep a little and check again.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107801
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@linux.com>
---
 lib/igt_pm.c | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/lib/igt_pm.c b/lib/igt_pm.c
index 339a51e6f..001025939 100644
--- a/lib/igt_pm.c
+++ b/lib/igt_pm.c
@@ -154,20 +154,28 @@ static int __igt_pm_enable_audio_runtime_pm(void)
 	while ((de = readdir(dir))) {
 		const char *match = "hwC";
 		char buf[32] = { }; /* for Valgrind */
-		char *tmp;
+		int loops = 500;
+		int base;
 		int ret;
 
 		if (de->d_type != DT_LNK ||
 		    strncmp(de->d_name, match, strlen(match)))
 			continue;
 
-		igt_assert(asprintf(&tmp,
-				    "/sys/class/sound/%s/vendor_name",
-				    de->d_name));
+		base = openat(dirfd(dir), de->d_name, O_RDONLY);
+		igt_assert_fd(base);
+
+		do {
+			fd = openat(base, "vendor_name", O_RDONLY);
+			if (fd < 0) /* module is still loading? */
+				usleep(1000);
+			else
+				break;
+		} while (--loops);
+		close(base);
+		if (fd < 0)
+			continue;
 
-		fd = open(tmp, O_RDONLY);
-		free(tmp);
-		igt_assert_fd(fd);
 		ret = read(fd, buf, sizeof(buf));
 		close(fd);
 		igt_assert(ret > 0);
-- 
2.19.0.rc1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for lib/pm: Wait a little for sound module load to complete (rev3)

[Patchwork]

== Series Details ==

Series: lib/pm: Wait a little for sound module load to complete (rev3)
URL   : https://patchwork.freedesktop.org/series/49079/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4754 -> IGTPW_1779 =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1779 need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1779, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49079/revisions/3/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1779:

  === IGT changes ===

    ==== Warnings ====

    igt@amdgpu/amd_prime@i915-to-amd:
      fi-kbl-8809g:       SKIP -> PASS

    
== Known issues ==

  Here are the changes found in IGTPW_1779 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@amdgpu/amd_prime@amd-to-i915:
      fi-kbl-8809g:       SKIP -> FAIL (fdo#107341)

    {igt@pm_rpm@module-reload}:
      fi-cnl-psr:         PASS -> WARN (fdo#107602, fdo#107708)

    
    ==== Possible fixes ====

    igt@kms_frontbuffer_tracking@basic:
      {fi-byt-clapper}:   FAIL (fdo#103167) -> PASS

    igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
      {fi-byt-clapper}:   FAIL (fdo#107362, fdo#103191) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-snb-2520m:       INCOMPLETE (fdo#103713) -> PASS

    igt@kms_psr@primary_page_flip:
      fi-cnl-psr:         FAIL (fdo#107336) -> PASS

    {igt@pm_rpm@module-reload}:
      fi-kbl-8809g:       FAIL (fdo#107798) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
  fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
  fdo#107341 https://bugs.freedesktop.org/show_bug.cgi?id=107341
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107602 https://bugs.freedesktop.org/show_bug.cgi?id=107602
  fdo#107708 https://bugs.freedesktop.org/show_bug.cgi?id=107708
  fdo#107798 https://bugs.freedesktop.org/show_bug.cgi?id=107798


== Participating hosts (52 -> 48) ==

  Additional (1): fi-skl-6700hq 
  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4620 -> IGTPW_1779

  CI_DRM_4754: b6b0b80157c9ecad0569a42bb8efeb6d2f27dfb3 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1779: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1779/
  IGT_4620: 20087bf22698612a526353f022bc232e2b0dcdcc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1779/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for lib/pm: Wait a little for sound module load to complete

[Patchwork]

== Series Details ==

Series: lib/pm: Wait a little for sound module load to complete
URL   : https://patchwork.freedesktop.org/series/49079/
State : failure

== Summary ==

= CI Bug Log - changes from IGT_4620_full -> IGTPW_1777_full =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_1777_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1777_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49079/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1777_full:

  === IGT changes ===

    ==== Possible regressions ====

    igt@pm_lpsp@non-edp:
      shard-kbl:          SKIP -> FAIL +11

    igt@pm_lpsp@screens-disabled:
      shard-apl:          SKIP -> FAIL +11

    igt@pm_rpm@cursor:
      shard-hsw:          PASS -> FAIL +45

    igt@pm_rpm@dpms-mode-unset-non-lpsp:
      shard-apl:          PASS -> FAIL +42

    igt@pm_rpm@gem-execbuf-stress-extra-wait:
      shard-snb:          NOTRUN -> FAIL +1

    igt@pm_rpm@gem-idle:
      shard-glk:          PASS -> FAIL +35

    igt@pm_rpm@gem-mmap-gtt:
      shard-snb:          SKIP -> FAIL +51

    igt@pm_rpm@modeset-lpsp:
      shard-glk:          SKIP -> FAIL +11

    igt@pm_rpm@modeset-non-lpsp:
      shard-glk:          NOTRUN -> FAIL +3

    igt@pm_rpm@modeset-non-lpsp-stress:
      shard-kbl:          PASS -> FAIL +41

    igt@pm_rpm@modeset-pc8-residency-stress:
      shard-hsw:          SKIP -> FAIL +9

    
== Known issues ==

  Here are the changes found in IGTPW_1777_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_cursor_crc@cursor-256x85-sliding:
      shard-kbl:          PASS -> DMESG-WARN (fdo#105602, fdo#103558) +14

    igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu:
      shard-glk:          PASS -> FAIL (fdo#103167)

    igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
      shard-snb:          PASS -> FAIL (fdo#103166)

    igt@kms_vblank@pipe-b-ts-continuation-dpms-rpm:
      shard-kbl:          PASS -> DMESG-FAIL (fdo#105602, fdo#103558)

    igt@kms_vblank@pipe-c-ts-continuation-suspend:
      shard-kbl:          PASS -> INCOMPLETE (fdo#107556, fdo#103665)

    
    ==== Possible fixes ====

    igt@drv_suspend@shrink:
      shard-kbl:          FAIL (fdo#106886) -> PASS

    igt@gem_exec_await@wide-contexts:
      shard-glk:          FAIL (fdo#105900) -> PASS

    igt@gem_exec_store@cachelines-bsd:
      shard-hsw:          FAIL (fdo#100007) -> PASS

    igt@kms_cursor_legacy@cursor-vs-flip-varying-size:
      shard-hsw:          FAIL (fdo#103355) -> PASS

    igt@kms_flip@flip-vs-expired-vblank:
      shard-glk:          FAIL (fdo#105363) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      shard-snb:          INCOMPLETE (fdo#105411) -> PASS

    igt@kms_plane@pixel-format-pipe-a-planes:
      shard-snb:          FAIL (fdo#107749) -> PASS

    igt@kms_rotation_crc@primary-rotation-180:
      shard-snb:          FAIL (fdo#103925) -> PASS

    igt@kms_setmode@basic:
      shard-apl:          FAIL (fdo#99912) -> PASS

    igt@perf@blocking:
      shard-hsw:          FAIL (fdo#102252) -> PASS

    
  fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
  fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
  fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
  fdo#105900 https://bugs.freedesktop.org/show_bug.cgi?id=105900
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
  fdo#107749 https://bugs.freedesktop.org/show_bug.cgi?id=107749
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4620 -> IGTPW_1777
    * Linux: CI_DRM_4753 -> CI_DRM_4754

  CI_DRM_4753: 0892613a442a70a96cba33b12bb344033b557879 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4754: b6b0b80157c9ecad0569a42bb8efeb6d2f27dfb3 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1777: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1777/
  IGT_4620: 20087bf22698612a526353f022bc232e2b0dcdcc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1777/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for lib/pm: Wait a little for sound module load to complete (rev2)

[Patchwork]

== Series Details ==

Series: lib/pm: Wait a little for sound module load to complete (rev2)
URL   : https://patchwork.freedesktop.org/series/49079/
State : failure

== Summary ==

= CI Bug Log - changes from IGT_4620_full -> IGTPW_1778_full =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_1778_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1778_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49079/revisions/2/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1778_full:

  === IGT changes ===

    ==== Possible regressions ====

    igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-xtiled:
      shard-glk:          PASS -> FAIL

    igt@kms_vblank@pipe-a-ts-continuation-dpms-rpm:
      shard-kbl:          PASS -> WARN +5

    igt@kms_vblank@pipe-b-ts-continuation-dpms-rpm:
      shard-apl:          PASS -> WARN +5

    igt@kms_vblank@pipe-c-ts-continuation-dpms-rpm:
      shard-glk:          PASS -> WARN +4

    igt@kms_vblank@pipe-c-ts-continuation-modeset-rpm:
      shard-glk:          NOTRUN -> WARN

    igt@pm_lpsp@non-edp:
      shard-hsw:          PASS -> WARN

    igt@pm_lpsp@screens-disabled:
      shard-hsw:          PASS -> FAIL

    
    ==== Warnings ====

    igt@pm_rpm@cursor:
      shard-hsw:          PASS -> SKIP +42

    
== Known issues ==

  Here are the changes found in IGTPW_1778_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-snb:          PASS -> FAIL (fdo#106641)

    igt@kms_cursor_crc@cursor-256x256-suspend:
      shard-kbl:          PASS -> INCOMPLETE (fdo#107556, fdo#103665)

    igt@kms_flip_event_leak:
      shard-kbl:          PASS -> DMESG-WARN (fdo#103558, fdo#105602) +8

    igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-wc:
      shard-snb:          PASS -> INCOMPLETE (fdo#105411)

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite:
      shard-glk:          PASS -> FAIL (fdo#103167)

    igt@perf@gen8-unprivileged-single-ctx-counters:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665)

    igt@pm_rpm@basic-rte:
      shard-hsw:          PASS -> FAIL (fdo#107708)

    igt@pm_rpm@cursor:
      shard-kbl:          PASS -> DMESG-FAIL (fdo#103558, fdo#105602)

    igt@pm_rpm@dpms-mode-unset-non-lpsp:
      shard-apl:          PASS -> WARN (fdo#107708) +36

    igt@pm_rpm@gem-idle:
      shard-glk:          PASS -> WARN (fdo#107708) +33

    igt@pm_rpm@modeset-non-lpsp:
      shard-glk:          NOTRUN -> WARN (fdo#107708) +2

    igt@pm_rpm@modeset-non-lpsp-stress:
      shard-kbl:          PASS -> WARN (fdo#107708) +35

    
    ==== Possible fixes ====

    igt@drv_suspend@shrink:
      shard-kbl:          FAIL (fdo#106886) -> PASS

    igt@gem_exec_await@wide-contexts:
      shard-glk:          FAIL (fdo#105900) -> PASS

    igt@gem_exec_store@cachelines-bsd:
      shard-hsw:          FAIL (fdo#100007) -> PASS

    igt@kms_cursor_legacy@cursor-vs-flip-varying-size:
      shard-hsw:          FAIL (fdo#103355) -> PASS

    igt@kms_flip@flip-vs-expired-vblank-interruptible:
      shard-glk:          FAIL (fdo#105363) -> PASS +1

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      shard-snb:          INCOMPLETE (fdo#105411) -> PASS

    igt@kms_setmode@basic:
      shard-kbl:          FAIL (fdo#99912) -> PASS

    igt@perf@blocking:
      shard-hsw:          FAIL (fdo#102252) -> PASS

    
    ==== Warnings ====

    igt@perf_pmu@rc6-runtime-pm-long:
      shard-apl:          FAIL (fdo#105010) -> WARN (fdo#107708)
      shard-glk:          FAIL (fdo#105010) -> WARN (fdo#107708)
      shard-kbl:          FAIL (fdo#105010) -> WARN (fdo#107708)

    
  fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
  fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
  fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#105010 https://bugs.freedesktop.org/show_bug.cgi?id=105010
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
  fdo#105900 https://bugs.freedesktop.org/show_bug.cgi?id=105900
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
  fdo#107708 https://bugs.freedesktop.org/show_bug.cgi?id=107708
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4620 -> IGTPW_1778
    * Linux: CI_DRM_4753 -> CI_DRM_4754

  CI_DRM_4753: 0892613a442a70a96cba33b12bb344033b557879 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4754: b6b0b80157c9ecad0569a42bb8efeb6d2f27dfb3 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1778: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1778/
  IGT_4620: 20087bf22698612a526353f022bc232e2b0dcdcc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1778/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for lib/pm: Wait a little for sound module load to complete (rev3)

[Patchwork]

== Series Details ==

Series: lib/pm: Wait a little for sound module load to complete (rev3)
URL   : https://patchwork.freedesktop.org/series/49079/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4620_full -> IGTPW_1779_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1779_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1779_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49079/revisions/3/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1779_full:

  === IGT changes ===

    ==== Warnings ====

    igt@pm_rc6_residency@rc6-accuracy:
      shard-kbl:          PASS -> SKIP

    
== Known issues ==

  Here are the changes found in IGTPW_1779_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_ppgtt@blt-vs-render-ctxn:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665, fdo#106023)

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-snb:          PASS -> FAIL (fdo#106641)

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-gtt:
      shard-glk:          PASS -> FAIL (fdo#103167)

    igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-gtt:
      shard-glk:          NOTRUN -> FAIL (fdo#103167)

    igt@kms_vblank@pipe-c-ts-continuation-suspend:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665, fdo#107556)

    
    ==== Possible fixes ====

    igt@drv_suspend@shrink:
      shard-kbl:          FAIL (fdo#106886) -> PASS

    igt@gem_exec_await@wide-contexts:
      shard-glk:          FAIL (fdo#105900) -> PASS

    igt@gem_exec_store@cachelines-bsd:
      shard-hsw:          FAIL (fdo#100007) -> PASS

    igt@kms_cursor_legacy@cursor-vs-flip-varying-size:
      shard-hsw:          FAIL (fdo#103355) -> PASS

    igt@kms_flip@flip-vs-expired-vblank-interruptible:
      shard-glk:          FAIL (fdo#105363) -> PASS +1

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      shard-snb:          INCOMPLETE (fdo#105411) -> PASS

    igt@kms_plane@pixel-format-pipe-a-planes:
      shard-snb:          FAIL (fdo#107749) -> PASS

    igt@kms_setmode@basic:
      shard-apl:          FAIL (fdo#99912) -> PASS

    igt@perf@blocking:
      shard-hsw:          FAIL (fdo#102252) -> PASS

    igt@perf_pmu@rc6-runtime-pm-long:
      shard-apl:          FAIL (fdo#105010) -> PASS
      shard-glk:          FAIL (fdo#105010) -> PASS
      shard-kbl:          FAIL (fdo#105010) -> PASS

    igt@testdisplay:
      shard-glk:          INCOMPLETE (fdo#103359, fdo#107093, k.org#198133) -> PASS

    
  fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
  fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#105010 https://bugs.freedesktop.org/show_bug.cgi?id=105010
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105900 https://bugs.freedesktop.org/show_bug.cgi?id=105900
  fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#107093 https://bugs.freedesktop.org/show_bug.cgi?id=107093
  fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
  fdo#107749 https://bugs.freedesktop.org/show_bug.cgi?id=107749
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4620 -> IGTPW_1779
    * Linux: CI_DRM_4753 -> CI_DRM_4754

  CI_DRM_4753: 0892613a442a70a96cba33b12bb344033b557879 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4754: b6b0b80157c9ecad0569a42bb8efeb6d2f27dfb3 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1779: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1779/
  IGT_4620: 20087bf22698612a526353f022bc232e2b0dcdcc @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1779/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2] lib/pm: Wait a little for sound module load to complete

[Imre Deak]

On Mon, Sep 03, 2018 at 02:02:00PM +0100, Chris Wilson wrote:
> Sometimes we may probe the sound module as it is still being registered
> and its debugfs not yet fully populated. If we do not find a file we
> expect to exist, sleep a little and check again.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107801
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak@linux.com>

Reviewed-by: Imre Deak <imre.deak@intel.com>

A different delay is when the snd_hda_intel's probing takes more than 5
sec (as you noticed in [1]), should we increase the timeout in
igt_pm_enable_audio_runtime_pm() for that as well?

[1] https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4618/fi-cnl-psr/igt@pm_rpm@module-reload.html

> ---
>  lib/igt_pm.c | 22 +++++++++++++++-------
>  1 file changed, 15 insertions(+), 7 deletions(-)
> 
> diff --git a/lib/igt_pm.c b/lib/igt_pm.c
> index 339a51e6f..c18bb87c6 100644
> --- a/lib/igt_pm.c
> +++ b/lib/igt_pm.c
> @@ -154,20 +154,28 @@ static int __igt_pm_enable_audio_runtime_pm(void)
>  	while ((de = readdir(dir))) {
>  		const char *match = "hwC";
>  		char buf[32] = { }; /* for Valgrind */
> -		char *tmp;
> +		int loops = 500;
> +		int base;
>  		int ret;
>  
>  		if (de->d_type != DT_LNK ||
>  		    strncmp(de->d_name, match, strlen(match)))
>  			continue;
>  
> -		igt_assert(asprintf(&tmp,
> -				    "/sys/class/sound/%s/vendor_name",
> -				    de->d_name));
> +		base = openat(dirfd(dir), de->d_name, O_RDONLY);
> +		igt_assert_fd(base);
> +
> +		do {
> +			fd = open(base, "vendor_name", O_RDONLY);
> +			if (fd < 0) /* module is still loading? */
> +				usleep(1000);
> +			else
> +				break;
> +		} while (--loops);
> +		close(base);
> +		if (fd < 0)
> +			continue;
>  
> -		fd = open(tmp, O_RDONLY);
> -		free(tmp);
> -		igt_assert_fd(fd);
>  		ret = read(fd, buf, sizeof(buf));
>  		close(fd);
>  		igt_assert(ret > 0);
> -- 
> 2.19.0.rc1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [PATCH i-g-t v2] lib/pm: Wait a little for sound module load to complete

[Imre Deak]

On Mon, Sep 03, 2018 at 02:02:00PM +0100, Chris Wilson wrote:
> Sometimes we may probe the sound module as it is still being registered
> and its debugfs not yet fully populated. If we do not find a file we
> expect to exist, sleep a little and check again.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107801
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak@linux.com>

Reviewed-by: Imre Deak <imre.deak@intel.com>

A different delay is when the snd_hda_intel's probing takes more than 5
sec (as you noticed in [1]), should we increase the timeout in
igt_pm_enable_audio_runtime_pm() for that as well?

[1] https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4618/fi-cnl-psr/igt@pm_rpm@module-reload.html

> ---
>  lib/igt_pm.c | 22 +++++++++++++++-------
>  1 file changed, 15 insertions(+), 7 deletions(-)
> 
> diff --git a/lib/igt_pm.c b/lib/igt_pm.c
> index 339a51e6f..c18bb87c6 100644
> --- a/lib/igt_pm.c
> +++ b/lib/igt_pm.c
> @@ -154,20 +154,28 @@ static int __igt_pm_enable_audio_runtime_pm(void)
>  	while ((de = readdir(dir))) {
>  		const char *match = "hwC";
>  		char buf[32] = { }; /* for Valgrind */
> -		char *tmp;
> +		int loops = 500;
> +		int base;
>  		int ret;
>  
>  		if (de->d_type != DT_LNK ||
>  		    strncmp(de->d_name, match, strlen(match)))
>  			continue;
>  
> -		igt_assert(asprintf(&tmp,
> -				    "/sys/class/sound/%s/vendor_name",
> -				    de->d_name));
> +		base = openat(dirfd(dir), de->d_name, O_RDONLY);
> +		igt_assert_fd(base);
> +
> +		do {
> +			fd = open(base, "vendor_name", O_RDONLY);
> +			if (fd < 0) /* module is still loading? */
> +				usleep(1000);
> +			else
> +				break;
> +		} while (--loops);
> +		close(base);
> +		if (fd < 0)
> +			continue;
>  
> -		fd = open(tmp, O_RDONLY);
> -		free(tmp);
> -		igt_assert_fd(fd);
>  		ret = read(fd, buf, sizeof(buf));
>  		close(fd);
>  		igt_assert(ret > 0);
> -- 
> 2.19.0.rc1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t v2] lib/pm: Wait a little for sound module load to complete

[Chris Wilson]

Quoting Imre Deak (2018-09-04 11:00:26)
> On Mon, Sep 03, 2018 at 02:02:00PM +0100, Chris Wilson wrote:
> > Sometimes we may probe the sound module as it is still being registered
> > and its debugfs not yet fully populated. If we do not find a file we
> > expect to exist, sleep a little and check again.
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107801
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Imre Deak <imre.deak@linux.com>
> 
> Reviewed-by: Imre Deak <imre.deak@intel.com>
> 
> A different delay is when the snd_hda_intel's probing takes more than 5
> sec (as you noticed in [1]), should we increase the timeout in
> igt_pm_enable_audio_runtime_pm() for that as well?

Just bump it to 10s and only worry if we see a test failure later?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [PATCH i-g-t v2] lib/pm: Wait a little for sound module load to complete

[Chris Wilson]

Quoting Imre Deak (2018-09-04 11:00:26)
> On Mon, Sep 03, 2018 at 02:02:00PM +0100, Chris Wilson wrote:
> > Sometimes we may probe the sound module as it is still being registered
> > and its debugfs not yet fully populated. If we do not find a file we
> > expect to exist, sleep a little and check again.
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107801
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Imre Deak <imre.deak@linux.com>
> 
> Reviewed-by: Imre Deak <imre.deak@intel.com>
> 
> A different delay is when the snd_hda_intel's probing takes more than 5
> sec (as you noticed in [1]), should we increase the timeout in
> igt_pm_enable_audio_runtime_pm() for that as well?

Just bump it to 10s and only worry if we see a test failure later?
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev